[issue27410] DLL hijacking vulnerability in Python 3.5.2 installer

2016-06-28 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +steve.dower ___ Python tracker ___ ___

[issue17911] traceback: add a new thin class storing a traceback without storing local variables

2016-06-28 Thread Martin Panter
Martin Panter added the comment: Robert: in issue17911-2.patch (and the eventual commit) you added a check for value == 'None' in _format_final_exc_line(). Why was this necessary? I think it is the cause of my Issue 27348 regression: >>> traceback.format_exception(Exception, Exception("One"),

[issue27348] traceback (and threading) drops exception message

2016-06-28 Thread Martin Panter
Martin Panter added the comment: I traced this back to revision 73afda5a4e4c (Issue 17911), which includes this change to traceback._format_final_exc_line(): -if value is None or not valuestr: +if value == 'None' or value is None or not valuestr: -- components: +Library (Lib)

[issue26226] Various test suite failures on Windows

2016-06-28 Thread Emanuel Barry
Emanuel Barry added the comment: That is good to know, thanks Eryk for the explanation! I also think making Python set LC_CTYPE on startup on Windows would be good. Martin's comment got me wondering, so I'm going to try to see if all modules properly got re-compiled, and re-run tests. I'll

[issue26226] Various test suite failures on Windows

2016-06-28 Thread Eryk Sun
Eryk Sun added the comment: time.strftime calls the CRT's strftime function, which the Windows universal CRT implements by calling wcsftime and encoding the result. The timezone name is actually stored as a char string (tzname), so wcsftime has to decode it via mbstowcs. The problem is that

[issue27410] DLL hijacking vulnerability in Python 3.5.2 installer

2016-06-28 Thread anandbhat
Changes by anandbhat : Added file: http://bugs.python.org/file43576/Python_3.5.2_64_exe_DLL_Hijack.PNG ___ Python tracker ___

[issue27410] DLL hijacking vulnerability in Python 3.5.2 installer

2016-06-28 Thread anandbhat
Changes by anandbhat : Removed file: http://bugs.python.org/file43574/Python_3.5.2_64_exe_DLL_Hijack.PNG ___ Python tracker ___

[issue27410] DLL hijacking vulnerability in Python 3.5.2 installer

2016-06-28 Thread anandbhat
Changes by anandbhat : Added file: http://bugs.python.org/file43575/Python_3.5.2_64_exe_version_DLL_Hijack.PNG ___ Python tracker ___

[issue27410] DLL hijacking vulnerability in Python 3.5.2 installer

2016-06-28 Thread anandbhat
New submission from anandbhat: The Python 3.5.2 Windows x86-64 executable installer (MD5: 4da6dbc8e43e2249a0892d257e977291) downloaded from https://www.python.org/ftp/python/3.5.2/python-3.5.2-amd64.exe is vulnerable to DLL hijacking. The installer attempts to load DLLs from the current

[issue27409] List socket.SO_*, SCM_*, MSG_*, IPPROTO_* symbols

2016-06-28 Thread Martin Panter
New submission from Martin Panter: The documentation just says that SO_* etc constants are defined. However when people add new ones, they add them as new features to a specific version (not backported as bug fixes), but do not alter the documentation at all. IMO it is silly adding

[issue1732367] Document the constants in the socket module

2016-06-28 Thread Martin Panter
Martin Panter added the comment: Reopening because the consensus seems to be to update and apply this sort of change. -- nosy: +martin.panter stage: -> needs patch status: closed -> open ___ Python tracker

[issue27408] Document importlib.abc.ExecutionLoader implements get_data()

2016-06-28 Thread Brett Cannon
New submission from Brett Cannon: The fact that importlib.abc.ExectionLoader.get_data() is implemented is missing (or put another way, it isn't documented that get_source() still needs to be implemented). -- assignee: docs@python components: Documentation messages: 269458 nosy:

[issue19802] socket.SO_PRIORITY is missing

2016-06-28 Thread Larry Hastings
Larry Hastings added the comment: Sorry, this is now too late for 3.4. 3.4 is now in "security fixes only" mode. This is not a security fix, therefore 3.4 is now ineligible. Since this change was committed to 3.5, it's better to let the historical record reflect that. So I'm changing the

[issue19802] socket.SO_PRIORITY is missing

2016-06-28 Thread Martin Panter
Changes by Martin Panter : -- versions: +Python 3.4 -Python 3.5 ___ Python tracker ___

[issue22970] asyncio: Cancelling wait() after notification leaves Condition in an inconsistent state

2016-06-28 Thread Jesús Cea Avión
Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing

[issue27377] Add smarter socket.fromfd()

2016-06-28 Thread Martin Panter
Martin Panter added the comment: The s.detach() thing isn’t a big deal, but I thought it would simplify the code (eliminate the need for the “finally” clause). I will try to propose a minor documentation update for SO_PASSCRED as a starting point for adding the others. --

[issue26226] Various test suite failures on Windows

2016-06-28 Thread Martin Panter
Martin Panter added the comment: test_distutils: Is the failure the same as before, or changed? Are you testing with new code that includes the Issue 27048 fix? It looks like test_distutils doesn’t support running directly via “unittest”. Perhaps try “python -m test -W test_distutils” or

[issue27384] itertools islice consumes items when given negative range

2016-06-28 Thread Raymond Hettinger
Raymond Hettinger added the comment: "Surprising" is in the eye of the beholder. Having islice() always consume at least "start" number of values seems reasonable enough and it is the documented behavior: "If start is non-zero, then elements from the iterable are skipped until start is

[issue4945] json checks True/False by identity, not boolean value

2016-06-28 Thread Raymond Hettinger
Raymond Hettinger added the comment: These latest two patches look fine. Go ahead with them. -- ___ Python tracker ___

[issue26844] Wrong error message during import

2016-06-28 Thread Brett Cannon
Brett Cannon added the comment: Should we use __qualname__ instead of __name__? And I haven't forgotten about your patch, Lev. I'm just occupied trying to get feature changes into Python 3.6 as that has a sooner deadline than bug fixes. -- ___

[issue27377] Add smarter socket.fromfd()

2016-06-28 Thread Neil Schemenauer
Neil Schemenauer added the comment: I've revised the patch based on the second round of comments from Martin. I've removed the ifdef test for CO_TYPE and assumed it is always available. That means fdtype() should be available on all platforms. I did not change the test as suggested to call

[issue27407] prepare_ssl.py missing in PCBuild folder

2016-06-28 Thread Zachary Ware
Zachary Ware added the comment: You can also use PC/VS9.0/build_ssl.py which was the progenitor of prepare_ssl.py. The project files in PC/VS9.0 will use build_ssl.py by default. FTR, I'm good with copying prepare_ssl.py to 2.7, and even with ensuring that it's 2.7 compatible (it probably

[issue27383] executuable in distutils triggering microsoft anti virus

2016-06-28 Thread Rob Bairos
Rob Bairos added the comment: Great. Thanks for the update On Tue, Jun 28, 2016 at 2:37 PM, Steve Dower wrote: > > Steve Dower added the comment: > > FYI the definitions have been updated and I'm no longer seeing the false > positive. > > Definition version:

[issue27383] executuable in distutils triggering microsoft anti virus

2016-06-28 Thread Steve Dower
Steve Dower added the comment: FYI the definitions have been updated and I'm no longer seeing the false positive. Definition version: 1.223.2858.0 -- ___ Python tracker

[issue27402] Sequence example in typing module documentation does not typecheck

2016-06-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0aec17c8f434 by Guido van Rossum in branch '3.5': Fix issue #27402: example for typing did not type-check. https://hg.python.org/cpython/rev/0aec17c8f434 New changeset 57f3514564f6 by Guido van Rossum in branch 'default': Fix issue #27402: example

[issue27407] prepare_ssl.py missing in PCBuild folder

2016-06-28 Thread Steve Dower
Steve Dower added the comment: It would need someone to volunteer to port and maintain it. I don't believe any of the current team want to maintain two different versions of the script, considering we all use Python 3 and have it available when updating the version of OpenSSL used.

[issue27407] prepare_ssl.py missing in PCBuild folder

2016-06-28 Thread George Ge
George Ge added the comment: I see. Would it be possible to have a version of prepare_ssl.py written in 2.7 for the official source releases? -- ___ Python tracker

[issue27407] prepare_ssl.py missing in PCBuild folder

2016-06-28 Thread Steve Dower
Steve Dower added the comment: It can be found at PCbuild/prepare_ssl.py in the default branch. Copying it into the 2.7 branch wouldn't hurt I guess, and I'm okay with having build scripts in there that depend on Python 3 ;) -- ___ Python tracker

[issue27337] 3.6.0a2 tarball has weird paths

2016-06-28 Thread Ulrich Petri
Ulrich Petri added the comment: Just as another datapoint: This also breaks installing a2 with pythonz. -- nosy: +ulope ___ Python tracker ___

[issue27407] prepare_ssl.py missing in PCBuild folder

2016-06-28 Thread George Ge
New submission from George Ge: The readme.txt file in the PCBuild folder in Python 2.7.11 and 2.7.12 sources both contain instructions on how to configure to build a different OpenSSL version using PCbuild\prepare_ssl.py, but this file is missing on both versions. -- components:

[issue23749] asyncio missing wrap_socket (starttls)

2016-06-28 Thread Yury Selivanov
Yury Selivanov added the comment: > yuri, did you saw guido added review on your patch? Yes. There are few more issues with the patch that I want to resolve before re-submitting it for another review. Will do it soon. -- ___ Python tracker

[issue27385] itertools.groupby has misleading doc string

2016-06-28 Thread Raymond Hettinger
Changes by Raymond Hettinger : Added file: http://bugs.python.org/file43571/groupbydoc.diff ___ Python tracker ___

[issue27385] itertools.groupby has misleading doc string

2016-06-28 Thread Raymond Hettinger
Raymond Hettinger added the comment: That's okay. I'm taking care of both in this issue. -- ___ Python tracker ___

[issue26226] Various test suite failures on Windows

2016-06-28 Thread Emanuel Barry
Emanuel Barry added the comment: About the strptime failure - it seems time.strftime returns "Est (heure d?été)" while _strptime.LocaleTime().timezone has "est (heure d\x92été)". I don't know why it's like that, but neither are correct - the character that goes there is a single quote (').

[issue26226] Various test suite failures on Windows

2016-06-28 Thread Emanuel Barry
Emanuel Barry added the comment: Some of the tests that used to fail are now passing, however some are still failing (and new ones are also failing now). Tests that are still failing: test_code_module (TestInteractiveConsole; test_ps1 and test_ps2 failed) test_codecencodings_iso2022 (blame

[issue27385] itertools.groupby has misleading doc string

2016-06-28 Thread R. David Murray
R. David Murray added the comment: Please open a separate issue for that problem. -- nosy: +r.david.murray ___ Python tracker ___

[issue27385] itertools.groupby has misleading doc string

2016-06-28 Thread Josh Rosenberg
Josh Rosenberg added the comment: While you're fixing, the docstring should say "groupby(iterable, key=None)", not "groupby(iterable[, keyfunc])"; the functions accepts the key function by name, and the name is key, not keyfunc. And it can be passed explicitly as None (equivalent to not

[issue12319] [http.client] HTTPConnection.request not support "chunked" Transfer-Encoding to send data

2016-06-28 Thread Rolf Krahl
Rolf Krahl added the comment: Martin, I'm almost through with your comments. There is however one item that I need some feedback on: You asked for more documentation on the new EncodingError exception. This was introduced by Demian. It is raised when the Transfer-encoding header set by the

[issue27406] subprocess.Popen() hangs in multi-threaded code

2016-06-28 Thread R. David Murray
R. David Murray added the comment: This is a duplicate of issue 20318. The advice is to use subprocess32. -- nosy: +r.david.murray resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> subprocess.Popen can hang in threaded applications in Python 2

[issue27406] subprocess.Popen() hangs in multi-threaded code

2016-06-28 Thread Kristján Valur Jónsson
New submission from Kristján Valur Jónsson: On a quad-core raspberrypi, i have experienced that subprocess.Popen() sometimes does not return immediatelly, but only much later, when an unrelated process has exited. Debugging the issue, I find the parent process hanging in #

[issue26226] Various test suite failures on Windows

2016-06-28 Thread R. David Murray
R. David Murray added the comment: It looks like this issue can be closed, but a new one should be opened for dealing with the newline issue under git on windows. However, I'm surprised there weren't failures in the email tests. Although I've been moving the email tests away from depending

[issue27350] Compact and ordered dict

2016-06-28 Thread INADA Naoki
INADA Naoki added the comment: Anyone can review this by Python 3.6a3 ? -- ___ Python tracker ___ ___

[issue27141] Fix collections.UserList shallow copy

2016-06-28 Thread Bar Harel
Bar Harel added the comment: Are the patch and tests good? -- ___ Python tracker ___ ___ Python-bugs-list

[issue26971] python v3.5.1: sys.paths not respecting DESTDIRS and DESTSHARED

2016-06-28 Thread Xavier de Gaye
Xavier de Gaye added the comment: Johannes, what are the values of CONFIG_ARGS and libdir in the config.log of your Linux SuSE. -- nosy: +xdegaye ___ Python tracker

[issue21134] Segfault when stringifying UnicodeEncodeError (or UnicodeDecodeError) created with __new__()

2016-06-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: What is the bug here (except fixed segfault)? -- ___ Python tracker ___

[issue27405] Ability to trace Tcl commands executed by Tkinter

2016-06-28 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: For debugging purpose it would be helpful to have an ability to show all Tcl commands executed by Tkinter. In particular it would be helpful for testing wherever some issue is Tkinter issue or Tcl/Tk issue. I'm working on a patch, but there is a design

[issue21134] Segfault when stringifying UnicodeEncodeError (or UnicodeDecodeError) created with __new__()

2016-06-28 Thread STINNER Victor
STINNER Victor added the comment: > Since there was no complains on this issue, I think it can be closed. I have a complain: we should not ignore bugs. IMO an exception must be raised. -- status: pending -> open ___ Python tracker

[issue26226] Various test suite failures on Windows

2016-06-28 Thread STINNER Victor
STINNER Victor added the comment: It looks like all issues are now fixed in the default branch, no? Can we close this issue? -- ___ Python tracker ___

[issue27025] More human readable generated widget names

2016-06-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I'm working on a patch that allows to trace all Tcl commands passed from Tkinter, and a number of ".`" in widget names looks not nice. -- ___ Python tracker

[issue26226] Various test suite failures on Windows

2016-06-28 Thread Martin Panter
Martin Panter added the comment: Regarding the files getting messed up in Lib/test/cjkencodings, IMO the solution is to not configure Git to mess with newlines in files. ;) But perhaps a reasonable workaround might be to rename the relevant files to something like *.txt.bin. Perhaps that will

[issue21134] Segfault when stringifying UnicodeEncodeError (or UnicodeDecodeError) created with __new__()

2016-06-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: An empty string is the result of str() on an instance created with __new__ for all standard exceptions except SyntaxError (str() returnns 'None' for the latter, and this looks as a bug). Since there was no complains on this issue, I think it can be closed.

[issue27085] Make it possible to select return type for os.listdir

2016-06-28 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> rejected status: open -> closed ___ Python tracker ___

[issue27255] More opcode predictions

2016-06-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: OK, I'm only +0 on adding these predictions and fine with status quo. The ratio 28:1 looks compelling to me, but all this is not enough important. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue23395] _thread.interrupt_main() errors if SIGINT handler in SIG_DFL, SIG_IGN

2016-06-28 Thread STINNER Victor
STINNER Victor added the comment: > It seems to be against the current HEAD -- is there a chance that this will > be backported to 2.7 (which is what I need to use)? Yes, I will fix Python 2.7 and 3.5, I will just make PyErr_SetInterruptWithErr() private (rename to