[issue27525] Wrong OS header on file created by gzip module

Dor Dankner added the comment: I'm convinced. Thank you all for your comments :) -- status: open -> closed ___ Python tracker ___

[issue21136] fractions.Fraction.__pow__ does unneeded renormalization

Changes by Vedran Čačić : -- type: performance -> behavior ___ Python tracker ___ ___

[issue27535] Memory leaks when opening tons of files

Александр Карпинский added the comment: @serhiy.storchaka Any filters not solves the problem because warnings module SAVES EVERY WARNING MESSAGE for further duplication checks. Yes, the file name is helpful for determining the source of the POSSIBLE leak. While file name in error message IS

[issue27535] Memory leaks when opening tons of files

Serhiy Storchaka added the comment: The file name is helpful for determining the source of the leak. If you don't want to close files in your script, set an appropriate warning filter to silence this kind of warnings. -- nosy: +serhiy.storchaka ___

[issue27525] Wrong OS header on file created by gzip module

Serhiy Storchaka added the comment: This byte identifies the type of file system. How can you determine it? Note that different filesystems can be used on the same OS. FAT still widely used on Windows (and what about exFAT, should it be considered as a flavour of FAT or separate type?),

[issue27536] Convert readme to reStructuredText

Changes by Louis Taylor : -- title: Convert readme to markdown -> Convert readme to reStructuredText ___ Python tracker ___

[issue27536] Convert readme to markdown

Louis Taylor added the comment: Oh, that's a very good point. Patch updated. -- Added file: http://bugs.python.org/file43764/readme-to-rst.patch ___ Python tracker

[issue27536] Convert readme to markdown

Changes by Ned Deily : -- nosy: +brett.cannon ___ Python tracker ___ ___ Python-bugs-list

[issue27536] Convert readme to markdown

Ned Deily added the comment: Thanks for the patch. If we do want to use a markup language for the README, we would want to use reStructuredText, the standard markup language for CPython, rather than Markdown, which we currently don't use at all. Github supports both, doesn't it? And, for

[issue27536] Convert readme to markdown

New submission from Louis Taylor: Since the move to github is happening, the readme should probably be changed to markdown in order to render nicer on the github web interface. Issue 27476 introduced a .github folder, so it seems that preemptive changes for the migration are okay. --

[issue27507] bytearray.extend lacks overflow check when increasing buffer

Decorater added the comment: Only 1 way to find out, test it till it breaks. :P -- ___ Python tracker ___ ___

[issue27507] bytearray.extend lacks overflow check when increasing buffer

Martin Panter added the comment: Yeah I see your point. Anyway I think the current patch is fine. -- ___ Python tracker ___

[issue27533] release GIL in nt._isdir

Steve Dower added the comment: Maybe so. If you find a core developer who cares about performance in 2.7, maybe they'll merge it :) -- ___ Python tracker

[issue27535] Memory leaks when opening tons of files

New submission from Александр Карпинский: Actually, this issue is related to the warning module. The test script creates a lot of files with different names and deletes them. On the first pass the scripts calls the `f.close()` method for every file. On the second it doesn't. As a result, on

[issue27515] Dotted name re-import does not rebind after deletion

Terry J. Reedy added the comment: I understand the reluctance to generically encourage something that does not always arise. With Nick's promise to help examine any particular problems with deletion of tkinter modules, should they arise, I feel comfortable closing this. I already tested and

[issue25507] IDLE: user code 'import tkinter; tkinter.font' should fail

Terry J. Reedy added the comment: I am thinking about addin a test. -- status: closed -> pending ___ Python tracker ___

[issue27533] release GIL in nt._isdir

Eryk Sun added the comment: OK. I thought fixing bugs in 2.7 was at the discretion of core developers, including small tweaks for performance -- just not enhancements with significant amounts of new code and features. -- ___ Python tracker

[issue25507] IDLE: user code 'import tkinter; tkinter.font' should fail

Terry J. Reedy added the comment: PS: the test suite run without error on my Win10, 32bit build. -- ___ Python tracker ___

[issue25507] IDLE: user code 'import tkinter; tkinter.font' should fail

Terry J. Reedy added the comment: I decided to fix this issue for both 3.5 and 3.6 by deleting the submodules both from tkinter and sys.modules (as discussed in #27515). I used a new version of tkimports.py to check the result of user imports after the patch. When this file loaded into IDLE

[issue27533] release GIL in nt._isdir

Steve Dower added the comment: No, it's not a security fix, so it doesn't go in 2.7. -- ___ Python tracker ___

[issue27469] Unicode filename gets crippled on Windows when drag and drop

Steve Dower added the comment: Attached my first pass at the shell extension. As this has the potential to crash Windows Explorer, I want to be _really_ thorough, so all reviews and feedback welcomed. -- keywords: +patch Added file: http://bugs.python.org/file43760/27469_1.patch

[issue27534] IDLE: Reduce number and time for user process imports

New submission from Terry J. Reedy: This issue continues #25507. I still want to reduce the number of modules imported when run.py starts a user process and the time they require. In the process, I expect to reduce the number of tkinter module imports that need to be reversed and thereby

[issue27533] release GIL in nt._isdir

Changes by Jeremy Spiegel : Added file: http://bugs.python.org/file43758/_isdir.2.7.patch ___ Python tracker ___

[issue27533] release GIL in nt._isdir

Changes by Jeremy Spiegel : Removed file: http://bugs.python.org/file43757/_isdir.2.7.patch ___ Python tracker ___

[issue27533] release GIL in nt._isdir

Changes by Jeremy Spiegel : Added file: http://bugs.python.org/file43757/_isdir.2.7.patch ___ Python tracker ___

[issue27533] release GIL in nt._isdir

Eryk Sun added the comment: Should this be backported to 2.7 posix__isdir()? -- nosy: +eryksun ___ Python tracker ___

[issue27532] Dictionary iterator has no len()

R. David Murray added the comment: Please read the referenced issue. Your points are addressed there. -- ___ Python tracker ___

[issue27533] release GIL in nt._isdir

Steve Dower added the comment: LGTM. This is the kind of patch I can't wait to have a one-click merge button... right now it'll have to wait until I have a clean repo. But if anyone else wants to get it, go ahead. -- stage: -> patch review type: -> behavior versions: +Python 3.5,

[issue27532] Dictionary iterator has no len()

James Lu added the comment: I think you closed it too quickly. You see, computing the length of combinations() doesn't require looping all the way through the iterator; you can compute it quickly. I created a wrapper class just for this purpose. On Sat, Jul 16, 2016 at 5:24 PM, R. David Murray

[issue26974] Crash in Decimal.from_float

Stefan Krah added the comment: The approaches look good, but for clarity I want to replace all method calls that should never be overridden by the plain C functions of their corresponding static types. I have no opinion about the Python version. The diff also "fixes" #26975 for the C

[issue27533] release GIL in nt._isdir

Changes by R. David Murray : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker ___

[issue22246] add strptime(s, '%s')

Changes by Raymond Hettinger : -- nosy: +brett.cannon ___ Python tracker ___ ___

[issue27532] Dictionary iterator has no len()

R. David Murray added the comment: If you read issue 24849, you will see that iterators having len was rejected by Guido long ago. -- nosy: +r.david.murray ___ Python tracker

[issue27532] Dictionary iterator has no len()

Changes by R. David Murray : -- resolution: -> duplicate stage: -> resolved superseder: -> Add __len__ to map, everything in itertools ___ Python tracker

[issue27532] Dictionary iterator has no len()

Changes by R. David Murray : -- status: open -> closed ___ Python tracker ___ ___

[issue27532] Dictionary iterator has no len()

James Lu added the comment: same for itertools iterators - libraries such as tqdm would benefit from this On Sat, Jul 16, 2016 at 3:08 PM, James Lu wrote: > > New submission from James Lu: > > This would be useful for libraries like tqdm (progress bar module). > >

[issue27533] release GIL in nt._isdir

New submission from Jeremy Spiegel: In Modules/posixmodule.c, the function os__isdir_impl calls GetFileAttributesA/GetFileAttributesW without releasing the GIL. This is problematic since it can result in disk or network I/O, depending on the filesystem. -- components: Library (Lib)

[issue1621] Do not assume signed integer overflow behavior

Antti Haapala added the comment: Gnulib portability library has https://www.gnu.org/software/gnulib/manual/html_node/Integer-Range-Overflow.html and https://www.gnu.org/softwarhe/gnulib/manual/html_node/Integer-Type-Overflow.html and even macros for producing well-defined integer wraparound

[issue22246] add strptime(s, '%s')

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue27532] Dictionary iterator has no len()

New submission from James Lu: This would be useful for libraries like tqdm (progress bar module). -- components: Interpreter Core messages: 270581 nosy: James.Lu priority: normal severity: normal status: open title: Dictionary iterator has no len() type: enhancement versions: Python 3.6

[issue1621] Do not assume signed integer overflow behavior

Jeffrey Walton added the comment: > Has this sort of thing been done in other projects? Yes. If you are using C, you can use safe_iop. Android uses it for safer integer operations. If you are using C++, you can use David LeBlanc's SafeInt class. Microsoft uses it for safer inter operations.

[issue24954] No way to generate or parse timezone as produced by datetime.isoformat()

Alexander Belopolsky added the comment: Antti, while I see some convenience in making %z parsing promiscuous, there is clear utility in adding %:z to strftime. If we do that, not allowing the same for parsing will be odd. Let's start with that. A case for a promiscuous %z can be made

[issue27083] PYTHONCASEOK is ignored on Windows

Brett Cannon added the comment: Buildbots are green again and I addressed the key type issue. Thanks for letting me know about the failure, Martin. -- stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue27531] Documentation for assert_not_called() has wrong signature

New submission from Michael Killough: The documentation for `Mock.assert_not_called` gives its signature as `assert_not_called(*args, **kwargs)`. Since 01ae1ac2daf4, its signature has just been `assert_not_called()`. I've attached a trivial patch that updates the documentation to match the

[issue27083] PYTHONCASEOK is ignored on Windows

Roundup Robot added the comment: New changeset 6b46c1510bfa by Brett Cannon in branch '3.5': Fix regressions introduced by fixes for issue #27083. https://hg.python.org/cpython/rev/6b46c1510bfa New changeset f4c91b883772 by Brett Cannon in branch 'default': Merge for #27083

[issue24954] No way to generate or parse timezone as produced by datetime.isoformat()

Antti Haapala added the comment: Alexander: that is true, because they are *separate* conversion flags. However even the POSIX standard strptime has some leniency: '%m` and `%d` accept the numbers *without* leading zeroes. This actually also means that one cannot use `%Y%m%d` to detect an

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Changes by Alexander Belopolsky : -- nosy: +haypo stage: needs patch -> commit review ___ Python tracker ___

[issue24773] Implement PEP 495 (Local Time Disambiguation)

Alexander Belopolsky added the comment: Submitting the latest Github snapshot as a patch against master for review. See issue24773-s3-2.diff. -- Added file: http://bugs.python.org/file43753/issue24773-s3-2.diff ___ Python tracker

[issue24954] No way to generate or parse timezone as produced by datetime.isoformat()

Alexander Belopolsky added the comment: "Be conservative in what you do, be liberal in what you accept from others" I would agree to this approach with respect to a proposed fromisoformat() method (see issue 15873), but setptime seems to be about specifying an exact format. For example,

[issue27530] Non-Critical Compiler WARNING: Python Embedding C++11 does not allow non-constant string literals

New submission from Daniel Lord: ERROR SUMMARY: abstract.h:1332:60: warning: ISO C++ forbids converting a string constant to ‘char*’ [-Wwrite-strings] #define PyMapping_Keys(O) PyObject_CallMethod(O,"keys",NULL) ISSUE CRITICALITY: Non-fatal Warning (will become an error eventually when

[issue27529] Tkinter memory leak on OS X

Changes by Ned Deily : -- Removed message: http://bugs.python.org/msg270570 ___ Python tracker ___

[issue27529] Tkinter memory leak on OS X

Ned Deily added the comment: tkinter is pretty much just a thin wrapper around the Tcl/Tk C API so suspicion for behavior like this should start there. Usually, the easiest way to confirm that is to write an equivalent test in Tcl using its wish shell but, in this case, there's an even

[issue27529] Tkinter memory leak on OS X

Ned Deily added the comment: tkinter is pretty much just a thin wrapper around the Tcl/Tk C API so suspicion for behavior like this start there. Usually, the easiest way to confirm that is to write an equivalent test in Tcl using its wish shell but, in this case, there's an even easier way.

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: I am on Debian 8 "jessie" that only has Python 3.4, so I want to patch webbrowser.py in a backward-compatible way. -- ___ Python tracker

[issue27507] bytearray.extend lacks overflow check when increasing buffer

Xiang Zhang added the comment: I can't totally agree the point. The code means every time we increase the buffer by half the current length. So when the length arrives 2/3 * PY_SSIZE_T_MAX it's going to overflow. There is a 1/3 * PY_SSIZE_T_MAX gap between the theoretical upper limit. I think

[issue23262] webbrowser module broken with Firefox 36+

Berker Peksag added the comment: I was talking about webbrowser.py-3.4-newfox.patch 3.4 is now in security-fix-only mode so we can't push the patch to the 3.4 branch. -- ___ Python tracker

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: Updated patch for Python 2.7 with subprocess.check_output(). -- Added file: http://bugs.python.org/file43751/webbrowser.py-2.7-newfox.patch ___ Python tracker

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: Updated patch for Python 3.4+ with subprocess.check_output(). -- Added file: http://bugs.python.org/file43752/webbrowser.py-3.4-newfox.patch ___ Python tracker

[issue27507] bytearray.extend lacks overflow check when increasing buffer

Martin Panter added the comment: Not particularly related, but the special fast case in Objects/listobject.c:811, listextend(), also seems to lack an overflow check. “An alternative would be to raise the error without trying to allocate Py_SSIZE_T_MAX first”: what I meant was removing the

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: Not subprocess.run() as I'm aiming to Python 2.7. Perhaps subprocess.check_output(). I'll try it. -- ___ Python tracker

[issue1621] Do not assume signed integer overflow behavior

Martin Panter added the comment: I tried the newer -fsanitize=undefined mode, and it is better than -ftrapv. It adds instrumentation that by default nicely reports the errors and continues running. My problem with the large slice step is not restricted to Element Tree; it affects list

[issue27130] zlib: OverflowError while trying to compress 2^32 bytes or more

Changes by Martin Panter : -- Removed message: http://bugs.python.org/msg270561 ___ Python tracker ___

[issue27130] zlib: OverflowError while trying to compress 2^32 bytes or more

Martin Panter added the comment: I added one comment, but I think this might almost be ready -- ___ Python tracker ___

[issue27130] zlib: OverflowError while trying to compress 2^32 bytes or more

Xiang Zhang added the comment: Upload the v9 version. It applies your last comment and catch up with the hg tip. -- Added file: http://bugs.python.org/file43750/64bit_support_for_zlib_v9.patch ___ Python tracker

[issue27525] Wrong OS header on file created by gzip module

R. David Murray added the comment: This is a harder call than #27521. There (IUUC), the *wrong* compression level was specified. Here, 'unknown' is a valid value. The biggest disadvantage of changing this is the maintenance burden of keeping it up to date with platform changes (eg: we're

[issue27527] Make not yielding from or awaiting a coroutine a SyntaxError

R. David Murray added the comment: Also, fyi it was couterproductive to code this as a Windows issue...that alerted the windows experts, but it is not a windows-specific issue, so it just pinged them needlessly. Also FYI, enahancements can only go into the next feature release, so the

[issue27527] Make not yielding from or awaiting a coroutine a SyntaxError

R. David Murray added the comment: It can't be a syntax error. There are legitimate reasons for calling a coroutine and then passing around the resulting object before awaiting it. -- nosy: +r.david.murray resolution: -> rejected stage: -> resolved status: open -> closed

[issue23262] webbrowser module broken with Firefox 36+

Berker Peksag added the comment: Thanks for the patches! Can't you just use a function from the high level subprocess API (like subprocess.run()? -- stage: -> patch review versions: +Python 3.6 -Python 3.4 ___ Python tracker

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: Patch for Python 3.4 and 3.5 to support Firefox >= 36.0, with version test. -- Added file: http://bugs.python.org/file43749/webbrowser.py-3.4-newfox.patch ___ Python tracker

[issue23262] webbrowser module broken with Firefox 36+

Oleg Broytman added the comment: Patch for Python 2.7 to support Firefox >= 36.0, with version test. -- keywords: +patch Added file: http://bugs.python.org/file43748/webbrowser.py-2.7-newfox.patch ___ Python tracker

[issue23262] webbrowser module broken with Firefox 36+

Changes by Antoine Pitrou : -- nosy: -pitrou ___ Python tracker ___ ___ Python-bugs-list

[issue25571] Improve the lltrace feature with the Py_Debug mode

Stéphane Wirtel added the comment: here is the patch, if you want to test it, just use the REPL and add __ltrace__ = None in the REPL. -- Added file: http://bugs.python.org/file43747/issue25571-2.diff ___ Python tracker

[issue25571] Improve the lltrace feature with the Py_Debug mode

Stéphane Wirtel added the comment: Here is a small example of lltrace when you enable it. ``` stephane@sg1 ~/s/h/cpython> ./python Python 3.6.0a3+ (default:0d8f139a6e19+, Jul 16 2016, 11:59:46) [GCC 6.1.1 20160621 (Red Hat 6.1.1-3)] on linux Type "help", "copyright", "credits" or "license"

[issue20842] pkgutil docs should reference glossary terms not PEP 302

Martin Panter added the comment: I still think the links are too dense. Three links to the same term in two short paragraphs is too much. Do you think it would be okay to just link the first occurrence for pkgutil.ImpImporter? Also, there is still a problem at least the definition of “finder”

[issue27529] Tkinter memory leak on OS X

New submission from Mirano Tuk: There seems to be a memory leak in tkinter on OSX (Windows and Linux don't seem to be affected). Explicitly calling Tk.update() sometimes permanently allocates a multiple of 4096 bytes. Allocation happens more frequently if update calls are in close succession.

[issue27525] Wrong OS header on file created by gzip module

Dor Dankner added the comment: It does not seem like a feature after you see this issue #27521. The OS was just hardcoded, the same way the compression level was hardcoded. you may say it's a feature too :P The way I see it, the gzip module should at least work like the original GNU gzip, if

[issue21136] fractions.Fraction.__pow__ does unneeded renormalization

Vedran Čačić added the comment: Unfortunately, this introduced a bug. It seems Mark Dickinson should go easier on his LGTMs. :-) >>> import fractions >>> fractions.Fraction(-1, 2) ** -1 Fraction(2, -1) That is a really strange object, since it's not normalized, and many functions expect all

[issue27487] -m switch regression in Python 3.5.2 (under rare circumstances)

Martin Panter added the comment: Here is a patch with the proposed warning. I think “Error finding module specification” might be a bit better than the current “finding spec”, so I included that change. With the patch, this is what the messages look like: $ ./python -m package.module

[issue27528] Document that filterwarnings(message=...) matches the start of a message

New submission from Martin Panter: I assumed that the “message” parameter could be used to match any substring of a warning message, but it turns out it calls regex.match(), which is anchored at the beginning of the search string (but is not anchored at the end). I propose this patch to

[issue27083] PYTHONCASEOK is ignored on Windows

Martin Panter added the comment: This appears to have broken the tests on Windows: http://buildbot.python.org/all/builders/x86%20Windows7%203.5/builds/1030/steps/test/logs/stdio == FAIL: test_insensitive

[issue27285] Document the deprecation of pyvenv in favor of `python3 -m venv`

Roundup Robot added the comment: New changeset 0d8f139a6e19 by Martin Panter in branch 'default': Issue #27285: Cleanup leftover susp-ignored entry after text was changed https://hg.python.org/cpython/rev/0d8f139a6e19 -- ___ Python tracker

[issue24954] No way to generate or parse timezone as produced by datetime.isoformat()

Antti Haapala added the comment: "Be conservative in what you do, be liberal in what you accept from others" they say. Also Z as a timezone designator is also widely used in iso 8601 timestamps. I believe the effort should be made to *parse* *any/all* of the ISO 8601 supported time-zone codes

[issue27515] Dotted name re-import does not rebind after deletion

Nick Coghlan added the comment: Terry: it's not a 100% guarantee, but it should be sufficient for your purposes (the more obscure failure modes mostly relate to C level globals, Python level module globals, pickling, and module import having side effects on state in other modules, and it's

[issue27527] Make not yielding from or awaiting a coroutine a SyntaxError

Decorater added the comment: So to make it Error it must be : import asyncio async def SomeCoroutine(): print("test...") SomeCoroutine() -- ___ Python tracker

[issue27527] Make not yielding from or awaiting a coroutine a SyntaxError

Decorater added the comment: Oh it does not happen if you use the asyncio.coroutine decorater but it does do RuntimeWarning if you use the async def on it. -- versions: -Python 3.4 ___ Python tracker