[issue28502] [Patch] Make os.chdir() optional

2016-10-21 Thread Ed Schouten
New submission from Ed Schouten: CloudABI is a POSIX-like strongly sandboxed runtime environment, for which we got Python to work (https://mail.python.org/pipermail/python-dev/2016-July/145708.html). Patches for this are slowly being upstreamed. CloudABI uses a capability-based security

[issue28501] [Patch] Make os.umask() optional

2016-10-21 Thread Ed Schouten
New submission from Ed Schouten: CloudABI is a POSIX-like strongly sandboxed runtime environment, for which we got Python to work (https://mail.python.org/pipermail/python-dev/2016-July/145708.html). Patches for this are slowly being upstreamed. As CloudABI uses a capability-based security

[issue20847] asyncio docs should call out that network logging is a no-no

2016-10-21 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: Hi, I added to asyncio logging doc that the log file should point to a file on local filesystem. Please review. Thanks :) -- keywords: +patch nosy: +Mariatta Added file: http://bugs.python.org/file45182/issue20847.patch

[issue27701] [posixmodule] [Refactoring patch] Simply call into *at() functions unconditionally when present

2016-10-21 Thread Ed Schouten
Ed Schouten added the comment: Attached is an updated version of the patch that applies cleanly against Python 3.6.0b2. -- Added file: http://bugs.python.org/file45181/27701.diff ___ Python tracker

[issue28435] test_urllib2_localnet.ProxyAuthTests fails with no_proxy and NO_PROXY env

2016-10-21 Thread Martin Panter
Martin Panter added the comment: I altered the comment (looks like it was a copy from code forcing proxies to be bypassed). Also, I didn’t port the second no_proxy fix to 2.7; it looks like there is a different workaround there which is not affected by the environment. -- resolution:

[issue28435] test_urllib2_localnet.ProxyAuthTests fails with no_proxy and NO_PROXY env

2016-10-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8f4424bdeadc by Martin Panter in branch '2.7': Issue #28435: Avoid no_proxy environment variable interfering with tests https://hg.python.org/cpython/rev/8f4424bdeadc New changeset dc9ad44125de by Martin Panter in branch '3.5': Issue #28435: Avoid

[issue26620] Fix ResourceWarning warnings in test_urllib2_localnet

2016-10-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset d76fccbad014 by Martin Panter in branch '3.5': Issue #26620: Fix ResourceWarning in test_urllib2_localnet https://hg.python.org/cpython/rev/d76fccbad014 -- ___ Python tracker

[issue27755] Retire DynOptionMenu with a ttk Combobox

2016-10-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: I did some experiments that cleared up some previous puzzlements about seemingly inconsistent behavior between interactive commands and those in scripts. The following prints '.mycombo' twice, on two lines, after selecting 'beta'. import tkinter as tk from

[issue27755] Retire DynOptionMenu with a ttk Combobox

2016-10-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: Your ping got me to look at the doc for tk_optionMenu, which is a function rather than a widget (http://www.tcl.tk/man/tcl8.6/TkCmd/optionMenu.htm), the code for tkinter.OptionMenu (the only accurate doc I know of), which is a widget with the function API,

[issue26240] Docstring of the subprocess module should be cleaned up

2016-10-21 Thread Martin Panter
Changes by Martin Panter : Added file: http://bugs.python.org/file45180/subprocess3-2.7.patch ___ Python tracker ___

[issue26240] Docstring of the subprocess module should be cleaned up

2016-10-21 Thread Martin Panter
Martin Panter added the comment: Here are corresponding patches for 3.5 and 2.7. -- stage: patch review -> commit review Added file: http://bugs.python.org/file45179/subprocess3-3.5.patch ___ Python tracker

[issue23214] BufferedReader.read1(size) signature incompatible with BufferedIOBase.read1(size=-1)

2016-10-21 Thread Martin Panter
Changes by Martin Panter : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue28482] test_typing fails if asyncio unavailable

2016-10-21 Thread Martin Panter
Martin Panter added the comment: Yep, working well. Thanks Guido & Ivan. -- stage: commit review -> resolved ___ Python tracker ___

[issue27321] Email parser creates a message object that can't be flattened

2016-10-21 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: While I was reviewing https://gitlab.com/mailman/mailman/merge_requests/197/diffs I noticed the KeyError and it made me thing "hmm, I wonder if this should be turned into one of the email package errors"? -- ___

[issue28498] tk busy command

2016-10-21 Thread klappnase
klappnase added the comment: Oops, just made a quick test with Python3, and found that I had missed that types.StringType is no longer present. So to be compatible with Python3 the busy_configure() func ought to look like: def busy_configure(self, cnf=None, **kw): if kw:

[issue28482] test_typing fails if asyncio unavailable

2016-10-21 Thread Guido van Rossum
Guido van Rossum added the comment: Martin can you verify that this worked? -- resolution: -> fixed stage: patch review -> commit review status: open -> closed ___ Python tracker

[issue28482] test_typing fails if asyncio unavailable

2016-10-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset c3363f684a2d by Guido van Rossum in branch '3.5': Issue #28482: Skip a few test_typing tests if asyncio unavailable https://hg.python.org/cpython/rev/c3363f684a2d New changeset 8f3b4779afaf by Guido van Rossum in branch '3.6': Issue #28482: Skip a

[issue28498] tk busy command

2016-10-21 Thread klappnase
klappnase added the comment: Funny thing, just today I came across the same issue. So far I came up with an a little bit refined version of the OP's suggestions. Until now I have tested this with Python-2.7.9 and tk-8.6.0 on debian Jessie, I think the same code should work for Python-3 , too.

[issue23214] BufferedReader.read1(size) signature incompatible with BufferedIOBase.read1(size=-1)

2016-10-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 2af6d94de492 by Martin Panter in branch 'default': Issue #23214: Fix formatting of -1 https://hg.python.org/cpython/rev/2af6d94de492 -- ___ Python tracker

[issue28499] Logging module documentation needs a rework.

2016-10-21 Thread Ned Deily
Changes by Ned Deily : -- nosy: +vinay.sajip ___ Python tracker ___ ___ Python-bugs-list

[issue28482] test_typing fails if asyncio unavailable

2016-10-21 Thread Ivan Levkivskyi
Ivan Levkivskyi added the comment: Martin, I have opened a PR with your patch at python/typing https://github.com/python/typing/pull/304 -- ___ Python tracker

[issue28414] SSL match_hostname fails for internationalized domain names

2016-10-21 Thread Yury Selivanov
Yury Selivanov added the comment: Christian, what's the status on this one? -- ___ Python tracker ___ ___

[issue28482] test_typing fails if asyncio unavailable

2016-10-21 Thread Martin Panter
Martin Panter added the comment: I will this to Git Hub when I get a chance to get set up, if that helps though :) -- ___ Python tracker ___

[issue23214] BufferedReader.read1(size) signature incompatible with BufferedIOBase.read1(size=-1)

2016-10-21 Thread Martin Panter
Martin Panter added the comment: Modifying the API to accept a keyword argument is not worthwhile IMO. That means modifying modules like http.client and zipfile (which use the wrong keyword name), and user-defined implementations may become incompatible. The question of documentation is

[issue28208] update sqlite to 3.14.2

2016-10-21 Thread Stéphane Wirtel
Changes by Stéphane Wirtel : -- stage: needs patch -> commit review ___ Python tracker ___

[issue26796] BaseEventLoop.run_in_executor shouldn't specify max_workers for default Executor

2016-10-21 Thread Yury Selivanov
Yury Selivanov added the comment: Thank you, Hans! -- resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.6, Python 3.7 ___ Python tracker

[issue26796] BaseEventLoop.run_in_executor shouldn't specify max_workers for default Executor

2016-10-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 785597e758a1 by Yury Selivanov in branch '3.5': Issue #26796: Don't configure the number of workers for default threadpool executor. https://hg.python.org/cpython/rev/785597e758a1 New changeset 99941cacfc38 by Yury Selivanov in branch '3.6': Merge

[issue28482] test_typing fails if asyncio unavailable

2016-10-21 Thread Guido van Rossum
Guido van Rossum added the comment: Ivan, if you want to apply it upstream be my guest! -- ___ Python tracker ___

[issue24658] open().write() fails on 2 GB+ data (OS X)

2016-10-21 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: upload a new version -- Added file: http://bugs.python.org/file45178/issue24658-3-3.6.diff ___ Python tracker ___

[issue24882] ThreadPoolExecutor doesn't reuse threads until #threads == max_workers

2016-10-21 Thread David MacKenzie
David MacKenzie added the comment: If each worker thread ties up other resources in an application, such as handles to server connections, conserving threads could have a significant impact. That's the situation for an application I am involved with. I've written and tested a patch to make

[issue26923] asyncio.gather drops cancellation

2016-10-21 Thread Yury Selivanov
Yury Selivanov added the comment: Thank you, Johannes! -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue26923] asyncio.gather drops cancellation

2016-10-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset b1aa485fad1b by Yury Selivanov in branch '3.5': Issue #26923: Fix asyncio.Gather to refuse being cancelled once all children are done. https://hg.python.org/cpython/rev/b1aa485fad1b New changeset b0af901b1e2a by Yury Selivanov in branch '3.6':

[issue28482] test_typing fails if asyncio unavailable

2016-10-21 Thread Ivan Levkivskyi
Changes by Ivan Levkivskyi : -- nosy: +levkivskyi ___ Python tracker ___ ___

[issue28497] future in tkinter

2016-10-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This is not Python issue, this is an issue of the future module. _default_root is dynamic attribute, it shouldn't be imported. And it is is private undocumented implementation detail, be careful with its using. -- nosy: +serhiy.storchaka resolution:

[issue28500] pep 525/asyncio: Handle when async generators are GCed from another thread

2016-10-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3908f432d0ac by Yury Selivanov in branch '3.6': Issue #28500: Fix asyncio to handle async gens GC from another thread. https://hg.python.org/cpython/rev/3908f432d0ac New changeset 3c82fa5b7b52 by Yury Selivanov in branch 'default': Merge 3.6 (issue

[issue28500] pep 525/asyncio: Handle when async generators are GCed from another thread

2016-10-21 Thread Yury Selivanov
Changes by Yury Selivanov : -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue28500] pep 525/asyncio: Handle when async generators are GCed from another thread

2016-10-21 Thread Yury Selivanov
New submission from Yury Selivanov: Proxy for https://github.com/python/asyncio/pull/447 -- assignee: yselivanov components: asyncio messages: 279154 nosy: gvanrossum, yselivanov priority: normal severity: normal stage: resolved status: open title: pep 525/asyncio: Handle when async

[issue28212] Closing server in asyncio is not efficient

2016-10-21 Thread Yury Selivanov
Yury Selivanov added the comment: > Seems that its not so hard - in loop.remove_reader add If you have a patch in mind, please create a PR on github.com/python/asyncio -- ___ Python tracker

[issue28498] tk busy command

2016-10-21 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka components: +Library (Lib) nosy: +serhiy.storchaka stage: -> needs patch type: -> enhancement versions: -Python 2.7, Python 3.3, Python 3.4, Python 3.5, Python 3.6

[issue28213] asyncio SSLProtocol _app_transport is private

2016-10-21 Thread Yury Selivanov
Yury Selivanov added the comment: Closing this one. I don't think we want to expose/document _app_transport. -- resolution: -> wont fix stage: -> resolved status: open -> closed ___ Python tracker

[issue28498] tk busy command

2016-10-21 Thread Miguel
New submission from Miguel: tcl tk 8.6.6 has a new busy command. The new tkinter library doesn't provide an interface for this command. https://www.tcl.tk/man/tcl/TkCmd/busy.htm The solution is to add to the class Misc of tkinter these methods: def tk_busy(self, *args, **kw):

[issue21081] missing vietnamese codec TCVN 5712:1993 in Python

2016-10-21 Thread Antti Haapala
Antti Haapala added the comment: Ah there was something that I overlooked before - the VN1 and VN2 both have combining accents too. If I read correctly, the main letter should precede the combining character, just as in Unicode; VN3 seems to lack combining characters altogether. Thus, for

[issue28430] asyncio: C implemeted Future cause Tornado test fail

2016-10-21 Thread Yury Selivanov
Yury Selivanov added the comment: The patch looks good. 2 things: - It appears it also touches Misc/NEWS a bit too much. Please make sure to not to commit that. - I'd also add a comment explaining why we ignore values passed to FI.send() and simply send None. The reason is how

[issue28499] Logging module documentation needs a rework.

2016-10-21 Thread Pierre Bousquie
New submission from Pierre Bousquie: At pyconf-fr 2016 Florian Strzelecki (@Exirel) made a great talk on how to make good documentation. At one time he asked "python logging doc?, did you realy found it clear and helpfull?" clear answer from the crowd: not at all. Stephane Wirtel ask us (the

[issue28499] Logging module documentation needs a rework.

2016-10-21 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: Hi Pierre, Thank you for your issue and mainly for me ;-) Now, I am really interested by your feedback or the feedback of Florian Strzelecki because he can give us the organization of the sections and maybe we can try to improve the current documentation of

[issue28497] future in tkinter

2016-10-21 Thread Miguel
New submission from Miguel: I load the future package. In the new package installed here: python2.7/dist-packages/tkinter/__init__.py it's not possible to import _default_root. One possible solution is to create a method in tkinter module that returns the _default_root object. ``` def

[issue21081] missing vietnamese codec TCVN 5712:1993 in Python

2016-10-21 Thread Antti Haapala
Antti Haapala added the comment: I found the full document on SlideShare: http://www.slideshare.net/sacobat/tcvn-5712-1993-cng-ngh-thng-tin-b-m-chun-8bit-k-t-vit-dng-trong-trao-i-thng-tin As far as I can understand, they're "subsets" of each other only in the sense that VN1 has the widest

[issue28439] Remove redundant checks in PyUnicode_EncodeLocale and PyUnicode_DecodeLocaleAndSize

2016-10-21 Thread Xiang Zhang
Xiang Zhang added the comment: Thanks for your review Serhiy. I don't receive the notification. :-( Honestly speaking I miss some notification emails from time to time, but not all. I'll consider choosing another ISP. I have to manually check the Rietveld now to avoid missing any comments.

[issue24882] ThreadPoolExecutor doesn't reuse threads until #threads == max_workers

2016-10-21 Thread David MacKenzie
David MacKenzie added the comment: This issue seems to overlap with 14119. -- ___ Python tracker ___ ___

[issue28396] Remove *.pyo references from man page

2016-10-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0c298486d879 by Brett Cannon in branch '3.5': Issue #28396: Remove any mention of .pyo files from the man page. https://hg.python.org/cpython/rev/0c298486d879 New changeset b33c7055220e by Brett Cannon in branch '3.6': Merge (issue #28396)

[issue25152] venv documentation doesn't tell you how to specify a particular version of python

2016-10-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9feff7ba89b2 by Brett Cannon in branch '3.5': Issue #25152: Mention the deprecation of pyvenv https://hg.python.org/cpython/rev/9feff7ba89b2 New changeset 126ff1f3b6cd by Brett Cannon in branch '3.6': Merge (issue #25152)

[issue28396] Remove *.pyo references from man page

2016-10-21 Thread Brett Cannon
Brett Cannon added the comment: Thanks for the patch, Ville! -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue25152] venv documentation doesn't tell you how to specify a particular version of python

2016-10-21 Thread Brett Cannon
Changes by Brett Cannon : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker ___

[issue28439] Remove redundant checks in PyUnicode_EncodeLocale and PyUnicode_DecodeLocaleAndSize

2016-10-21 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Added comments on Rietveld. Xiang, seem you have provided wrong e-mail address for Rietveld. I constantly get error messages "Undelivered Mail Returned to Sender" after pushing comments to patches that your are following. I suppose you don't receive

[issue21081] missing vietnamese codec TCVN 5712:1993 in Python

2016-10-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Since no Unicode mapping table is found at the Unicode website, we need at least the link to public official document that specifies the encoding. If VN3 is a subset of VN2, which itself is a subset of VN1, VN1 definitely looks the most preferable choice

[issue28281] Remove year limits from calendar

2016-10-21 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: Who can merge this patch ? -- nosy: +matrixise ___ Python tracker ___ ___

[issue28281] Remove year limits from calendar

2016-10-21 Thread Stéphane Wirtel
Changes by Stéphane Wirtel : -- stage: needs patch -> commit review ___ Python tracker ___

[issue28496] Mark up constants 0, 1, -1 in C API docs

2016-10-21 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: Serhiy, I think you can commit it. -- nosy: +matrixise stage: patch review -> commit review ___ Python tracker ___

[issue28492] C implementation of asyncio.Future doesn't set value of StopIteration correctly

2016-10-21 Thread Yury Selivanov
Changes by Yury Selivanov : -- stage: commit review -> resolved ___ Python tracker ___

[issue28208] update sqlite to 3.14.2

2016-10-21 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: how to build the osx installer ? Thank you -- ___ Python tracker ___ ___

[issue28439] Remove redundant checks in PyUnicode_EncodeLocale and PyUnicode_DecodeLocaleAndSize

2016-10-21 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___

[issue28426] PyUnicode_AsDecodedObject can only return unicode now

2016-10-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Marc-Andre, what are your thoughts about this? -- ___ Python tracker ___

[issue24658] open().write() fails on 2 GB+ data (OS X)

2016-10-21 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: Victor, could you check the new patch ? -- Added file: http://bugs.python.org/file45177/issue24658-2-3.6.diff ___ Python tracker

[issue18219] csv.DictWriter is slow when writing files with large number of columns

2016-10-21 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: Thanks David. I uploaded patch to address your concern with the docs. Can you please check? Serhiy, with regards to applying docs and test to 3.5, does that require a different patch than what I have? Thanks. -- Added file:

[issue28214] Improve exception reporting for problematic __set_name__ attributes

2016-10-21 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue28410] Add convenient C API for "raise ... from ..."

2016-10-21 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue28410] Add convenient C API for "raise ... from ..."

2016-10-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 969c8bfe8872 by Serhiy Storchaka in branch '3.6': Issue #28410: Added _PyErr_FormatFromCause() -- the helper for raising https://hg.python.org/cpython/rev/969c8bfe8872 New changeset 2119cb0beace by Serhiy Storchaka in branch 'default': Issue

[issue28214] Improve exception reporting for problematic __set_name__ attributes

2016-10-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset f7e1e39ccddd by Serhiy Storchaka in branch '3.6': Issue #28214: Improved exception reporting for problematic __set_name__ https://hg.python.org/cpython/rev/f7e1e39ccddd New changeset 7c3ec24f4582 by Serhiy Storchaka in branch 'default': Issue

[issue18219] csv.DictWriter is slow when writing files with large number of columns

2016-10-21 Thread R. David Murray
R. David Murray added the comment: Serhiy: I know you prefer applying test changes to the maint version, and I don't disagree, but there are others who prefer not to and we really don't have an official policy on it at this point. (We used to say no, a few years ago :) The doc change looks

[issue28447] socket.getpeername() failure on broken TCP/IP connection

2016-10-21 Thread R. David Murray
R. David Murray added the comment: The socket module is a relatively thin wrapper around the C socket library. 'getpeername' is inspecting the *current* peer of the socket, and if there is no current peer, there is no current peer name. Retaining information the socket library does not is

[issue28495] MagickMock created by patсh annotation refuses to apply function side_effect at second time

2016-10-21 Thread R. David Murray
R. David Murray added the comment: Your test file only compiles the function definitions, it doesn't actually run any code. If I convert it into a unittest, it works as expected. If this is minimized example of code where you actually found a problem, I suspect there's something else wrong

[issue28410] Add convenient C API for "raise ... from ..."

2016-10-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 81666d3e4a37 by Serhiy Storchaka in branch '3.5': Issue #28410: Keep the traceback of original exception in _PyErr_ChainExceptions(). https://hg.python.org/cpython/rev/81666d3e4a37 New changeset 23a1d9ec35d5 by Serhiy Storchaka in branch '3.6':

[issue18219] csv.DictWriter is slow when writing files with large number of columns

2016-10-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Shouldn't docs changes and new tests be added to 3.5? -- ___ Python tracker ___

[issue28491] Remove bundled libffi for OSX

2016-10-21 Thread Kubilay Kocak
Changes by Kubilay Kocak : -- nosy: +koobs ___ Python tracker ___ ___

[issue28491] Remove bundled libffi for OSX

2016-10-21 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: Hi Ronald, As you can see in my message #msg279069 I have tested with the last version of libffi (installed with HomeBrew), so in this case, I think we can say "Yes" to your question, the current release of libffi works fine with OSX. Now, I can check more

[issue28491] Remove bundled libffi for OSX

2016-10-21 Thread Ronald Oussoren
Ronald Oussoren added the comment: Does the upstream libffi work reliably on OSX by this time? The bundled version of libffi was extracted from PyObjC, and that copy is itself a patched version of the system libffi on OSX. The reason I don't use the system libffi is both that I don't want

[issue18219] csv.DictWriter is slow when writing files with large number of columns

2016-10-21 Thread INADA Naoki
INADA Naoki added the comment: committed. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue18219] csv.DictWriter is slow when writing files with large number of columns

2016-10-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1928074e6519 by INADA Naoki in branch '3.6': Issue #18219: Optimize csv.DictWriter for large number of columns. https://hg.python.org/cpython/rev/1928074e6519 New changeset 6f1602dfa4d5 by INADA Naoki in branch 'default': Issue #18219: Optimize

[issue18219] csv.DictWriter is slow when writing files with large number of columns

2016-10-21 Thread Mariatta Wijaya
Changes by Mariatta Wijaya : Added file: http://bugs.python.org/file45175/issue18219v8.patch ___ Python tracker ___

[issue18219] csv.DictWriter is slow when writing files with large number of columns

2016-10-21 Thread STINNER Victor
STINNER Victor added the comment: > My mentor (Yury) prohibit it while I'm beginner. Oh right, trust your mentor more than me ;-) -- ___ Python tracker

[issue18219] csv.DictWriter is slow when writing files with large number of columns

2016-10-21 Thread INADA Naoki
INADA Naoki added the comment: > If you are confident (ex: if the change is simple, like this one), you can > push it directly. My mentor (Yury) prohibit it while I'm beginner. And as you saw, I missed PEP 8 violation :) -- ___ Python tracker

[issue18219] csv.DictWriter is slow when writing files with large number of columns

2016-10-21 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: Inada-san, Victor, thank you. Here is the updated patch. -- Added file: http://bugs.python.org/file45174/issue18219v7.patch ___ Python tracker

[issue18219] csv.DictWriter is slow when writing files with large number of columns

2016-10-21 Thread STINNER Victor
STINNER Victor added the comment: issue18219v6.patch: LGTM, but I added a minor PEP 8 comment. INADA Naoki: "LGTM, Thanks Mariatta. (But one more LGTM from coredev is required for commit)" If you are confident (ex: if the change is simple, like this one), you can push it directly.

[issue18219] csv.DictWriter is slow when writing files with large number of columns

2016-10-21 Thread INADA Naoki
INADA Naoki added the comment: LGTM, Thanks Mariatta. (But one more LGTM from coredev is required for commit) -- nosy: +inada.naoki versions: -Python 3.5 ___ Python tracker

[issue18219] csv.DictWriter is slow when writing files with large number of columns

2016-10-21 Thread Mariatta Wijaya
Changes by Mariatta Wijaya : Added file: http://bugs.python.org/file45173/issue18219v6.patch ___ Python tracker ___

[issue18219] csv.DictWriter is slow when writing files with large number of columns

2016-10-21 Thread Mariatta Wijaya
Changes by Mariatta Wijaya : Added file: http://bugs.python.org/file45172/issue18219v5.patch ___ Python tracker ___

[issue28496] Mark up constants 0, 1, -1 in C API docs

2016-10-21 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Proposed patch marks up constants 0, 1 and -1 (mostly return values) in C API documentation as literal test. Most occurrences already are marked up. It also changes :const:`ULONG_MAX + 1` to ``ULONG_MAX + 1``, since this is not a constant name.

[issue18219] csv.DictWriter is slow when writing files with large number of columns

2016-10-21 Thread Mariatta Wijaya
Changes by Mariatta Wijaya : Added file: http://bugs.python.org/file45170/issue18219v4.patch ___ Python tracker ___

[issue18219] csv.DictWriter is slow when writing files with large number of columns

2016-10-21 Thread Mariatta Wijaya
Changes by Mariatta Wijaya : Added file: http://bugs.python.org/file45169/issue18219v3.patch ___ Python tracker ___

[issue23214] BufferedReader.read1(size) signature incompatible with BufferedIOBase.read1(size=-1)

2016-10-21 Thread STINNER Victor
STINNER Victor added the comment: 2016-10-21 5:17 GMT+02:00 Martin Panter : > The idea of changing the signature is to avoid people thinking it accepts a > keyword argument. See e.g. Issue 25030 for seek(offset, whence=SEEK_SET), > Issue 14586 for truncate(size=None).

[issue28099] Drop Mac OS X Tiger support in Python 3.6

2016-10-21 Thread Ned Deily
Ned Deily added the comment: With the recent changes (fd9a4bd16587) in Issue28092 to make the dtrace stubs static inline, 3.6 once again compiles and links with the Xcode 2.5 gcc4.0 on Mac OS X 10.4. We can look at this again for 3.7. -- resolution: -> out of date stage: ->