[issue7434] general pprint rewrite

Changes by Andreas Stenberg : -- nosy: +astenberg ___ Python tracker ___ ___

[issue28689] OpenSSL 1.1.0c test failures

Matthias Klose added the comment: Fyi, Debian's 1.1.0c is fixed, so please don't blacklist this version in general. -- nosy: +doko ___ Python tracker

[issue28968] xml rpc server fails with connection reset by peer error no 104

Changes by Manish Singh : -- nosy: +loewis ___ Python tracker ___ ___ Python-bugs-list

[issue28968] xml rpc server fails with connection reset by peer error no 104

Manish Singh added the comment: Hi loewis, Can you please look into this issue -- ___ Python tracker ___ ___

[issue28147] Unbounded memory growth resizing split-table dicts

Wenzel Jakob added the comment: Hi, pybind11 (https://github.com/pybind/pybind11) dev here. We're seeing massive memory increases due to this bug, which completely break our test suite (and likely any use of this library, which is commonly used to bind C++ code to Python). Please look at

[issue5322] Python 2.6 object.__new__ argument calling autodetection faulty

Serhiy Storchaka added the comment: Yes, it was what the patch did by setting tp_new to slot_tp_new. The problem is that the same code is used for inherited __new__ and assigned in class body. It is hard to distinguish between these cases. In any case I think that Cython shouldn't generate

[issue28180] sys.getfilesystemencoding() should default to utf-8

Nick Coghlan added the comment: Downstream Fedora issue proposing the above idea for F26: https://bugzilla.redhat.com/show_bug.cgi?id=1404918 I've also attached the patch from that issue here. -- keywords: +patch Added file:

[issue28971] nntplib is broken when responses are longer than _MAXLINE

Changes by Serhiy Storchaka : -- nosy: +christian.heimes, serhiy.storchaka ___ Python tracker ___

[issue5322] Python 2.6 object.__new__ argument calling autodetection faulty

Benjamin Peterson added the comment: BTW, at least for #25731, I think the right approach in the MI case is to synthesize a __new__ on the subclass that calls the solid base __new__. -- ___ Python tracker

[issue18896] Remove namedtuple 255 arguments restriction

Raymond Hettinger added the comment: Thanks. The patch looks good. -- ___ Python tracker ___ ___

[issue28931] urllib ignores FTP 226 response, breaking further FTP requests

Ivan Pozdeev added the comment: Was fixed in c741ba9e37ef (3.2) . urllib gets around the ftplib issue by closing the session after each transfer. -- ___ Python tracker

[issue28941] Update the link to Source Code in Python Docs from hg to github

Mariatta Wijaya added the comment: Please let me know if I'm doing this right :) Thanks. -- ___ Python tracker ___

[issue28941] Update the link to Source Code in Python Docs from hg to github

Mariatta Wijaya added the comment: Patch for 2.7 branch. The url will change from https://hg.python.org/cpython/file/2.7/Lib/abc.py into https://github.com/python/cpython/blob/2.7/Lib/abc.py -- Added file: http://bugs.python.org/file45906/issue28941v27.patch

[issue28941] Update the link to Source Code in Python Docs from hg to github

Mariatta Wijaya added the comment: Patch for 3.5 branch. The url will change from https://hg.python.org/cpython/file/3.5/Lib/abc.py into https://github.com/python/cpython/blob/3.5/Lib/abc.py -- Added file: http://bugs.python.org/file45905/issue28941v35.patch

[issue28941] Update the link to Source Code in Python Docs from hg to github

Mariatta Wijaya added the comment: Attached is the patch that will work for 3.6 and 3.7 branches. The url will be changed from https://hg.python.org/cpython/file/3.6/Lib/abc.py into https://github.com/python/cpython/blob/3.6/Lib/abc.py for python version 3.6, and

[issue28971] nntplib is broken when responses are longer than _MAXLINE

Martin Panter added the comment: Just a quick note for the moment: It may not be wise to drop the limit to readline(). That is undoing Issue 16040. Maybe we need a better test if this change doesn't fail the test suite. -- ___ Python tracker

[issue28961] unittest.mock._Call ignores `name` parameter

Jiajun Huang added the comment: I think we can write `_Call.__new__` as: def __new__(cls, value=(), name='',...) it's much simpler and readable. -- ___ Python tracker

[issue28091] Document PEP 525

Eric Appelt added the comment: Thanks for the explanations and example code in the review! Working on this issue is really helping to improve my understanding of a number of tricky things like finalization. I *think* that I have all the comments implemented in the attached patch. I also

[issue28976] incorrect description that dose not conform to the actual behavior

woo yoo added the comment: Forget to attach the link https://docs.python.org/3/reference/compound_stmts.html#compound-statements -- ___ Python tracker

[issue28976] incorrect description that dose not conform to the actual behavior

New submission from woo yoo: The paragraph that describes the precedence of semicolon encounters a minor error, which said : "Also note that the semicolon binds tighter than the colon in this context, so that in the following example, either all or none of the print() calls are executed: if x

[issue28954] Incorrect EBNF rule of keywords_arguments

Changes by Berker Peksag : -- nosy: +martin.panter ___ Python tracker ___ ___

[issue28961] unittest.mock._Call ignores `name` parameter

Berker Peksag added the comment: Thanks for the patch, Jiajun. The _Call class is tested in CallTest (located in Lib/unittest/test/testmock/testhelpers.py) Would it be possible to add a test case to make sure that we actually fixed the bug? -- nosy: +berker.peksag stage: commit review

[issue28944] A lack of line 6

Berker Peksag added the comment: Thanks for the report, woo woo. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior versions: +Python 3.6, Python 3.7 ___ Python tracker

[issue28944] A lack of line 6

Roundup Robot added the comment: New changeset a89469328b78 by Berker Peksag in branch '3.5': Issue #28944: Fix footnote numbering https://hg.python.org/cpython/rev/a89469328b78 New changeset 502f5d53fb4a by Berker Peksag in branch '3.6': Issue #28944: Merge from 3.5

[issue28919] Simplify `_copy_func_details` in unittest.mock

Berker Peksag added the comment: Thanks, Jiajun! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue28919] Simplify `_copy_func_details` in unittest.mock

Roundup Robot added the comment: New changeset bbdfde7958a8 by Berker Peksag in branch 'default': Issue #28919: Simplify _copy_func_details() in unittest.mock https://hg.python.org/cpython/rev/bbdfde7958a8 -- nosy: +python-dev ___ Python tracker

[issue28971] nntplib is broken when responses are longer than _MAXLINE

Xavier de Gaye added the comment: > I found that there were three other mails raising this same > NNTPDataError('line too long') in the 40 last mails. Cannot reproduce it. These three exceptions must have been NNTPProtocolError instead, caused by the initial NNTPDataError. --

[issue25458] ftplib: command response shift - mismatch

Ivan Pozdeev added the comment: Python 3.5.2 (v3.5.2:4def2a2901a5, Jun 25 2016, 22:01:18) [MSC v.1900 32 bit (Intel)] on win32 Type "help", "copyright", "credits" or "license" for more information. >>> import ftplib <...> >>> ftp.sendcmd('NOOP') '226 Directory send OK.' There are no changes in

[issue28975] os.walk generator giving inconsistent results

Colin David Chen added the comment: Ah, you're correct. The behavior is consistent if you use strings in both invocations. The Path conversion strips the final '\\'. Doc examples do use the names of directories rather than a Path object. I will close the issue. Thanks for the quick response!

[issue28975] os.walk generator giving inconsistent results

Eric V. Smith added the comment: Assuming Path is pathlib.Path, this is equivalent to the difference between: >>> list(os.walk('/tmp')) [('/tmp', and: >>> list(os.walk('/tmp/')) [('/tmp/', Because: >>> pathlib.Path('/tmp') PosixPath('/tmp') >>> pathlib.Path('/tmp/') PosixPath('/tmp')

[issue28975] os.walk generator giving inconsistent results

Eric V. Smith added the comment: Isn't the difference that you use os.walk(Path(source)) in the first example, and os.walk(source) in the second one? -- nosy: +eric.smith ___ Python tracker

[issue28975] os.walk generator giving inconsistent results

Changes by Colin David Chen : -- title: os.walk generator vs -> os.walk generator giving inconsistent results ___ Python tracker ___

[issue28975] os.walk generator vs

New submission from Colin David Chen: os.walk in 3.6rc1 (Windows) appears to generate different output depending on its invocation. In the first invocation, I use the generator to yield one result at a time: source = "C:\\cdchen_data\\downloads\\python-xlib-0.18\\" texasranger =

[issue28974] Make default __format__ be equivalent to __str__

New submission from Serhiy Storchaka: Originally PEP 3101 defined the default __format__ implementation, object.__format__ as def __format__(self, format_spec): return format(str(self), format_spec) After few changes (issue7994, issue28385) it now looks as def

[issue28931] urllib ignores FTP 226 response, breaking further FTP requests

Giampaolo Rodola' added the comment: I can't reproduce the issue on Python 3.5 (but I can on 2.7). -- nosy: +giampaolo.rodola versions: -Python 3.3, Python 3.4, Python 3.5, Python 3.6, Python 3.7 ___ Python tracker

[issue28971] nntplib is broken when responses are longer than _MAXLINE

Xavier de Gaye added the comment: When the server sends a line longer than _MAXLINE, nntplib reads only _MAXLINE + 1 bytes leaving the remaining bytes left to be processed by the next command that will interpret those bytes as a protocol error. Hence the failing tests that follow the first

[issue25458] ftplib: command response shift - mismatch

Ivan Pozdeev added the comment: * The initial msg253326 has a code snippet using ftplib directly and showing the error. * The linked issue28931 has another snippet that uses ftplib through urllib and results in the same error. There isn't a single mention of "thread" in either. Could you just

[issue18896] Remove namedtuple 255 arguments restriction

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___

[issue14156] argparse.FileType for '-' doesn't work for a mode of 'rb'

Aviv Palivoda added the comment: As we talk here about stdin and stdout which we don't want to close I think this issue is irrelevant to python2. In any case the patch in issue #13824 cover that problem. I actually write a lot of small scripts and if I need to open the file in binary mode I

[issue25458] ftplib: command response shift - mismatch

Giampaolo Rodola' added the comment: Maybe it's me but I still fail to understand what's the issue here. From what I understand from the last message(s) it seems there is complaint about not being able to use ftplib with threads. FTP is a "command - response" protocol which is designed to

[issue28849] do not define sys.implementation._multiarch on Android

Roundup Robot added the comment: New changeset ab3d870aa3bc by Xavier de Gaye in branch '3.6': Issue #28849: Skip test_sysconfig.test_triplet_in_ext_suffix on non linux platforms. https://hg.python.org/cpython/rev/ab3d870aa3bc New changeset 0ff181ca7558 by Xavier de Gaye in branch 'default':

[issue28683] bind() on a unix socket raises PermissionError on Android for a non-root user

Changes by Xavier de Gaye : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue14156] argparse.FileType for '-' doesn't work for a mode of 'rb'

paul j3 added the comment: The problem with Python2.7 is that 'open' does not take 'closefd', or any of the other parameters that were added for Python3. open(name[, mode[, buffering]]) 'rb' may make a difference on Py2 on Windows, but I haven't done any work in the environment in a long

[issue7434] general pprint rewrite

Louis Riviere added the comment: I've made a Pretty Printer and I'd like to know if anybody thinks it could of some help here. (I do) It's easily extensible and customizable to support any type in any way. https://github.com/louis-riviere-xyz/prettypy.git -- nosy: +dugres

[issue28871] Destructor of ElementTree.Element is recursive

Serhiy Storchaka added the comment: Proposed patch fixes the crash. -- keywords: +patch stage: needs patch -> patch review Added file: http://bugs.python.org/file45900/etree-trashcan.patch ___ Python tracker

[issue14156] argparse.FileType for '-' doesn't work for a mode of 'rb'

Aviv Palivoda added the comment: Hi paul thanks for looking into this. First are you sure this is a bug in python 2? If so I will happily port this patch once it is reviewed. As for use cases you may look at issue #26488. Although the patch was rejected you can see that I first used

[issue5322] Python 2.6 object.__new__ argument calling autodetection faulty

Changes by Serhiy Storchaka : -- priority: release blocker -> normal ___ Python tracker ___

[issue5322] Python 2.6 object.__new__ argument calling autodetection faulty

Roundup Robot added the comment: New changeset f89ef18f9824 by Serhiy Storchaka in branch '2.7': Issue #5322: Restored tests for __new__. https://hg.python.org/cpython/rev/f89ef18f9824 New changeset 06e4b9f2e4b0 by Serhiy Storchaka in branch '3.5': Revert changeset 1f31bf3f76f5 (issue5322)

[issue28971] nntplib fails on all buildbots

Xavier de Gaye added the comment: BTW while searching for this problem, I found that there were three other mails raising this same NNTPDataError('line too long') in the 40 last mails. -- ___ Python tracker

[issue28965] Multiprocessing spawn/forkserver fails to pass Queues

Changes by Davin Potts : -- nosy: +davin type: crash -> behavior ___ Python tracker ___

[issue28971] nntplib fails on all buildbots

Xavier de Gaye added the comment: The problem is when getting an overview of the following comp.lang.python mail: OT - "Soft" ESC key on the new MacBook Pro Michael Torrie Tue Dec 13 21:33:07 EST 2016 This is at index (last - 16) now and that is why the buildbots do not fail anymore.

[issue28973] The fact that multiprocess.Queue uses serialization should be documented.

Davin Potts added the comment: All communication between processes in multiprocessing has consistently used pickle to serialize the data being communicated (this includes what is described in the "Shared memory" section of the docs). The documentation has not done a great job of making this

[issue28971] nntplib fails on all buildbots

Zachary Ware added the comment: This appears to have been a transient failure; all builders are passing a forced build. I'm no expert on nntplib, but I'm not sure there's much we can do here beyond replacing the outside connection with a mock server. That pretty much defeats the purpose of

[issue28959] Add a macro for dict size

STINNER Victor added the comment: Ignore my previous comment, PyDict_GET_SIZE-3.patch LGTM. > I don't think the changes in _datetimemodule.c and typeobject.c change the > behavior. Oh wait, it seems like I misunderstood the new code. Modules/_datetimemodule.c: dictptr =

[issue20754] Distribution.parse_config_files uses interpolation since Python 3

Jason R. Coombs added the comment: I've created a backport implementation in https://github.com/pypa/setuptools/issues/889. All that remains then is to have a test for Python, which can probably borrow from the fix for issue20120. I'll leave it to others to draft the patch for the test.

[issue28963] Use-after-free in _asyncio_Future_remove_done_callback() of _asynciomodule.c

Ned Deily added the comment: This doesn't sound like a showstopper issue so I think it can wait for 3.6.1. -- ___ Python tracker ___

[issue28963] Use-after-free in _asyncio_Future_remove_done_callback() of _asynciomodule.c

Changes by Giampaolo Rodola' : -- nosy: -giampaolo.rodola ___ Python tracker ___ ___

[issue28959] Add a macro for dict size

Serhiy Storchaka added the comment: I don't think the changes in _datetimemodule.c and typeobject.c change the behavior. -- ___ Python tracker ___

[issue28959] Add a macro for dict size

STINNER Victor added the comment: PyDict_GET_SIZE-3.patch: Except of the changes in _datetimemodule.c and typeobject.c on *dictptr type, the patch LGTM. I suggest to open a new issue for these two specific changes, since it changes the behaviour and it's a weird corner case unrelated to this

[issue28973] The fact that multiprocess.Queue uses serialization should be documented.

R. David Murray added the comment: Yeah, that's why I said "in the general case". Making it clear in the overview seems reasonable to me. -- ___ Python tracker

[issue28971] nntplib fails on all buildbots

Changes by Xavier de Gaye : -- nosy: +martin.panter ___ Python tracker ___ ___

[issue28973] The fact that multiprocess.Queue uses serialization should be documented.

Bernhard10 added the comment: My first thought was that Queue was implemented using shared memory. I guess from the fact that the "Shared memory" section is separate in the multiprocessing documentation I should have known better, though. So I guess some clarification in the documentation

[issue28959] Add a macro for dict size

STINNER Victor added the comment: I wrote a short script to check the size of dict: --- import sys def size(obj): print(sys.getsizeof(obj)) size({}) size({i:i for i in range(3)}) size({i:i for i in range(10)}) size({i:i for i in range(100)}) --- On Linux x86_64, the sizes don't change

[issue28949] Stdlib modules disappear from file system

Jason R. Coombs added the comment: I paused the Dropbox sync and ran the `rm -R .tox; tox` routine many times without incident, which strongly implicates Dropbox. I'm going to now re-enable Dropbox sync and see if I can trigger the behavior. Now even with Dropbox updated back to the latest

[issue28973] The fact that multiprocess.Queue uses serialization should be documented.

R. David Murray added the comment: That fact that this is so is implicit in the name multi*process*ing and the documented restrictions of the id function. That is, it is the purpose of the module is to manage computation across multiple processes. Since different processes have distinct

[issue20754] Distribution.parse_config_files uses interpolation since Python 3

Jason R. Coombs added the comment: I reviewed the docs for configparser, and I agree - using ConfigParser(interpolation=None) is preferable to the "legacy" RawConfigParser. -- ___ Python tracker

[issue28973] The fact that multiprocess.Queue uses serialization should be documented.

Bernhard10 added the comment: See http://stackoverflow.com/a/925241/5069869 Apparently multiprocessing.Queue uses pickle to serialize the objects in the queue, which explains the change of identity, but is absolutely unclear from the documentation. -- assignee: -> docs@python

[issue28973] multiprocess.Queue changes objects identity

New submission from Bernhard10: When I did some tests involving unittest.mock.sentinel and multiprocessing.Queue, I noticed that multiprocessing.Queue changes the id of the sentinel. This behaviour is definitely surprising and not documented. -- files: mwe.py messages: 283192 nosy:

[issue28960] Small typo in Thread.join docs

Ryan added the comment: Removing the comma instead of the double-dash -- Added file: http://bugs.python.org/file45898/fixdoc2.patch ___ Python tracker

[issue28961] unittest.mock._Call ignores `name` parameter

Changes by Emanuel Barry : -- stage: needs patch -> commit review ___ Python tracker ___

[issue28972] Document all "python -m" utilities

New submission from Miki Tebeka: Several modules can be invoked with -m and are pretty handy (json.tool, zipfile, tarfile ...). There should be a section in the documentation that groups all of these "python -m" tools together. Something like

[issue28971] nntplib fails on all buildbots

New submission from Xavier de Gaye: All the buildbots are currently failing at test_nntplib. See the errors in attached test_nntplib.log. The same error messages can be reproduced with a 3.5.2 interpreter: $ python Python 3.5.2 (default, Nov 7 2016, 11:31:36) [GCC 6.2.1 20160830] on linux Type

[issue28970] ctypes.from_buffer counterpart to actively remove the mapping

New submission from Hans-Peter Jansen: In an attempt of using ctypes.from_buffer() to map a structure to a memory mapped file, it is important to destroy the mapping after use, because the mmap won't be resizable or freeable correctly until then. The best approach, I was able to came up with

[issue26110] Speedup method calls 1.2x

Changes by INADA Naoki : Added file: http://bugs.python.org/file45896/callmethod-doc3.patch ___ Python tracker ___

[issue28960] Small typo in Thread.join docs

Evan added the comment: I think the patch should remove the comma, not the double dash. This is a parenthetical remark and should end the same way it starts. See https://www.grammarly.com/handbook/punctuation/dash/2/dash-parenthetical-information/ -- nosy: +evan_

[issue28683] bind() on a unix socket raises PermissionError on Android for a non-root user

Roundup Robot added the comment: New changeset b65ae19bc42a by Xavier de Gaye in branch '3.6': Issue #28683: Fix the tests that bind() a unix socket and raise PermissionError https://hg.python.org/cpython/rev/b65ae19bc42a New changeset 0350e0634a4b by Xavier de Gaye in branch 'default': Issue

[issue28969] fnmatch is not threadsafe

New submission from Nicolas Savoire: With python3.5, fnmatch appears not to be thrad safe. It fails with the following exception: Traceback (most recent call last): File "test.py", line 18, in f.result() File "/opt/anaconda3/lib/python3.5/concurrent/futures/_base.py", line 405, in

[issue26865] Meta-issue: support of the android platform

Changes by Xavier de Gaye : -- dependencies: -setup.py: do not add system header locations when cross compiling ___ Python tracker

[issue20211] setup.py: do not add system header locations when cross compiling

Xavier de Gaye added the comment: Same patch, but this one is properly set to be handled by Rietveld. -- Added file: http://bugs.python.org/file45894/multiarch_2.patch ___ Python tracker

[issue20211] setup.py: do not add system header locations when cross compiling

Xavier de Gaye added the comment: >> this assumption is wrong for the multiarch case. > > Please explain why it is wrong. Sadly no explanations have been given, we have to take Matthias word for it. This new patch updates the add_multiarch_paths() method and includes LIBDIR and INCLUDEDIR in

[issue20211] setup.py: do not add system header locations when cross compiling

Roundup Robot added the comment: New changeset d1b400943483 by Xavier de Gaye in branch '3.6': Issue #20211: Do not add the directory for installing C header files and https://hg.python.org/cpython/rev/d1b400943483 New changeset fcc9f19fcc13 by Xavier de Gaye in branch 'default': Issue #20211:

[issue28959] Add a macro for dict size

Serhiy Storchaka added the comment: Updated patch addresses Victor's issue. _PyDict_GET_SIZE is renamed to PyDict_GET_SIZE and now it includes an assertion. This is good argument for introducing this macro against using PyDict_Size (without checking the result for error) and Py_SIZE (which

[issue26110] Speedup method calls 1.2x

Changes by INADA Naoki : Added file: http://bugs.python.org/file45891/callmethod-doc2.patch ___ Python tracker ___

[issue28968] xml rpc server fails with connection reset by peer error no 104

New submission from Manish Singh: I have used xml rpc library with transport http. My client and server are running on same host. In normal load scenario(20% cpu usage, 80% memory usage, 18 GB memory free), some request of xml rpc client fails with connection reset by peer error. I have used

[issue26110] Speedup method calls 1.2x

Changes by INADA Naoki : Removed file: http://bugs.python.org/file45890/callmethod-doc2.patch ___ Python tracker ___

[issue26110] Speedup method calls 1.2x

Changes by INADA Naoki : Added file: http://bugs.python.org/file45890/callmethod-doc2.patch ___ Python tracker ___

[issue28963] Use-after-free in _asyncio_Future_remove_done_callback() of _asynciomodule.c

STINNER Victor added the comment: _asyncio_Future_remove_done_callback() is still wrong with Issue28963.patch: what if an evil __eq__() methods inserts or remove directly items of the future callbacks list? By design, it's not safe to iterate on a list if the body of the list calls

[issue5322] Python 2.6 object.__new__ argument calling autodetection faulty

STINNER Victor added the comment: Since this change seems to break the backward compatibility, is it safe to apply it to Python 3.5.x and Python 3.6.x? The bug was reported in 2009, 7 years ago. Can the fix wait for Python 3.7? test_file contains code which worked well before the change and

[issue26110] Speedup method calls 1.2x

STINNER Victor added the comment: INADA Naoki: "My current idea is adding new `tp_fastcall` slot which has same signature to _PyFunction_FastCallDict or _PyCFunction_FastCallDict." FYI I'm working on a solution to avoid tuple and dict to pass parameters to tp_new, tp_init and tp_call. I have

[issue28959] Add a macro for dict size

STINNER Victor added the comment: > dict doesn't end with array. Right, but... Recently I looked at dict internals. As a newcomer, I have to confess that it's currently really hard to understand the purpose of each dict field: they are many "sizes": size of the hash table, number of usable

[issue28959] Add a macro for dict size

STINNER Victor added the comment: > Should we use Py_SIZE or _PyDict_GET_SIZE? I prefer _PyDict_GET_SIZE() just to make the code more readable: it helps to repeat the type of variables. Moreover, it can give you a free check on the type if you agree my suggestion to add an assertion into the

[issue28959] Add a macro for dict size

STINNER Victor added the comment: > It looks like the struct of a dict is already arranged in a way that it could > switch to PyObject_VAR_HEAD Can someone check if it has an impact of the size of the structure (because of the complex rules of alignment)? If the structure has the same size,

[issue28963] Use-after-free in _asyncio_Future_remove_done_callback() of _asynciomodule.c

Yury Selivanov added the comment: Inada-san, thanks for the review. You're right, we need to fix another edge-case. I'll upload a new patch tomorrow. Victor, fourth option we should go with is to commit the attached patch (with Inada-san review comment fixed). I guess it's up to Ned if he

[issue28963] Use-after-free in _asyncio_Future_remove_done_callback() of _asynciomodule.c

Changes by STINNER Victor : -- title: Use-after-free in _asynciomodule.c -> Use-after-free in _asyncio_Future_remove_done_callback() of _asynciomodule.c ___ Python tracker

[issue28963] Use-after-free in _asynciomodule.c

STINNER Victor added the comment: I see three options: * avoid PyObject_RichCompareBool() which can run arbitrary Python code: this can be complicated since callbacks can be proxies, functools.partial, lambda, and other funny callable objects * reimplement the same algorithm than the Python

[issue28963] Use-after-free in _asynciomodule.c

STINNER Victor added the comment: > Oh, this is a release blocker. I'll take a look later today. The bug requires to have an "evil" class which is unlikely in an application. I don't think that it's a release blocker. -- priority: release blocker ->