[issue27647] Update Windows 2.7 build to Tcl/Tk 8.5.19

2017-02-01 Thread Joshua Kinard
Joshua Kinard added the comment: Fair enough. I am stuck working with 2.7 for quite a while longer due to platform constraints, but hopefully can migrate over to 3.x at some point. Was worth asking :) At least try to cherrypick that one commit from the TCL/Tk source I referenced so that

[issue29407] Remove redundant ensure_future() calls in factorial example

2017-02-01 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the review, Guido. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue29364] msilib Fetch raises MSIError rather than return None

2017-02-01 Thread Berker Peksag
Changes by Berker Peksag : -- stage: -> resolved superseder: -> Add support for _msi.Record.GetString() and _msi.Record.GetInteger() ___ Python tracker

[issue29407] Remove redundant ensure_future() calls in factorial example

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset e4f6874abda6 by Berker Peksag in branch '3.5': Issue #29407: Remove redundant ensure_future() calls in factorial example https://hg.python.org/cpython/rev/e4f6874abda6 New changeset 7196ab02b7ce by Berker Peksag in branch '3.6': Issue #29407: Merge

[issue29364] msilib Fetch raises MSIError rather than return None

2017-02-01 Thread Jason Matthew
Jason Matthew added the comment: Thanks for pointing that one out Berker. I agree, this is a dup. -- resolution: -> duplicate status: open -> closed ___ Python tracker

[issue29414] Change 'the for statement is such an iterator' in Tutorial

2017-02-01 Thread Jim Fasarakis-Hilliard
Changes by Jim Fasarakis-Hilliard : -- keywords: +patch Added file: http://bugs.python.org/file46482/issue29414.patch ___ Python tracker

[issue29414] Change 'the for statement is such an iterator' in Tutorial

2017-02-01 Thread Jim Fasarakis-Hilliard
New submission from Jim Fasarakis-Hilliard: The current line is confusing hinting that the for statement is actually an object, it also makes a reference to iterators which the tutorial doesn't disambiguate until the chapter on Classes. I've added a small patch that, in my opinion, makes it

[issue29344] sock_recv not detected a coroutine

2017-02-01 Thread Guido van Rossum
Guido van Rossum added the comment: OP is correct. sock_recv(), sock_sendall(), sock_connect(), sock_accept() all are functions that return Futures. The docs are wrong, as are the docstrings in the code. -- versions: +Python 3.5, Python 3.7 ___

[issue29377] Add the 'wrapper_descriptor' type to the types module

2017-02-01 Thread Guido van Rossum
Guido van Rossum added the comment: Thanks Manuel and Ivan! -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue29377] Add the 'wrapper_descriptor' type to the types module

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3db1959c2c53 by Guido van Rossum in branch 'default': Issue #29377: Add three new wrappers to types.py (Manuel Krebber). https://hg.python.org/cpython/rev/3db1959c2c53 -- nosy: +python-dev ___ Python

[issue29413] ssl.SSLSocket.unwrap() is not flexible enough

2017-02-01 Thread Greg Stark
New submission from Greg Stark: This is not a bug, but rather a request for API improvements. Correct SSL shutdown processing is frequent source of confusion. Python’s ssl module unfortunately lacks the flexibility to accommodate some common paradigms. The problem is that the unwrap()

[issue14376] sys.exit documents argument as "integer" but actually requires "subtype of int"

2017-02-01 Thread Gareth Rees
Gareth Rees added the comment: Thanks for the revised patch, Mark. The new tests look good. -- ___ Python tracker ___

[issue14376] sys.exit documents argument as "integer" but actually requires "subtype of int"

2017-02-01 Thread Mark Dickinson
Mark Dickinson added the comment: The test portion of the existing patch doesn't apply cleanly to 2.7 tip. Here's an updated patch that does, with slightly expanded tests and a Misc/NEWS entry. There was discussion above about two overflow cases: C long to C int, and C int to byte, but with

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset da331c7d12c4648b9734ebb07e9f722c8478d269 by Victor Stinner in branch 'master': Fix test_gdb.test_wrapper_call() on Python 2 https://github.com/python/cpython/commit/da331c7d12c4648b9734ebb07e9f722c8478d269 --

[issue29404] "TypeError: 'int' does not have the buffer interface" on memoryview over bytearray

2017-02-01 Thread Brett Cannon
Brett Cannon added the comment: I'm not quite sure what you're asking for here. The Python 2.7 semantics can't change because Python 2.7 is only receiving bugfixes. So do you want the Python 3 case to become an error? -- nosy: +brett.cannon ___

[issue29364] msilib Fetch raises MSIError rather than return None

2017-02-01 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report, Jason. I think this is a duplicate of issue 1102. The second patch (_msi_fetch.patch.txt) there should fix your problem (if I read MSDN correctly, 103 is ERROR_NO_MORE_ITEMS.) I don't have access to a Windows box at the moment so could

[issue11549] Build-out an AST optimizer, moving some functionality out of the peephole optimizer

2017-02-01 Thread Brett Cannon
Brett Cannon added the comment: Dropping ast.Lit is fine. As for the docstring part, I'm torn. Yes it's nice as that will show up semantically in the Python code, but it's also easy to check for by just looking if the first statement is a Str (or Constant if that's what we make all strings).

[issue29407] Remove redundant ensure_future() calls in factorial example

2017-02-01 Thread Guido van Rossum
Guido van Rossum added the comment: LGTM, and should be committed to 3.5 and merged upwards from there. And yes, it's time for the asyncio docs to converge on async/await everywhere, making `yield from` a footnoot to history. -- ___ Python tracker

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset efaf32ac89ec by Victor Stinner in branch 'default': Fix test_gdb.test_wrapper_call() on Python 2 https://hg.python.org/cpython/rev/efaf32ac89ec -- ___ Python tracker

[issue29318] Optimize _PyFunction_FastCallDict() for **kwargs

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: Serhiy Storchaka: "Why Roundup Robot spams with empty or almost empty messages?" It smells like the migration to GitHub started :-) -- ___ Python tracker

[issue29406] asyncio SSL contexts leak sockets after calling close with certain Apache servers

2017-02-01 Thread Alexander Mohr
Alexander Mohr added the comment: Thanks so much for the patch! may want to change spelling of what was supposed to be "shutdown" =) Also think it's worth a comment stating why it's needed? Like certain Apache servers were noticed to not complete the SSL shutdown process. --

[issue29234] Disable inlining of _PyStack_AsTuple() to reduce the stack consumption

2017-02-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Victor. Your work on reducing the stack consumption is great. -- ___ Python tracker ___

[issue28618] Decorate hot functions using __attribute__((hot)) to optimize Python

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: Victor: "FYI I wrote an article about this issue: https://haypo.github.io/analysis-python-performance-issue.html Sadly, it seems like I was just lucky when adding __attribute__((hot)) fixed the issue, because call_method is slow again!" I upgraded

[issue29318] Optimize _PyFunction_FastCallDict() for **kwargs

2017-02-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > Changes by Roundup Robot : Why Roundup Robot spams with empty or almost empty messages? -- ___ Python tracker

[issue29140] time_hash() reads the wrong bytes to get microseconds

2017-02-01 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue29157] random.c: Prefer getrandom() over getentropy() to support glibc 2.24 on Linux

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: I fixed the bug in Python 2.7, 3.5, 3.6 and 3.7 (default). Thanks for the reviews Nick & Christian! -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue29300] Modify the _struct module to use FASTCALL and Argument Clinic

2017-02-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It looks to me that the type of the self parameter can be changed from PyObject* to PyStructObject*. This will make the patch larger but the final code simpler. class Struct "PyStructObject *" "" -- ___

[issue29227] Reduce C stack consumption in function calls

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: Victor: "I plan to run a benchmark when all my patches to reduce the stack consumption will be ready." msg285200 of issue #28870: "I also ran the reliable performance benchmark suite with LTO+PGO. There is no significant performance change on these benchmarks

[issue29234] Disable inlining of _PyStack_AsTuple() to reduce the stack consumption

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: The initial issue has been fixed. With the issue #28870 (msg285169): "The default branch is now as good as Python 3.4, in term of stack consumption, and Python 3.4 was the Python version which used the least stack memory according to my tests." Serhiy: As I

[issue28870] Reduce stack consumption of PyObject_CallFunctionObjArgs() and like

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: "The default branch is now as good as Python 3.4, in term of stack consumption, and Python 3.4 was the Python version which used the least stack memory according to my tests." I consider that the initial issue is now fixed, so I close the issue. Thanks

[issue29286] Use METH_FASTCALL in str methods

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : -- stage: -> resolved ___ Python tracker ___

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29318] Optimize _PyFunction_FastCallDict() for **kwargs

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 88835e6022a81d8107a296c9f6e5f16c7d39e27a by Victor Stinner in branch 'master': Make test_gdb.test_wrapper_call() make reliable https://github.com/python/cpython/commit/88835e6022a81d8107a296c9f6e5f16c7d39e27a --

[issue29318] Optimize _PyFunction_FastCallDict() for **kwargs

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : -- resolution: rejected -> fixed ___ Python tracker ___

[issue29286] Use METH_FASTCALL in str methods

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29318] Optimize _PyFunction_FastCallDict() for **kwargs

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 2c145e9eda756aa2001282d7c016e740dd00a2d7 by Victor Stinner in branch 'master': Document that _PyFunction_FastCallDict() must copy kwargs https://github.com/python/cpython/commit/2c145e9eda756aa2001282d7c016e740dd00a2d7 --

[issue29318] Optimize _PyFunction_FastCallDict() for **kwargs

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : -- stage: -> resolved ___ Python tracker ___

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29286] Use METH_FASTCALL in str methods

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5910fd7231d34363798d2815be2f66909e638d1c by Victor Stinner in branch 'master': Issue #29286: Rename private PyArg_UnpackStack_impl() to unpack_stack() https://github.com/python/cpython/commit/5910fd7231d34363798d2815be2f66909e638d1c --

[issue29286] Use METH_FASTCALL in str methods

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29260] Use designated initializers to define PyTypeObject types

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: The question was discussed on the python-dev mailing list: [Python-Dev] Can we use "designated initializer" widely in core modules? https://mail.python.org/pipermail/python-dev/2017-January/147154.html I understood that it's ok to use them in new code, but not

[issue29263] Implement LOAD_METHOD/CALL_METHOD for C functions

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: INADA Naoki: "Maybe, we should do: * Make clinic use more METH_FASTCALL * Use clinic more in builtin methods; before trying this optimization." I created the issue #29286 "Use METH_FASTCALL in str methods" which is now fixed. I started to propose patches for

[issue29286] Use METH_FASTCALL in str methods

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: str type still has a few methods using METH_VARARGS (slower than METH_FASTCALL): * count() * find() * index() * rfind() * rindex() * startswith() * endswith() * format() Maybe I will propose a change later to convert these methods to Argument Clinic, but I

[issue29286] Use METH_FASTCALL in str methods

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: Serhiy Storchaka: "Oh, I have wrote almost the same patch before going to sleep yesteday! ;) But the building crashed (likely due to a bug in _PyStack_UnpackDict()) and it was too late to resolve this." Oh, sorry that you wrote almost the same code. Well, at

[issue29286] Use METH_FASTCALL in str methods

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 758674087b12 by Victor Stinner in branch 'default': Issue #29286: Rename private PyArg_UnpackStack_impl() to unpack_stack() https://hg.python.org/cpython/rev/758674087b12 -- ___ Python tracker

[issue29286] Use METH_FASTCALL in str methods

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: Recently, I saw complains that I push changes too fast without reviews. This issue is a good example. So let me elaborate myself a little bit on these changes. I'm not really proud of the "Rename _PyArg_ParseStack to _PyArg_ParseStackAndKeywords" change. It

[issue29289] Convert OrderedDict methods to Argument Clinic

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: Thanks again Serhiy for the better docstrings! Known issues are now fixed, so I close the issue. Thanks for the review Naoki. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue29300] Modify the _struct module to use FASTCALL and Argument Clinic

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: Serhiy: Would you mind to review my latest patch, struct_fastcall-6.patch? It should address all your remarks, except your proposal to write a converter for cache_struct(): see my previous comment about this idea. Thanks in advance ;) --

[issue29311] Argument Clinic: convert dict methods

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: Thank you very much for the docstring enhancement Serhiy! I like your new docstrings. It seems like all known issues are now fixed, so I close the issue. Thanks Naoki and Martin too for the reviews. -- resolution: -> fixed status: open -> closed

[issue29318] Optimize _PyFunction_FastCallDict() for **kwargs

2017-02-01 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> rejected status: open -> closed ___ Python tracker ___

[issue29318] Optimize _PyFunction_FastCallDict() for **kwargs

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: INADA Naoki: "Since mutating kw dict shouldn't affect caller's dict, caller and callee can't share the dict." Oh, I knew that, it's not the first time that I propose to implement this optimization and that I got this answer !? So I added a comment for myself,

[issue29318] Optimize _PyFunction_FastCallDict() for **kwargs

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset fcba9c9d987b by Victor Stinner in branch 'default': Document that _PyFunction_FastCallDict() must copy kwargs https://hg.python.org/cpython/rev/fcba9c9d987b -- nosy: +python-dev ___ Python tracker

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : -- stage: -> resolved ___ Python tracker ___

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : -- resolution: -> fixed ___ Python tracker ___

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset ffd2e5f9256a by Victor Stinner in branch 'default': Make test_gdb.test_wrapper_call() make reliable https://hg.python.org/cpython/rev/ffd2e5f9256a -- ___ Python tracker

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : -- status: open -> closed ___ Python tracker ___

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 30867b703933d6ba30bc5f609a1a2337925ead33 by Victor Stinner in branch 'master': python-gdb.py supports method-wrapper https://github.com/python/cpython/commit/30867b703933d6ba30bc5f609a1a2337925ead33 --

[issue29362] regrtest: don't fail immediately if a child does crash

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: Attached patch changes libregrtest to handle CHILD_ERROR as a normal result and continue the execution of following tests. As a result, it displays the test summary as usual on such crash. -- Ammar Askar: Thanks for regrtest_crash.diff, but I prefer to

[issue29367] python-gdb: display wrapper_call()

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 54fa95b19fae by Victor Stinner in branch 'default': python-gdb.py supports method-wrapper https://hg.python.org/cpython/rev/54fa95b19fae -- nosy: +python-dev ___ Python tracker

[issue29412] IndexError thrown on email.message.Message.get

2017-02-01 Thread Joel Uckelman
Changes by Joel Uckelman : -- title: IndexError thrown on email.message.EmailMessage.get -> IndexError thrown on email.message.Message.get ___ Python tracker

[issue24869] shlex lineno inaccurate with certain inputs

2017-02-01 Thread Gareth Rees
Gareth Rees added the comment: Here's a patch that implements my proposal (1) -- under this patch, tokens read from an input stream belong to a subtype of str with startline and endline attributes giving the line numbers of the first and last character of the token. This allows the accurate

[issue27400] Datetime NoneType after calling Py_Finalize and Py_Initialize

2017-02-01 Thread Nick Coghlan
Nick Coghlan added the comment: I've added Steve Dower to the nosy list, as he's done some work recently on making the Windows builds more embedding-friendly, and I believe at least some of that time may have been funded work. Unfortunately, we don't currently have anyone I'm aware of that's

[issue29412] IndexError thrown on email.message.EmailMessage.get

2017-02-01 Thread Joel Uckelman
Joel Uckelman added the comment: No dice. I get the same exception with issue27931_v2.patch. I briefly looked at the other two, and don't expect those will help, either. -- ___ Python tracker

[issue27051] Create PIP gui

2017-02-01 Thread Nick Coghlan
Nick Coghlan added the comment: Rather than "rejected" per se, I've closed this as "postponed" - I still think there's potential value in bundling a component management GUI in the future, but it should be *after* a project has established itself as the de facto introductory approach via

[issue29412] IndexError thrown on email.message.EmailMessage.get

2017-02-01 Thread R. David Murray
R. David Murray added the comment: Does the patch from issue 27931 fix your problem as well? I haven't looked closely enough to see if I think it should, I'm just hoping :) -- ___ Python tracker

[issue14376] sys.exit documents argument as "integer" but actually requires "subtype of int"

2017-02-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Count me as +1. The patch LGTM. See also issue28998. -- ___ Python tracker ___

[issue29412] IndexError thrown on email.message.EmailMessage.get

2017-02-01 Thread Joel Uckelman
Changes by Joel Uckelman : -- title: IndexError thrown on email.message.M -> IndexError thrown on email.message.EmailMessage.get ___ Python tracker

[issue29412] IndexError thrown on email.message.M

2017-02-01 Thread Joel Uckelman
New submission from Joel Uckelman: Test case: import email import email.policy txt = '''From: juckel...@strozfriedberg.co.uk To: (Recipient list suppressed) Date: Thu, 22 Aug 2013 04:13:02 + Subject: ADSF-1082 Hey! ''' msg = email.message_from_string(txt)

[issue14376] sys.exit documents argument as "integer" but actually requires "subtype of int"

2017-02-01 Thread Gareth Rees
Gareth Rees added the comment: In Windows, under cmd.exe, you can use %errorlevel% -- ___ Python tracker ___

[issue14376] sys.exit documents argument as "integer" but actually requires "subtype of int"

2017-02-01 Thread Terry J. Reedy
Terry J. Reedy added the comment: Summary of overt and implied votes: Core Devs: +1 Mark Dickenson +1 Ethan Furman ?? Serhiy Storchaka -1 Alexander Belopolsky (at first, but unclear after) Other: +1 Ryan Gonzales, quoting Guido about equivalence of ints and longs. The sys.exit docstring says

[issue29410] Moving to SipHash-1-3

2017-02-01 Thread Christian Heimes
Christian Heimes added the comment: Unless somebody is able to show a real-world example with a considerable performance boost (>5%), I'm strictly against any kind of special casing for short strings. I don't want to trade security for performance. You might be able to persuade me to go for a

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7c1f136e83fe9a145f509b27417a8dd2a37ac27c by doko in branch 'master': Issue #29169: Fix NEWS entry. https://github.com/python/cpython/commit/7c1f136e83fe9a145f509b27417a8dd2a37ac27c -- ___ Python

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7c1f136e83fe9a145f509b27417a8dd2a37ac27c by doko in branch '3.5': Issue #29169: Fix NEWS entry. https://github.com/python/cpython/commit/7c1f136e83fe9a145f509b27417a8dd2a37ac27c -- ___ Python tracker

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : -- stage: -> resolved ___ Python tracker ___

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Changes by Roundup Robot : ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7c1f136e83fe9a145f509b27417a8dd2a37ac27c by doko in branch '3.6': Issue #29169: Fix NEWS entry. https://github.com/python/cpython/commit/7c1f136e83fe9a145f509b27417a8dd2a37ac27c -- ___ Python tracker

[issue29410] Moving to SipHash-1-3

2017-02-01 Thread INADA Naoki
INADA Naoki added the comment: https://emboss.github.io/blog/2012/12/14/breaking-murmur-hash-flooding-dos-reloaded/ Murmur may be safe for <16 byte too. -- ___ Python tracker

[issue29410] Moving to SipHash-1-3

2017-02-01 Thread INADA Naoki
INADA Naoki added the comment: Py_HASH_CUTOFF uses different secret from siphash already. The problem is the secret doesn't affects to collision at all. Attacker can produce large number of collision, without knowing the secret. BTW, we have FNV already. Let's survey about FNV-1 short string

[issue29410] Moving to SipHash-1-3

2017-02-01 Thread Christian Heimes
Christian Heimes added the comment: We can and should still use hash randomization for short strings, but a different key than for hash randomization for longer strings. -- ___ Python tracker

[issue29410] Moving to SipHash-1-3

2017-02-01 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 01.02.2017 13:03, INADA Naoki wrote: > Maybe, we should remove Py_HASH_CUTOFF completely? I think we ought to look for a better hash algorithm for short strings, e.g. a CRC based one. Some interesting investigations on this:

[issue29410] Moving to SipHash-1-3

2017-02-01 Thread Christian Heimes
Christian Heimes added the comment: Py_HASH_CUTOFF was an experimental feature for low-performance platforms. On modern hardware the performance increase is marginal to non-existing. I planned to deprecate the feature in 3.6 but forgot. We can deprecate it now and remove it in either 3.7 or

[issue14376] sys.exit documents argument as "integer" but actually requires "subtype of int"

2017-02-01 Thread Gareth Rees
Gareth Rees added the comment: Is there any chance of making progress on this issue? Is there anything wrong with my patch? Did I omit any relevant point in my message of 2016-06-11 16:26? It would be nice if this were not left in limbo for another four years. --

[issue27400] Datetime NoneType after calling Py_Finalize and Py_Initialize

2017-02-01 Thread Christopher Schramm
Christopher Schramm added the comment: This issue should have a much higher priority as it basically breaks Python embedding unless the user either does not re-initialize the interpreter or avoid the use of _datetime.strptime. We're currently testing with a patch based on Christian and

[issue29410] Moving to SipHash-1-3

2017-02-01 Thread INADA Naoki
INADA Naoki added the comment: Current Py_HASH_CUTOFF implementation seems weak. ``` switch(len) { /* ((hash << 5) + hash) + *p == hash * 33 + *p */ case 7: hash = ((hash << 5) + hash) + *p++; /* fallthrough */ ... case 1: hash = ((hash << 5) + hash) +

[issue29169] update zlib to 1.2.11

2017-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7b279c263708 by doko in branch '3.5': Issue #29169: Fix NEWS entry. https://hg.python.org/cpython/rev/7b279c263708 -- ___ Python tracker

[issue27200] make doctest in CPython has failures

2017-02-01 Thread Marco Buttu
Marco Buttu added the comment: Thank you Raymond for your time. I just want to note that does not distrac the reader, because it is not show in the output. Furthermore, to doctest an example we do not need to add the prompt (>>>): we can use the testcode/testoutput Sphinx directives.

[issue27647] Update Windows 2.7 build to Tcl/Tk 8.5.19

2017-02-01 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- versions: -Python 3.5 ___ Python tracker ___ ___

[issue27647] Update Windows 2.7 build to Tcl/Tk 8.5.19

2017-02-01 Thread Terry J. Reedy
Terry J. Reedy added the comment: I changed title to match what might and, I think, should happen. My take: x.y is normally followed within 2 years by x.(y+1), which on Windows includes the latest tcl/tk. So, on Windows, anyone who wants the new tcl/tk can upgrade to the newer Python. For

<    1   2   3   >