[issue30746] Reject environment variable names containing '='

Changes by Serhiy Storchaka : -- pull_requests: +2441 ___ Python tracker ___ ___

[issue30746] Reject environment variable names containing '='

Changes by Serhiy Storchaka : -- pull_requests: +2440 ___ Python tracker ___ ___

[issue30751] IDLE: Display entry errors for key sequence entry in entry box

New submission from Terry J. Reedy: One of the features of query.Query boxes is that error messages are displayed in the box (in red) rather than in a separate tkinter.messagebox error box (showerror). This issue is about copying the idea and implementation to config_key.GetKeysDialog. To

[issue30062] datetime in Python 3.6+ no longer respects 'TZ' environment variable

Ammar Askar added the comment: Closing this since as you pointed out this behavior is already documented. As an aside, seeing as you guys already have pytz as a dependency. Instead of fixing this with tzset you can also just explicitly do datetime.datetime.fromtimestamp(time,

[issue30746] Reject environment variable names containing '='

Changes by Serhiy Storchaka : -- pull_requests: +2439 ___ Python tracker ___ ___

[issue30746] Reject environment variable names containing '='

Changes by Serhiy Storchaka : -- pull_requests: +2438 ___ Python tracker ___ ___

[issue30746] Reject environment variable names containing '='

Serhiy Storchaka added the comment: New changeset 77703942c5997dff00c48f10df1b29b11645624c by Serhiy Storchaka in branch 'master': bpo-30746: Prohibited the '=' character in environment variable names (#2382) https://github.com/python/cpython/commit/77703942c5997dff00c48f10df1b29b11645624c

[issue27523] Silence Socket Depreciation Warnings.

Zachary Ware added the comment: This is being handled in bpo-23451, GH-2318. -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Deprecation warnings building 3.5 Visual Studio Windows 8.1 64 bit ___ Python

[issue27523] Silence Socket Depreciation Warnings.

Changes by Decorater : -- versions: +Python 3.7 ___ Python tracker ___ ___

[issue27523] Silence Socket Depreciation Warnings.

Changes by Decorater : -- pull_requests: +2437 ___ Python tracker ___ ___

[issue27523] Silence Socket Depreciation Warnings.

Decorater added the comment: Reopened as I found where to actually silence it. -- status: closed -> open ___ Python tracker ___

[issue30748] Upgrade tuples in socket to named tuple like

Changes by Roundup Robot : -- pull_requests: +2436 ___ Python tracker ___

[issue30576] http.server should support HTTP compression (gzip)

Martin Panter added the comment: For existing “.gz” files, I wasn’t suggesting to compress them a second time, just for the server report that they are already compressed, like how it reports the Content-Type value based on the file name. Including Content-Encoding would help browsers display

[issue30747] _Py_atomic_* not actually atomic on Windows with MSVC

Changes by Serhiy Storchaka : -- nosy: +mark.dickinson ___ Python tracker ___

[issue24813] Redesign Help => About IDLE, make it non-modal

Terry J. Reedy added the comment: There are no *nix buildbots running gui tests. Please run python3 -m test.test_ttk_guionly -v and post failure part of result on core_mentorship or open a tracker issue. -- ___ Python tracker

[issue30750] Update `make patchcheck` to understand Misc/NEWS.d

Changes by Antoine Pitrou : -- pull_requests: +2435 ___ Python tracker ___ ___

[issue30750] Update `make patchcheck` to understand Misc/NEWS.d

New submission from Brett Cannon: Title says it all. -- messages: 296797 nosy: brett.cannon, pitrou priority: normal severity: normal status: open title: Update `make patchcheck` to understand Misc/NEWS.d ___ Python tracker

[issue21519] IDLE : Bug in keybinding validity check

Terry J. Reedy added the comment: configdialog.ConfigDialog.getNewKeys() calls config_key.GetKeysDialog with a list of lists of one or more sequences (currentKeySequences). GetKeysDialog.KeysOK looks for keys.split() in currentKeySequences. Since KeysOK on only called for the no-space

[issue29097] datetime.fromtimestamp(t) when 0 <= t <= 86399 fails on Python 3.6

Ammar Askar added the comment: Created a github pull request for the recommended patch along with a test: https://github.com/python/cpython/pull/2385 -- ___ Python tracker

[issue29097] datetime.fromtimestamp(t) when 0 <= t <= 86399 fails on Python 3.6

Changes by Ammar Askar : -- pull_requests: +2434 ___ Python tracker ___ ___

[issue30749] Non-atomic and unusual (wrong) rename behavior under OS X, Python 2.7.13

New submission from Alex Groce: Attached file causes a failed rename, which is fine. However, after the failed rename, the directory structure has changed (and the error reported is not very helpful). Behavior does not match Linux or Windows behavior. Discovered using random testing to

[issue30747] _Py_atomic_* not actually atomic on Windows with MSVC

Steve Dower added the comment: Unless you've got an example of this causing actual issues, it should only go into 3.7. All platforms supported by Windows guarantee atomicity for aligned, pointer-sized reads and writes, but there appear to be memory fencing semantics in here too. I don't

[issue30748] Upgrade tuples in socket to named tuple like

New submission from Ben Lewis: Within the socket module, there are various tuples that are used for different representations of a socket address. There are also other tuples returned by other functions in the socket module. As suggested on

[issue30687] build.bat should locate msbuild.exe rather than vcvarsall.bat

Steve Dower added the comment: I suspect that should be filed as a bug against VS 2017 - I'll do that when I get to work on Monday. Our workaround should be to check for that targets file and keep searching if it's not found. Your best workaround is to start the build from the VS 2015

[issue30747] _Py_atomic_* not actually atomic on Windows with MSVC

Changes by Antoine Pitrou : -- nosy: +paul.moore, steve.dower, tim.golden, zach.ware stage: -> patch review type: enhancement -> behavior versions: +Python 3.5 ___ Python tracker

[issue24813] Redesign Help => About IDLE, make it non-modal

Cheryl Sabella added the comment: $:~/cpython/Lib$ /home/cheryl/cpython/python -m test -ugui == CPython 3.7.0a0 (heads/bpo24813:48fbe52, Jun 23 2017, 15:42:25) [GCC 5.4.0 20160609] == Linux-4.4.0-78-generic-x86_64-with-debian-stretch-sid little-endian == hash algorithm: siphash24 64bit == cwd:

[issue30671] dict: improve lookup function

Tim Peters added the comment: Actually, there is something to be gained here, for smaller tables. The simple formulas for the expected number of probes under uniform hashing are upper bounds, and are significantly overstated when the load factor is very high (not a concern for Python) or the

[issue24813] Redesign Help => About IDLE, make it non-modal

Terry J. Reedy added the comment: I should have been clearer - the full *python* test suite, not just IDLE, an with gui available -- "python -m test -ugui". I don't think the check is applied with just one file, and definitely not with 'test.test_idle' versus 'test -ugui test_idle'. The

[issue30747] _Py_atomic_* not actually atomic on Windows with MSVC

Changes by Pär Björklund : -- pull_requests: +2433 ___ Python tracker ___ ___

[issue24813] Redesign Help => About IDLE, make it non-modal

Cheryl Sabella added the comment: I had run the full test before pushing the changes without any messages. I didn't run it with any options though. -- $:~/cpython/Lib$ /home/cheryl/cpython/python -m test.test_idle

[issue30747] _Py_atomic_* not actually atomic on Windows with MSVC

New submission from Pär Björklund: _Py_atomic_store and _Py_atomic_load are not implemented as atomic operations on Windows when using Visual Studio to build. This might cause hard to troubleshoot behaviour, especially in third party hosting applications.. -- components: Interpreter

[issue24813] Redesign Help => About IDLE, make it non-modal

Terry J. Reedy added the comment: Please run the full test suite to see if it ends with a warning about test_idle altering something. I cannot because of #30715. I usually save and restore original objects when mocking, but I don't really know when this is and is not needed. --

[issue30687] build.bat should locate msbuild.exe rather than vcvarsall.bat

Pär Björklund added the comment: Currently I have VS2017 installed without C++ tooling for .NET development. The C++ tooling breaks other projects I'm working on. I have VS2015 Community update 3 installed with C++ tooling and the latest compatible Windows SDK. Before this patch everything

[issue30687] build.bat should locate msbuild.exe rather than vcvarsall.bat

Steve Dower added the comment: You're going to get build failures without the C++ tooling anyway, and msbuild should find previous installs that are compatible. What is your system setup that causes this failure when you expect success? -- ___

[issue30715] Test_winreg, test_dynamic_key hangs on my Win 10

Terry J. Reedy added the comment: Ping. I still cannot run the test suite to completion, so I cannot tell whether I add a warning failure regression. Does anyone else have the same problem? Should I patch the file to skip this test? -- ___

[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

Changes by Serhiy Storchaka : -- pull_requests: +2432 ___ Python tracker ___ ___

[issue30746] Reject environment variable names containing '='

Changes by Serhiy Storchaka : -- pull_requests: +2431 ___ Python tracker ___ ___

[issue30746] Reject environment variable names containing '='

New submission from Serhiy Storchaka: Environment variable names shouldn't contain the '=' character, because it often is used as a separator between a name and a value. There is an exception -- starting '=' on Windows is used for defining "hidden" environment variables. Using names

[issue30687] build.bat should locate msbuild.exe rather than vcvarsall.bat

Pär Björklund added the comment: This change causes build failures when VS2017 is installed without the C++ tooling as it finds MSBuild belonging to VS2017 but it can't build using it. Microsoft recommends using this tool https://github.com/microsoft/vswhere to find and set up the paths, it

[issue30596] Add close() to multiprocessing.Process

Antoine Pitrou added the comment: New changeset 13e96cc596d158b98996db3fa291086ea4afecd9 by Antoine Pitrou in branch 'master': Fix bpo-30596: Add close() method to multiprocessing.Process (#2010) https://github.com/python/cpython/commit/13e96cc596d158b98996db3fa291086ea4afecd9 --

[issue30596] Add close() to multiprocessing.Process

Changes by Antoine Pitrou : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker ___

[issue24813] Redesign Help => About IDLE, make it non-modal

Changes by Cheryl Sabella : -- pull_requests: +2430 ___ Python tracker ___ ___

[issue30703] test_multiprocessing_forkserver hangs on the master branch

Antoine Pitrou added the comment: Thanks for trying :-) Hmm, that's annoying. I don't know if you'd like to give me shell access to the machine (and a CPython checkout I can play with, perhaps)? -- ___ Python tracker

[issue30703] test_multiprocessing_forkserver hangs on the master branch

Matt Billenstein added the comment: I don't see anything odd -- it runs for awhile and then times out once it's deadlocked: 0:03:18 load avg: 3.20 [224] test_multiprocessing_forkserver test_many_processes (test.test_multiprocessing_forkserver.WithProcessesTestProcess) ... ok

[issue30616] Cannot use functional API to create enum with zero values

Ethan Furman added the comment: New changeset 504b95047a8ada06ab630abce55ac2f85566ca37 by ethanfurman (Dong-hee Na) in branch '3.6': [3.6] bpo-30616: Functional API of enum allows to create empty enums. (#2304) (#2324)

[issue30703] test_multiprocessing_forkserver hangs on the master branch

Antoine Pitrou added the comment: It would be nice to know if there is additional output (for example exceptions happening in other threads or processes) when you run that command and manage to trigger a hang. -- ___ Python tracker

[issue30703] test_multiprocessing_forkserver hangs on the master branch

Matt Billenstein added the comment: Cool -- do you need me to do something more to help debug this? -- ___ Python tracker ___

[issue30623] python-nightly import numpy fails since recently

Thomas Caswell added the comment: https://github.com/python/cpython/pull/1236 has been merged, I believe this issue can be closed. -- nosy: +tcaswell ___ Python tracker

[issue30745] Warnings in Modules/_winapi.c

Serhiy Storchaka added the comment: New changeset e0d446e9caa38923e43818f78c94f95fe0aa995e by Serhiy Storchaka in branch '3.5': [3.5] bpo-30745: Fix compiler warnings introduced in bpo-30730. (GH-2376) (#2379) https://github.com/python/cpython/commit/e0d446e9caa38923e43818f78c94f95fe0aa995e

[issue30730] Injecting environment variable in subprocess on Windows

Serhiy Storchaka added the comment: New changeset e0d446e9caa38923e43818f78c94f95fe0aa995e by Serhiy Storchaka in branch '3.5': [3.5] bpo-30745: Fix compiler warnings introduced in bpo-30730. (GH-2376) (#2379) https://github.com/python/cpython/commit/e0d446e9caa38923e43818f78c94f95fe0aa995e

[issue30744] Local variable assignment is broken when combined with threads + tracing + closures

Nick Coghlan added the comment: The writeback-only-if-changed approach sounds like a plausible improvement to me. I'd be hesitant to include such a change in 3.5.4 though, since we don't get a second go at that if something breaks unexpectedly. However, I don't think returning a write-through

[issue30730] Injecting environment variable in subprocess on Windows

Serhiy Storchaka added the comment: New changeset 0e1f9e8d3ea82262cbb9a403b70a884da5e6a6ac by Serhiy Storchaka in branch '3.6': [3.6] bpo-30745: Fix compiler warnings introduced in bpo-30730. (GH-2376) (#2378) https://github.com/python/cpython/commit/0e1f9e8d3ea82262cbb9a403b70a884da5e6a6ac

[issue30745] Warnings in Modules/_winapi.c

Serhiy Storchaka added the comment: New changeset 0e1f9e8d3ea82262cbb9a403b70a884da5e6a6ac by Serhiy Storchaka in branch '3.6': [3.6] bpo-30745: Fix compiler warnings introduced in bpo-30730. (GH-2376) (#2378) https://github.com/python/cpython/commit/0e1f9e8d3ea82262cbb9a403b70a884da5e6a6ac

[issue30745] Warnings in Modules/_winapi.c

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.5, Python 3.6 ___ Python tracker

[issue30745] Warnings in Modules/_winapi.c

Changes by Serhiy Storchaka : -- pull_requests: +2428 ___ Python tracker ___ ___

[issue30730] Injecting environment variable in subprocess on Windows

Changes by Serhiy Storchaka : -- pull_requests: +2429 ___ Python tracker ___ ___

[issue30730] Injecting environment variable in subprocess on Windows

Changes by Serhiy Storchaka : -- pull_requests: +2427 ___ Python tracker ___ ___

[issue30745] Warnings in Modules/_winapi.c

Changes by Serhiy Storchaka : -- pull_requests: +2426 ___ Python tracker ___ ___

[issue30730] Injecting environment variable in subprocess on Windows

Serhiy Storchaka added the comment: New changeset 0ee32c148119031e19c79359f5c4789ee69fa355 by Serhiy Storchaka in branch 'master': bpo-30745: Fix compiler warnings introduced in bpo-30730. (#2376) https://github.com/python/cpython/commit/0ee32c148119031e19c79359f5c4789ee69fa355 --

[issue30745] Warnings in Modules/_winapi.c

Serhiy Storchaka added the comment: New changeset 0ee32c148119031e19c79359f5c4789ee69fa355 by Serhiy Storchaka in branch 'master': bpo-30745: Fix compiler warnings introduced in bpo-30730. (#2376) https://github.com/python/cpython/commit/0ee32c148119031e19c79359f5c4789ee69fa355 --

[issue30744] Local variable assignment is broken when combined with threads + tracing + closures

Changes by Xavier G. Domingo : -- nosy: +xgdomingo ___ Python tracker ___ ___

[issue6739] IDLE: refuse invalid key bindings

Cheryl Sabella added the comment: I've made a PR for the patch. Even though other tests need to be added, I only added a test for the call to sequence_ok(). Testing this by itself will probably allow it to be mocked in other tests. I also added a call to the unittest in config_key.py.

[issue30745] Warnings in Modules/_winapi.c

Segev Finer added the comment: I tried the PR locally and I didn't get the warnings. :) -- ___ Python tracker ___

[issue6739] IDLE: refuse invalid key bindings

Changes by Cheryl Sabella : -- pull_requests: +2425 ___ Python tracker ___ ___

[issue30745] Warnings in Modules/_winapi.c

Serhiy Storchaka added the comment: Thank you for noticing this Segev. I hope the following PR fixes warnings. -- assignee: -> serhiy.storchaka ___ Python tracker

[issue30726] [Windows] Warnings in elementtree due to new expat

Changes by Segev Finer : -- versions: +Python 3.5, Python 3.6 ___ Python tracker ___ ___

[issue30730] Injecting environment variable in subprocess on Windows

Changes by Serhiy Storchaka : -- pull_requests: +2424 ___ Python tracker ___ ___

[issue30745] Warnings in Modules/_winapi.c

Changes by Serhiy Storchaka : -- pull_requests: +2423 ___ Python tracker ___ ___

[issue30726] [Windows] Warnings in elementtree due to new expat

Segev Finer added the comment: It seems that the issue repeats in pyexpat.vcxproj. I submitted a PR for that one as well. -- ___ Python tracker ___

[issue30726] [Windows] Warnings in elementtree due to new expat

Changes by Segev Finer : -- pull_requests: +2422 ___ Python tracker ___ ___

[issue30745] Warnings in Modules/_winapi.c

New submission from Segev Finer: ..\Modules\_winapi.c(886): warning C4090: 'function': different 'const' qualifiers ..\Modules\_winapi.c(848): warning C4101: 'wenvironment_size': unreferenced local variable Added in d174d24a5d37d1516b885dc7c82f71ecd5930700 -- components: Windows

[issue30730] Injecting environment variable in subprocess on Windows

Serhiy Storchaka added the comment: New changeset 9dda2caca8edc7ff1285f6b0d1c5279b51854b7d by Serhiy Storchaka in branch '2.7': [2.7] bpo-30730: Prevent environment variables injection in subprocess on Windows. (GH-2325) (#2372)

[issue29097] datetime.fromtimestamp(t) when 0 <= t <= 86399 fails on Python 3.6

Ammar Askar added the comment: Hey, sorry for the late response. I just ran: import datetime from dateutil.zoneinfo import get_zonefile_instance import dateutil.tz zonenames = list(get_zonefile_instance().zones) for tz in zonenames: tz = dateutil.tz.gettz(tz) for i in

[issue30647] CODESET error on AMD64 FreeBSD 10.x Shared 3.x caused by the PEP 538

Changes by Nick Coghlan : -- pull_requests: +2421 ___ Python tracker ___ ___

[issue30541] Add restricted mocks to the python unittest mocking framework

Changes by László Kiss Kollár : -- nosy: +László Kiss Kollár ___ Python tracker ___

[issue30744] Local variable assignment is broken when combined with threads + tracing + closures

Nathaniel Smith added the comment: Some thoughts based on discussion with Armin in #pypy: It turns out if you simply delete the LocalsToFast and FastToLocals calls in call_trampoline, then the test suite still passes. I'm pretty sure that pdb relies on this as a way to set local variables,

[issue30744] Local variable assignment is broken when combined with threads + tracing + closures

Armin Rigo added the comment: (Note: x.py is for Python 2.7; for 3.x, of course, replace ``.next()`` with ``.__next__()``. The result is the same) -- ___ Python tracker

[issue30744] Local variable assignment is broken when combined with threads + tracing + closures

Armin Rigo added the comment: A version of the same problem without threads, using generators instead to get the bug deterministically. Prints 1, 1, 1, 1 on CPython and 1, 2, 3, 3 on PyPy; in both cases we would rather expect 1, 2, 3, 4. -- Added file:

[issue30744] Local variable assignment is broken when combined with threads + tracing + closures

Changes by Armin Rigo : -- nosy: +arigo ___ Python tracker ___ ___

[issue30708] Ensure that the result of PyUnicode_AsWideCharString() doesn't contain null characters if size is not returned

Serhiy Storchaka added the comment: Could anyone please make a review of this PR? Especially the documentation part. This PR is a part of a set of PRs that fix potential vulnerabilities (issue13617, issue30730, and yet few issues planned). -- ___

[issue30744] Local variable assignment is broken when combined with threads + tracing + closures

Changes by Nick Coghlan : -- nosy: +ncoghlan ___ Python tracker ___ ___ Python-bugs-list

[issue30730] Injecting environment variable in subprocess on Windows

Changes by Serhiy Storchaka : -- pull_requests: +2420 ___ Python tracker ___ ___