[issue31236] improve some error messages of min() and max()

2017-08-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. -- components: +Interpreter Core -IO dependencies: +wrong error messages when too many kwargs are received nosy: +serhiy.storchaka stage: -> patch review type: behavior -> enhancement ___ Python tracker

[issue31230] Define a general "asynchronous operation introspection" protocol

2017-08-18 Thread Nick Coghlan
Nick Coghlan added the comment: I agree https://bugs.python.org/issue31197 is orthogonal - refactoring the current logic is useful regardless of what we do at the object attribute layer. Regarding __delegated_to__/__returns_to__, the reason I like *not* having "async" in the attribute names

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

2017-08-18 Thread Cheryl Sabella
Changes by Cheryl Sabella : -- pull_requests: +3189 ___ Python tracker ___ ___

[issue31205] IDLE, configdialog: Factor out KeysPage class from ConfigDialog

2017-08-18 Thread Cheryl Sabella
Changes by Cheryl Sabella : -- pull_requests: +3190 ___ Python tracker ___ ___

[issue31239] namedtuple comparison ignores types

2017-08-18 Thread Vlad Shcherbina
Vlad Shcherbina added the comment: While we are at it, namedtuple inherits other operations that make no sense for fixed-length tuples: >>> Rectangle(width=1, height=2) * 3 (1, 2, 1, 2, 1, 2) >>> Rectangle(width=1, height=2) + Ellipse(x_axis=3, y_axis=4) (1, 2, 3, 4) But those are not so

[issue31239] namedtuple comparison ignores types

2017-08-18 Thread Vlad Shcherbina
New submission from Vlad Shcherbina: Toy example: >>> from collections import namedtuple >>> Rectangle = namedtuple('Rectangle', 'width height') >>> Ellipse = namedtuple('Ellipse', 'x_axis y_axis') >>> Rectangle(width=1, height=2) == Ellipse(x_axis=1, y_axis=2) True I understand this happens

[issue31234] Make support.threading_cleanup() stricter

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset b50e7683acac36ff16e6c6c2c32d9a15e46b5174 by Victor Stinner in branch '3.6': bpo-31234: test_threading: fix ref cycle (#3150) (#3152) https://github.com/python/cpython/commit/b50e7683acac36ff16e6c6c2c32d9a15e46b5174 --

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

2017-08-18 Thread Łukasz Langa
Changes by Łukasz Langa : -- pull_requests: +3187 ___ Python tracker ___ ___

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

2017-08-18 Thread Łukasz Langa
Changes by Łukasz Langa : -- pull_requests: +3187, 3188 ___ Python tracker ___ ___

[issue31234] Make support.threading_cleanup() stricter

2017-08-18 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +3186 ___ Python tracker ___ ___

[issue31234] Make support.threading_cleanup() stricter

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset 3d284c081fc3042036adfe1bf2ce92c34d743b0b by Victor Stinner in branch 'master': bpo-31234: test_threading: fix ref cycle (#3150) https://github.com/python/cpython/commit/3d284c081fc3042036adfe1bf2ce92c34d743b0b --

[issue31234] Make support.threading_cleanup() stricter

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: test_logging: see bpo-30830. -- ___ Python tracker ___ ___ Python-bugs-list

[issue31234] Make support.threading_cleanup() stricter

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: test_pydoc: see bpo-31238. -- ___ Python tracker ___ ___ Python-bugs-list

[issue31238] pydoc: ServerThread.stop() leaves a dangling thread

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: This issue is similar to bpo-31151: socketserver ForkingMixIn.server_close() leaks zombie processes. -- ___ Python tracker

[issue31238] pydoc: ServerThread.stop() leaves a dangling thread

2017-08-18 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +3185 ___ Python tracker ___ ___

[issue31238] pydoc: ServerThread.stop() leaves a dangling thread

2017-08-18 Thread STINNER Victor
New submission from STINNER Victor: When using https://github.com/python/cpython/pull/3138 I see that test_pydoc leaves a dangling thread. The bug comes from test_server() which uses pydoc ServerThread. ServerThread.stop() and test_pydoc don't join the thread. Moreover,

[issue31237] test_gdb disables 25% of tests in optimized builds

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: Sadly, python-gdb fails to get required data for some commands, so python-gdb doesn't work fully on optimized builds. -- ___ Python tracker

[issue31237] test_gdb disables 25% of tests in optimized builds

2017-08-18 Thread Łukasz Langa
New submission from Łukasz Langa: We are skipping a lot of tests when optimizations are enabled (which essentially means: compiled without `--with-pydebug`). This seems overly aggressive since most Python users are using the gdb bindings with a non-debug build. I think we should have tests

[issue31234] Make support.threading_cleanup() stricter

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: test_threading: https://github.com/python/cpython/pull/3150 -- ___ Python tracker ___

[issue31234] Make support.threading_cleanup() stricter

2017-08-18 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +3184 ___ Python tracker ___ ___

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

2017-08-18 Thread Łukasz Langa
Łukasz Langa added the comment: The issue originally stems from the fact that a non-debug Python build with --enable-shared is inlining PyEval_EvalFrameEx into _PyEval_EvalFrameDefault. So, the patch should really become to *replace* discovering PyEval_EvalFrameEx with the discovery of

[issue31151] socketserver.ForkingMixIn.server_close() leaks zombie processes

2017-08-18 Thread STINNER Victor
Changes by STINNER Victor : -- title: test_socketserver: Warning -- reap_children() reaped child process -> socketserver.ForkingMixIn.server_close() leaks zombie processes ___ Python tracker

[issue30391] test_threading_handled() and test_threading_not_handled() of test_socketserver hangs randomly on AMD64 FreeBSD 10.x Shared 3.6

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: I recently found two issues in socketserver: * bpo-31233: socketserver.ThreadingMixIn leaks running threads after server_close() * bpo-31151: socketserver.ForkingMixIn.server_close() leaks zombie processes Fixing these two issues is likely to help to fix this

[issue30849] test_stress_delivery_dependent() of test_signal randomly fails on AMD64 Debian root 3.6/3.x

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: test_stress_delivery_dependent() failed on AMD64 Debian root 3.x too, it's not specific to 3.6: http://buildbot.python.org/all/builders/AMD64%20Debian%20root%203.x/builds/1192/steps/test/logs/stdio

[issue30849] test_stress_delivery_dependent() of test_signal randomly fails on AMD64 Debian root 3.6/3.x

2017-08-18 Thread STINNER Victor
Changes by STINNER Victor : -- title: test_stress_delivery_dependent() of test_signal randomly fails on AMD64 Debian root 3.6 -> test_stress_delivery_dependent() of test_signal randomly fails on AMD64 Debian root 3.6/3.x

[issue31235] test_logging: ResourceWarning: unclosed

2017-08-18 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue31235] test_logging: ResourceWarning: unclosed

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset 3e866dfaecaa4eb8f98c12782d2488f681225c37 by Victor Stinner in branch '3.6': bpo-31235: Fix ResourceWarning in test_logging (#3147) (#3149) https://github.com/python/cpython/commit/3e866dfaecaa4eb8f98c12782d2488f681225c37 --

[issue30947] Update embeded copy of libexpat from 2.2.1 to 2.2.3

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset ec4ab09b7c0b5070bdb27351f979cbecc4636245 by Victor Stinner in branch '2.7': bpo-30947: Update libexpat from 2.2.1 to 2.2.3 (#3106) (#3145) https://github.com/python/cpython/commit/ec4ab09b7c0b5070bdb27351f979cbecc4636245 --

[issue30947] Update embeded copy of libexpat from 2.2.1 to 2.2.3

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset 83e37e16f3065086d721d4e62a3788e01db3431c by Victor Stinner in branch '3.6': bpo-30947: Update libexpat from 2.2.1 to 2.2.3 (#3106) (#3143) https://github.com/python/cpython/commit/83e37e16f3065086d721d4e62a3788e01db3431c --

[issue31235] test_logging: ResourceWarning: unclosed

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: Python 2.7 is not affected: it doesn't have SMTPHandlerTest. -- versions: +Python 3.6 ___ Python tracker ___

[issue31235] test_logging: ResourceWarning: unclosed

2017-08-18 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +3183 ___ Python tracker ___ ___

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

2017-08-18 Thread Terry J. Reedy
Terry J. Reedy added the comment: I cannot do the backport at the moment, so at your convenience, please run cherry picker for PR3141 for 3.6. You can submit the 2nd PR for 3.7 without waiting for me to merge the backport. -- ___ Python tracker

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

2017-08-18 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset a32e40561a24de373d1c5a437a8aa329758ba8e4 by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-31206: IDLE: Factor HighPage class from ConfigDialog (#3141) https://github.com/python/cpython/commit/a32e40561a24de373d1c5a437a8aa329758ba8e4

[issue31205] IDLE, configdialog: Factor out KeysPage class from ConfigDialog

2017-08-18 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset a32e40561a24de373d1c5a437a8aa329758ba8e4 by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-31206: IDLE: Factor HighPage class from ConfigDialog (#3141) https://github.com/python/cpython/commit/a32e40561a24de373d1c5a437a8aa329758ba8e4

[issue31235] test_logging: ResourceWarning: unclosed

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset a7719e27b3cad0f2b86cb932a76cbe55c541b02e by Victor Stinner in branch 'master': bpo-31235: Fix ResourceWarning in test_logging (#3147) https://github.com/python/cpython/commit/a7719e27b3cad0f2b86cb932a76cbe55c541b02e --

[issue5001] Remove assertion-based checking in multiprocessing

2017-08-18 Thread drallensmith
drallensmith added the comment: Sorry! I was starting to wonder if the PR had been overlooked somehow... -- ___ Python tracker ___

[issue31235] test_logging: ResourceWarning: unclosed

2017-08-18 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +3182 ___ Python tracker ___ ___

[issue31235] test_logging: ResourceWarning: unclosed

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: Traceback from tracemalloc: 10-STABLE-amd64% ./python -X tracemalloc=10 -m test -v test_logging --fail-env-changed (...) /usr/home/haypo/cpython/Lib/test/support/__init__.py:1515: ResourceWarning: unclosed gc.collect() Object allocated at (most recent

[issue31236] improve some error messages of min() and max()

2017-08-18 Thread Oren Milman
Changes by Oren Milman : -- pull_requests: +3181 ___ Python tracker ___ ___

[issue30947] Update embeded copy of libexpat from 2.2.1 to 2.2.3

2017-08-18 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +3180 ___ Python tracker ___ ___

[issue30947] Update embeded copy of libexpat from 2.2.1 to 2.2.3

2017-08-18 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +3179 ___ Python tracker ___ ___

[issue31236] improve some error messages of min() and max()

2017-08-18 Thread Oren Milman
New submission from Oren Milman: currently, we have the following: >>> min(0, a=1) TypeError: 'a' is an invalid keyword argument for this function >>> max(0, a=1) TypeError: 'a' is an invalid keyword argument for this function >>> max(0, a=1, b=2, c=3) TypeError: function

[issue30947] Update embeded copy of libexpat from 2.2.1 to 2.2.3

2017-08-18 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +3178 ___ Python tracker ___ ___

[issue30830] test_logging leaks dangling threads on FreeBSD

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: > New changeset 6966960468327c958b03391f71f24986bd697307 by Victor Stinner in > branch 'master': > bpo-30830: test_logging uses threading_setup/cleanup (#3137) With this commit, test_logging should detect better bugs in the code. The commit also skips all

[issue30830] test_logging leaks dangling threads on FreeBSD

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset 6966960468327c958b03391f71f24986bd697307 by Victor Stinner in branch 'master': bpo-30830: test_logging uses threading_setup/cleanup (#3137) https://github.com/python/cpython/commit/6966960468327c958b03391f71f24986bd697307 --

[issue31233] socketserver.ThreadingMixIn leaks running threads after server_close()

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset 6966960468327c958b03391f71f24986bd697307 by Victor Stinner in branch 'master': bpo-30830: test_logging uses threading_setup/cleanup (#3137) https://github.com/python/cpython/commit/6966960468327c958b03391f71f24986bd697307 --

[issue30947] Update embeded copy of libexpat from 2.2.1 to 2.2.3

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset 93d0cb58b4da2a88c56f472c6c19491cc7a390df by Victor Stinner in branch 'master': bpo-30947: Update libexpat from 2.2.1 to 2.2.3 (#3106) https://github.com/python/cpython/commit/93d0cb58b4da2a88c56f472c6c19491cc7a390df --

[issue31235] test_logging: ResourceWarning: unclosed

2017-08-18 Thread STINNER Victor
New submission from STINNER Victor: Sometimes, running test_logging emits such warning: ResourceWarning: unclosed I'm not sure where it does come from. See also bpo-30830 (test_logging leaks dangling threads on FreeBSD). -- messages: 300534 nosy: haypo priority: normal severity:

[issue31233] socketserver.ThreadingMixIn leaks running threads after server_close()

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: Oh, test_socketserver just failed with ENV_CHANGED on AMD64 Windows7 SP1 3.x: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/865/steps/test/logs/stdio test_TCPServer (test.test_socketserver.SocketServerTest) ... creating server

[issue14976] queue.Queue() is not reentrant, so signals and GC can cause deadlocks

2017-08-18 Thread Guido van Rossum
Guido van Rossum added the comment: Given the date from that comment I assume that I told Raymond this during the 2016 core sprint. I can't recall that conversation but I am still pretty worried about using an RLock. (What if someone slightly more insane decides to call get() from inside a GC

[issue31234] Make support.threading_cleanup() stricter

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset c99d41f9c0304fcf06550515c3db55f93a629e9e by Victor Stinner in branch 'master': bpo-31234: fork_wait tests now join threads (#3139) https://github.com/python/cpython/commit/c99d41f9c0304fcf06550515c3db55f93a629e9e --

[issue28777] Add asyncio.Queue __aiter__, __anext__ methods

2017-08-18 Thread Guido van Rossum
Guido van Rossum added the comment: Let's not do this. -- resolution: -> rejected stage: test needed -> resolved status: open -> closed ___ Python tracker

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: > You have to rebuild python for /Tools/gdb/libpython.py to land in /python-gdb.py. The latter is used during test_gdb.py. Ah yes, sorry, that's not obvious. "make" does the copy for you. -- ___ Python tracker

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

2017-08-18 Thread Łukasz Langa
Łukasz Langa added the comment: OK, I got the repro. You have to rebuild python for /Tools/gdb/libpython.py to land in /python-gdb.py. The latter is used during test_gdb.py. -- ___ Python tracker

[issue30923] Add -Wimplicit-fallthrough=0 to Makefile ?

2017-08-18 Thread Stefan Krah
Stefan Krah added the comment: New changeset d73a960c575207539c3f9765cff26d4fff400b45 by Stefan Krah in branch 'master': bpo-30923: Disable warning that has been part of -Wextra since gcc-7.0. (#3142) https://github.com/python/cpython/commit/d73a960c575207539c3f9765cff26d4fff400b45

[issue30923] Add -Wimplicit-fallthrough=0 to Makefile ?

2017-08-18 Thread Stefan Krah
Changes by Stefan Krah : -- pull_requests: +3177 ___ Python tracker ___ ___

[issue30923] Add -Wimplicit-fallthrough=0 to Makefile ?

2017-08-18 Thread Stefan Krah
Stefan Krah added the comment: So I installed gcc-7.2.0 from source. Hilariously compiling gcc *itself* emits fallthrough warnings! Then I tried to be a good open source drone and add 20 /* fall through */ comments to libmpdec. gcc is too stupid to recognize the /* fall through */ at the

[issue31232] Backport the new custom "print >> sys.stderr" error message?

2017-08-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It will not break this code. The only visible effect is changing error messages of some TypeError exceptions. -- nosy: +serhiy.storchaka ___ Python tracker

[issue31109] zipimport argument clinic conversion

2017-08-18 Thread Brett Cannon
Brett Cannon added the comment: New changeset 02f3b7d5ab2206d256879e5a8a34f560218ed397 by Brett Cannon (Yaron de Leeuw) in branch 'master': bpo-31109: Convert zipimport to use Argument Clinic (GH-2990) https://github.com/python/cpython/commit/02f3b7d5ab2206d256879e5a8a34f560218ed397

[issue31232] Backport the new custom "print >> sys.stderr" error message?

2017-08-18 Thread Raymond Hettinger
Raymond Hettinger added the comment: But this backport would break my code: >>> print = 10 >>> print >> 1 5 Just kidding ;-) +1 for the backport. It will likely save some headaches. -- nosy: +rhettinger ___ Python tracker

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

2017-08-18 Thread Cheryl Sabella
Changes by Cheryl Sabella : -- pull_requests: +3176 ___ Python tracker ___ ___

[issue31232] Backport the new custom "print >> sys.stderr" error message?

2017-08-18 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: It's probably fine, since it should be a rare occurrence, but it of course has the potential to break things like tests (doc and otherwise). Unlikely, but it should be pointed out. Still, I'm also fine with backporting it. -- nosy: +barry

[issue30830] test_logging leaks dangling threads on FreeBSD

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: I opened bpo-31233: socketserver.ThreadingMixIn leaks running threads after server_close(). -- dependencies: +socketserver.ThreadingMixIn leaks running threads after server_close() ___ Python tracker

[issue9566] Compilation warnings under x64 Windows

2017-08-18 Thread Segev Finer
Changes by Segev Finer : -- pull_requests: +3174 ___ Python tracker ___ ___

[issue30747] _Py_atomic_* not actually atomic on Windows with MSVC

2017-08-18 Thread Segev Finer
Changes by Segev Finer : -- pull_requests: +3175 ___ Python tracker ___ ___

[issue31234] Make support.threading_cleanup() stricter

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: test_fork1, test_wait3: https://github.com/python/cpython/pull/3139 -- ___ Python tracker ___

[issue31234] Make support.threading_cleanup() stricter

2017-08-18 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +3173 ___ Python tracker ___ ___

[issue31234] Make support.threading_cleanup() stricter

2017-08-18 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +3172 ___ Python tracker ___ ___

[issue31234] Make support.threading_cleanup() stricter

2017-08-18 Thread STINNER Victor
New submission from STINNER Victor: Currently, support.threading_cleanup() waits 1 second before emitting a warning about threads running in the background. I propose to emit immediately the warning to be able to catch bugs quicker, bugs like bpo-31233 or bpo-30830. The problem is that

[issue31233] socketserver.ThreadingMixIn leaks running threads after server_close()

2017-08-18 Thread Antoine Pitrou
Antoine Pitrou added the comment: The difference is that letting a thread run doesn't create a zombie thread, so I don't think the issue is really similar. -- nosy: +pitrou ___ Python tracker

[issue31230] Define a general "asynchronous operation introspection" protocol

2017-08-18 Thread syncosmic
syncosmic added the comment: I like where this is heading! Aside from the cleaner patterns for handling these objects, I think it'll make it a little easier for people who are just starting to use asynchronous objects in Python (e.g. me) to grasp what's similar about them. +1 that

[issue30830] test_logging leaks dangling threads on FreeBSD

2017-08-18 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +3171 ___ Python tracker ___ ___

[issue30830] test_logging leaks dangling threads on FreeBSD

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: > Example: > > 10-STABLE-amd64% ./python -m test -v test_logging --fail-env-changed -F -m > test.test_logging.DatagramHandlerTest.test_output -m > test.test_logging.ConfigDictTest.test_listen_config_10_ok >

[issue31211] distutils/util.py get_platform() does not identify linux-i686 platforms

2017-08-18 Thread Éric Araujo
Éric Araujo added the comment: > both wheel/pip makes calls to distutils.util.get_platform(). Fixing it in one > location > would fix it across the board. True, but it may have unintended effects in other places that disrupt or break parts of the CPython build process, or downstream packaging

[issue31233] socketserver.ThreadingMixIn leaks running threads after server_close()

2017-08-18 Thread STINNER Victor
New submission from STINNER Victor: test_logging has a race condition: sometimes, it leaks dangling threads on FreeBSD: bpo-30830. I identified the root issue: socketserver.ThreadingMixIn spawns threads without waiting for their completion in server_close(). This issue is very similar to

[issue30830] test_logging leaks dangling threads on FreeBSD

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: The problem is that socketserver.ThreadingMixIn spawns threads without waiting for their completion in server_close(). For example, the following two tests use socketserver.ThreadingMixIn and so can leak a running thread: *

[issue18156] Add an 'attr' attribute to AttributeError

2017-08-18 Thread Brett Cannon
Changes by Brett Cannon : -- keywords: -easy ___ Python tracker ___ ___ Python-bugs-list

[issue5001] Remove assertion-based checking in multiprocessing

2017-08-18 Thread Antoine Pitrou
Antoine Pitrou added the comment: Please allow us a bit of time :-) We are all volunteers here. -- ___ Python tracker ___

[issue14976] queue.Queue() is not reentrant, so signals and GC can cause deadlocks

2017-08-18 Thread Antoine Pitrou
Antoine Pitrou added the comment: Le 18/08/2017 à 17:37, Yury Selivanov a écrit : > > Is it guaranteed that the GC will happen in the same thread that is holding > the lock? By design, if it's called from a different thread, Queue will cope fine: __del__ implicitly calls RLock.acquire which,

[issue14976] queue.Queue() is not reentrant, so signals and GC can cause deadlocks

2017-08-18 Thread Yury Selivanov
Yury Selivanov added the comment: > Here is a pure Python PoC patch that allows unbounded Queue and LifoQueue to > have reentrant put(). Is it guaranteed that the GC will happen in the same thread that is holding the lock? IOW will RLock help with all GC/__del__ deadlocking scenarios?

[issue14976] queue.Queue() is not reentrant, so signals and GC can cause deadlocks

2017-08-18 Thread Antoine Pitrou
Antoine Pitrou added the comment: Also, to elaborate a bit, I don't think we should aim to make Queue fully reentrant, as that would be extremely involved. I think we can settle on the simpler goal of making put() reentrant for unbounded LIFO and FIFO queues, which is what most people care

[issue31231] Travis CI mac test broken: ./python: is a directory

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: Thanks Han Lee for the bug report, the issue should now be fixed. -- ___ Python tracker ___

[issue31231] Travis CI mac test broken: ./python: is a directory

2017-08-18 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.7 ___ Python tracker

[issue31231] Travis CI mac test broken: ./python: is a directory

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset 92b1f90143286385c0ff5be98d3721b90580a912 by Victor Stinner in branch 'master': bpo-31231: Fix pythoninfo in Travis config (#3134) https://github.com/python/cpython/commit/92b1f90143286385c0ff5be98d3721b90580a912 --

[issue30871] Add test.pythoninfo

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset 92b1f90143286385c0ff5be98d3721b90580a912 by Victor Stinner in branch 'master': bpo-31231: Fix pythoninfo in Travis config (#3134) https://github.com/python/cpython/commit/92b1f90143286385c0ff5be98d3721b90580a912 --

[issue14976] queue.Queue() is not reentrant, so signals and GC can cause deadlocks

2017-08-18 Thread Antoine Pitrou
Antoine Pitrou added the comment: Guido, apparently you are opposed to the Queue implementation using a RLock instead of a Lock, according to Raymond in https://bugs.python.org/issue14976#msg275377. I find this a bit surprising, so could you confirm it yourself? -- nosy: +gvanrossum

[issue14976] queue.Queue() is not reentrant, so signals and GC can cause deadlocks

2017-08-18 Thread Antoine Pitrou
Antoine Pitrou added the comment: I'll believe it when Guido chimes in and actually says so himself. Otherwise, I am skeptical Guido cares a lot about whether the internal implementation of Queue uses a Lock, a RLock or whatever else. -- ___

[issue30830] test_logging leaks dangling threads on FreeBSD

2017-08-18 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +3170 ___ Python tracker ___ ___

[issue31231] Travis CI mac test broken: ./python: is a directory

2017-08-18 Thread R. David Murray
R. David Murray added the comment: Ah, this is probably the issue: https://github.com/python/cpython/pull/3134 -- ___ Python tracker ___

[issue31231] Travis CI mac test broken: ./python: is a directory

2017-08-18 Thread R. David Murray
R. David Murray added the comment: Heh. I saw the PR but didn't realize it was attached to this issue :) -- ___ Python tracker ___

[issue31231] Travis CI mac test broken: ./python: is a directory

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: The error comes from "./python -m test.pythoninfo": see bpo-30871. Attached PR should fix this bug. -- nosy: +haypo ___ Python tracker

[issue30871] Add test.pythoninfo

2017-08-18 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +3169 ___ Python tracker ___ ___

[issue31231] Travis CI mac test broken: ./python: is a directory

2017-08-18 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +3168 ___ Python tracker ___ ___

[issue31231] Travis CI mac test broken: ./python: is a directory

2017-08-18 Thread R. David Murray
R. David Murray added the comment: The docs you point to are correct (they mention python.exe). The Travis log also shows it using python.exe. So the error message about the directory must be about some other operation than just running the python command. -- components: +macOS

[issue14976] queue.Queue() is not reentrant, so signals and GC can cause deadlocks

2017-08-18 Thread mike bayer
mike bayer added the comment: > Here is a pure Python PoC patch that allows unbounded Queue and LifoQueue to > have reentrant put(). per http://bugs.python.org/msg275377 guido does not want an RLock here. -- ___ Python tracker

[issue31232] Backport the new custom "print >> sys.stderr" error message?

2017-08-18 Thread Ned Deily
Ned Deily added the comment: I am OK with adding it to 3.6.x. -- ___ Python tracker ___ ___ Python-bugs-list

[issue30871] Add test.pythoninfo

2017-08-18 Thread STINNER Victor
STINNER Victor added the comment: I applied Segev Finer's fix for bpo-30121 (commit 4d3851727fb82195e4995c6064b0b2d6cbc031c4 ), so test.pythoninfo now works properly on Windows. I added a new pythoninfo step to Unix and Windows buildbots. It seems like everything is fine. I will wait a few

[issue30871] Add test.pythoninfo

2017-08-18 Thread STINNER Victor
Changes by STINNER Victor : -- title: Add a "python info" command somewhere to dump versions of all dependencies -> Add test.pythoninfo ___ Python tracker

[issue28777] Add asyncio.Queue __aiter__, __anext__ methods

2017-08-18 Thread Matt Rasband
Matt Rasband added the comment: I attempted this myself, it seemed to have too many costs associated for the stdlib and is something easy enough to wrap myself when I need this functionality with explicit semantics on how to "stop" the queue (using an `object()` sentinel). My implementation

[issue30121] Windows: subprocess debug assertion on failure to execute the process

2017-08-18 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +3167 ___ Python tracker ___ ___

  1   2   >