[issue31178] [EASY] subprocess: TypeError: can't concat str to bytes, in _execute_child()

2017-09-05 Thread Ammar Askar
Ammar Askar added the comment: If it doesn't manage to make it by tomorrow afternoon, I can backport it manually. It doesn't look like its been able to do it yet. -- nosy: +ammar2 ___ Python tracker __

[issue31361] Update feedparser.py to prevent theano compiling fail in python3

2017-09-05 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- components: +email nosy: +barry, r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue31361] Update feedparser.py to prevent theano compiling fail in python3

2017-09-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Why not fix theano instead? Implicit stringification of an argument can hide other bugs. The resolution field should be changed only when close an issue. -- nosy: +serhiy.storchaka resolution: fixed -> ___ Python

[issue31178] [EASY] subprocess: TypeError: can't concat str to bytes, in _execute_child()

2017-09-05 Thread Gregory P. Smith
Gregory P. Smith added the comment: awaiting our new carrot nosed bot the create the backport PR to take care of 3.6 :) -- assignee: -> gregory.p.smith versions: +Python 3.6 -Python 3.7 ___ Python tracker ___

[issue31178] [EASY] subprocess: TypeError: can't concat str to bytes, in _execute_child()

2017-09-05 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 3fc499bca18454b9f432b9b0106cab662bfeb549 by Gregory P. Smith (Ammar Askar) in branch 'master': bpo-31178: Avoid concatenating bytes with str in subprocess error (#3066) https://github.com/python/cpython/commit/3fc499bca18454b9f432b9b0106cab662bf

[issue31336] Speed up _PyType_Lookup() for class creation

2017-09-05 Thread Stefan Behnel
Stefan Behnel added the comment: BTW, it seems that Yury's dict copy optimisation would also help here. When I use a benchmark scenario with a simple non-empty method/attribute dict (from Cython this time), almost 10% of the creation time is spent copying that dict, which should essentially ju

[issue31362] "async" and "await" are not keyword

2017-09-05 Thread Ammar Askar
Ammar Askar added the comment: For what its worth, "async" and "await" are special keywords. They only act as keywords under certain situations by the tokenizer. You can read more about this here: https://www.python.org/dev/peps/pep-0492/#transition-plan As far as I am aware, this special casi

[issue31362] "async" and "await" are not keyword

2017-09-05 Thread Conor Cal
Changes by Conor Cal : -- resolution: -> duplicate ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue31362] "async" and "await" are not keyword

2017-09-05 Thread Conor Cal
Conor Cal added the comment: "async" and "await" became kaywords in CPython 3.6. But they are not in kwlist of the keyword library, and will return False by iskeyword method. -- ___ Python tracker

[issue31362] "async" and "await" are not keyword

2017-09-05 Thread Conor Cal
Changes by Conor Cal : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue31362] "async" and "await" are not keyword

2017-09-05 Thread Conor Cal
New submission from Conor Cal: "async" and "await" became kaywords in CPython 3.6. but in the keyword library, they are not in kwlist, and will return False by iskeyword method. -- components: asyncio messages: 301443 nosy: Conor Cal, yselivanov priority: normal severity: normal status:

[issue31358] Pull zlib out to cpython-source-deps

2017-09-05 Thread Matthias Klose
Matthias Klose added the comment: +1, if that's ok with the Windows maintainers. -- ___ Python tracker ___ ___ Python-bugs-list mailin

[issue31361] Update feedparser.py to prevent theano compiling fail in python3

2017-09-05 Thread Wei-Shun Lo
Changes by Wei-Shun Lo : -- resolution: -> fixed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue31361] Update feedparser.py to prevent theano compiling fail in python3

2017-09-05 Thread Wei-Shun Lo
Wei-Shun Lo added the comment: Issue resolved in pull request : https://github.com/python/cpython/pull/3336 -- ___ Python tracker ___

[issue31361] Update feedparser.py to prevent theano compiling fail in python3

2017-09-05 Thread Wei-Shun Lo
New submission from Wei-Shun Lo: To get theano compiled successfully -- messages: 301440 nosy: Wei-Shun Lo priority: normal pull_requests: 3390 severity: normal status: open title: Update feedparser.py to prevent theano compiling fail in python3 type: enhancement versions: Python 3.6 __

[issue29781] SSLObject.version returns incorrect value before handshake.

2017-09-05 Thread Christian Heimes
Changes by Christian Heimes : -- pull_requests: +3389 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue29781] SSLObject.version returns incorrect value before handshake.

2017-09-05 Thread Christian Heimes
Christian Heimes added the comment: New changeset 6877111648ac3e042ee5d0458cbeb65dd1a84b2d by Christian Heimes in branch 'master': bpo-29781: Fix SSLObject.version before handshake (#3364) https://github.com/python/cpython/commit/6877111648ac3e042ee5d0458cbeb65dd1a84b2d -- __

[issue30860] Consolidate stateful C globals under a single struct.

2017-09-05 Thread Eric Snow
Eric Snow added the comment: New changeset 05351c1bd8b70d1878527762174cdaaba3572395 by Eric Snow in branch 'master': Revert "bpo-30860: Consolidate stateful runtime globals." (#3379) https://github.com/python/cpython/commit/05351c1bd8b70d1878527762174cdaaba3572395 --

[issue30860] Consolidate stateful C globals under a single struct.

2017-09-05 Thread Eric Snow
Changes by Eric Snow : -- pull_requests: -3387 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue30860] Consolidate stateful C globals under a single struct.

2017-09-05 Thread Eric Snow
Changes by Eric Snow : -- pull_requests: +3388 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue30860] Consolidate stateful C globals under a single struct.

2017-09-05 Thread Eric Snow
Changes by Eric Snow : -- pull_requests: +3387 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue31360] argparse mutually_exclusive_group under add_argument_group fails if part of parent_processor

2017-09-05 Thread Paul Traina (discontent)
New submission from Paul Traina (discontent): Hopefully I'm not being obtuse, but I seem to be getting incorrect/unexpected help output when using mutually_exclusive_group under an add_argument_group if this layering is happening in a parent parser. Here's an example of the triggering usage:

[issue30860] Consolidate stateful C globals under a single struct.

2017-09-05 Thread Benjamin Peterson
Benjamin Peterson added the comment: I'm also a bit skeptical about the header design in this PR. We should not to have a monolithic _Python.h header, and it should not be sometimes included in Python.h. Rather, code that needs the internal headers should include them directly. In fact, this P

[issue30860] Consolidate stateful C globals under a single struct.

2017-09-05 Thread STINNER Victor
STINNER Victor added the comment: Sadly, Windows doesn't like much your big change. Just one example: 2>C:\buildbot.python.org\3.x.kloth-win64\build\Include\Python-ast.h(563): warning C4005: 'Yield': macro redefinition [C:\buildbot.python.org\3.x.kloth-win64\build\PCbuild\pythoncore.vcxp

[issue31350] asyncio: Optimize get_event_loop and _get_running_loop

2017-09-05 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: This has been backported. Thanks all :) -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue31350] asyncio: Optimize get_event_loop and _get_running_loop

2017-09-05 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: New changeset ff125e1aa9ee4eb928de79320a0e7c1b0c0f58f4 by Mariatta (Miss Islington (bot)) in branch '3.6': bpo-31350: Optimize get_event_loop and _get_running_loop (GH-3347) (GH-3373) https://github.com/python/cpython/commit/ff125e1aa9ee4eb928de79320a0e7c1b0c0

[issue31359] `configure` script incorrectly detects symbols as available on Mac w/ Xcode 8+

2017-09-05 Thread Maxime Belanger
Changes by Maxime Belanger : -- components: +Build, macOS nosy: +ned.deily, ronaldoussoren type: -> compile error ___ Python tracker ___

[issue31359] `configure` script incorrectly detects symbols as available on Mac w/ Xcode 8+

2017-09-05 Thread Maxime Belanger
New submission from Maxime Belanger: At Dropbox, we use a custom fork of Python to deploy our Desktop Client onto various platforms, including macOS. We currently use the Mac OS X 10.11 SDK, but are considering updating to the macOS 10.12 SDK, which introduced new low-level functions, such as

[issue31355] Remove Travis CI macOS job: rely on buildbots

2017-09-05 Thread Ned Deily
Ned Deily added the comment: New changeset 2bc83afb30850f682487ffa560c9e3663788baaa by Ned Deily (Victor Stinner) in branch '2.7': bpo-31355: Travis CI: remove the macOS job (#3367) https://github.com/python/cpython/commit/2bc83afb30850f682487ffa560c9e3663788baaa -- _

[issue31355] Remove Travis CI macOS job: rely on buildbots

2017-09-05 Thread Ned Deily
Ned Deily added the comment: New changeset 11453524ed26ee449275c32bedfd86ef19dd91ee by Ned Deily (Victor Stinner) in branch '3.6': bpo-31355: Travis CI: remove the macOS job (#3367) https://github.com/python/cpython/commit/11453524ed26ee449275c32bedfd86ef19dd91ee -- _

[issue30860] Consolidate stateful C globals under a single struct.

2017-09-05 Thread Eric Snow
Eric Snow added the comment: New changeset 76d5abc8684bac4f2fc7cccfe2cd940923357351 by Eric Snow in branch 'master': bpo-30860: Consolidate stateful runtime globals. (#2594) https://github.com/python/cpython/commit/76d5abc8684bac4f2fc7cccfe2cd940923357351 -- _

[issue29988] (async) with blocks and try/finally are not as KeyboardInterrupt-safe as one might like

2017-09-05 Thread Nick Coghlan
Nick Coghlan added the comment: I've updated the draft PR to actually raise the exception from a pending call hook, rather than emulating it in a trace hook. This was a bit trickier than I first expected, as it required moving the trace hook itself into C, as otherwise the "return" bytecode at

[issue31355] Remove Travis CI macOS job: rely on buildbots

2017-09-05 Thread STINNER Victor
Changes by STINNER Victor : -- title: Remove Travis CI job: rely on buildbots -> Remove Travis CI macOS job: rely on buildbots ___ Python tracker ___ ___

[issue30662] fix OrderedDict.__init__ docstring to reflect PEP 468

2017-09-05 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: Backport done. Thanks all :) -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___

[issue30662] fix OrderedDict.__init__ docstring to reflect PEP 468

2017-09-05 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: New changeset 3b9dfe631117430dee8ef8a2f205b4b450d5 by Mariatta in branch '3.6': [3.6] bpo-30662: fixed OrderedDict.__init__ docstring re PEP 468 (GH-2179) (GH-3370) https://github.com/python/cpython/commit/3b9dfe631117430dee8ef8a2f205b4b450d5 --

[issue31320] test_ssl logs a traceback

2017-09-05 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: New changeset c506403faf8dbfc8baf4212e8e2aedb7268acb5e by Mariatta (Miss Islington (bot)) in branch '3.6': [3.6] bpo-31320: No traceback to sys.stderr in test_ssl (GH-3360) (GH-3369) https://github.com/python/cpython/commit/c506403faf8dbfc8baf4212e8e2aedb7268a

[issue31170] Update to expat 2.2.4 (expat: utf8_toUtf8 cannot properly handle exhausting buffer)

2017-09-05 Thread Benjamin Peterson
Benjamin Peterson added the comment: New changeset c00d5087cd308cc8be41e0afd8df27726185347f by Benjamin Peterson (Victor Stinner) in branch '2.7': bpo-31170: Update libexpat from 2.2.3 to 2.2.4 (#3315) https://github.com/python/cpython/commit/c00d5087cd308cc8be41e0afd8df27726185347f -

[issue30947] Update embeded copy of libexpat from 2.2.1 to 2.2.3

2017-09-05 Thread Ned Deily
Ned Deily added the comment: New changeset 297516ea509c72d8ebed3a9b3ce200f023aca0b7 by Ned Deily (Victor Stinner) in branch '3.3': [3.3] bpo-30947, bpo-31170: Update expat from 2.2.1 to 2.2.4 (#3352) https://github.com/python/cpython/commit/297516ea509c72d8ebed3a9b3ce200f023aca0b7 --

[issue31170] Update to expat 2.2.4 (expat: utf8_toUtf8 cannot properly handle exhausting buffer)

2017-09-05 Thread Ned Deily
Ned Deily added the comment: New changeset 297516ea509c72d8ebed3a9b3ce200f023aca0b7 by Ned Deily (Victor Stinner) in branch '3.3': [3.3] bpo-30947, bpo-31170: Update expat from 2.2.1 to 2.2.4 (#3352) https://github.com/python/cpython/commit/297516ea509c72d8ebed3a9b3ce200f023aca0b7 --

[issue31355] Remove Travis CI job: rely on buildbots

2017-09-05 Thread STINNER Victor
STINNER Victor added the comment: New changeset 501b324d3a940d26e0021a38aae8d896a30fbcff by Victor Stinner in branch 'master': bpo-31355: Travis CI: remove the macOS job (#3367) https://github.com/python/cpython/commit/501b324d3a940d26e0021a38aae8d896a30fbcff -- _

[issue20994] Disable TLS Compression

2017-09-05 Thread Christian Heimes
Christian Heimes added the comment: Issue #28043 did disable compression along with other improvements. 3.5 is now out of scope but I'm considering to backport #28043 to 2.7. I'm closing this issue in favor of #28043. -- resolution: -> duplicate stage: needs patch -> resolved status:

[issue28043] Sane defaults for SSLContext options and ciphers

2017-09-05 Thread Christian Heimes
Christian Heimes added the comment: 3.6 and master are looking good. Should I backport the fix to 2.7, too? -- status: pending -> open ___ Python tracker ___

[issue31358] Pull zlib out to cpython-source-deps

2017-09-05 Thread Zachary Ware
Changes by Zachary Ware : -- pull_requests: +3386 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue31338] Use abort() for code we never expect to hit

2017-09-05 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- pull_requests: +3385 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue31358] Pull zlib out to cpython-source-deps

2017-09-05 Thread Zachary Ware
New submission from Zachary Ware: We currently bundle zlib in our source at Modules/zlib, but it is only used on Windows. The soon-to-be-attached PR instead pulls it from https://github.com/python/cpython-source-deps There is one failure in test_venv only when zlib is not built at all, which

[issue31337] Small opportunity for NULL dereference in compile.c

2017-09-05 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Alright, I'm going to close this bug in favor of bpo-31338 -- resolution: -> wont fix stage: -> resolved status: open -> closed ___ Python tracker __

[issue31350] asyncio: Optimize get_event_loop and _get_running_loop

2017-09-05 Thread Roundup Robot
Changes by Roundup Robot : -- pull_requests: +3384 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue31350] asyncio: Optimize get_event_loop and _get_running_loop

2017-09-05 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset 80bbe6a7b67f33d0d0976bb8e3e5ba26b6b0e626 by Yury Selivanov (jimmylai) in branch 'master': bpo-31350: Optimize get_event_loop and _get_running_loop (#3347) https://github.com/python/cpython/commit/80bbe6a7b67f33d0d0976bb8e3e5ba26b6b0e626

[issue14191] argparse doesn't allow optionals within positionals

2017-09-05 Thread R. David Murray
R. David Murray added the comment: I got an offline agreement from Zach Ware, and nobody here at the sprint has objected (though I don't know if anyone else looked), so I'll go ahead and finish the PR. -- ___ Python tracker

[issue17852] Built-in module _io can lose data from buffered files at exit

2017-09-05 Thread Neil Schemenauer
Changes by Neil Schemenauer : -- pull_requests: +3382, 3383 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue17852] Built-in module _io can lose data from buffered files at exit

2017-09-05 Thread Neil Schemenauer
Changes by Neil Schemenauer : -- pull_requests: +3382 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue31357] Expose `worker_target` and `workitem_cls` as arugments to customize `ThreadPoolExecutor` behaviour

2017-09-05 Thread SenbinYu
New submission from SenbinYu: With the two arguments, we can esaily to customize behaviour when I submit task to a ThreadPoolExecutor instance. It's more useful when I want to execute coroutine function with this executor. With this, we can run coroutine in any pattern programs and don't care

[issue31355] Remove Travis CI job: rely on buildbots

2017-09-05 Thread Zachary Ware
Zachary Ware added the comment: I will note that my on-going research on rewriting the buildbot config makes it look like we should be able to securely enable building PRs by checking for the 'awaiting merge' label. -- ___ Python tracker

[issue17852] Built-in module _io can lose data from buffered files at exit

2017-09-05 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- title: Built-in module _io can loose data from buffered files at exit -> Built-in module _io can lose data from buffered files at exit ___ Python tracker _

[issue30442] Skip test_xml_etree under coverage

2017-09-05 Thread STINNER Victor
STINNER Victor added the comment: New changeset 9a3b3852afe61f9083d336c4394984d0e92799a3 by Victor Stinner in branch '3.6': bpo-30442: Skips refcount test in test_xml_etree under coverage (#1767) (#3363) https://github.com/python/cpython/commit/9a3b3852afe61f9083d336c4394984d0e92799a3 ---

[issue31355] Remove Travis CI job: rely on buildbots

2017-09-05 Thread Ned Deily
Ned Deily added the comment: Since Travis CI time is a bottleneck for the ongoing sprint, I agree that it makes sense to disable the macOS build checks for now. Longer term, it would be nice to resolve the problem but we certainly could rely on our own macOS buildbots; I'm not aware of many (

[issue30662] fix OrderedDict.__init__ docstring to reflect PEP 468

2017-09-05 Thread Raymond Hettinger
Raymond Hettinger added the comment: Mariatta is working on the backport. -- assignee: rhettinger -> Mariatta nosy: +Mariatta ___ Python tracker ___ _

[issue28705] Clean up design FAQ question about compiling to C

2017-09-05 Thread Benjamin Peterson
Changes by Benjamin Peterson : -- pull_requests: +3380 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue14976] queue.Queue() is not reentrant, so signals and GC can cause deadlocks

2017-09-05 Thread Raymond Hettinger
Raymond Hettinger added the comment: Just for the record, Guido explained his aversion to RLocks. Roughly: 1) RLocks are slower and more complex 2) It is difficult to correctly write code that can survive reentrancy, so it is easy fool yourself into believing you've written correct code 3) G

[issue30662] fix OrderedDict.__init__ docstring to reflect PEP 468

2017-09-05 Thread Mariatta Wijaya
Changes by Mariatta Wijaya : -- pull_requests: +3379 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue31355] Remove Travis CI job: rely on buildbots

2017-09-05 Thread STINNER Victor
STINNER Victor added the comment: Failures of the two Allowed Failure jobs, coverage and macOS, are not reported to GitHub PR. For example, the coverage job is failing on Python 3.6 since May 2016 at least, and nobody noticed. I don't think that it's worth it to waste Travis CI resources if no

[issue31356] Add context manager to temporarily disable GC

2017-09-05 Thread Raymond Hettinger
New submission from Raymond Hettinger: Used like this: with gc_disabled(): run_some_timing() with gc_disabled(): # do_something_that_has_real_time_guarantees # such as a pair trade, robotic braking, etc This would be implemented in C for atomicity and speed. It

[issue16137] Using time.asctime() with an array with negative tm_hour causes Python Crash.

2017-09-05 Thread STINNER Victor
STINNER Victor added the comment: This issue should be fixed by my commit eeadf5fc231163ec97a8010754d9c995c7c14876. -- ___ Python tracker ___ ___

[issue31339] [2.7] time.asctime() crash with year > 9999 using musl C library

2017-09-05 Thread STINNER Victor
STINNER Victor added the comment: Ok, it's now fixed. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ _

[issue27768] ssl: get CPU cap flags for AESNI and PCLMULQDQ

2017-09-05 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Instead of making the cipher suite selection more complicated, we should > just rely on OpenSSL to provide sensible defaults. +1 ! -- ___ Python tracker __

[issue31320] test_ssl logs a traceback

2017-09-05 Thread Roundup Robot
Changes by Roundup Robot : -- pull_requests: +3378 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue31320] test_ssl logs a traceback

2017-09-05 Thread Christian Heimes
Christian Heimes added the comment: New changeset 305e56c27afce605e5d2f71903a966cf0bb95038 by Christian Heimes in branch 'master': bpo-31320: No traceback to sys.stderr in test_ssl (#3360) https://github.com/python/cpython/commit/305e56c27afce605e5d2f71903a966cf0bb95038 -- __

[issue31339] [2.7] time.asctime() crash with year > 9999 using musl C library

2017-09-05 Thread STINNER Victor
STINNER Victor added the comment: New changeset eeadf5fc231163ec97a8010754d9c995c7c14876 by Victor Stinner in branch '2.7': bpo-31339: Rewrite time.asctime() and time.ctime() (#3293) https://github.com/python/cpython/commit/eeadf5fc231163ec97a8010754d9c995c7c14876 --

[issue27768] ssl: get CPU cap flags for AESNI and PCLMULQDQ

2017-09-05 Thread Christian Heimes
Christian Heimes added the comment: I'm retracting my patch. Instead of making the cipher suite selection more complicated, we should just rely on OpenSSL to provide sensible defaults. -- resolution: -> rejected stage: -> resolved status: open -> closed __

[issue31338] Use abort() for code we never expect to hit

2017-09-05 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Sep 5, 2017, at 16:07, STINNER Victor wrote: > > STINNER Victor added the comment: > >> Neither gcc (macOS, Ubuntu), nor clang (Ubuntu) complain. > > Ok, cool. In that case, go ahead. I checked with @steve.dower and I think abort() will work on MSVC too.

[issue31170] Update to expat 2.2.4 (expat: utf8_toUtf8 cannot properly handle exhausting buffer)

2017-09-05 Thread STINNER Victor
STINNER Victor added the comment: New changeset e5f2f8038540f9f06478f842f8f7313df4d2e59b by Victor Stinner in branch '3.6': bpo-31170: Update libexpat from 2.2.3 to 2.2.4 (#3315) (#3350) https://github.com/python/cpython/commit/e5f2f8038540f9f06478f842f8f7313df4d2e59b --

[issue31355] Remove Travis CI job: rely on buildbots

2017-09-05 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +3377 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue31355] Remove Travis CI job: rely on buildbots

2017-09-05 Thread STINNER Victor
New submission from STINNER Victor: Currently, Travis CI has a job running tests on macOS. Sadly, there is a bug on Travis: *sometimes*, the macOS job blocks a Pull Request to be merged even if macOS is marked as "Allowed Failure". If you cancel the job, it's even worse: Travis CI is marked a

[issue30662] fix OrderedDict.__init__ docstring to reflect PEP 468

2017-09-05 Thread Raymond Hettinger
Raymond Hettinger added the comment: New changeset faa57cbe7074b26807cd7ed89a7b173b5cbf3086 by Raymond Hettinger (Jonathan Eunice) in branch 'master': bpo-30662: fixed OrderedDict.__init__ docstring re PEP 468 (#2179) https://github.com/python/cpython/commit/faa57cbe7074b26807cd7ed89a7b173b5cbf

[issue30445] test_traceback fails in coverage run

2017-09-05 Thread STINNER Victor
STINNER Victor added the comment: New changeset 6fce7ea893dc3f69b607dd6ef48c2d3d0f6ca414 by Victor Stinner in branch '3.6': bpo-30445: Allow appended output in RecursionError message (#3356) https://github.com/python/cpython/commit/6fce7ea893dc3f69b607dd6ef48c2d3d0f6ca414 -- nosy: +ha

[issue31338] Use abort() for code we never expect to hit

2017-09-05 Thread STINNER Victor
STINNER Victor added the comment: > Neither gcc (macOS, Ubuntu), nor clang (Ubuntu) complain. Ok, cool. In that case, go ahead. -- ___ Python tracker ___ ___

[issue31338] Use abort() for code we never expect to hit

2017-09-05 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: So with this diff: modified Include/pymacro.h @@ -95,4 +95,6 @@ #define Py_UNUSED(name) _unused_ ## name #endif +#define Py_UNREACHABLE() abort() + #endif /* Py_PYMACRO_H */ modified Python/compile.c @@ -1350,8 +1350,7 @@ get_const_value(expr_ty e)

[issue31338] Use abort() for code we never expect to hit

2017-09-05 Thread STINNER Victor
STINNER Victor added the comment: +#define Py_UNREACHABLE() abort() Using such macro, I don't think that __builtin_unreachable() is useful. https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html Another use for __builtin_unreachable is following a call a function that never returns but that i

[issue18880] ssl.SSLSocket shutdown doesn't behave like socket.shutdown

2017-09-05 Thread Christian Heimes
Christian Heimes added the comment: I agree with Antoine. I tried to test your patch and found out that is not compatible with socketserver. The socketserver module shuts down the connection with SHUT_WR. We could either ignore the problem or ignore the how and use SHUT_RDWR in all cases. --

[issue20762] SSLSocket.read() not documented

2017-09-05 Thread Christian Heimes
Christian Heimes added the comment: I'll deprecate read() and write() in my upcoming PEP. -- resolution: -> later stage: needs patch -> resolved status: open -> closed ___ Python tracker __

[issue18880] ssl.SSLSocket shutdown doesn't behave like socket.shutdown

2017-09-05 Thread Antoine Pitrou
Antoine Pitrou added the comment: This will needlessly break code which until now accepts both kinds of sockets. By the way, socket.shutdown() doesn't specify that *only* one direction is shut down when using SHUT_RD or SHUT_WR; what is guaranteed is that *at least* the given direction will sh

[issue31354] Fixing a bug related to LTO only build

2017-09-05 Thread Octavian Soldea
Changes by Octavian Soldea : -- pull_requests: +3376 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue18880] ssl.SSLSocket shutdown doesn't behave like socket.shutdown

2017-09-05 Thread Christian Heimes
Christian Heimes added the comment: Sounds like a good idea. -- versions: +Python 2.7, Python 3.6 ___ Python tracker ___ ___ Python-bu

[issue28938] match_hostname treats SAN IP address as DNS name and fails to check CN then

2017-09-05 Thread Christian Heimes
Changes by Christian Heimes : -- stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue30502] Fix buffer handling of OBJ_obj2txt

2017-09-05 Thread Christian Heimes
Changes by Christian Heimes : -- resolution: -> fixed stage: -> resolved status: open -> closed versions: -Python 3.5 ___ Python tracker ___ __

[issue28938] match_hostname treats SAN IP address as DNS name and fails to check CN then

2017-09-05 Thread Alex Gaynor
Alex Gaynor added the comment: +1 Christian, we should not be expanding our usage of CNs at all. -- status: pending -> open ___ Python tracker ___ ___

[issue28938] match_hostname treats SAN IP address as DNS name and fails to check CN then

2017-09-05 Thread Christian Heimes
Christian Heimes added the comment: I don't like to change the behavior of match_hostname(). RFC 2818 is deprecated. Recent browsers are no longer using CN to verify hostnames. Python is going to ignore CN soonish, too. -- status: open -> pending type: -> behavior versions: +Python 2.

[issue29781] SSLObject.version returns incorrect value before handshake.

2017-09-05 Thread Christian Heimes
Changes by Christian Heimes : -- pull_requests: +3375 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue14976] queue.Queue() is not reentrant, so signals and GC can cause deadlocks

2017-09-05 Thread Raymond Hettinger
Raymond Hettinger added the comment: To handle the logging.handlers.QueueHandler case, the SimpleQueue needs a put_nowait() method (see line 1959 of Lib/logging/handlers.py. [Mike Bayer] > I noticed it's very hard to find documentation on exactly when > gc might run. The answer I got from the

[issue30442] Skip test_xml_etree under coverage

2017-09-05 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +3374 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue31352] Travis CI coverage job fails on Python 3.6

2017-09-05 Thread Ned Batchelder
Changes by Ned Batchelder : -- nosy: +nedbat title: Tracis CI coverage job fails on Python 3.6 -> Travis CI coverage job fails on Python 3.6 ___ Python tracker ___ _

[issue31354] Fixing a bug related to LTO only build

2017-09-05 Thread STINNER Victor
STINNER Victor added the comment: Would you mind to create a pull request? -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list

[issue29781] SSLObject.version returns incorrect value before handshake.

2017-09-05 Thread Christian Heimes
Christian Heimes added the comment: It should be possible to solve the issue w/o tracking the connection state manually. It doesn't work correctly with transparent negotiation -- that is implicit handshake with SSL_write(). SSL_is_init_finished() (https://www.openssl.org/docs/manmaster/man3/S

[issue14976] queue.Queue() is not reentrant, so signals and GC can cause deadlocks

2017-09-05 Thread Antoine Pitrou
Antoine Pitrou added the comment: One tangential note about a potential full-fledged Queue in C: the pure Python implementation is fair towards consumers, as it uses a threading.Condition which is itself fair. Achieving the same thing in C may significantly complicate the implementation. Ray

[issue30140] Binary arithmetic does not always call subclasses first

2017-09-05 Thread Stephan Hoyer
Stephan Hoyer added the comment: Serhiy: thanks for the tip. I've updated my PR, which I think is now ready for review. -- ___ Python tracker ___ ___

[issue31354] Fixing a bug related to LTO only build

2017-09-05 Thread Octavian Soldea
New submission from Octavian Soldea: Hi All, This is Octavian Soldea from the Scripting Languages Optimization team at Intel Corporation. I would like to submit a patch to fix an LTO build issue. With "./configure --with-lto" followed by "make", CPython should be built with LTO or Link-Time-O

[issue14976] queue.Queue() is not reentrant, so signals and GC can cause deadlocks

2017-09-05 Thread Gregory P. Smith
Gregory P. Smith added the comment: yeah, there are others such as https://www.liblfds.org/ that seem better from that standpoint (gcc, and microsoft compiler support - I'm sure clang is fine as well - anything gcc can do they can do). Ensuring they're supported across build target platforms

[issue31320] test_ssl logs a traceback

2017-09-05 Thread Christian Heimes
Changes by Christian Heimes : -- pull_requests: +3373 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue14976] queue.Queue() is not reentrant, so signals and GC can cause deadlocks

2017-09-05 Thread Antoine Pitrou
Antoine Pitrou added the comment: Le 05/09/2017 à 23:21, Gregory P. Smith a écrit : > > FYI - here is an appropriately licensed (WTFPL) very simple lock-free queue > implemented in C Looks like it uses busy-waiting inside its get() equivalent. Also we would need a portable version of the atomi

[issue14976] queue.Queue() is not reentrant, so signals and GC can cause deadlocks

2017-09-05 Thread Gregory P. Smith
Gregory P. Smith added the comment: FYI - here is an appropriately licensed (WTFPL) very simple lock-free queue implemented in C: https://github.com/darkautism/lfqueue -- nosy: +gregory.p.smith ___ Python tracker

  1   2   3   >