[issue31265] Remove doubly-linked list from C OrderedDict

INADA Naoki added the comment: > Original Raymond's design didn't preserve ordering during deletion. Original Raymond's pure Python implementation rebuilds index table. Without it, proving can be very long or infinite loop. See L89-92 in http://code.activestate.com/recipes/578375/ Strictly

[issue29526] Documenting format() function

Changes by Serhiy Storchaka : -- keywords: +patch pull_requests: +3484 stage: -> patch review ___ Python tracker ___

[issue31415] Add -X option to show import time

Changes by INADA Naoki : -- keywords: +patch pull_requests: +3483 stage: -> patch review ___ Python tracker ___

[issue31265] Remove doubly-linked list from C OrderedDict

Serhiy Storchaka added the comment: Note that mixed insertion and deletion is worst-case O(n) in current implementation. Original Raymond's design didn't preserve ordering during deletion. It had worst-case O(1) for mixed insertion and deletion. I didn't follow the numerous discussions about

[issue31415] Add -X option to show import time

New submission from INADA Naoki: I used my local patch to profile import time. I think it's useful for 3rd party authors. For example: ./python -Ximportprofile -c 'import traceback' - _codecs 71 [us] - codecs 677 [us] - encodings.aliases 412 [us] - encodings 1688 [us] - encodings.utf_8

[issue30744] Local variable assignment is broken when combined with threads + tracing + closures

Nick Coghlan added the comment: The same way the dis module does: by looking at the names listed in the various code object attributes. If it's listed in co_cellvars, then it's a local variable in the current frame that's in a cell because it's part of the closure for a nested function. If

[issue29718] Fixed compile on cygwin.

Decorater added the comment: Closing this in favor of https://www.python.org/dev/peps/pep-0539/. -- stage: -> resolved status: open -> closed ___ Python tracker

[issue31308] forkserver process isn't re-launched if it died

Davin Potts added the comment: I have two concerns with this: 1) The implicit restart of the forkserver process seems in conflict with the zen of making things explicit. 2) This would seem to make forkserver's behavior inconsistent with the behavior of things like the Manager which similarly

[issue27755] Retire DynOptionMenu with a ttk Combobox

Changes by Cheryl Sabella : -- pull_requests: +3482 stage: test needed -> patch review ___ Python tracker ___

[issue30781] IDLE: configdialog -- switch to ttk widgets.

Terry J. Reedy added the comment: I moved PR3215 to #27755. So this issue is really closed. -- ___ Python tracker ___

[issue30781] IDLE: configdialog -- switch to ttk widgets.

Terry J. Reedy added the comment: New changeset 4a8b53a2083506ee13ff2eba2c14264f5a7faa91 by Terry Jan Reedy (Miss Islington (bot)) in branch '3.6': [3.6] bpo-30781: IDLE: Fix help button on configdialog (GH-3238) (#3489)

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Changes by Terry J. Reedy : -- dependencies: +IDLE: Entry tests should delete before insert. ___ Python tracker ___

[issue31414] IDLE: Entry tests should delete before insert.

New submission from Terry J. Reedy: Test_configdialog 'tests' several integer entry widgets by inserting a digit and then checking that the new value was sent to changes. However, users may delete an entry totally and enter a new value. If we associate an IntVar with the entry widget,

[issue27099] IDLE: turn built-in extensions into regular modules

Terry J. Reedy added the comment: Charles, thank you for the work. This was pretty tough for both of us. My takeaway: getting configdialog nearly covered first was essential; even better tests for configdialog and other modules would have helped. -- resolution: -> fixed stage: test

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Terry J. Reedy added the comment: I just pushed the extension conversion patch. The tests we did already were greatly helpful, and some tests not done or inadequate hindered. I am now looking to polish configdialog before 3.6.3. If you have anything worth a new issue and PR, I will be

[issue30781] IDLE: configdialog -- switch to ttk widgets.

Changes by Roundup Robot : -- pull_requests: +3481 ___ Python tracker ___

[issue30781] IDLE: configdialog -- switch to ttk widgets.

Terry J. Reedy added the comment: New changeset 3866d9bbcf808cea98b3d7f9f246b83858ce by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-30781: IDLE: Fix help button on configdialog (#3238) https://github.com/python/cpython/commit/3866d9bbcf808cea98b3d7f9f246b83858ce

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Changes by Cheryl Sabella : -- keywords: +patch pull_requests: +3480 stage: test needed -> patch review ___ Python tracker ___

[issue27099] IDLE: turn built-in extensions into regular modules

Terry J. Reedy added the comment: Here is a high-level overview of the steps involved in the patch, and a few TODOs for new issues. Move menu specifications from feature files to mainmenu.py. Remove enable items from config-extensions.def sections. Most features were enabled for both shell

[issue27240] 'UnstructuredTokenList' object has no attribute '_fold_as_ew'

Changes by R. David Murray : -- keywords: +patch pull_requests: +3478 stage: needs patch -> patch review ___ Python tracker ___

[issue30788] email.policy.SMTP.fold() issue for long filenames with spaces

Changes by R. David Murray : -- keywords: +patch pull_requests: +3479 stage: -> patch review ___ Python tracker ___

[issue31413] Support importing anything in ._pth files.

Changes by Decorater : -- type: -> crash ___ Python tracker ___ ___ Python-bugs-list

[issue31413] Support importing anything in ._pth files.

New submission from Decorater: E:\TinyURL\app\Release>tinyurl Fatal Python error: only 'import site' is supported in ._pth file Current thread 0x161c (most recent call first): The above Happens when I try to use the ._pth file to automatically call .main() However it prints that and then

[issue31345] Backport docstring improvements to the C version of OrderedDict

Mariatta Wijaya added the comment: Thanks Henk-Jaap for the PR. It's been merged. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue31265] Remove doubly-linked list from C OrderedDict

INADA Naoki added the comment: > I'm unclear about whether you understand and acknowledge why the > doubly-linked list was chosen and what kind of workloads it supports (we > didn't choose it because it was either convenient or fun, we chose it because > it was an algorithmically correct way

[issue31265] Remove doubly-linked list from C OrderedDict

Raymond Hettinger added the comment: ISTM that what is being proposed is an algorithmically flawed re-implementation of the ordered dictionary. I'm unclear about whether you understand and acknowledge why the doubly-linked list was chosen and what kind of workloads it supports (we didn't

[issue27099] IDLE: turn built-in extensions into regular modules

Terry J. Reedy added the comment: New changeset d6c397bf772a8f17e00afc5e0a2cf37fdebcdf29 by Terry Jan Reedy in branch '3.6': [3.6] bpo-27099: IDLE - Convert built-in extensions to regular features (GH-2494) (#3487)

[issue31361] Update feedparser.py to prevent theano compiling fail in python3

Wei-Shun Lo added the comment: Hi David, >From the error message, the source of the None object was from pip, and it is grabbing data from the metadata of the package. File "/usr/local/lib/python3.6/site-packages/pip/utils/packaging.py", line 48, in check_dist_requires_python -- By adding

[issue31265] Remove doubly-linked list from C OrderedDict

INADA Naoki added the comment: > Just for the record, here is the draft of the post I was going to make on > python-dev but didn't prove to be necessary. Thank you for write down your thought. For move_to_end(), I admit new behavior is *amortized* O(1) and current behavior is *worst-case*

[issue31373] demoting floating float values to unrepresentable types is undefined behavior

Mark Dickinson added the comment: > It's hard to win here I think. Agreed. > It seems like the undefined behavior sanitizer is being overzealous when the > target supports IEEE754. Also agreed. -- ___ Python tracker

[issue31265] Remove doubly-linked list from C OrderedDict

INADA Naoki added the comment: The discussion on [1] was for removing pure Python implementation, not about changing C implementation. [1]: https://mail.python.org/pipermail/python-dev/2017-September/149147.html While I withdrawed my suggestion about removing pure Python implementation, I

[issue25115] SSL_set_verify_depth not exposed by the ssl module

Grant Bremer added the comment: The use case is for an internal PKI implementation where verification should be, needs to be limited to certificates signed by the PKI CA and no higher to, say, a larger realm which would not be appropriate. -- ___

[issue31265] Remove doubly-linked list from C OrderedDict

Raymond Hettinger added the comment: Just for the record, here is the draft of the post I was going to make on python-dev but didn't prove to be necessary. - I think would be a mistake to replace the implementation of collections.OrderedDict() with

[issue31265] Remove doubly-linked list from C OrderedDict

Raymond Hettinger added the comment: Based on the python-dev discussion, can we close this now? -- ___ Python tracker ___

[issue27099] IDLE: turn built-in extensions into regular modules

Changes by Terry J. Reedy : -- keywords: +patch pull_requests: +3477 stage: test needed -> patch review ___ Python tracker ___

[issue8231] Unable to run IDLE without write-access to home directory

Terry J. Reedy added the comment: I closed #30918 as a duplicate of this. It has full 'set' and expanduser info. -- ___ Python tracker ___

[issue30918] Unable to launch IDLE in windows 7

Terry J. Reedy added the comment: Thanks for the information. I hope to get to this before 3.6.3. -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Unable to run IDLE without write-access to home directory ___

[issue27099] IDLE: turn built-in extensions into regular modules

Terry J. Reedy added the comment: New changeset 58fc71c447049d0efe4e11db1b55edc307f1bede by Terry Jan Reedy (wohlganger) in branch 'master': bpo-27099: IDLE - Convert built-in extensions to regular features (#2494)

[issue30918] Unable to launch IDLE in windows 7

dongdong added the comment: Hi Terry, Sorry, I missed your resply because it was buried in my trash email. Here are the configuration in my PC: HOMEDRIVE=Z: HOMEPATH=\ HOMESHARE=\\nt3.imec.be\zhai65 LOCALAPPDATA=C:\Users\zhai65\AppData\Local USERPROFILE=C:\Users\zhai65 In python >>>

[issue31373] demoting floating float values to unrepresentable types is undefined behavior

Benjamin Peterson added the comment: I'm going to undo the changes to getargs.c and floatobject.c. I think the pytime.c change is still correct because the doubles are explicitly rounded before conversion (and the old code checked for error > 1.0). It's hard to win here I think. The clang

[issue31373] demoting floating float values to unrepresentable types is undefined behavior

Changes by Benjamin Peterson : -- pull_requests: +3476 ___ Python tracker ___ ___

[issue31411] SystemError raised by warn_explicit() in case warnings.onceregistry is not a dict

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue31411] SystemError raised by warn_explicit() in case warnings.onceregistry is not a dict

Changes by Oren Milman : -- keywords: +patch pull_requests: +3475 stage: -> patch review ___ Python tracker ___

[issue31412] wave.open does not accept PathLike objects

Changes by Michael Cuthbert : -- keywords: +patch pull_requests: +3474 stage: -> patch review ___ Python tracker ___

[issue31336] Speed up _PyType_Lookup() for class creation

Christian Heimes added the comment: Victor is currently travelling and recovering from jetlag. I'm sure he'll reply within a day or two. -- assignee: -> haypo ___ Python tracker

[issue29136] Add OP_NO_TLSv1_3

Christian Heimes added the comment: New changeset 28580316a57d1757978196c27286f989d21ec0f3 by Christian Heimes in branch '3.6': bpo-29136: Fix versionchange for TLS 1.3 changes (#3483) https://github.com/python/cpython/commit/28580316a57d1757978196c27286f989d21ec0f3 --

[issue29136] Add OP_NO_TLSv1_3

Christian Heimes added the comment: Thanks, I fixed versionchanged. -- stage: patch review -> resolved status: open -> closed versions: +Python 2.7, Python 3.7 ___ Python tracker

[issue31336] Speed up _PyType_Lookup() for class creation

Stefan Behnel added the comment: No, that one was addressed. I think only Victor's comment is still open, that's why I asked back. -- ___ Python tracker

[issue31412] wave.open does not accept PathLike objects

Changes by Michael Cuthbert : -- components: +Library (Lib) type: -> enhancement ___ Python tracker ___

[issue31412] wave.open does not accept PathLike objects

New submission from Michael Cuthbert: The wave library (reading and writing .wav audio files) accepts filehandles, strings, and bytes, but does not accept PathLike objects. Patch will modify wave.py to allow open to use these objects. -- messages: 301826 nosy: mscuthbert priority:

[issue31336] Speed up _PyType_Lookup() for class creation

Serhiy Storchaka added the comment: My comment was addressed. As for using the _Py_IDENTIFIER API, I don't think it is related. The speedup was caused by avoiding few simple checks and function calls. The _Py_IDENTIFIER API is great, but it has a small overhead which is comparable to the

[issue29136] Add OP_NO_TLSv1_3

Changes by Christian Heimes : -- pull_requests: +3473 stage: needs patch -> patch review ___ Python tracker ___

[issue31370] Remove support for threads-less builds

Changes by Antoine Pitrou : -- pull_requests: +3472 ___ Python tracker ___ ___

[issue31336] Speed up _PyType_Lookup() for class creation

Christian Heimes added the comment: Good work, Stefan! It's an impressive speedup of class creation. It looks like you have not yet addressed Serhiy's comment https://github.com/python/cpython/pull/3279/files#r136815648 -- nosy: +christian.heimes

[issue31410] int.__repr__() is slower than repr()

Changes by Serhiy Storchaka : -- keywords: +patch pull_requests: +3471 ___ Python tracker ___

[issue31336] Speed up _PyType_Lookup() for class creation

Stefan Behnel added the comment: Any more comments on the proposed implementation? 13-15% seem worth it to me. @Victor, or are you saying "PyId, or no change at all"? -- ___ Python tracker

[issue31411] SystemError raised by warn_explicit() in case warnings.onceregistry is not a dict

New submission from Oren Milman: The following code causes warn_explicit() (in Python/_warnings.c) to raise a SystemError: import warnings warnings.filterwarnings('once') warnings.onceregistry = None warnings.warn_explicit(message='foo', category=Warning, filename='bar',

[issue31410] int.__repr__() is slower than repr()

New submission from Serhiy Storchaka: Following the StackOverflow question [1]. Calling repr() is faster than calling unbound method __repr__(). This looks strange at first glance because it is *obvious* that repr() is implemented via calling __repr__(). $ ./python -m timeit

[issue29136] Add OP_NO_TLSv1_3

Christian Heimes added the comment: Good catch, thanks! I'll update the documentation. -- stage: resolved -> needs patch status: closed -> open versions: -Python 2.7, Python 3.7 ___ Python tracker

[issue28638] Optimize namedtuple creation

Raymond Hettinger added the comment: New changeset 8b57d7363916869357848e666d03fa7614c47897 by Raymond Hettinger in branch 'master': bpo-28638: Optimize namedtuple() creation time by minimizing use of exec() (#3454)

[issue28638] Optimize namedtuple creation

Changes by Raymond Hettinger : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue31409] Implement PEP 559 - built-in noop()

Barry A. Warsaw added the comment: Rejected by GvR! -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue31406] crashes when comparing between a Decimal object and a bad Rational object

Changes by Stefan Krah : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue31406] crashes when comparing between a Decimal object and a bad Rational object

Stefan Krah added the comment: Thanks for the report and the patch! -- resolution: -> fixed versions: +Python 3.6 ___ Python tracker ___

[issue31409] Implement PEP 559 - built-in noop()

Changes by Barry A. Warsaw : -- keywords: +patch pull_requests: +3470 stage: -> patch review ___ Python tracker ___

[issue31409] Implement PEP 559 - built-in noop()

New submission from Barry A. Warsaw: Placeholder issue for discussion of the design of the implementation of PEP 559. -- assignee: barry components: Interpreter Core messages: 301816 nosy: barry priority: normal severity: normal status: open title: Implement PEP 559 - built-in noop()

[issue31406] crashes when comparing between a Decimal object and a bad Rational object

Stefan Krah added the comment: New changeset f8909d0e4b652256e4da153fa6be664490f60a07 by Stefan Krah (Miss Islington (bot)) in branch '3.6': [3.6] bpo-31406: Fix crash due to lack of type checking in subclassing. (GH-3477) (#3479)

[issue31406] crashes when comparing between a Decimal object and a bad Rational object

Changes by Roundup Robot : -- pull_requests: +3469 ___ Python tracker ___

[issue31408] Leak in typeobject.c

INADA Naoki added the comment: Maybe, PyDict_ClearFreeList() is not called? -- nosy: +inada.naoki ___ Python tracker ___

[issue31406] crashes when comparing between a Decimal object and a bad Rational object

Stefan Krah added the comment: New changeset 3cedf46cdbeefc019f4a672c1104f3d5e94712bd by Stefan Krah in branch 'master': bpo-31406: Fix crash due to lack of type checking in subclassing. (#3477) https://github.com/python/cpython/commit/3cedf46cdbeefc019f4a672c1104f3d5e94712bd --

[issue31408] Leak in typeobject.c

New submission from Stefan Krah: I traced this valgrind result down to 2ebc5ce42a8a9e047e790aefbf9a94811569b2b6 : ==23495== 240 (72 direct, 168 indirect) bytes in 1 blocks are definitely lost in loss record 2,255 of 2,922 ==23495==at 0x4C2A9A1: malloc (vg_replace_malloc.c:299) ==23495==

[issue21009] Potential deadlock in concurrent futures when garbage collection occurs during Queue.get

Simon Jagoe added the comment: In the script attached to the original issue, the weakref callback that causes the hang is the callback defined in ThreadPoolExecutor._adjust_thread_count Attached is a faulthandler stack captured from Python 3.6.1. The script submitted here uses a patched

[issue31407] --without-pymalloc broken

New submission from Stefan Krah: ./configure --without-pymalloc produces: Objects/obmalloc.c: In function ‘bumpserialno’: Objects/obmalloc.c:1326:21: error: ‘struct _pymem_runtime_state’ has no member named ‘serialno’ ++_PyRuntime.mem.serialno; ^ Objects/obmalloc.c:

[issue31406] crashes when comparing between a Decimal object and a bad Rational object

Changes by Stefan Krah : -- pull_requests: +3468 ___ Python tracker ___ ___

[issue31406] crashes when comparing between a Decimal object and a bad Rational object

Changes by Oren Milman : -- keywords: +patch pull_requests: +3467 stage: -> patch review ___ Python tracker ___

[issue31406] crashes when comparing between a Decimal object and a bad Rational object

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka, skrah ___ Python tracker ___

[issue31406] crashes when comparing between a Decimal object and a bad Rational object

New submission from Oren Milman: The following code crashes the interpreter: import decimal import fractions class BadRational(fractions.Fraction): numerator = None denominator = 42 decimal.Decimal() < BadRational() this is because numerator_as_decimal() (in

[issue31373] demoting floating float values to unrepresentable types is undefined behavior

Mark Dickinson added the comment: > Do you know a way to get the IEEE 754 rounding behavior without invoking C > undefined behavior? One option is to hard-code the actual boundary, which is 2**128 * (1 - 2**-25) (as opposed to FLT_MAX, which is 2**128 * (1 - 2**-24)): values equal to or

[issue31311] a SystemError and a crash in PyCData_setstate() when __dict__ is bad

Oren Milman added the comment: just in case it was missed - I have opened two PRs for this issue. -- ___ Python tracker ___

[issue31345] Backport docstring improvements to the C version of OrderedDict

Henk-Jaap Wagenaar added the comment: Hi Mariatta, Thanks for pointing that out about 3.5. Is that also why the build failed!? I found it hard to parse travis' output and was surprised it failed. Thanks for letting me know---getting it fixed. I have added my github account to the other one,

[issue31370] Remove support for threads-less builds

Arfrever Frehtes Taifersar Arahesis added the comment: Also 'import threading' code in Tools/scripts/run_tests.py should be cleaned. -- nosy: +Arfrever ___ Python tracker

[issue28638] Optimize namedtuple creation

Serhiy Storchaka added the comment: Microbenchmark for caching docstrings: $ ./python -m perf timeit -s "from collections import namedtuple; names = ['field%d' % i for i in range(1000)]" -- "namedtuple('A', names)" With sys.intern(): Mean +- std dev: 3.57 ms +- 0.05 ms With Python-level

[issue29136] Add OP_NO_TLSv1_3

Arfrever Frehtes Taifersar Arahesis added the comment: In backport to 2.7 branch, ".. versionadded:: 2.7.15" and ".. versionchanged:: 2.7.15" were used. However, in backport to 3.6 branch, ".. versionadded:: 3.7" and ".. versionchanged:: 3.7" were used, instead of expected ".. versionadded::

[issue25684] ttk.OptionMenu radiobuttons aren't unique between two instances of OptionMenu

Mariatta Wijaya added the comment: Fixed and backported to 3.6 and 2.7. Thanks, all! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue25684] ttk.OptionMenu radiobuttons aren't unique between two instances of OptionMenu

Mariatta Wijaya added the comment: New changeset e1847ea4a9bdc7549893091a63e14f2afbdecc32 by Mariatta (Cheryl Sabella) in branch '2.7': bpo-25684: ttk.OptionMenu radiobuttons weren't unique (GH-2276) (GH-2960) https://github.com/python/cpython/commit/e1847ea4a9bdc7549893091a63e14f2afbdecc32