[issue32145] Wrong ExitStack Callback recipe

2018-01-01 Thread Nick Coghlan
Nick Coghlan added the comment: As per the comment at https://bugs.python.org/issue32445#msg309356, there's a bug in my suggested changes to `ExitStack.pop_all()`: the right method to call is ExitStack.push(), *not* ExitStack.callback() (the latter adds a wrapper function

[issue32445] Skip creating redundant wrapper functions in ExitStack.callback

2018-01-01 Thread Nick Coghlan
Nick Coghlan added the comment: Ah, you're right, I wasn't thinking clearly when I filed this - the correct public API method to transfer existing exit stack entries to a new stack would be "ExitStack.push()". I'll make a note of that on the original issue. --

[issue32478] Add tests for 'break' and 'return' inside 'finally' clause

2018-01-01 Thread Roundup Robot
Change by Roundup Robot : -- pull_requests: +4958 ___ Python tracker ___

[issue32452] Brackets and Parentheses used in an ambiguous way

2018-01-01 Thread Roundup Robot
Change by Roundup Robot : -- pull_requests: +4957 ___ Python tracker ___

[issue32452] Brackets and Parentheses used in an ambiguous way

2018-01-01 Thread Roundup Robot
Change by Roundup Robot : -- pull_requests: +4956 ___ Python tracker ___

[issue32452] Brackets and Parentheses used in an ambiguous way

2018-01-01 Thread R. David Murray
R. David Murray added the comment: New changeset f190eb59e60e2ae7a7cbd396458389a7a076e0d3 by R. David Murray (Emily Morehouse) in branch 'master': bpo-32452: clarify term 'brackets' in generator tutorial (#5079)

[issue32478] Add tests for 'break' and 'return' inside 'finally' clause

2018-01-01 Thread Roundup Robot
Change by Roundup Robot : -- pull_requests: +4955 ___ Python tracker ___

[issue32478] Add tests for 'break' and 'return' inside 'finally' clause

2018-01-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 7cc42c356b0dc5ad9eaa9392789e84bd4aa1c7de by Serhiy Storchaka in branch 'master': bpo-32478: Add tests for 'break' and 'return' inside 'finally' clause. (#5078)

[issue32452] Brackets and Parentheses used in an ambiguous way

2018-01-01 Thread Emily Morehouse
Change by Emily Morehouse : -- nosy: +emilyemorehouse ___ Python tracker ___ ___

[issue32452] Brackets and Parentheses used in an ambiguous way

2018-01-01 Thread Emily Morehouse
Change by Emily Morehouse : -- keywords: +patch pull_requests: +4954 stage: -> patch review ___ Python tracker ___

[issue32453] shutil.rmtree can have O(n^2) performance on large dirs

2018-01-01 Thread Niklas Hambüchen
Niklas Hambüchen added the comment: A better location to view the whole coreutils thread is: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=29921 -- ___ Python tracker

[issue32478] Add tests for 'break' and 'return' inside 'finally' clause

2018-01-01 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +4953 stage: -> patch review ___ Python tracker ___

[issue32478] Add tests for 'break' and 'return' inside 'finally' clause

2018-01-01 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : 'break' and 'return' are never used inside 'finally' clause in the stdlib. Therefore these cases are not covered by tests even implicitly. The proposed patch adds explicit tests for them. 'continue' inside 'finally' clause

[issue32477] Move jumps optimization from the peepholer to the compiler

2018-01-01 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +4952 stage: -> patch review ___ Python tracker ___

[issue32477] Move jumps optimization from the peepholer to the compiler

2018-01-01 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : The proposed patch moves jumps optimization from the peepholer to the compiler. The optimization is performed for lists of instructions before generating concrete bytecode and is not restricted by the size of bytecode

[issue17611] Move unwinding of stack for "pseudo exceptions" from interpreter to compiler.

2018-01-01 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +4951 ___ Python tracker ___ ___

[issue32474] argparse nargs should support string wrapped integers too

2018-01-01 Thread R. David Murray
R. David Murray added the comment: Agreed. I don't think there is sufficient motivation for doing this, and there are downsides as Eric has pointed out. Rejecting. -- resolution: -> rejected stage: patch review -> resolved status: open -> closed

[issue17611] Move unwinding of stack for "pseudo exceptions" from interpreter to compiler.

2018-01-01 Thread Antoine Pitrou
Antoine Pitrou added the comment: > I just worked on it. I meant Mark's PR :-) -- ___ Python tracker ___

[issue17611] Move unwinding of stack for "pseudo exceptions" from interpreter to compiler.

2018-01-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > It would be nice to know if it's able to fix the stack size issues as in the > following tests: I just worked on it. See issue24340. -- dependencies: +co_stacksize estimate can be highly off

[issue24340] co_stacksize estimate can be highly off

2018-01-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Tests originally based on Antoine's tests added for PR 2827. -- ___ Python tracker ___

[issue24340] co_stacksize estimate can be highly off

2018-01-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: With PR 5076 the result of the above example is 10. -- ___ Python tracker ___

[issue24340] co_stacksize estimate can be highly off

2018-01-01 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +4950 ___ Python tracker ___

[issue32474] argparse nargs should support string wrapped integers too

2018-01-01 Thread Andrew Svetlov
Andrew Svetlov added the comment: -1 -- nosy: +asvetlov ___ Python tracker ___

[issue32476] Add concat functionality to ElementTree xpath find

2018-01-01 Thread John Jolly
New submission from John Jolly : The current implementation of the xpath specification in ElementTree does not allow for predicates that may contain both an apostrophe and a quote. Either one or the other is allowed, but escaping (either string escaping using the backslash or

[issue32416] Refactor and add new tests for the f_lineno setter

2018-01-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 439ce8a93936d92e4f10765c482195a28e93ec76 by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6': bpo-32416: Add two new tests in test_sys_settrace. (GH-5072) (#5073)

[issue32416] Refactor and add new tests for the f_lineno setter

2018-01-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 2de47ca109d0418c7c01e451b5614f748ad76ee9 by Serhiy Storchaka (Miss Islington (bot)) in branch '2.7': bpo-32416: Add two new tests in test_sys_settrace. (GH-5072) (#5074)

[issue32474] argparse nargs should support string wrapped integers too

2018-01-01 Thread Shubham Sharma
Change by Shubham Sharma : -- pull_requests: +4949 ___ Python tracker ___ ___

[issue17611] Move unwinding of stack for "pseudo exceptions" from interpreter to compiler.

2018-01-01 Thread Antoine Pitrou
Antoine Pitrou added the comment: I took a quick look at Mark's PR. The main thing going for it IMHO is that it produces simpler bytecode: it removes the complicated with/finally-related opcodes, while Serhiy's has non-trivial END_FINALLY and POP_FINALLY. It would be nice to

[issue32416] Refactor and add new tests for the f_lineno setter

2018-01-01 Thread Roundup Robot
Change by Roundup Robot : -- pull_requests: +4948 ___ Python tracker ___

[issue32416] Refactor and add new tests for the f_lineno setter

2018-01-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset e8ed96550c6aa9a1e39c36e67e892994e25e2c41 by Serhiy Storchaka in branch 'master': bpo-32416: Add two new tests in test_sys_settrace. (#5072)

[issue32416] Refactor and add new tests for the f_lineno setter

2018-01-01 Thread Roundup Robot
Change by Roundup Robot : -- pull_requests: +4947 ___ Python tracker ___

[issue17611] Move unwinding of stack for "pseudo exceptions" from interpreter to compiler.

2018-01-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New opcodes in PR 5071 look interesting, but I think it is better to leave this experiment for a separate issue. Complexities of PRs (ignoring tests, documentation, and generated files): PR 4682: Include/opcode.h | 12 +-

[issue27632] build on AIX fails when builddir != srcdir, more than bad path to ld_so_aix

2018-01-01 Thread Michael Felt
Michael Felt added the comment: There were changes made - I know not when - but OOT builds work now. This issue may be closed. -- ___ Python tracker

[issue28290] BETA report: Python-3.6 build messages to stderr: AIX and "not GCC"

2018-01-01 Thread Michael Felt
Michael Felt added the comment: this was just feedback - and should probably be closed. -- ___ Python tracker ___

[issue32474] argparse nargs should support string wrapped integers too

2018-01-01 Thread Eric V. Smith
Change by Eric V. Smith : -- versions: -Python 3.8 ___ Python tracker ___ ___

[issue27643] test_ctypes fails on AIX with xlc

2018-01-01 Thread Michael Felt
Michael Felt added the comment: As I was not responding properly (too verbose) - I'll reread the thread for the initial patch suggestion - and hope it still fits the current 'master'. My apologies for the long silence on this. -- nosy: -aixto...@gmail.com

[issue32416] Refactor and add new tests for the f_lineno setter

2018-01-01 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +4946 ___ Python tracker ___ ___

[issue17611] Move unwinding of stack for "pseudo exceptions" from interpreter to compiler.

2018-01-01 Thread Mark Shannon
Mark Shannon added the comment: It shouldn't be a surprise that I have submitted a PR. The original patch was my work and a month ago I said I would update it over the Christmas break. To avoid "competing" PRs in future, simply asking before appropriating other peoples work

[issue32475] Add ability to query number of buffered bytes available on buffered I/O

2018-01-01 Thread Antoine Pitrou
Antoine Pitrou added the comment: Why don't you use BufferedReader.peek()? -- nosy: +pitrou ___ Python tracker ___

[issue17611] Move unwinding of stack for "pseudo exceptions" from interpreter to compiler.

2018-01-01 Thread Antoine Pitrou
Antoine Pitrou added the comment: So we now have three competing PRs... each of which is not trivial. It would be nice if somehow there could be some conciliation, or at least a synthetic comparison. I don't think I want to review all three proposals (and I already spent time

[issue32390] AIX (xlc_r) compile error with Modules/posixmodule.c: Function argument assignment between types "unsigned long" and "struct fsid_t" is not allowed

2018-01-01 Thread Michael Felt
Michael Felt added the comment: Did some additional research. The code can work asis when _ALL_SOURCE is undefined. Or, in other words - there does not have to be a variable syntax issue or separate code for AIX. As you read this - please remember that since issue

[issue17611] Move unwinding of stack for "pseudo exceptions" from interpreter to compiler.

2018-01-01 Thread Mark Shannon
Change by Mark Shannon : -- pull_requests: +4945 ___ Python tracker ___ ___ Python-bugs-list

[issue32466] Fix missing test coverage for fractions.Fraction.__new__

2018-01-01 Thread Mark Dickinson
Mark Dickinson added the comment: I've retitled the issue to avoid confusion, since we're no longer proposing removing the _gcd function. -- title: Remove fractions._gcd() -> Fix missing test coverage for fractions.Fraction.__new__

[issue32466] Remove fractions._gcd()

2018-01-01 Thread Mark Dickinson
Mark Dickinson added the comment: > the types in question were added to the numeric tower for gmpy 2.0.9 and > 2.1.0. Ah, good to know. Thanks. I was using 2.0.8. > * We're back to needing a test for the line in question. Agreed. It's not currently covered, and with the

[issue32474] argparse nargs should support string wrapped integers too

2018-01-01 Thread Shubham Sharma
Change by Shubham Sharma : -- keywords: +patch pull_requests: +4944 stage: -> patch review ___ Python tracker ___

[issue32475] Add ability to query number of buffered bytes available on buffered I/O

2018-01-01 Thread Tim Savannah
New submission from Tim Savannah : Hello! This is my first time submitting to Python bug tracker, so please bear with me if I miss/mess something. So a little bit of relevant background, I'm an avid python developer with many open-source projects. One of the projects I