[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

2018-06-19 Thread Tal Einat
Tal Einat added the comment: > I just merged 2nd PR for #33907. I've merged master into the PR branch for this issue and fixed the merge issues. -- ___ Python tracker ___ ___

[issue33906] IDLE: rename windows.py as window.py

2018-06-19 Thread Srinivas Reddy T
Change by Srinivas Reddy T : -- keywords: +patch pull_requests: +7421 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue33905] IDLE: stackbrowser.Stackbrowser should accept exception.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: Only one of tb and exc may be passed. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue33906] IDLE: rename windows.py as window.py

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: Also rename idle_test.test_windows as test_window with git mv. Imports: F:\dev\3x\lib\idlelib\editor.py: 28: from idlelib import windows F:\dev\3x\lib\idlelib\idle_test\test_windows.py: 3: from idlelib import windows F:\dev\3x\lib\idlelib\macosx.py: 131:

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread miss-islington
miss-islington added the comment: New changeset 17d4c53fa3516f78df3c4f343bc6d2007af157cf by Miss Islington (bot) in branch '3.6': bpo-33907: Rename an IDLE module and classes. (GH-7810) https://github.com/python/cpython/commit/17d4c53fa3516f78df3c4f343bc6d2007af157cf -- ___

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread miss-islington
miss-islington added the comment: New changeset ce52f5ee0925925f5662f6b34cc637cfe6c0a46e by Miss Islington (bot) in branch '3.7': bpo-33907: Rename an IDLE module and classes. (GH-7810) https://github.com/python/cpython/commit/ce52f5ee0925925f5662f6b34cc637cfe6c0a46e -- nosy: +miss-

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

2018-06-19 Thread Tal Einat
Tal Einat added the comment: > I [...] would like the popups to respond keyboard (Tab) focus changes as well > as mouse movement focus changes. Should tooltips also be shown automatically when the keyboard focus is on a widget? Using the same delay as for the mouse hover, perhaps? I've nev

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

2018-06-19 Thread Tal Einat
Tal Einat added the comment: >> TclError from widget.destroy suggests that we *might* be able to cleanup >> better. > Any suggestions for a better cleanup mechanism? (Following up my own question with another question...) Would it be better to check self.winfo_exists() instead of the try/ex

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: I just merged 2nd PR for #33907. Combined effect is that module calltips and its class CallTips are now calltip and Calltip. In module calltip_w class CallTip is now CalltipWindow. -- ___ Python tracker

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread miss-islington
Change by miss-islington : -- pull_requests: +7420 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread miss-islington
Change by miss-islington : -- pull_requests: +7419 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 9af1836664d241fec6e62955ffaa559b3a2eaf1b by Terry Jan Reedy in branch 'master': bpo-33907: Rename an IDLE module and classes. (GH-7810) https://github.com/python/cpython/commit/9af1836664d241fec6e62955ffaa559b3a2eaf1b -- _

[issue33904] IDLE: In rstrip, rename class RstripExtension as Rstrip

2018-06-19 Thread Srinivas Reddy T
Change by Srinivas Reddy T : -- keywords: +patch pull_requests: +7418 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue30462] urllib does not support NO_PROXY environment variable containing domain with asterisk

2018-06-19 Thread Xiang Zhang
Xiang Zhang added the comment: Hi, Jiri. Could you update your PR and let's continue with this issue? -- versions: +Python 3.8 -Python 3.7 ___ Python tracker ___ _

[issue33908] remove unecessary variable assignments

2018-06-19 Thread Xiang Zhang
Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: resource usage -> versions: -Python 3.7 ___ Python tracker ___ _

[issue33908] remove unecessary variable assignments

2018-06-19 Thread Srinivas Reddy T
New submission from Srinivas Reddy T : https://github.com/python/cpython/pull/7116 -- messages: 320018 nosy: thatiparthy priority: normal severity: normal status: open title: remove unecessary variable assignments type: resource usage versions: Python 3.7, Python 3.8 _

[issue33908] remove unecessary variable assignments

2018-06-19 Thread Srinivas Reddy T
Change by Srinivas Reddy T : -- keywords: +patch pull_requests: +7417 stage: -> patch review ___ Python tracker ___ ___ Python-bug

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Change by Terry J. Reedy : -- pull_requests: +7416 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list ma

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset e97a685185b82ba6de6de576fc2a4cf3cd6192af by Terry Jan Reedy in branch '3.6': [3.6] bpo-33907: Rename an IDLE module and class. (GH-7807) (GH-7809) https://github.com/python/cpython/commit/e97a685185b82ba6de6de576fc2a4cf3cd6192af --

[issue33301] Add __contains__ to pathlib

2018-06-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There was a similar (closed) issue about making Path an iterable. The problem with both these related ideas is that they are ambiguous. Does it means that a directory contains a specified file, or that a path contains a specified path component, or that a

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: The calltip window class name is only used in 4 places, so I decided to expand to CalltipWindow. -- ___ Python tracker ___ _

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: I also changed calltips.CallTips to calltip.Calltip, which is the same class name as for calltip_w.Calltip (formerly CallTip). This is confusing now and would block merging the files. Change the latter to calltip_w.CalltipW (for Window). -- nosy:

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Change by Terry J. Reedy : -- pull_requests: +7415 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread miss-islington
miss-islington added the comment: New changeset b89a376b3b9bdc3b6f1b7d05ff64babcbfd93cc2 by Miss Islington (bot) in branch '3.7': bpo-33907: Rename an IDLE module and class. (GH-7807) https://github.com/python/cpython/commit/b89a376b3b9bdc3b6f1b7d05ff64babcbfd93cc2 -- nosy: +miss-is

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread miss-islington
Change by miss-islington : -- pull_requests: +7414 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 06e2029dfa500a42e3565ed7ba8573412f153d1c by Terry Jan Reedy in branch 'master': bpo-33907: Rename an IDLE module and class. (GH-7807) https://github.com/python/cpython/commit/06e2029dfa500a42e3565ed7ba8573412f153d1c -- ___

[issue33855] IDLE: Minimally test every non-startup module.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: Still open for a patch explaining idle_test.template in README. I opened #33904 for rstrip, #33905 for stackbrowser, #33906 for windows, and #33907 for calltips/CallTip renaming. -- stage: patch review -> test needed

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Change by Terry J. Reedy : -- keywords: +patch pull_requests: +7413 stage: needs patch -> patch review ___ Python tracker ___ ___ Py

[issue23548] TypeError in event loop finalizer, new in Python 3.4.3

2018-06-19 Thread William Woodall
William Woodall added the comment: Just an update to my previous post. We ran into this issue again, but only noticed later because we do not see this problem on Ubuntu Bionic with Python 3.6.5, but we did see it again when we tested later on Ubuntu Xenial with Python 3.5.1. See: https://gi

[issue33855] IDLE: Minimally test every non-startup module.

2018-06-19 Thread miss-islington
miss-islington added the comment: New changeset cbaee6fe02d22f357c2edf4e463c240d5df22f14 by Miss Islington (bot) in branch '3.7': bpo-33855: Still more edits and minimal tests for IDLE (GH-7784) https://github.com/python/cpython/commit/cbaee6fe02d22f357c2edf4e463c240d5df22f14 -- _

[issue33855] IDLE: Minimally test every non-startup module.

2018-06-19 Thread miss-islington
miss-islington added the comment: New changeset 90209a172c5b629f512cf292a22950285a2c3d81 by Miss Islington (bot) in branch '3.6': bpo-33855: Still more edits and minimal tests for IDLE (GH-7784) https://github.com/python/cpython/commit/90209a172c5b629f512cf292a22950285a2c3d81 -- _

[issue33301] Add __contains__ to pathlib

2018-06-19 Thread Andrew Berger
Andrew Berger added the comment: I think the idea is that either a subdir or file could be valid inputs. So `Path('/usr/bar') in Path('/etc/foo')` return True if `Path('/etc/foo/usr/bar')` is either a dir or file. As for PurePath, I did overlook that accessing an inode via a call to stat w

[issue33855] IDLE: Minimally test every non-startup module.

2018-06-19 Thread miss-islington
Change by miss-islington : -- pull_requests: +7412 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33855] IDLE: Minimally test every non-startup module.

2018-06-19 Thread miss-islington
Change by miss-islington : -- pull_requests: +7411 stage: test needed -> patch review ___ Python tracker ___ ___ Python-bugs-list ma

[issue33855] IDLE: Minimally test every non-startup module.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 4d92158f4c3917fc4fbfebff15224e74782abf79 by Terry Jan Reedy in branch 'master': bpo-33855: Still more edits and minimal tests for IDLE (GH-7784) https://github.com/python/cpython/commit/4d92158f4c3917fc4fbfebff15224e74782abf79 -- ___

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: I am going to change calltips.py and CallTips to calltip.py and Calltip in #33907, but will not change tooltip.py there as I would expect a merge conflict. Once the change is made elsewhere, change should be made to tooltip and test_tooltip directly. -

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
New submission from Terry J. Reedy : Rename module 'calltips' as 'calltip' 1. 'calltips' and 'windows' are the only two plural module names. 2. 'calltip' fits better with 'calltip_w' (which may, however, be merged in 'calltip'. Module rename can be checked as with 'window', #33906. and class C

[issue33904] IDLE: In rstrip, rename class RstripExtension as Rstrip

2018-06-19 Thread Terry J. Reedy
Change by Terry J. Reedy : -- title: IDLE: In rstrip, change class RstripExtension to Rstrip -> IDLE: In rstrip, rename class RstripExtension as Rstrip ___ Python tracker ___

[issue33906] IDLE: rename windows.py as window.py

2018-06-19 Thread Terry J. Reedy
Change by Terry J. Reedy : -- title: IDLE: change windows.py to window.py -> IDLE: rename windows.py as window.py ___ Python tracker ___ __

[issue33906] IDLE: change windows.py to window.py

2018-06-19 Thread Terry J. Reedy
New submission from Terry J. Reedy : Change module 'windows' to 'window':: 1. 'calltips' and 'windows' are the only two plural module names. 2. The top menu entry was changed from 'Windows' to 'Window' some time ago. 3. 'windows' is also a OS. With all modules at least imported in a test, all i

[issue30811] A venv created and activated from within a virtualenv uses the outer virtualenv's site-packages rather than its own.

2018-06-19 Thread Josh Holland
Change by Josh Holland : -- nosy: +anowlcalledjosh ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33905] IDLE: stackbrowser.Stackbrowser should accept exception.

2018-06-19 Thread Terry J. Reedy
New submission from Terry J. Reedy : Stackbrowser is currently initialized with a traceback and/or the sys.last_xyz attributes. The latter are not set when unittesting; the test framework somehow prevents this. The tests needed are the ones that will be enabled by Stackbrower accepting an

[issue33904] IDLE: In rstrip, change class RstripExtension to Rstrip

2018-06-19 Thread Terry J. Reedy
New submission from Terry J. Reedy : Rstrip is no longer an extension. Change all occurrences throughout idlelib, including tests. Some may not be covered in tests. Branch after #33855 is merged. -- assignee: terry.reedy components: IDLE messages: 320001 nosy: terry.reedy priority:

[issue33901] test_dbm_gnu.test_reorganize() failed on x86-64 High Sierra 3.x

2018-06-19 Thread STINNER Victor
STINNER Victor added the comment: Thanks Serhiy and Xiang for the reviews and to help to debug this bug. -- ___ Python tracker ___

[issue33901] test_dbm_gnu.test_reorganize() failed on x86-64 High Sierra 3.x

2018-06-19 Thread STINNER Victor
STINNER Victor added the comment: Ok, the test have been fixed in 3.6, 3.7 and master. I added a private version number in master. If someone wants to add a public version number, please go ahead but open a new issue. -- resolution: -> fixed stage: patch review -> resolved status:

[issue33901] test_dbm_gnu.test_reorganize() failed on x86-64 High Sierra 3.x

2018-06-19 Thread STINNER Victor
STINNER Victor added the comment: New changeset 00f9edb98dd64e14daf5c44f303deca5cbc3cdeb by Victor Stinner in branch 'master': bpo-33901: Add _gdbm._GDBM_VERSION (GH-7794) https://github.com/python/cpython/commit/00f9edb98dd64e14daf5c44f303deca5cbc3cdeb -- _

[issue33855] IDLE: Minimally test every non-startup module.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: Change windows.py to window.py, in line with change of menu. Should be safer with everything imported. -- stage: patch review -> test needed ___ Python tracker ___

[issue33902] entry_points/console_scripts is too slow

2018-06-19 Thread George King
George King added the comment: OK, thanks. I agree that this is best pursued with the developers of the relevant modules. I appreciate your quick and detailed responses! -- ___ Python tracker __

[issue33902] entry_points/console_scripts is too slow

2018-06-19 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: "It's complicated" :) But technically speaking they are all separate projects, so while there is synergy, CPython itself *imports* some of those to provide various tasks, but it doesn't lead their development. You'll find a lot of the same players in all

[issue33902] entry_points/console_scripts is too slow

2018-06-19 Thread George King
George King added the comment: Thanks Barry. My question then is, what relationship does cpython have with pip, setuptools, distutils and pkg_resources? Since pip comes bundled with Python now it seems a little bit closer than "3rd party". Thanks! --

[issue17237] m68k aligns on 16bit boundaries.

2018-06-19 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: -7408 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue31680] Expose curses library name and version on Python level

2018-06-19 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +7410 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue27777] cgi.FieldStorage can't parse simple body with Content-Length and no Content-Disposition

2018-06-19 Thread Chris Eykamp
Chris Eykamp added the comment: Packaged patch offered below into PR 7804 https://github.com/python/cpython/pull/7804 -- versions: +Python 3.5 ___ Python tracker ___

[issue33301] Add __contains__ to pathlib

2018-06-19 Thread Antoine Pitrou
Antoine Pitrou added the comment: Not a good idea IMHO. Why would containment mean the existence of a file in a directory? It could just as well mean that a certain path component is part of the path. Also I don't understand what would e.g. `Path('/usr/bar') in Path('/etc/foo')` mean. As

[issue27777] cgi.FieldStorage can't parse simple body with Content-Length and no Content-Disposition

2018-06-19 Thread Chris Eykamp
Change by Chris Eykamp : -- pull_requests: +7409 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue17237] m68k aligns on 16bit boundaries.

2018-06-19 Thread INADA Naoki
Change by INADA Naoki : -- pull_requests: +7408 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue33717] Enhance test.pythoninfo: meta-ticket for multiple changes

2018-06-19 Thread Xiang Zhang
Xiang Zhang added the comment: New changeset 6aa283a6036f80e5820db2beae98c62745fae96f by Xiang Zhang (Miss Islington (bot)) in branch '3.6': bpo-33717: set terse to True when calling platform.platform in test.pythoninfo (GH-7797) (GH-7802) https://github.com/python/cpython/commit/6aa283a6036

[issue33717] Enhance test.pythoninfo: meta-ticket for multiple changes

2018-06-19 Thread Xiang Zhang
Xiang Zhang added the comment: New changeset b2dd5f1b667b37b5d36b39adc3a3aa6ebf59ef0b by Xiang Zhang (Miss Islington (bot)) in branch '2.7': bpo-33717: set terse to True when calling platform.platform in test.pythoninfo (GH-7797) (GH-7803) https://github.com/python/cpython/commit/b2dd5f1b667

[issue33901] test_dbm_gnu.test_reorganize() failed on x86-64 High Sierra 3.x

2018-06-19 Thread Barry A. Warsaw
Change by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue33902] entry_points/console_scripts is too slow

2018-06-19 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: This really isn't enough information to know exactly what's going on in your case, but there are things that are known to be slow for CLI startups. Probably the biggest contributor is pkg_resources. Of course, that's a third party library that's popular f

[issue33717] Enhance test.pythoninfo: meta-ticket for multiple changes

2018-06-19 Thread miss-islington
Change by miss-islington : -- pull_requests: +7407 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33717] Enhance test.pythoninfo: meta-ticket for multiple changes

2018-06-19 Thread miss-islington
Change by miss-islington : -- pull_requests: +7406 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33901] test_dbm_gnu.test_reorganize() failed on x86-64 High Sierra 3.x

2018-06-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The buildbot is green again! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue33901] test_dbm_gnu.test_reorganize() failed on x86-64 High Sierra 3.x

2018-06-19 Thread miss-islington
miss-islington added the comment: New changeset fe8122d7b7c747fc344dde8467b09de6b5888d01 by Miss Islington (bot) in branch '3.6': bpo-33901: Fix test_dbm_gnu for gdbm 1.15 (GH-7798) https://github.com/python/cpython/commit/fe8122d7b7c747fc344dde8467b09de6b5888d01 -- nosy: +miss-isli

[issue33895] LoadLibraryExW called with GIL held can cause deadlock

2018-06-19 Thread Eryk Sun
Eryk Sun added the comment: In some of these cases, it would be simpler to just remove the explicit dynamic linking. 3.6+ doesn't support XP, so CancelIoEx, CreateSymbolicLinkW, RegDeleteKeyExW, RegDisableReflectionKey, RegEnableReflectionKey, and RegQueryReflectionKey can be linked implicit

[issue30345] test_gdb fails on Python 3.6 when built with LTO+PGO

2018-06-19 Thread STINNER Victor
STINNER Victor added the comment: Ok, I pushed a change to the master branch. Now the question is if Python 2.7, 3.6 and 3.7 should be fixed as well? I will wait at least one day to see if buildbots are happy. -- ___ Python tracker

[issue30345] test_gdb fails on Python 3.6 when built with LTO+PGO

2018-06-19 Thread STINNER Victor
STINNER Victor added the comment: New changeset 06fe77a84bd29d51506ab2ff703ae585a6121af2 by Victor Stinner in branch 'master': bpo-30345: Add -g to LDFLAGS for LTO (GH-7709) https://github.com/python/cpython/commit/06fe77a84bd29d51506ab2ff703ae585a6121af2 -- ___

[issue33717] Enhance test.pythoninfo: meta-ticket for multiple changes

2018-06-19 Thread Xiang Zhang
Change by Xiang Zhang : -- pull_requests: +7405 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue33901] test_dbm_gnu.test_reorganize() failed on x86-64 High Sierra 3.x

2018-06-19 Thread miss-islington
Change by miss-islington : -- pull_requests: +7404 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33901] test_dbm_gnu.test_reorganize() failed on x86-64 High Sierra 3.x

2018-06-19 Thread STINNER Victor
STINNER Victor added the comment: New changeset 13c79c677f9ec9437c82eda72fa1c2d288d8fceb by Victor Stinner in branch '3.7': bpo-33901: Fix test_dbm_gnu for gdbm 1.15 (GH-7798) https://github.com/python/cpython/commit/13c79c677f9ec9437c82eda72fa1c2d288d8fceb -- _

[issue33671] Efficient zero-copy for shutil.copy* functions (Linux, OSX and Win)

2018-06-19 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +7403 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33746] testRegisterResult in test_unittest fails in verbose mode

2018-06-19 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +7402 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33901] test_dbm_gnu.test_reorganize() failed on x86-64 High Sierra 3.x

2018-06-19 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +7401 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33901] test_dbm_gnu.test_reorganize() failed on x86-64 High Sierra 3.x

2018-06-19 Thread STINNER Victor
STINNER Victor added the comment: New changeset c44d8e5db6fb9d3847c49e9c9718f2b4cf71f506 by Victor Stinner in branch 'master': bpo-33901: Better test_dbm_gnu.test_reorganize() fix (GH-7795) https://github.com/python/cpython/commit/c44d8e5db6fb9d3847c49e9c9718f2b4cf71f506 -- ___

[issue33895] LoadLibraryExW called with GIL held can cause deadlock

2018-06-19 Thread Tony Roberts
Tony Roberts added the comment: Sure, that's reasonable :) For my case I have a usable workaround so not back porting it to < 3.8 is fine for me. My workaround will just leak the thread state if another thread is in __import__, which happens so rarely that it's not really a problem (but not

[issue33671] Efficient zero-copy for shutil.copy* functions (Linux, OSX and Win)

2018-06-19 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: New changeset c7f02a965936f197354d7f4e6360f4cfc86817ed by Giampaolo Rodola in branch 'master': bpo-33671 / shutil.copyfile: use memoryview() with dynamic size on Windows (#7681) https://github.com/python/cpython/commit/c7f02a965936f197354d7f4e6360f4cfc868

[issue30345] test_gdb fails on Python 3.6 when built with LTO+PGO

2018-06-19 Thread STINNER Victor
STINNER Victor added the comment: Very interesting article about PGO and LTO changes in GCC: https://hubicka.blogspot.com/2018/06/gcc-8-link-time-and-interprocedural.html See "Early debug info" paragraph. -- ___ Python tracker

[issue33865] [EASY] Missing code page aliases: "unknown encoding: 874"

2018-06-19 Thread STINNER Victor
STINNER Victor added the comment: Prawin Phichitnitikorn: "But for me I'm resolve by adding (...)" Ok, so can you please give the value of: * sys.stdin.encoding * sys.stdout.encoding * sys.stderr.encoding * os.device_encoding(0) * os.device_encoding(1) * os.device_encoding(2) * locale.getpref

[issue33895] LoadLibraryExW called with GIL held can cause deadlock

2018-06-19 Thread Steve Dower
Steve Dower added the comment: Yeah, just after posting I remembered that the blocker is the loader lock and not filesystem/arbitrary code. Still, "I don't think" isn't sufficient to justify making the change in 3.7 or earlier. If we can show that properly working code could never have assu

[issue33902] entry_points/console_scripts is too slow

2018-06-19 Thread Eric N. Vander Weele
Change by Eric N. Vander Weele : -- nosy: +ericvw ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue33865] [EASY] Missing code page aliases: "unknown encoding: 874"

2018-06-19 Thread Ronald Oussoren
Ronald Oussoren added the comment: @Serhiy: The screenshot suggests that this is regular python install. -- ___ Python tracker ___

[issue33895] LoadLibraryExW called with GIL held can cause deadlock

2018-06-19 Thread Tony Roberts
Tony Roberts added the comment: GetProcAddress and GetModuleHandle do block in the same way as LoadLibrary and FreeLibrary - they acquire the loader lock too. Yes, ideally the application would terminate its threads cleanly, however when Python is embedded in another application it may not h

[issue33903] Can't use lib2to3 with embeddable zip file

2018-06-19 Thread Mickaël S .
New submission from Mickaël S. : As stated by https://bugs.python.org/issue24960, the bug should be fixed in 3.6.5 (if it is the same, not sure). Simple reproduction steps are: 1) Download and unzip python-3.6.5-embed-win32.zip. 2) Install pip (OK): C:\Users\TestW764\python-3.6.5-embed-win32>

[issue33663] Web.py wsgiserver3.py raises TypeError when CSS file is not found

2018-06-19 Thread Steve Dower
Steve Dower added the comment: Congratulations on your first contribution, Valeriya! Let us know when you find something else you'd like to work on (you can add my name to the "Nosy List" on the bug and it'll get my attention). -- resolution: -> fixed stage: patch review -> resolved

[issue33895] LoadLibraryExW called with GIL held can cause deadlock

2018-06-19 Thread Steve Dower
Steve Dower added the comment: What about existing code that assumes the GIL is already held? Also, your patch addresses many more situations than raised here, most of which are unnecessary (GetProcAddress and GetModuleHandle don't block in the way that LoadLibrary and FreeLibrary may). Per

[issue33902] entry_points/console_scripts is too slow

2018-06-19 Thread George King
New submission from George King : On my newish macOS laptop using Python 3.6 or 3.7, a no-op script takes 3 times as long to invoke using the entry_points machinery as it does to invoke directly. Here are some exemplary times (best times after several tries). $ time python3.6 entrypoint.py

[issue33901] test_dbm_gnu.test_reorganize() failed on x86-64 High Sierra 3.x

2018-06-19 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +7400 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33365] http/client.py does not print correct headers in debug

2018-06-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for your contribution Marco! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker _

[issue33896] Document what components make up the filecmp.cmp os.stat signature.

2018-06-19 Thread R. David Murray
R. David Murray added the comment: I think it might be OK to document what goes in to the signature, but probably in a footnote, as it is somewhat of an implementation detail and could conceivably change. We could then also add a caution about mtime imprecision being a particular risk on so

[issue33896] Document what components make up the filecmp.cmp os.stat signature.

2018-06-19 Thread R. David Murray
Change by R. David Murray : -- versions: +Python 2.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue33365] http/client.py does not print correct headers in debug

2018-06-19 Thread miss-islington
miss-islington added the comment: New changeset 34cd4821ed97639896f85bdf0c0d5c75b23f8a76 by Miss Islington (bot) in branch '3.6': bpo-33365: print the header values beside the keys (GH-6611) https://github.com/python/cpython/commit/34cd4821ed97639896f85bdf0c0d5c75b23f8a76 -- __

[issue33365] http/client.py does not print correct headers in debug

2018-06-19 Thread miss-islington
miss-islington added the comment: New changeset 2edcf0a3db608457f42f4e4b74aff28237b4c91b by Miss Islington (bot) in branch '3.7': bpo-33365: print the header values beside the keys (GH-6611) https://github.com/python/cpython/commit/2edcf0a3db608457f42f4e4b74aff28237b4c91b -- nosy: +

[issue33901] test_dbm_gnu.test_reorganize() failed on x86-64 High Sierra 3.x

2018-06-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: How can we test an API if calling it doesn't have any effect? reorganize() can be a no-op method, and still pass the test. -- ___ Python tracker _

[issue6280] calendar.timegm() belongs in time module, next to time.gmtime()

2018-06-19 Thread oric
oric added the comment: Please don't name it timegm which is such a stupid name (why not mgemit!). I knows it comes from history but history had timelocal which has been replaced by mktime (and python has mktime and not timelocal) so please, call it mkgmtime time.mkgmtime() I think it would

[issue33901] test_dbm_gnu.test_reorganize() failed on x86-64 High Sierra 3.x

2018-06-19 Thread STINNER Victor
STINNER Victor added the comment: Xiang: "Considering adding gdbm version to pythoninfo? It is possible to expose version info from gnu dbm." I wrote PR 7794. What do you think of this? -- ___ Python tracker _

[issue33365] http/client.py does not print correct headers in debug

2018-06-19 Thread miss-islington
Change by miss-islington : -- pull_requests: +7397 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33365] http/client.py does not print correct headers in debug

2018-06-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 936f03e7fafc28fd6fdfba11d162c776b89c0167 by Serhiy Storchaka (Marco Strigl) in branch 'master': bpo-33365: print the header values beside the keys (GH-6611) https://github.com/python/cpython/commit/936f03e7fafc28fd6fdfba11d162c776b89c0167 --

[issue33901] test_dbm_gnu.test_reorganize() failed on x86-64 High Sierra 3.x

2018-06-19 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +7399 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33901] test_dbm_gnu.test_reorganize() failed on x86-64 High Sierra 3.x

2018-06-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Did not increasing the size of the value fixed the test? -- ___ Python tracker ___ ___ Python-b

  1   2   >