[issue34901] Missing isolated (-I) flag in sys.flags table

2018-10-04 Thread Karthikeyan Singaravelan
New submission from Karthikeyan Singaravelan : Thanks for the PR @danishprakash . `-I` was added as part of 3.4 with commit ad73a9cf977 and not backported to 2.7 . Also 3.4 and 3.5 branches are in security fixes mode. So I am removing 2.7, 3.4 and 3.5 . -- nosy: +xtreak versions:

[issue34902] Azure pipelines PR build fails with "Unexpected vmImage 'vs2017-win2017'"

2018-10-04 Thread Karthikeyan Singaravelan
New submission from Karthikeyan Singaravelan : Azure pipelines PR seems to fail with the error "Unexpected vmImage 'vs2017-win2017'" . First build failure with this message : https://dev.azure.com/Python/cpython/_build/results?buildId=31800=results Last successful build :

[issue18291] codecs.open interprets FS, RS, GS as line ends

2018-10-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There is an open issue for changing str.splitlines(): issue22232. It would help to fix this issue. The only problem is that we don't have agreement about the new parameter name (and changing the behavior unconditionally is not an option). --

[issue18291] codecs.open interprets FS, RS, GS as line ends

2018-10-04 Thread Neil Schemenauer
Neil Schemenauer added the comment: New patch that changes str.splitlines to work like Python 2 str.splitlines and like Python 3 bytes.splitlines. Surprisingly, only a few cases in the unit test suite fail. I've fixed them in my patch. -- Added file:

[issue34812] [EASY] support.args_from_interpreter_flags() doesn't inherit -I (isolated) flag

2018-10-04 Thread Danish Prakash
Danish Prakash added the comment: Linking this[1] here in case someone else stumbles upon this thread. I've created an issue and a PR for the documentation issue regarding the absence of -I flag from the sys.flags table which came into picture from the discussions in this thread. [1]:

[issue34901] Missing isolated (-I) flag in sys.flags table

2018-10-04 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch pull_requests: +9093 stage: -> patch review ___ Python tracker ___ ___

[issue34901] Missing isolated (-I) flag in sys.flags table

2018-10-04 Thread Danish Prakash
Change by Danish Prakash : -- assignee: docs@python components: Documentation nosy: danishprakash, docs@python priority: normal severity: normal status: open title: Missing isolated (-I) flag in sys.flags table versions: Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7,

[issue23706] pathlib.Path.write_text should include a newline argument

2018-10-04 Thread Thrlwiti
Change by Thrlwiti : -- nosy: +THRlWiTi ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18291] codecs.open interprets FS, RS, GS as line ends

2018-10-04 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18291] codecs.open interprets FS, RS, GS as line ends

2018-10-04 Thread Neil Schemenauer
Neil Schemenauer added the comment: Some further progress on this. My patch slows down reading files with the codecs module very significantly. So, I think it could never be merged as is. Maybe we would need to implement an alternative str.splitlines that behaves as we want, implemented

[issue34900] unittest subTests() fails when called from debug()

2018-10-04 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29143] Logger should ignore propagate property for disabled handlers.

2018-10-04 Thread Oleg Serov
Oleg Serov added the comment: I tried and failed to reproduce. If it changes, I'll update it. -- ___ Python tracker ___ ___

[issue18291] codecs.open interprets FS, RS, GS as line ends

2018-10-04 Thread Neil Schemenauer
Neil Schemenauer added the comment: Attached is a rough patch that tries to fix this problem. I changed the behavior in that unicode char 0x2028 is no longer treated as a line separator. It would be trival to change the regex to support that too, if we want to preserve backwards

[issue34900] unittest subTests() fails when called from debug()

2018-10-04 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch pull_requests: +9092 stage: -> patch review ___ Python tracker ___ ___

[issue34897] distutils test errors when CXX is not set

2018-10-04 Thread Michael Felt
Change by Michael Felt : -- keywords: +patch pull_requests: +9091 stage: -> patch review ___ Python tracker ___ ___

[issue18291] codecs.open interprets FS, RS, GS as line ends

2018-10-04 Thread Neil Schemenauer
Neil Schemenauer added the comment: I think one bug here is that codecs readers use str.splitlines() internally. The splitlines method treats a bunch of different characters as line separators, unlike io..readlines(). So, you end up with different behavior between doing

[issue30825] csv.Sniffer does not detect lineterminator

2018-10-04 Thread Neil Schemenauer
Neil Schemenauer added the comment: There is another issue related to this. If you use codecs to get a reader, it uses str.splitlines() internally, which treats a bunch of different characters as line terminators. See issue #18291 and:

[issue34867] Add mode to disable small integer and interned string caches

2018-10-04 Thread Gregory P. Smith
Gregory P. Smith added the comment: The intent is to use only enable this during testing / continuous integration. -- ___ Python tracker ___

[issue34900] unittest subTests() fails when called from debug()

2018-10-04 Thread Bruno Oliveira
Change by Bruno Oliveira : -- type: -> crash ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34900] unittest subTests() fails when called from debug()

2018-10-04 Thread Bruno Oliveira
New submission from Bruno Oliveira : Consider this code: import unittest class TC(unittest.TestCase): def test_subtest(self): with self.subTest(): pass tc = TC('test_subtest') tc.run() This works when executed, but if we change

[issue34899] Possible assertion failure due to int_from_bytes_impl()

2018-10-04 Thread Zackery Spytz
Change by Zackery Spytz : -- keywords: +patch pull_requests: +9090 stage: -> patch review ___ Python tracker ___ ___

[issue34899] Possible assertion failure due to int_from_bytes_impl()

2018-10-04 Thread Zackery Spytz
New submission from Zackery Spytz : If _PyLong_FromByteArray() fails in int_from_bytes_impl(), PyObject_CallFunctionObjArgs() might be called with a live exception. -- components: Interpreter Core messages: 327091 nosy: ZackerySpytz priority: normal severity: normal status: open

[issue21880] IDLE: Ability to run 3rd party code checkers

2018-10-04 Thread Tal Einat
Tal Einat added the comment: It's unfortunate that this has gone dormant for so long. Is anyone interested in picking this up? I'd be happy to provide guidance and feedback. -- nosy: +taleinat ___ Python tracker

[issue34898] add mtime argument to gzip.compress

2018-10-04 Thread Guo Ci Teo
Change by Guo Ci Teo : -- keywords: +patch pull_requests: +9089 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue34898] add mtime argument to gzip.compress

2018-10-04 Thread Guo Ci Teo
New submission from Guo Ci Teo : With the `mtime` argument, the output from `gzip.compress` can be reproducible. -- components: Library (Lib) messages: 327088 nosy: guoci priority: normal severity: normal status: open title: add mtime argument to gzip.compress versions: Python 3.6,

[issue26005] Denial of Service in SimpleHTTPServer and BaseHTTPServer

2018-10-04 Thread Martin Panter
Martin Panter added the comment: Issue 34576 was recently opened about adding a security warning. -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> [EASY doc] http.server, SimpleHTTPServer: warn users on security

[issue34576] [EASY doc] http.server, SimpleHTTPServer: warn users on security

2018-10-04 Thread Martin Panter
Martin Panter added the comment: FYI Senthil made an earlier suggestion for wording at -- nosy: +martin.panter ___ Python tracker

[issue34041] add *deterministic* parameter to sqlite3.Connection.create_function()

2018-10-04 Thread rian
rian added the comment: Any possible way we can backport these changes to Python 3.5+? 3.8 is a ways away. -- nosy: +rian ___ Python tracker ___

[issue34801] codecs.getreader() splits lines containing control characters

2018-10-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This is a duplicate of issue18291. -- nosy: +serhiy.storchaka resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> codecs.open interprets FS, RS, GS as line ends ___ Python tracker

[issue34801] codecs.getreader() splits lines containing control characters

2018-10-04 Thread Neil Schemenauer
Neil Schemenauer added the comment: Perhaps the 'csv' module should do some sanity checking on the file passed to the reader. The docs recommend that newline='' be used to open the file. Maybe 'csv' could check that and warn if its not the case. I poked around but it seems like io files

[issue34897] distutils test errors when CXX is not set

2018-10-04 Thread Michael Felt
New submission from Michael Felt : while researching issue11191 I cam across 6 additional errors. There is a test in Lib/test/support/__init__.py def missing_compiler_executable(cmd_names=[]): """Check if the compiler components used to build the interpreter exist. Check for the

[issue34801] codecs.getreader() splits lines containing control characters

2018-10-04 Thread Neil Schemenauer
Neil Schemenauer added the comment: Thank you for the research. The problem is indeed that \v is getting treated as a line separator. That is an intentional design choice, see: https://bugs.python.org/issue12855 It would seem to have some surprising implications for CSV parsing. E.g. if

[issue34725] Py_GetProgramFullPath() odd behaviour in Windows

2018-10-04 Thread Steve Dower
Steve Dower added the comment: Reading the docs, I'm pretty sure we need a new Py_SetProgramFullPath() function. Py_SetProgramName explicitly is only providing a hint to figure out the file containing the executable, and I really want this to make my new launcher feasible:

[issue34850] Emit a syntax warning for "is" with a literal

2018-10-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > Turn the check on only when PYTHONDEVMODE is set? This will reduce the value of this warning to zero. If the user doesn't know that using "is" with string or numerical literals is bad and doesn't use checkers, it is unlikely that he uses PYTHONDEVMODE.

[issue34893] Add 2to3 fixer to change send and recv methods of socket object.

2018-10-04 Thread Pranav Devarakonda
Pranav Devarakonda added the comment: Thanks Karthikeyan -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34751] Hash collisions for tuples

2018-10-04 Thread Tim Peters
Tim Peters added the comment: >> people already wrote substantial test suites dedicated >> to that sole purpose, and we should aim to be "mere >> consumers" of functions that pass _those_ tests. > There are hash functions that pass those tests which > are still bad in practice when used as

[issue34844] logging.Formatter enhancement - Checking on style and fmt fields

2018-10-04 Thread Luna Chen
Change by Luna Chen : -- keywords: +patch pull_requests: +9088 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue34871] test_site fails if run after test_inspect

2018-10-04 Thread Yury Selivanov
Yury Selivanov added the comment: Thank you Inada-san for taking care of this. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue34871] test_site fails if run after test_inspect

2018-10-04 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset 476c294f260ebe1b44157a168c3dfa4a43724ce3 by Yury Selivanov (Miss Islington (bot)) in branch '3.7': bpo-34871: inspect: Don't pollute sys.modules (GH-9696) (#9701) https://github.com/python/cpython/commit/476c294f260ebe1b44157a168c3dfa4a43724ce3

[issue34871] test_site fails if run after test_inspect

2018-10-04 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset 70a083bc46aea84e3b3ffca2c10c295917a98fec by Yury Selivanov (Miss Islington (bot)) in branch '3.6': bpo-34871: inspect: Don't pollute sys.modules (GH-9696) (GH-9702)

[issue34850] Emit a syntax warning for "is" with a literal

2018-10-04 Thread Neil Schemenauer
Neil Schemenauer added the comment: > The problem with a SyntaxWarning is that the wrong people will see it. It > gets in the way of users of applications that happen to be written in Python. Turn the check on only when PYTHONDEVMODE is set? Seems like it solves the issue with the wrong

[issue34867] Add mode to disable small integer and interned string caches

2018-10-04 Thread Neil Schemenauer
Neil Schemenauer added the comment: Woudn't turning these off hurt performance a lot? If so, I don't know if people would actually use such a mode. Then it becomes pretty useless. Could we combine this idea with the PYTHONDEVMODE flag? If PYTHONDEVMODE is turned on, we could do a check

[issue34893] Add 2to3 fixer to change send and recv methods of socket object.

2018-10-04 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Ah, sorry I totally forgot about dict fixer. Thanks for the details. I would wait for Benjamin's call on this. Thanks -- ___ Python tracker

[issue34801] codecs.getreader() splits lines containing control characters

2018-10-04 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: codecs.getreader('utf-8')(open('test.txt', 'rb')) during iteration str.splitlines on the decoded data that takes '\x0b' as a valid newline as specified in [0] being a superset of universal newlines. Thus splits on '\x0b' as a valid newline for

[issue34893] Add 2to3 fixer to change send and recv methods of socket object.

2018-10-04 Thread Pranav Devarakonda
Pranav Devarakonda added the comment: Thanks for taking time and updating this, Karthikeyan Singaravelan. I do agree that there there is no proper way to find out if an object is of type socket or not. However other fixers in lib2to3 are not any different. For example the fix_dict.py

[issue34896] Unable to install Python 3.5

2018-10-04 Thread Zachary Ware
Zachary Ware added the comment: According to the name of your log file, you're trying to install an old pre-release version (3.5.0rc3). Try the latest version instead (https://www.python.org/ftp/python/3.5.4/python-3.5.4-amd64-webinstall.exe). Since 3.5 is in security-fix-only mode and

[issue34576] [EASY doc] http.server, SimpleHTTPServer: warn users on security

2018-10-04 Thread Prashant Sharma
Prashant Sharma added the comment: Should this change be done? If so, I would want to take up this issue. -- nosy: +gutsytechster ___ Python tracker ___

[issue34751] Hash collisions for tuples

2018-10-04 Thread Tim Peters
Change by Tim Peters : -- components: +Interpreter Core -XML ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34896] Unable to install Python 3.5

2018-10-04 Thread Ruchir Jha
New submission from Ruchir Jha : Hi, I was trying to install Danjo to work on Python. However it was not working fine hence I uninstalled the version 3.5 which I installed and tried to install it again as the earlier version was used for Anaconda. However even after multiple attempts to

[issue34871] test_site fails if run after test_inspect

2018-10-04 Thread miss-islington
Change by miss-islington : -- pull_requests: +9087 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34871] test_site fails if run after test_inspect

2018-10-04 Thread miss-islington
Change by miss-islington : -- pull_requests: +9086 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34871] test_site fails if run after test_inspect

2018-10-04 Thread miss-islington
miss-islington added the comment: New changeset 6f85b826b527e240551613aeec3118a5469e3a33 by Miss Islington (bot) (INADA Naoki) in branch 'master': bpo-34871: inspect: Don't pollute sys.modules (GH-9696) https://github.com/python/cpython/commit/6f85b826b527e240551613aeec3118a5469e3a33

[issue34895] Mark optional stdlib modules in documentation

2018-10-04 Thread Marcus
New submission from Marcus : Some stdlib modules have external build time dependencies and will be automatically disabled if the dependencies can't be met (cf. detect_modules() in setup.py). >From a user's perspective there is no reason to assume that the presence of a >stdlib module may not

[issue34893] Add 2to3 fixer to change send and recv methods of socket object.

2018-10-04 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks for the report. In my opinion it's difficult to handle this scenario and as far as I know 2to3 can only do syntax level changes with modular fixers for each case. Since Python is dynamic and there is no static type system available it's

[issue34751] Hash collisions for tuples

2018-10-04 Thread Tim Peters
Tim Peters added the comment: >> In the 64-bit build there are no collisions across my >> tests except for 11 in the new tuple test. > That's pretty bad actually. With 64 bits, you statistically > expect something in the order of 10**-8 collisions. So > what you're seeing is 9 orders of

[issue34776] Postponed annotations break inspection of dataclasses

2018-10-04 Thread Yury Selivanov
Yury Selivanov added the comment: > Please note that postponed annotations only reveal a problem that we already > had if anybody used a string forward reference: Yeah, makes sense. It's cool that the PR fixes string forward references as well. --

[issue34751] Hash collisions for tuples

2018-10-04 Thread Tim Peters
Tim Peters added the comment: > Note that I'm always considering parametrized > versions of the hash functions that I'm testing. > I'm replacing the fixed multiplier (all algorithms > mentioned here have such a thing) by a random > multiplier which is 3 mod 8. I've explained before in some

[issue34894] Unexpected error while unpickling lxml.etree.Element object

2018-10-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This is a tracker for bugs in the C implementation of Python. lxml is not a part of the Python standard library. Use corresponded bug trackers for reporting bugs in third-party packages. -- nosy: +serhiy.storchaka resolution: -> third party

[issue34776] Postponed annotations break inspection of dataclasses

2018-10-04 Thread Łukasz Langa
Łukasz Langa added the comment: Yury, thanks for your patch. I'll review it soon. Please note that postponed annotations only reveal a problem that we already had if anybody used a string forward reference: >>> from dataclasses import dataclass >>> from typing import get_type_hints >>> class

[issue34878] Lock Objects documentation bug

2018-10-04 Thread ulrich.stern
ulrich.stern added the comment: I still think the documentation should be changed, and an improved version would look more like your comment than what it looks now. I assume to most people "owning" means exclusively holding the lock, and a particular thread can do this for Lock Objects.

[issue34890] Support functools.partial in inspect.is*function() checks

2018-10-04 Thread Yury Selivanov
Yury Selivanov added the comment: Feel free to work on the PR. If we want to push this to 3.8 we should do that now and have enough time for it to be tested. -- ___ Python tracker

[issue34890] Support functools.partial in inspect.is*function() checks

2018-10-04 Thread Yury Selivanov
Yury Selivanov added the comment: I think the fact that `inspect.isfunction` recognizes partials is a very strong argument to enable inspect.iscoroutinefunction to do so as well. This is a backwards incompatible change though, strictly speaking. --

[issue34751] Hash collisions for tuples

2018-10-04 Thread Jeroen Demeyer
Jeroen Demeyer added the comment: > Taking an algorithm in wide use that's already known to get a top score on > SMHasher and fiddling it to make a "slight" improvement in one tiny Python > test doesn't make sense to me. OK, I won't do that. The difference is not that much anyway (it

[issue34894] Unexpected error while unpickling lxml.etree.Element object

2018-10-04 Thread Marcin Raczyński
New submission from Marcin Raczyński : If we use pickle.HIGHEST_PROTOCOL we can pickle lxml.etree.Element object but unpickling give us misleading error description: >>> from lxml import etree >>> import pickle >>> import sys sys.version '2.7.15rc1 (default, Apr 15 2018, 21:51:34) \n[GCC

[issue6686] xml.sax.xmlreader.XMLReader.getProperty (xml.sax.handler.property_xml_string) returns bytes

2018-10-04 Thread Zachary Ware
Change by Zachary Ware : -- nosy: +christian.heimes ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34893] Add 2to3 fixer to change send and recv methods of socket object.

2018-10-04 Thread Pranav Devarakonda
New submission from Pranav Devarakonda : The send() method of the the Socket object in Python 3.x requires the data to be sent to be first converted into bytes(object) which was not the case with Python 2.x. The 2to3 tool doesn't handle this case and hence an explicit fixer would help many

[issue34892] persistence of attributes with new instance

2018-10-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This is how default values work in Python. See the FAQ question: https://docs.python.org/3/faq/programming.html#why-are-default-values-shared-between-objects -- nosy: +serhiy.storchaka resolution: -> not a bug stage: -> resolved status: open ->

[issue34892] persistence of attributes with new instance

2018-10-04 Thread Florian Michaux
New submission from Florian Michaux : Hello, I don't know what's going on. When using a for loop over multiple same instance creation, i got persistence with instance attributes Code example in attachement. -- components: Interpreter Core files: buggyclass.py messages: 327051 nosy:

[issue27165] Skip callables when displaying exception fields in cgitb

2018-10-04 Thread Adam Bielański
Change by Adam Bielański : -- pull_requests: +9085 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34871] test_site fails if run after test_inspect

2018-10-04 Thread miss-islington
miss-islington added the comment: New changeset c57eb9a336391dc22aa29e9db592fa06d7fb7101 by Miss Islington (bot) (Chih-Hsuan Yen) in branch 'master': bpo-34871: Fix two typos in test_inspect.py (GH-9698) https://github.com/python/cpython/commit/c57eb9a336391dc22aa29e9db592fa06d7fb7101

[issue34871] test_site fails if run after test_inspect

2018-10-04 Thread Chih-Hsuan Yen
Change by Chih-Hsuan Yen : -- pull_requests: +9084 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34891] Multi-processing example inaccurate warning

2018-10-04 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks for the report. Are you referring to the below warning? > Functionality within this package requires that the __main__ module be > importable by the children. This is covered in Programming guidelines however > it is worth pointing out

[issue27165] Skip callables when displaying exception fields in cgitb

2018-10-04 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33331] Clean modules in the reversed order

2018-10-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: While this change fixes issue33328, it doesn't help with the similar issue13044 which is more complex. Still I think there is a value of wiping modules in such order. -- ___ Python tracker

[issue11191] test_search_cpp error on AIX (with xlc)

2018-10-04 Thread Michael Felt
Michael Felt added the comment: The current PR8709 resolves two issues, not one - so will create a new issue for the second element. Am also shorting the NEWS text, with the expanded explanation here as: * skip the distutils test 'test_search_cpp' when not gcc as compiler because not all

[issue34891] Multi-processing example inaccurate warning

2018-10-04 Thread Anthony Flury
New submission from Anthony Flury : On the Multi-processing page (just above the reference section) there is a warning that the examples wont work from the interpreter. This is not entirely accurate in that the examples do work, in

[issue34871] test_site fails if run after test_inspect

2018-10-04 Thread INADA Naoki
Change by INADA Naoki : -- keywords: +patch pull_requests: +9083 stage: -> patch review ___ Python tracker ___ ___

[issue34751] Hash collisions for tuples

2018-10-04 Thread Jeroen Demeyer
Jeroen Demeyer added the comment: > In the 64-bit build there are no collisions across my tests except for 11 in > the new tuple test. That's pretty bad actually. With 64 bits, you statistically expect something in the order of 10**-8 collisions. So what you're seeing is 9 orders of

[issue27165] Skip callables when displaying exception fields in cgitb

2018-10-04 Thread Roundup Robot
Change by Roundup Robot : -- pull_requests: +9082 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34751] Hash collisions for tuples

2018-10-04 Thread Jeroen Demeyer
Jeroen Demeyer added the comment: > Taking an algorithm in wide use that's already known to get a top score on > SMHasher and fiddling it to make a "slight" improvement in one tiny Python > test doesn't make sense to me. What I'm doing is the most innocent change: just applying a fixed

[issue34751] Hash collisions for tuples

2018-10-04 Thread Jeroen Demeyer
Jeroen Demeyer added the comment: > people already wrote substantial test suites dedicated to that sole purpose, > and we should aim to be "mere consumers" of functions that pass _those_ tests. There are hash functions that pass those tests which are still bad in practice when used as tuple

[issue34751] Hash collisions for tuples

2018-10-04 Thread Jeroen Demeyer
Jeroen Demeyer added the comment: > Note: I'm assuming that by "PRIME32_2" you mean 2246822519U Yes indeed. > and that "MULTIPLIER" means 2654435761U. No, I mean a randomly chosen multiplier which is 3 mod 8. -- ___ Python tracker

[issue34739] Get rid of tp_getattro in xml.etree.ElementTree.XMLParser

2018-10-04 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34740] Get rid of tp_getattro in ossaudiodev.oss_audio_device

2018-10-04 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34740] Get rid of tp_getattro in ossaudiodev.oss_audio_device

2018-10-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 5f5a7781c8bf7bcc476d3e05d980711be3920724 by Serhiy Storchaka in branch 'master': bpo-34740: Get rid of tp_getattro in ossaudiodev.oss_audio_device. (GH-9421) https://github.com/python/cpython/commit/5f5a7781c8bf7bcc476d3e05d980711be3920724

[issue34739] Get rid of tp_getattro in xml.etree.ElementTree.XMLParser

2018-10-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset b2953fa3dda5898fcb0029792d9229f150e6e2cb by Serhiy Storchaka in branch 'master': bpo-34739: Get rid of tp_getattro in xml.etree.ElementTree.XMLParser. (GH-9420) https://github.com/python/cpython/commit/b2953fa3dda5898fcb0029792d9229f150e6e2cb

[issue34890] Support functools.partial in inspect.is*function() checks

2018-10-04 Thread Andrew Svetlov
New submission from Andrew Svetlov : isfunction() processes both `isfunction(func)` and `isfunction(partial(func, arg))` correctly. But `iscoroutinefunction()` misses this functionality. We can implement it easy by adding a check for `isinstance(func, partial)` and applying a coroutine

[issue34883] test_lzma: Multiple test failures when liblzma is built without complete codec set

2018-10-04 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34751] Hash collisions for tuples

2018-10-04 Thread Jeroen Demeyer
Jeroen Demeyer added the comment: > I've posted several SeaHash cores that suffer no collisions at all in any of > our tests (including across every "bad example" in these 100+ messages), > except for "the new" tuple test. Which it also passed, most recently with 7 > collisions. That was