[issue35414] A reference counting bug in PyState_RemoveModule()

2018-12-04 Thread miss-islington
miss-islington added the comment: New changeset afb07fccf013f20b89b33516f126695388be47b9 by Miss Islington (bot) in branch '3.6': bpo-35414: Add a missing Py_INCREF(Py_None) in PyState_RemoveModule(). (GH-10914) https://github.com/python/cpython/commit/afb07fccf013f20b89b33516f126695388be47b

[issue35414] A reference counting bug in PyState_RemoveModule()

2018-12-04 Thread miss-islington
miss-islington added the comment: New changeset 2d594f857865a4719876ac545ddfd62f474522cd by Miss Islington (bot) in branch '3.7': bpo-35414: Add a missing Py_INCREF(Py_None) in PyState_RemoveModule(). (GH-10914) https://github.com/python/cpython/commit/2d594f857865a4719876ac545ddfd62f474522c

[issue35414] A reference counting bug in PyState_RemoveModule()

2018-12-04 Thread miss-islington
Change by miss-islington : -- pull_requests: +10155 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35414] A reference counting bug in PyState_RemoveModule()

2018-12-04 Thread miss-islington
Change by miss-islington : -- pull_requests: +10154 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35414] A reference counting bug in PyState_RemoveModule()

2018-12-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 2a893430c9c8378cbdfac95895a64fa07aaff9ed by Serhiy Storchaka (Zackery Spytz) in branch 'master': bpo-35414: Add a missing Py_INCREF(Py_None) in PyState_RemoveModule(). (GH-10914) https://github.com/python/cpython/commit/2a893430c9c8378cbdfac9

[issue35414] A reference counting bug in PyState_RemoveModule()

2018-12-04 Thread Zackery Spytz
Change by Zackery Spytz : -- keywords: +patch pull_requests: +10153 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-l

[issue35414] A reference counting bug in PyState_RemoveModule()

2018-12-04 Thread Zackery Spytz
New submission from Zackery Spytz : There's a missing Py_INCREF(Py_None) in PyState_RemoveModule(). -- components: Interpreter Core messages: 331091 nosy: ZackerySpytz priority: normal severity: normal status: open title: A reference counting bug in PyState_RemoveModule() versions: Pyth

[issue35398] SQLite incorrect row count for UPDATE

2018-12-04 Thread Montana Low
Montana Low added the comment: I took a stab at patch. It fixes the issue for me, as proven via the Test Case. -- ___ Python tracker ___ __

[issue35398] SQLite incorrect row count for UPDATE

2018-12-04 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch pull_requests: +10152 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-l

[issue35330] When using mock to wrap an existing object, side_effect requires return_value

2018-12-04 Thread Terry J. Reedy
Change by Terry J. Reedy : -- components: +Tests nosy: +cjw296 stage: -> test needed versions: +Python 3.7, Python 3.8 ___ Python tracker ___ _

[issue35363] test_eintr: test_open() hangs randomly on x86-64 El Capitan 3.x buildbot

2018-12-04 Thread STINNER Victor
STINNER Victor added the comment: New changeset 93d038c91dc3075dd34b41ce6b6fb4ea07fbb8c3 by Victor Stinner in branch '3.6': bpo-35363, test_eintr: skip test_open() on macOS (GH-10896) (GH-10912) https://github.com/python/cpython/commit/93d038c91dc3075dd34b41ce6b6fb4ea07fbb8c3 -- __

[issue35363] test_eintr: test_open() hangs randomly on x86-64 El Capitan 3.x buildbot

2018-12-04 Thread STINNER Victor
Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue35363] test_eintr: test_open() hangs randomly on x86-64 El Capitan 3.x buildbot

2018-12-04 Thread STINNER Victor
STINNER Victor added the comment: New changeset c93e3b05d5672dc9e8d6e2f2dce332799d5b95d2 by Victor Stinner in branch '3.7': bpo-35363, test_eintr: skip test_open() on macOS (GH-10896) (GH-10911) https://github.com/python/cpython/commit/c93e3b05d5672dc9e8d6e2f2dce332799d5b95d2 -- __

[issue34172] multiprocessing.Pool and ThreadPool leak resources after being deleted

2018-12-04 Thread STINNER Victor
STINNER Victor added the comment: multiprocessing should help the developer to detect when the API is misused. For example, emit a ResourceWarning if a pool is not released explicitly. It might help to detect such bugs: * bpo-33676 * bpo-35413 -- ___

[issue35413] test_multiprocessing_fork: test_del_pool() leaks dangling threads and processes on AMD64 FreeBSD CURRENT Shared 3.x

2018-12-04 Thread STINNER Victor
New submission from STINNER Victor : Previous issue fixing such bug: bpo-33676. https://buildbot.python.org/all/#/builders/168/builds/332 test_empty_string (test.test_multiprocessing_fork.WithThreadsTestPoll) ... ok test_strings (test.test_multiprocessing_fork.WithThreadsTestPoll) ... ok test_

[issue35363] test_eintr: test_open() hangs randomly on x86-64 El Capitan 3.x buildbot

2018-12-04 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +10151 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35363] test_eintr: test_open() hangs randomly on x86-64 El Capitan 3.x buildbot

2018-12-04 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +10150 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35411] FTP tests of test_urllib2net fail on Travis CI: 425 Security: Bad IP connecting.

2018-12-04 Thread miss-islington
miss-islington added the comment: New changeset c7976da5c262be818a06c344d43ac09b1083c80b by Miss Islington (bot) in branch '2.7': bpo-35411: Skip test_urllib2net FTP tests on Travis CI (GH-10907) https://github.com/python/cpython/commit/c7976da5c262be818a06c344d43ac09b1083c80b -- _

[issue35411] FTP tests of test_urllib2net fail on Travis CI: 425 Security: Bad IP connecting.

2018-12-04 Thread STINNER Victor
STINNER Victor added the comment: New changeset 65a5eff67474703329477b070d9c081fee17c69c by Victor Stinner (Miss Islington (bot)) in branch '3.6': bpo-35411: Skip test_urllib2net FTP tests on Travis CI (GH-10907) (GH-10909) https://github.com/python/cpython/commit/65a5eff67474703329477b070d9c

[issue35411] FTP tests of test_urllib2net fail on Travis CI: 425 Security: Bad IP connecting.

2018-12-04 Thread miss-islington
miss-islington added the comment: New changeset 74a80e1ed0c9067ef47f0a637d7f718a51b4f34e by Miss Islington (bot) in branch '3.7': bpo-35411: Skip test_urllib2net FTP tests on Travis CI (GH-10907) https://github.com/python/cpython/commit/74a80e1ed0c9067ef47f0a637d7f718a51b4f34e -- no

[issue35411] FTP tests of test_urllib2net fail on Travis CI: 425 Security: Bad IP connecting.

2018-12-04 Thread miss-islington
Change by miss-islington : -- pull_requests: +10149 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35411] FTP tests of test_urllib2net fail on Travis CI: 425 Security: Bad IP connecting.

2018-12-04 Thread miss-islington
Change by miss-islington : -- pull_requests: +10147 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35411] FTP tests of test_urllib2net fail on Travis CI: 425 Security: Bad IP connecting.

2018-12-04 Thread STINNER Victor
STINNER Victor added the comment: New changeset c11b3b19a5b022c6c229043d37f9a9fd06f22500 by Victor Stinner in branch 'master': bpo-35411: Skip test_urllib2net FTP tests on Travis CI (GH-10907) https://github.com/python/cpython/commit/c11b3b19a5b022c6c229043d37f9a9fd06f22500 --

[issue35411] FTP tests of test_urllib2net fail on Travis CI: 425 Security: Bad IP connecting.

2018-12-04 Thread miss-islington
Change by miss-islington : -- pull_requests: +10148 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35411] FTP tests of test_urllib2net fail on Travis CI: 425 Security: Bad IP connecting.

2018-12-04 Thread STINNER Victor
STINNER Victor added the comment: According to my PR 10906, FTP tests of test_urllib2net now also fail each time on master (not all of them, at least two tests fail). I wrote PR 10907 to skip the tests on Travis CI. We have AppVeyor to run these tests in pre-commit, and the buildbot farm to

[issue35411] FTP tests of test_urllib2net fail on Travis CI: 425 Security: Bad IP connecting.

2018-12-04 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +10146 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35411] FTP tests of test_urllib2net fail on Travis CI: 425 Security: Bad IP connecting.

2018-12-04 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +10145 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-

[issue35412] test_future4 ran no test

2018-12-04 Thread STINNER Victor
New submission from STINNER Victor : Since bpo-34279 has been fixed, regrtest now logs a message when a test runs no test. I noticed that test_future4 logs such message: ... 0:05:23 load avg: 0.56 [152/412] test_future4 0:05:24 load avg: 0.56 [153/412] test_future5 -- test_future4 run no tests

[issue35411] FTP tests of test_urllib2net fail on Travis CI: 425 Security: Bad IP connecting.

2018-12-04 Thread STINNER Victor
STINNER Victor added the comment: Another similar issue in a different project: https://sagebionetworks.jira.com/browse/SYNPY-731 The fix... removed the test :-) https://github.com/Sage-Bionetworks/synapsePythonClient/pull/571/files -- ___ Python t

[issue35411] FTP tests of test_urllib2net fail on Travis CI: 425 Security: Bad IP connecting.

2018-12-04 Thread STINNER Victor
New submission from STINNER Victor : ERROR: test_ftp (test.test_urllib2net.OtherNetworkTests) (url='ftp://www.pythontest.net/README') ERROR: test_ftp_basic (test.test_urllib2net.TimeoutTest) ERROR: test_ftp_default_timeout (test.test_urllib2net.TimeoutTest) ERROR: test_ftp_no_timeout (test.test

[issue35305] subprocess.Popen(['/sbin/ldconfig', '-p'], stdin=PIPE) itself hangs/deadlocks (Linux)

2018-12-04 Thread HenrikB
HenrikB added the comment: Thanks for taking your time on this one. I'll report back if I find out more about this kernel-specific issue. Here're my replies to the outstanding questions/comments: >> where the *child* process (`self.pid == 0`) get stuck while calling >> _dup2(c2pwrite = 4,

[issue35296] Install Include/internal/ header files

2018-12-04 Thread STINNER Victor
Change by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35296] Install Include/internal/ header files

2018-12-04 Thread STINNER Victor
STINNER Victor added the comment: New changeset b02774f42108aaf18eb19865472c8d5cd95b5f11 by Victor Stinner in branch '3.7': bpo-35296: make install now installs the internal API (GH-10665) (GH-10897) https://github.com/python/cpython/commit/b02774f42108aaf18eb19865472c8d5cd95b5f11 -

[issue29564] ResourceWarning: suggest to enable tracemalloc in the message

2018-12-04 Thread STINNER Victor
Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.7, Python 3.8 ___ Python tracker ___

[issue29564] ResourceWarning: suggest to enable tracemalloc in the message

2018-12-04 Thread STINNER Victor
STINNER Victor added the comment: New changeset 0091f349cde179ea991f4ee4d095119cd1fc3802 by Victor Stinner (Miss Islington (bot)) in branch '3.7': bpo-29564: warnings suggests to enable tracemalloc (GH-10486) (GH-10509) https://github.com/python/cpython/commit/0091f349cde179ea991f4ee4d095119c

[issue35390] ctypes not possible to pass NULL c_void_p in structure by reference

2018-12-04 Thread Dan
Dan added the comment: Thank you both, that's really helpful. Yes, I agree eryksun, I was saying that pointers to c_double and other normal pointer objects work fine, but that if you change to void* and c_void_p in my example it doesn't work. The private field seems like a reasonable soluti

[issue35410] copy.deepcopy does not respect metaclasses with __deepcopy__ implementations

2018-12-04 Thread Eliot Bixby
New submission from Eliot Bixby : __deepcopy__ implementations on metaclasses are ignored because deepcopy explicitly ignores class objects. It seems to me that more consistent behavior would be to use a null op as a fallback for class objects that do not have any of the relevant methods imp

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

2018-12-04 Thread Şahin
Şahin added the comment: OK, thank you all for information. It's now clear for me too why this is not an issue. I'll try to close this issue by selecting status as close but if it isn't working with this way (I'm new, I don't know how) anyone can close this. -- stage: patch review ->

[issue35235] Access violation on alloc in Windows x86-64 python, pymalloc_alloc

2018-12-04 Thread Mark Inderhees
Mark Inderhees added the comment: Correction to my previous post. I did use capital X, ie '-X dev'. -- ___ Python tracker ___ ___ P

[issue35364] Datetime “fromtimestamp()” ignores inheritance if timezone is not None

2018-12-04 Thread Paul Ganssle
Change by Paul Ganssle : -- keywords: +patch pull_requests: +10143 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-li

[issue32417] fromutc does not respect datetime subclasses

2018-12-04 Thread Paul Ganssle
Change by Paul Ganssle : -- keywords: +patch pull_requests: +10142 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-li

[issue35235] Access violation on alloc in Windows x86-64 python, pymalloc_alloc

2018-12-04 Thread Mark Inderhees
Mark Inderhees added the comment: I have reproduced this with both PYTHONMALLOC=debug and "py -3.7 -x dev ", but it did not print out any allocation debug info. When using this option, it does take many more attempts to hit the issue than if running without debugging turned on. Is there some

[issue35398] SQLite incorrect row count for UPDATE

2018-12-04 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Did some debugging here. If I am understanding this correctly the rowcount is set at https://github.com/python/cpython/blob/b8e689a6e8134e88f857a55e50b6a4977967e385/Modules/_sqlite/cursor.c#L574 . It checks for is_dml flag that is set here https:/

[issue16482] pdb.set_trace() clobbering traceback on error

2018-12-04 Thread Aaron Meurer
Aaron Meurer added the comment: You can download the branch for a pull request even if the repo is deleted using this https://stackoverflow.com/a/28622034/161801. That will let you keep the original commits intact. -- nosy: +asmeurer ___ Python tr

[issue35398] SQLite incorrect row count for UPDATE

2018-12-04 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- nosy: +lys.nikolaou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue35398] SQLite incorrect row count for UPDATE

2018-12-04 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +ghaering, xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue35364] Datetime “fromtimestamp()” ignores inheritance if timezone is not None

2018-12-04 Thread Paul Ganssle
Paul Ganssle added the comment: Another thing to note: I'm pretty sure this was a mistake in the first place. There are many examples of places where the datetime module was just not designed with inheritance in mind, for example: - issue 32404 / issue 32403 - fromtimestamp not calling __new

[issue20371] datetime.datetime.replace bypasses a subclass's __new__

2018-12-04 Thread Alexander Belopolsky
Change by Alexander Belopolsky : -- resolution: -> duplicate stage: needs patch -> resolved status: open -> closed superseder: -> datetime.py implementation of .replace inconsistent with C implementation ___ Python tracker

[issue20371] datetime.datetime.replace bypasses a subclass's __new__

2018-12-04 Thread Paul Ganssle
Paul Ganssle added the comment: This issue was fixed in Python 3.7, and it turns out issue 31222 was a duplicate of it. It can be closed now. -- nosy: +p-ganssle ___ Python tracker _

[issue35364] Datetime “fromtimestamp()” ignores inheritance if timezone is not None

2018-12-04 Thread Paul Ganssle
Paul Ganssle added the comment: > This is not easy problem, ant it doesn't have right solution. Different > decisions were made for the result type of alternate constructors and > operators for different classes. It's certainly true that it occasionally makes sense to do something like this,

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

2018-12-04 Thread Natal Ngétal
Change by Natal Ngétal : -- pull_requests: +10141 stage: test needed -> patch review ___ Python tracker ___ ___ Python-bugs-list maili

[issue16482] pdb.set_trace() clobbering traceback on error

2018-12-04 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I too just hit this issue with pdb and checked out the PR locally. It works fine though it has merge conflicts with latest master. I am adding 3.8, 3.7 and 3.6 removing the older versions that don't support bug fixes. Since the PR has unknown repos

[issue35257] Add LDFLAGS_NODIST for the LDFLAGS not intended for propagation to C extensions.

2018-12-04 Thread Charalampos Stratakis
Change by Charalampos Stratakis : -- keywords: +patch pull_requests: +10140 stage: -> patch review ___ Python tracker ___ ___ Pytho

[issue35405] Wrong traceback for AssertionError while running under pdb

2018-12-04 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Seems this is a known issue and has an open PR https://github.com/python/cpython/pull/6233 . I checked out the PR locally and it works fine on the examples presented though has merge conflicts with master. I am closing it as duplicate of issue16482

[issue31961] subprocess._execute_child doesn't accept a single PathLike argument for args

2018-12-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Ping. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue35346] Modernize Lib/platform.py code

2018-12-04 Thread STINNER Victor
STINNER Victor added the comment: New changeset b8e689a6e8134e88f857a55e50b6a4977967e385 by Victor Stinner in branch 'master': bpo-35346, platform: import subprocess in _syscmd_file() (GH-10892) https://github.com/python/cpython/commit/b8e689a6e8134e88f857a55e50b6a4977967e385 -- __

[issue35296] Install Include/internal/ header files

2018-12-04 Thread STINNER Victor
STINNER Victor added the comment: I reopen the issue since I'm now also interested to make the change in Python 3.7. I wrote PR 10897. See discussion on python-dev: https://mail.python.org/pipermail/python-dev/2018-December/155921.html -- resolution: fixed -> status: closed -> open

[issue35363] test_eintr: test_open() hangs randomly on x86-64 El Capitan 3.x buildbot

2018-12-04 Thread STINNER Victor
STINNER Victor added the comment: New changeset 4752e65250bce60b97d5af702d586092d02fbf58 by Victor Stinner in branch 'master': bpo-35363, test_eintr: skip test_open() on macOS (GH-10896) https://github.com/python/cpython/commit/4752e65250bce60b97d5af702d586092d02fbf58 -- __

[issue35296] Install Include/internal/ header files

2018-12-04 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +10137 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35363] test_eintr: test_open() hangs randomly on x86-64 El Capitan 3.x buildbot

2018-12-04 Thread miss-islington
Change by miss-islington : -- pull_requests: +10139 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35363] test_eintr: test_open() hangs randomly on x86-64 El Capitan 3.x buildbot

2018-12-04 Thread miss-islington
Change by miss-islington : -- pull_requests: +10138 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35364] Datetime “fromtimestamp()” ignores inheritance if timezone is not None

2018-12-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This is not easy problem, ant it doesn't have right solution. Different decisions were made for the result type of alternate constructors and operators for different classes. The frombytes() method of an int subclass returns an int. As well arithmetic op

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

2018-12-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: They are not in the __all__ list and are not documented. If __all__ is defined for the module, there is no need to use the underscore prefix for private globals. The calendar module is not special, many other modules follow this convention. -- __

[issue35364] Datetime “fromtimestamp()” ignores inheritance if timezone is not None

2018-12-04 Thread Paul Ganssle
Paul Ganssle added the comment: This is another manifestation of issue 32417. The biggest complication, to me, is that adding a `timedelta` to a datetime always returns a `datetime.datetime` rather than the subclass that it was added to. I *think* most if not all people would consider this

[issue35363] test_eintr: test_open() hangs randomly on x86-64 El Capitan 3.x buildbot

2018-12-04 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +10136 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-

[issue35363] test_eintr: test_open() hangs randomly on x86-64 El Capitan 3.x buildbot

2018-12-04 Thread STINNER Victor
STINNER Victor added the comment: Oh. That's just a variant of the old bpo-25234. -- ___ Python tracker ___ ___ Python-bugs-list ma

[issue35376] modulefinder skips nested modules with same name as top-level bad module

2018-12-04 Thread rdb
Change by rdb : -- pull_requests: -10133 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue35376] modulefinder skips nested modules with same name as top-level bad module

2018-12-04 Thread rdb
Change by rdb : -- pull_requests: +10134 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

2018-12-04 Thread Paul Ganssle
Paul Ganssle added the comment: Might it be worth moving `nextmonth` and `prevmonth` to `calendar._nextmonth` and `calendar._prevmonth` to make it more clear that these are private methods? Due to Hyrum's Law, people will be using them anyway, but it could have a short deprecation period whe

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

2018-12-04 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: > On Dec 4, 2018, at 10:27 AM, Şahin wrote: > > Is there anything similar to this for "public API functions"? Yes - read the reference manual. If the function is not there it is not public. -- ___ Python tra

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

2018-12-04 Thread Şahin
Şahin added the comment: OK now it isn't a problem if we shouldn't use this function directly but how am i going to understand if a function is public API or not? In classes, we are using single or double underscore to indicate that the function or variable we're declaring is intended to be p

[issue35376] modulefinder skips nested modules with same name as top-level bad module

2018-12-04 Thread rdb
Change by rdb : -- pull_requests: +10133 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue35351] LTOFLAGS are passed to BASECFLAGS when using LTO

2018-12-04 Thread miss-islington
miss-islington added the comment: New changeset 1751423686d05e3facdd6da2620202728e5d7917 by Miss Islington (bot) in branch '3.7': bpo-35351: Pass link time optimization flags to CFLAGS_NODIST (GH-10797) https://github.com/python/cpython/commit/1751423686d05e3facdd6da2620202728e5d7917 --

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

2018-12-04 Thread శ్రీనివాస్ రెడ్డి తాటిపర్తి
Srinivas Reddy Thatiparthy(శ్రీనివాస్ రెడ్డి తాటిపర్తి) added the comment: I agree with Serhiy, nextmonth() is not a public API,you should not use it. -- nosy: +thatiparthy ___ Python tracker __

[issue35351] LTOFLAGS are passed to BASECFLAGS when using LTO

2018-12-04 Thread miss-islington
Change by miss-islington : -- pull_requests: +10132 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35351] LTOFLAGS are passed to BASECFLAGS when using LTO

2018-12-04 Thread STINNER Victor
STINNER Victor added the comment: New changeset f92c7aa1ae81efa475b5aecf66e4711ef0f52c4c by Victor Stinner (stratakis) in branch 'master': bpo-35351: Pass link time optimization flags to CFLAGS_NODIST (GH-10797) https://github.com/python/cpython/commit/f92c7aa1ae81efa475b5aecf66e4711ef0f52c4c

[issue35408] Python3.7 crash in PyCFunction_New due to broken _PyObject_GC_TRACK

2018-12-04 Thread STINNER Victor
STINNER Victor added the comment: I close the issue as "not a bug". Even if the code "worked" in Python 3.6, it worked because of a mistake :-) -- nosy: +eric.snow, ncoghlan resolution: -> not a bug stage: -> resolved status: open -> closed ___ P

[issue35408] Python3.7 crash in PyCFunction_New due to broken _PyObject_GC_TRACK

2018-12-04 Thread STINNER Victor
STINNER Victor added the comment: > Python3.7 crash in PyCFunction_New due to broken _PyObject_GC_TRACK It's unrelated. Your must not use the Python API before Python is initialized. If you modify your code like that, it works as expected: int main() { Py_Initialize(); PyMethodDef methodd

[issue35408] Python3.7 crash in PyCFunction_New due to broken _PyObject_GC_TRACK

2018-12-04 Thread STINNER Victor
Change by STINNER Victor : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue35346] Modernize Lib/platform.py code

2018-12-04 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +10131 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

2018-12-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: nextmonth() is not a public API. You should not use it. If you want to make IllegalMonthError be always raised instead of IndexError for out of range month values, this is a different issue. -- ___ Python tracke

[issue35405] Wrong traceback for AssertionError while running under pdb

2018-12-04 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks Serhiy, is this a known behavior or issue since it's from 2.7 ? This is highly confusing and misleading as in your example and also while debugging tests that fail at a different line of assertion statement from the current line in pdb which

[issue35409] Async generator might re-throw GeneratorExit on aclose()

2018-12-04 Thread Vincent Michel
Change by Vincent Michel : -- keywords: +patch Added file: https://bugs.python.org/file47974/patch.diff ___ Python tracker ___ ___ P

[issue35409] Async generator might re-throw GeneratorExit on aclose()

2018-12-04 Thread Vincent Michel
Change by Vincent Michel : Added file: https://bugs.python.org/file47973/test.py ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue35407] Datetime function with selenium

2018-12-04 Thread Steven D'Aprano
Steven D'Aprano added the comment: This is for reporting bugs in the Python interpreter and standard library, not for asking for help with bugs in your own code. The code you show contains a syntax error (some of the indentation is wrong) and at least one undefined variable, "new". The trace

[issue35409] Async generator might re-throw GeneratorExit on aclose()

2018-12-04 Thread Vincent Michel
New submission from Vincent Michel : As far as I can tell, this issue is different than: https://bugs.python.org/issue34730 I noticed `async_gen.aclose()` raises a GeneratorExit exception if the async generator finalization awaits and silence a failing unfinished future (see example.py). Th

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

2018-12-04 Thread Şahin
Şahin added the comment: I'm suggesting this idea to consistency. Why an IllegalMonthError exists in calendar module if we don't raise this error when required? What would you say if I asked you to "What is the month number coming after 156th month?" Would you say 157 or prefer to inform me t

[issue35389] Use gnu_get_libc_version() in platform.libc_ver()?

2018-12-04 Thread STINNER Victor
STINNER Victor added the comment: > Currently libc_ver() can be used for other executable. See issue26544 for > discussion about libc_ver(). Oh, my PR had a bug: it ignores executable. Fixed: it now only uses os.confstr() if the executable argument is not set. -- __

[issue35408] Python3.7 crash in PyCFunction_New due to broken _PyObject_GC_TRACK

2018-12-04 Thread Enric Tejedor Saavedra
New submission from Enric Tejedor Saavedra : Attached is a reproducer that calls PyCFunction_New. The reproducer runs normally with Python 3.6.5, but it crashes with Python 3.7.1. The reason seems to be that the _PyObject_GC_TRACK macro ends up being called and it is broken in Python3.7. A f

[issue35407] Datetime function with selenium

2018-12-04 Thread Sameer Joshi
Sameer Joshi added the comment: I have defined 2 variables , 1 for Friday and other for rest of weekdays. However when I match these two with the website date(which is 'today - 3' for Monday and 'today -1' )it shows the error as variable not defined. Below is code for the same. import datet

[issue35407] Datetime function with selenium

2018-12-04 Thread Sameer Joshi
New submission from Sameer Joshi : I have defined 2 variables , 1 for Friday and other for rest of weekdays. However when I match these two with the website date(which is 'today - 3' for Monday and 'today -1' )it shows the error as variable not defined. Below is code for the same. import dat

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

2018-12-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: What is the problem with current code? Can you provide an example that doesn't work correctly? -- ___ Python tracker ___ _

[issue35389] Use gnu_get_libc_version() in platform.libc_ver()?

2018-12-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Currently libc_ver() can be used for other executable. See issue26544 for discussion about libc_ver(). -- nosy: +serhiy.storchaka ___ Python tracker _

[issue35389] Use gnu_get_libc_version() in platform.libc_ver()?

2018-12-04 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +10130 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

2018-12-04 Thread Şahin
Şahin added the comment: I understand you but i still think these functions need to check it. As an end-user, I shouldn't see these functions to work with no errors for illegal months. -- ___ Python tracker ___

[issue35365] Use wchar_t* buffer instead of Unicode object in code page decoder

2018-12-04 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue35405] Wrong traceback for AssertionError while running under pdb

2018-12-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There is nothing specific for assert and AssertionError. Other example: import pdb; pdb.set_trace() x = 1 y = 1/0 -- nosy: +serhiy.storchaka ___ Python tracker __

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

2018-12-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: prevmonth() and nextmonth() are internal functions. They are used only in itermonthdays3(), and the month is already checked before calling them. -- nosy: +belopolsky, rhettinger, serhiy.storchaka ___ Python trac

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

2018-12-04 Thread Şahin
Change by Şahin : -- keywords: +patch pull_requests: +10128 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list maili

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

2018-12-04 Thread Şahin
New submission from Şahin : import calendar calendar.nextmonth(2018, 11) returns (2018, 12) which is OK. calendar.nextmonth(2018, 12) returns (2019, 1) which is also OK. calendar.nextmonth(2018, 13) returns (2018, 14). It would make more sense if this was raise calendar.IllegalMonthError. -

  1   2   >