[issue35568] Expose the C raise() function in the signal module, for use on Windows

2018-12-26 Thread Nathaniel Smith
Nathaniel Smith added the comment: I'd like to see it in 3.8, but don't know if I'll get to it, and it'd be a good onramp issue for someone who wants to get into cpython development. So, let's put the keyword on it for now, and see what happens... -- keywords: +easy (C)

[issue35121] Cookie domain check returns incorrect results

2018-12-26 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Also looking at the docs for different frameworks like [Flask](http://flask.pocoo.org/docs/1.0/api/#flask.Response.set_cookie) and [Django](https://docs.djangoproject.com/en/2.1/ref/request-response/#django.http.HttpResponse.set_cookie) they

[issue24928] mock.patch.dict spoils order of items in collections.OrderedDict

2018-12-26 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Hi Vaibhav, As noted in the thread the issue is fixed in 3.6 and above due to dict order being guaranteed. But it would be nice to have the test in the patch converted as a unit test. With respect to backport the fixes are backported to

[issue35559] Optimize base64.b16decode to use compiled regex

2018-12-26 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks for the feedback. I am closing this as rejected since it's not worth the cost of increasing import time and for performance reasons there are other options as Serhiy noted in msg332339. -- resolution: -> rejected stage: patch

[issue1222585] C++ compilation support for distutils

2018-12-26 Thread marsam
Change by marsam : -- versions: +Python 3.7 -Python 3.5 Added file: https://bugs.python.org/file48016/python-3.x-distutils-C++.patch ___ Python tracker ___

[issue34855] batch file variables

2018-12-26 Thread Steve Dower
Steve Dower added the comment: They should set it, and it will be read in PCbuild/python.props which has the "correct" name (I forget what it is right now and am not looking it up on my phone) -- ___ Python tracker

[issue34855] batch file variables

2018-12-26 Thread Eric Lindblad
Eric Lindblad added the comment: Should windows-steps.yml (line 11) and windows-appx-test.yml committed 6 Dec. (line 39) both read EXTERNALS_DIR? -- ___ Python tracker ___

[issue33661] urllib may leak sensitive HTTP headers to a third-party web site

2018-12-26 Thread Katsuhiko YOSHIDA
Katsuhiko YOSHIDA added the comment: Thanks. But I think the “add_unredirected_header” is not enough. These sensitive headers should be removed only when redirecting to cross-site automatically for security like HTTPBasicAuthHandler of urllib2. In order to fulfill this requirement, I think

[issue35583] (glibc2.28/MIPS32EL) python 3.7.x interpreter segmentation fault (3.6.x/2.7.x compile fine)

2018-12-26 Thread Gagan
Gagan added the comment: i tried compiling using "--without-pymalloc" and experienced the same problem. there is no REASONABLE explanation for how this anomaly has arisen within SUBVERSIONS. in the words of some infamous rappers: "what, the 'embedded' (ARM-fellating) [east coast] crew

[issue22171] stack smash when using ctypes/libffi to access union

2018-12-26 Thread Sam Kerr
Sam Kerr added the comment: I was also able to get the stack smashing behavior with the following: OS: Linux slaptop 4.19.12-arch1-1-ARCH #1 SMP PREEMPT Fri Dec 21 13:56:54 UTC 2018 x86_64 GNU/Linux GCC: gcc (GCC) 8.2.1 20181127 I was able to track down the issue into the src/x86/ffi64.c

[issue26537] ConfigParser has optionxform, but not sectionxform

2018-12-26 Thread Cheryl Sabella
Cheryl Sabella added the comment: Would it be worthwhile to convert this patch to a PR for 3.8? -- nosy: +cheryl.sabella ___ Python tracker ___

[issue35495] argparse does not honor default argument for nargs=argparse.REMAINDER argument

2018-12-26 Thread paul j3
paul j3 added the comment: argparse.REMAINDER matches an empty list of arguments, just like '?' and '*'. So they are always 'filled', even by `parse_args([])`. '?' and '*' have some special handling of defaults in this case, see in argparse.ArgumentParser._get_values the two

[issue35592] Not able to use Python 3.7.2 due to SSL issue

2018-12-26 Thread Christian Heimes
Christian Heimes added the comment: I don't see any error message. Please describe how you have installed Python and which version of Windows you are running. A traceback and an error message would be helpful, too. -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden,

[issue35442] Chain of several subcommands in argparse

2018-12-26 Thread paul j3
Change by paul j3 : -- nosy: +paul.j3 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35537] use os.posix_spawn in subprocess

2018-12-26 Thread Gregory P. Smith
Gregory P. Smith added the comment: Thanks for all your research and reference links on this! As a _posixsubprocess maintainer, I am not against either posix_spawn or vfork being used directly in the future when feasible. A challenge, especially with platform specific vfork, is making sure

[issue35592] Not able to use Python 3.7.2 due to SSL issue

2018-12-26 Thread Gunasekar Rajendran
New submission from Gunasekar Rajendran : I am trying to run python code in Visual studio code and get the below error while trying to connect to mysql db Python installation has no SSL support -- assignee: christian.heimes components: SSL files: dbconnect.py messages: 332564 nosy:

[issue34836] test_ssl.test_default_ecdh_curve needs no tls1.3 flag in 2.7, for now

2018-12-26 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> christian.heimes ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35559] Optimize base64.b16decode to use compiled regex

2018-12-26 Thread Stefan Behnel
Stefan Behnel added the comment: I agree with Antoine. After all, we are optimising a safety check here that runs in linear time. If people want speed, they should consider methods that do not do this check in the first place. -- ___ Python

[issue35585] Speedup Enum lookup

2018-12-26 Thread Andrew Svetlov
Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue35585] Speedup Enum lookup

2018-12-26 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset 705b5998035739b1794a862123d3dc6e339a14d0 by Andrew Svetlov (Miss Islington (bot)) in branch '3.7': Speed-up building enums by value, e.g. http.HTTPStatus(200) (GH-11318) (GH-11324)

[issue33661] urllib may leak sensitive HTTP headers to a third-party web site

2018-12-26 Thread Martin Panter
Martin Panter added the comment: Are you aware of the “add_unredirected_header” method? Maybe that is enough to avoid your problem. https://docs.python.org/dev/library/urllib.request.html#urllib.request.Request.add_unredirected_header -- nosy: +martin.panter title: urllib may leak

[issue28097] IDLE: document all key bindings, add menu items for more.

2018-12-26 Thread Cheryl Sabella
Cheryl Sabella added the comment: PR11325 adds Previous/Next History to the Shell menu. -- nosy: +cheryl.sabella stage: patch review -> needs patch ___ Python tracker ___

[issue28097] IDLE: document all key bindings, add menu items for more.

2018-12-26 Thread Cheryl Sabella
Change by Cheryl Sabella : -- keywords: +patch pull_requests: +10588 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue28097] IDLE: document all key bindings, add menu items for more.

2018-12-26 Thread Cheryl Sabella
Change by Cheryl Sabella : -- keywords: +patch, patch pull_requests: +10588, 10589 stage: needs patch -> patch review ___ Python tracker ___

[issue28097] IDLE: document all key bindings, add menu items for more.

2018-12-26 Thread Cheryl Sabella
Change by Cheryl Sabella : -- keywords: +patch, patch, patch pull_requests: +10588, 10589, 10590 stage: needs patch -> patch review ___ Python tracker ___

[issue35591] IDLE: Traceback on Find Selection

2018-12-26 Thread Cheryl Sabella
New submission from Cheryl Sabella : This probably isn't a traceback that's likely to happen, but I wanted to document it since I was able to recreate it. To recreate: In a new shell, do Select All, then Find Selection. Exception in Tkinter callback Traceback (most recent call last): File

[issue35585] Speedup Enum lookup

2018-12-26 Thread miss-islington
Change by miss-islington : -- pull_requests: +10587 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35585] Speedup Enum lookup

2018-12-26 Thread Ethan Furman
Ethan Furman added the comment: New changeset 34ae04f74dcf4ac97d07c3e82eaf8f619d80cedb by Ethan Furman (Andrew Svetlov) in branch 'master': Speed-up building enums by value, e.g. http.HTTPStatus(200) (#11318) https://github.com/python/cpython/commit/34ae04f74dcf4ac97d07c3e82eaf8f619d80cedb

[issue35588] Speed up mod/divmod/floordiv for Fraction type

2018-12-26 Thread Stefan Behnel
Stefan Behnel added the comment: Thanks for your review and ideas, Serhiy. I added a couple of test cases, but failed to find any case where the new implementation is not much faster. I also tried "divmod(n_div, d_div)" for implementing __divmod__(), and the results are mixed, e.g.

[issue35579] Typo in in asyncio-task documentation

2018-12-26 Thread miss-islington
miss-islington added the comment: New changeset dcf14d1a9875143747cd87c66fae6e693b21c6de by Miss Islington (bot) in branch '3.7': bpo-35579: Fix typo in in asyncio-task documentation (GH-11321) https://github.com/python/cpython/commit/dcf14d1a9875143747cd87c66fae6e693b21c6de --

[issue35579] Typo in in asyncio-task documentation

2018-12-26 Thread miss-islington
miss-islington added the comment: New changeset 3a81076bbf899b1a549f005dd9299e7ae0946321 by Miss Islington (bot) (Vaibhav Gupta) in branch 'master': bpo-35579: Fix typo in in asyncio-task documentation (GH-11321)

[issue35588] Speed up mod/divmod/floordiv for Fraction type

2018-12-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I want to check whether removing the normalization step has a negative performance effect larger than the time spent on normalization. -- ___ Python tracker

[issue35588] Speed up mod/divmod/floordiv for Fraction type

2018-12-26 Thread Stefan Behnel
Stefan Behnel added the comment: Sure, I can add tests, but I wonder what kind of regression you expect. The algorithm is still the same as before, it's just implemented more efficiently. It does trade a bit of memory for the speed, though, since there is no longer an intermediate

[issue35579] Typo in in asyncio-task documentation

2018-12-26 Thread miss-islington
miss-islington added the comment: New changeset 3a81076bbf899b1a549f005dd9299e7ae0946321 by Miss Islington (bot) (Vaibhav Gupta) in branch 'master': bpo-35579: Fix typo in in asyncio-task documentation (GH-11321)

[issue35579] Typo in in asyncio-task documentation

2018-12-26 Thread miss-islington
miss-islington added the comment: New changeset 3a81076bbf899b1a549f005dd9299e7ae0946321 by Miss Islington (bot) (Vaibhav Gupta) in branch 'master': bpo-35579: Fix typo in in asyncio-task documentation (GH-11321)

[issue34148] Fatal error on SSL transport

2018-12-26 Thread yjq
yjq added the comment: I'm sure that this should be a bug in python. But because I'm naive, I'm not sure about how to fix it. I think we can just add the exception to base_events._FATAL_ERROR_IGNORE. -- ___ Python tracker

[issue34148] Fatal error on SSL transport

2018-12-26 Thread yjq
yjq added the comment: https://github.com/aio-libs/aiohttp/issues/3202#issuecomment-439644135 -- versions: -Python 3.6 ___ Python tracker ___

[issue35579] Typo in in asyncio-task documentation

2018-12-26 Thread miss-islington
miss-islington added the comment: New changeset dcf14d1a9875143747cd87c66fae6e693b21c6de by Miss Islington (bot) in branch '3.7': bpo-35579: Fix typo in in asyncio-task documentation (GH-11321) https://github.com/python/cpython/commit/dcf14d1a9875143747cd87c66fae6e693b21c6de --

[issue35588] Speed up mod/divmod/floordiv for Fraction type

2018-12-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Please make several additional tests, and ensure that there is no regression. 1. Test with fractions with the same large denominator (for example 2**50, 2**100, 10**30, 3**50, factorial(30), or a large pseudo-primary number) and small and large

[issue35579] Typo in in asyncio-task documentation

2018-12-26 Thread miss-islington
miss-islington added the comment: New changeset dcf14d1a9875143747cd87c66fae6e693b21c6de by Miss Islington (bot) in branch '3.7': bpo-35579: Fix typo in in asyncio-task documentation (GH-11321) https://github.com/python/cpython/commit/dcf14d1a9875143747cd87c66fae6e693b21c6de --

[issue35579] Typo in in asyncio-task documentation

2018-12-26 Thread miss-islington
miss-islington added the comment: New changeset 3a81076bbf899b1a549f005dd9299e7ae0946321 by Miss Islington (bot) (Vaibhav Gupta) in branch 'master': bpo-35579: Fix typo in in asyncio-task documentation (GH-11321)

[issue35579] Typo in in asyncio-task documentation

2018-12-26 Thread miss-islington
miss-islington added the comment: New changeset 3a81076bbf899b1a549f005dd9299e7ae0946321 by Miss Islington (bot) (Vaibhav Gupta) in branch 'master': bpo-35579: Fix typo in in asyncio-task documentation (GH-11321)

[issue35579] Typo in in asyncio-task documentation

2018-12-26 Thread miss-islington
miss-islington added the comment: New changeset 3a81076bbf899b1a549f005dd9299e7ae0946321 by Miss Islington (bot) (Vaibhav Gupta) in branch 'master': bpo-35579: Fix typo in in asyncio-task documentation (GH-11321)

[issue35579] Typo in in asyncio-task documentation

2018-12-26 Thread miss-islington
miss-islington added the comment: New changeset 3a81076bbf899b1a549f005dd9299e7ae0946321 by Miss Islington (bot) (Vaibhav Gupta) in branch 'master': bpo-35579: Fix typo in in asyncio-task documentation (GH-11321)

[issue35579] Typo in in asyncio-task documentation

2018-12-26 Thread Andrew Svetlov
Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue35579] Typo in in asyncio-task documentation

2018-12-26 Thread miss-islington
miss-islington added the comment: New changeset dcf14d1a9875143747cd87c66fae6e693b21c6de by Miss Islington (bot) in branch '3.7': bpo-35579: Fix typo in in asyncio-task documentation (GH-11321) https://github.com/python/cpython/commit/dcf14d1a9875143747cd87c66fae6e693b21c6de --

[issue35579] Typo in in asyncio-task documentation

2018-12-26 Thread miss-islington
Change by miss-islington : -- pull_requests: +10585, 10586 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35579] Typo in in asyncio-task documentation

2018-12-26 Thread miss-islington
Change by miss-islington : -- pull_requests: +10585 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24928] mock.patch.dict spoils order of items in collections.OrderedDict

2018-12-26 Thread Vaibhav Gupta
Vaibhav Gupta added the comment: Hi. I would like to make a PR for this. Also, I am not very familiar with the process of backporting. Is something specific needs to be done for that which is related to this? -- nosy: +dojutsu-user ___ Python

[issue35590] logging.handlers.SysLogHandler with STREAM connects in constructor without timeout

2018-12-26 Thread Emmanuel Arias
Change by Emmanuel Arias : -- components: +Library (Lib) type: -> enhancement ___ Python tracker ___ ___ Python-bugs-list mailing

[issue35590] logging.handlers.SysLogHandler with STREAM connects in constructor without timeout

2018-12-26 Thread Emmanuel Arias
Emmanuel Arias added the comment: Hi, If I don't see bad, if a timeout occur this is catch by the OSError exception. -- nosy: +eamanu ___ Python tracker ___

[issue35588] Speed up mod/divmod/floordiv for Fraction type

2018-12-26 Thread Stefan Behnel
Stefan Behnel added the comment: Motivation for the latter: $ ./python -m timeit -s 'from fractions import Fraction as F; a = F(-7, 3); b = F(3, 2)' 'a // b' 10 loops, best of 5: 3.7 usec per loop $ ./python -m timeit -s 'from fractions import Fraction as F; a = F(-7, 3); b = F(3, 2)'

[issue35588] Speed up mod/divmod for Fraction type

2018-12-26 Thread Stefan Behnel
Stefan Behnel added the comment: Similarly, I think "//" (__floordiv__) should be implemented using integer operations rather than math.floor(): (a.numerator * b.denominator) // (b.numerator * a.denominator) Thoughts? -- ___ Python tracker

[issue35590] logging.handlers.SysLogHandler with STREAM connects in constructor without timeout

2018-12-26 Thread jso2460
New submission from jso2460 : logging.handlers.SysLogHandler in __init__ contains the following code, where socket is created and then connected right away. This seem to provide no way to specify a connection timeout for the socket being created. sock = socket.socket(af, socktype, proto) if

[issue35589] BaseSelectorEventLoop.sock_sendall() performance regression: extra copy of data

2018-12-26 Thread Andrew Svetlov
Andrew Svetlov added the comment: Thanks for the report! -- assignee: -> asvetlov ___ Python tracker ___ ___ Python-bugs-list

[issue35589] BaseSelectorEventLoop.sock_sendall() performance regression: extra copy of data

2018-12-26 Thread Huazuo Gao
New submission from Huazuo Gao : Prior to PR 10419, sock_sendall does not make a copy of the data. PR 10419 introduced an extra copy, which may cause problem for code that send a huge chunk of data simultaneously to many peers. Relevant change is:

[issue35588] Speed up mod/divmod for Fraction type

2018-12-26 Thread Stefan Behnel
Change by Stefan Behnel : -- nosy: +mark.dickinson, serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35588] Speed up mod/divmod for Fraction type

2018-12-26 Thread Stefan Behnel
Change by Stefan Behnel : -- keywords: +patch, patch, patch pull_requests: +10582, 10583, 10584 stage: -> patch review ___ Python tracker ___

[issue35588] Speed up mod/divmod for Fraction type

2018-12-26 Thread Stefan Behnel
Change by Stefan Behnel : -- keywords: +patch, patch pull_requests: +10582, 10583 stage: -> patch review ___ Python tracker ___

[issue35588] Speed up mod/divmod for Fraction type

2018-12-26 Thread Stefan Behnel
Change by Stefan Behnel : -- keywords: +patch pull_requests: +10582 stage: -> patch review ___ Python tracker ___ ___

[issue35588] Speed up mod/divmod for Fraction type

2018-12-26 Thread Stefan Behnel
New submission from Stefan Behnel : Spelling out the numerator/denominator calculation in the __mod__ special method, and actually implementing __divmod__, speeds up both operations by 2-3x. This is due to avoiding repeated Fraction instantiation and normalisation, as well as less arithmetic

[issue35579] Typo in in asyncio-task documentation

2018-12-26 Thread Vaibhav Gupta
Change by Vaibhav Gupta : -- keywords: +patch, patch, patch, patch pull_requests: +10578, 10579, 10580, 10581 stage: -> patch review ___ Python tracker ___

[issue35579] Typo in in asyncio-task documentation

2018-12-26 Thread Vaibhav Gupta
Change by Vaibhav Gupta : -- keywords: +patch, patch, patch pull_requests: +10578, 10579, 10580 stage: -> patch review ___ Python tracker ___

[issue35579] Typo in in asyncio-task documentation

2018-12-26 Thread Vaibhav Gupta
Change by Vaibhav Gupta : -- keywords: +patch, patch pull_requests: +10578, 10579 stage: -> patch review ___ Python tracker ___

[issue35579] Typo in in asyncio-task documentation

2018-12-26 Thread Vaibhav Gupta
Change by Vaibhav Gupta : -- keywords: +patch pull_requests: +10578 stage: -> patch review ___ Python tracker ___ ___