[issue36102] TestSharedMemory fails on AMD64 FreeBSD CURRENT Shared 3.x

2019-02-25 Thread Davin Potts
Change by Davin Potts : -- keywords: +patch pull_requests: +12065 stage: -> patch review ___ Python tracker ___ ___

[issue36039] Replace append loops with list comprehensions

2019-02-25 Thread Lukas Geiger
Lukas Geiger added the comment: Thank you very much for your thorough explanation, totally makes sense. -- ___ Python tracker ___

[issue36108] Avoid failing the build on race condition in clean

2019-02-25 Thread Steve Dower
New submission from Steve Dower : In PCbuild/openssl.props there is a task that deletes some copied files. This *might* fail on rebuilds where a Python process from a previous build has been running (for a very specific example, the rebuild as part of the release build triggered this). We

[issue35840] Control flow inconsistency on closed asyncio stream

2019-02-25 Thread Emmanuel Arias
Emmanuel Arias added the comment: Ok, I am working on that. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue36107] aarch64 python3 buffer overflow with stack protector on rpi3 (alpine linux)

2019-02-25 Thread Natanael Copa
Change by Natanael Copa : -- type: -> crash ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32129] IDLE app icon is blurry on macOS with Aqua Tk 8.6

2019-02-25 Thread Ned Deily
Ned Deily added the comment: Thanks, Kevin, for the reminder. Yeah, there's no reason not to push this. I've attached PRs for 3.x and for 2.7. -- stage: patch review -> commit review title: Icon on macOS -> IDLE app icon is blurry on macOS with Aqua Tk 8.6 versions: +Python 2.7,

[issue36103] Increase shutil.COPY_BUFSIZE

2019-02-25 Thread desbma
desbma added the comment: If you do a benchmark by reading from a file, and then writing to /dev/null several times, without clearing caches, you are measuring *only* the syscall overhead: * input data is read from the Linux page cache, not the file on your SSD itself * no data is written

[issue35178] Typo/trivial mistake in warnings.py (may be related to 2.x to 3.x conversion)

2019-02-25 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- keywords: +patch pull_requests: +12063 stage: -> patch review ___ Python tracker ___ ___

[issue32129] Icon on macOS

2019-02-25 Thread Ned Deily
Change by Ned Deily : -- pull_requests: +12064 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36107] aarch64 python3 buffer overflow with stack protector on rpi3 (alpine linux)

2019-02-25 Thread Natanael Copa
Natanael Copa added the comment: It seems like python 3.7.2 works. Any idea which commit(s) may have fixed it? -- ___ Python tracker ___

[issue33608] [subinterpreters] Add a cross-interpreter-safe mechanism to indicate that an object may be destroyed.

2019-02-25 Thread Eric Snow
Eric Snow added the comment: GH-11617 has introduces a slight performance regression which will need to be resolved. If I can't find the problem right away then I'll probably temporarily revert the commit. See https://mail.python.org/pipermail/python-dev/2019-February/156451.html.

[issue36030] add internal API function to create tuple without items array initialization

2019-02-25 Thread Sergey Fedoseev
Change by Sergey Fedoseev : -- pull_requests: +12062 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36107] aarch64 python3 buffer overflow with stack protector on rpi3 (alpine linux)

2019-02-25 Thread Natanael Copa
Natanael Copa added the comment: Valgrind claims there are some use of uninitialized values. -- Added file: https://bugs.python.org/file48169/valgrind.out ___ Python tracker

[issue36107] aarch64 python3 buffer overflow with stack protector on rpi3 (alpine linux)

2019-02-25 Thread Natanael Copa
Natanael Copa added the comment: Interestingly, it does not crash when I run python in valgrind. -- ___ Python tracker ___ ___

[issue36030] add internal API function to create tuple without items array initialization

2019-02-25 Thread STINNER Victor
STINNER Victor added the comment: New changeset 234531b4462b20d668762bd78406fd2ebab129c9 by Victor Stinner (Sergey Fedoseev) in branch 'master': bpo-36030: Add _PyTuple_FromArray() function (GH-11954) https://github.com/python/cpython/commit/234531b4462b20d668762bd78406fd2ebab129c9

[issue36107] aarch64 python3 buffer overflow with stack protector on rpi3 (alpine linux)

2019-02-25 Thread Natanael Copa
New submission from Natanael Copa : Alpine Linux's python 3.6.8 native build on aarch64 gets killed by stack protector when run on Raspberry Pi 3. It does not happen when same binary runs on packet.net's aarch64 machine. I was able to get a backtrace by copying the core. Core was generated

[issue32129] Icon on macOS

2019-02-25 Thread Ned Deily
Change by Ned Deily : -- pull_requests: +12061 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue28450] Misleading/inaccurate documentation about unknown escape sequences in regular expressions

2019-02-25 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue28450] Misleading/inaccurate documentation about unknown escape sequences in regular expressions

2019-02-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 95fc8e687c487ecf97f4b1b98dfc0c05e3c9cbff by Serhiy Storchaka in branch '3.7': [3.7] bpo-28450: Fix and improve the documentation for unknown escapes in RE. (GH-11920). (GH-12029)

[issue34781] infinite waiting in multiprocessing.Pool

2019-02-25 Thread Dongyan Li
Dongyan Li added the comment: I got the same issue with Python 3.7.2 on Windows Build 14393. Seems that the program got stuck on the `waiter.acquire()` method. -- nosy: +Dongyan Li ___ Python tracker

[issue35459] Use PyDict_GetItemWithError() instead of PyDict_GetItem()

2019-02-25 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue28450] Misleading/inaccurate documentation about unknown escape sequences in regular expressions

2019-02-25 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +12060 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36048] Deprecate implicit truncating when convert Python numbers to C integers: use __index__, not __int__

2019-02-25 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue35178] Typo/trivial mistake in warnings.py (may be related to 2.x to 3.x conversion)

2019-02-25 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: @tashrifbillah I will be happy to add a test on a follow up PR attributing to the original PR as per https://github.com/python/cpython/pull/10343#issuecomment-467026474 Thanks -- nosy: +xtreak ___

[issue35459] Use PyDict_GetItemWithError() instead of PyDict_GetItem()

2019-02-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset a24107b04c1277e3c1105f98aff5bfa3a98b33a0 by Serhiy Storchaka in branch 'master': bpo-35459: Use PyDict_GetItemWithError() instead of PyDict_GetItem(). (GH-2)

[issue28450] Misleading/inaccurate documentation about unknown escape sequences in regular expressions

2019-02-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset a180b007d96fe68b32f11dec720fbd0cd5b6758a by Serhiy Storchaka in branch 'master': bpo-28450: Fix and improve the documentation for unknown escapes in RE. (GH-11920)

[issue36048] Deprecate implicit truncating when convert Python numbers to C integers: use __index__, not __int__

2019-02-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 6a44f6eef3d0958d2347190b3e2d1222c2e9 by Serhiy Storchaka in branch 'master': bpo-36048: Use __index__() instead of __int__() for implicit conversion if available. (GH-11952)

[issue36103] Increase shutil.COPY_BUFSIZE

2019-02-25 Thread Inada Naoki
Inada Naoki added the comment: > Your first link explains why 128kB buffer size is faster in the context of > cp: it's due to fadvise and kernel read ahead. > > None of the shutil functions call fadvise, so the benchmark and conclusions > are irrelevant to the Python buffer size IMO. Even

[issue36106] resolve sinpi() name clash with libm

2019-02-25 Thread Emmanuel Arias
Change by Emmanuel Arias : -- nosy: +eamanu ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36105] Windows: use GetNativeSystemInfo instead of GetSystemInfo

2019-02-25 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: It appears you guys are right. Sorry for the noise. -- ___ Python tracker ___ ___

[issue36102] TestSharedMemory fails on AMD64 FreeBSD CURRENT Shared 3.x

2019-02-25 Thread Davin Potts
Davin Potts added the comment: In local testing, I found the following systems to impose the leading slash as a requirement for simply creating a shared memory block: * NetBSD 8.0 * FreeBSD 12.x * TrueOS 18.12 (the OS formerly known as PC-BSD) I found the following systems to have no

[issue36030] add internal API function to create tuple without items array initialization

2019-02-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This change is virtually renaming _PyStack_AsTuple to _PyTuple_FromArray and using it in appropriate places for code simplification. I am +1 for such change. -- ___ Python tracker

[issue36106] resolve sinpi() name clash with libm

2019-02-25 Thread Dmitrii Pasechnik
Dmitrii Pasechnik added the comment: e.g. if I rename `m_lgamma` to `lgamma` I get ``` mathmodule.c:389:1: error: static declaration of ‘lgamma’ follows non-static declaration lgamma(double x) ``` -- ___ Python tracker

[issue36106] resolve sinpi() name clash with libm

2019-02-25 Thread Dmitrii Pasechnik
Dmitrii Pasechnik added the comment: This has a potential header conflict. For the same reason functions like lgamma, etc. are prefixed with `m_` in Modules/mathmodule.c -- ___ Python tracker

[issue36105] Windows: use GetNativeSystemInfo instead of GetSystemInfo

2019-02-25 Thread Steve Dower
Steve Dower added the comment: Yeah, possibly only the CPU count one could change, but there's an ongoing discussion on another bug about whether that should return the actual count or the usable count. 32-bit processes have restrictions beyond what the system is capable of, and I believe

[issue30782] Allow limiting the number of concurrent tasks in asyncio.as_completed

2019-02-25 Thread Andrey Paramonov
Andrey Paramonov added the comment: > an implicit requirement that back pressure from the consumer should be > handled (i.e. if whoever's iterating through "async for fut in > as_completed(...)" is too slow, then the tasks should pause until it catches > up) No, I don't think it is

[issue36106] resolve sinpi() name clash with libm

2019-02-25 Thread Emmanuel Arias
Emmanuel Arias added the comment: Hi!, It seem a good improve to resolve a potential problem. But I am not convinced if that problem could appear because sinpi() is definded locally. -- ___ Python tracker

[issue36078] argparse: positional with type=int, default=SUPPRESS raise ValueError

2019-02-25 Thread Axel
Axel added the comment: Thanks for so fast looking into this. Good idea to use the workaround with a own conversion function. I'll use this for now. To see what's happening, I tried a own Action with print in __call__ and a own conversion function with printing. I found following workflow:

[issue36103] Increase shutil.COPY_BUFSIZE

2019-02-25 Thread desbma
desbma added the comment: Your first link explains why 128kB buffer size is faster in the context of cp: it's due to fadvise and kernel read ahead. None of the shutil functions call fadvise, so the benchmark and conclusions are irrelevant to the Python buffer size IMO. In general, the

[issue36104] test_httplib and test_nntplib fail on ARMv7 Ubuntu

2019-02-25 Thread STINNER Victor
Change by STINNER Victor : -- stage: needs patch -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list

[issue36102] TestSharedMemory fails on AMD64 FreeBSD CURRENT Shared 3.x

2019-02-25 Thread Davin Potts
Davin Potts added the comment: Though apparently undocumented on FreeBSD, their implementation of shm_open differs from others in the following way: all names for shared memory blocks *must* begin with a slash. This requirement does not exist on OpenBSD. According to its man page on

[issue35925] test_httplib test_nntplib test_ssl fail on ARMv7 Debian buster bot (OpenSSL 1.1.1a)

2019-02-25 Thread STINNER Victor
STINNER Victor added the comment: Lukasz: this issue is that Debian Buster uses a strict OpenSSL policy. I guess that external public server used by tests are incompatible with this strict policy. -- nosy: +lukasz.langa ___ Python tracker

[issue35925] test_httplib test_nntplib test_ssl fail on ARMv7 Debian buster bot (OpenSSL 1.1.1a)

2019-02-25 Thread STINNER Victor
STINNER Victor added the comment: bpo-36104 has been marked as a duplicate of this issue. Copy of Lukasz's msg336511: The ARMv7 Ubuntu buildbot is consistently failing since build #2160: https://buildbot.python.org/all/#/builders/106/builds/2160 This looks like a testing environment issue

[issue36104] test_httplib and test_nntplib fail on ARMv7 Ubuntu

2019-02-25 Thread STINNER Victor
Change by STINNER Victor : -- resolution: -> duplicate superseder: -> test_httplib test_nntplib test_ssl fail on ARMv7 Debian buster bot (OpenSSL 1.1.1a) ___ Python tracker

[issue36106] resolve sinpi() name clash with libm

2019-02-25 Thread SilentGhost
Change by SilentGhost : -- nosy: +mark.dickinson stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue36106] resolve sinpi() name clash with libm

2019-02-25 Thread Dmitrii Pasechnik
New submission from Dmitrii Pasechnik : The standard math library (libm) may follow IEEE-754 recommendation to include an implementation of sinPi(), i.e. sinPi(x):=sin(pi*x). And this triggers a name clash, found by FreeBSD developer Steve Kargl, who worken on putting sinpi into libm used on

[issue36104] test_httplib and test_nntplib fail on ARMv7 Ubuntu

2019-02-25 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +pablogsal, vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue36104] test_httplib and test_nntplib fail on ARMv7 Ubuntu

2019-02-25 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Related to issue35925 ? -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list

[issue32129] Icon on macOS

2019-02-25 Thread Kevin Walzer
Kevin Walzer added the comment: Is there any reason not to commit the patch I submitted to address this issue?As an alternative I can submit a high-res PNG that can be used, and will submit a different patch to incorporate it, which would work from either the standard app bundle or the

[issue33671] Efficient zero-copy for shutil.copy* functions (Linux, OSX and Win)

2019-02-25 Thread STINNER Victor
STINNER Victor added the comment: > Yes, it's deliberate, see PR-12016. "I decided not to document `shutil.COPY_BUFSIZE` because I consider it a corner case." Ok. I have no opinion on that, I just wanted to ask the question :-) -- ___ Python

[issue35810] Object Initialization does not incref Heap-allocated Types

2019-02-25 Thread Eddie Elizondo
Eddie Elizondo added the comment: > could we just remove the whole concept of heap allocated types? I do have plans to start migrating more and more CPython modules to use heap allocated types. For example I have posixmodule up in the queue (PR10854) and a local change with all of _io

[issue33671] Efficient zero-copy for shutil.copy* functions (Linux, OSX and Win)

2019-02-25 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: Yes, it's deliberate, see PR-12016. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue36105] Windows: use GetNativeSystemInfo instead of GetSystemInfo

2019-02-25 Thread Ronald Oussoren
Ronald Oussoren added the comment: I guess it depends on what the information is used for. From a quick glance at the code I'd say that the current usage is correct, and that GetNativeSystemInfo could be used when reporting about the currently running system (for example by functions in the

[issue36105] Windows: use GetNativeSystemInfo instead of GetSystemInfo

2019-02-25 Thread Giampaolo Rodola'
New submission from Giampaolo Rodola' : This is what MS doc says about GetSystemInfo: https://docs.microsoft.com/en-us/windows/desktop/api/sysinfoapi/nf-sysinfoapi-getsysteminfo <> $ grep -r GetSystemInfo Modules/_ctypes/malloc_closure.c:GetSystemInfo(); Modules/mmapmodule.c:

[issue36104] test_httplib and test_nntplib fail on ARMv7 Ubuntu

2019-02-25 Thread Łukasz Langa
New submission from Łukasz Langa : The ARMv7 Ubuntu buildbot is consistently failing since build #2160: https://buildbot.python.org/all/#/builders/106/builds/2160 This looks like a testing environment issue to me rather than a code issue. But I'd like it fixed either way before we get to

[issue35886] Move PyInterpreterState into Include/internal/pycore_pystate.h

2019-02-25 Thread Nathaniel Smith
Nathaniel Smith added the comment: The cffi issue is: https://bitbucket.org/cffi/cffi/issues/403/build-fails-on-38-dev-pyinterpreterstate Armin already went ahead and committed the change to make cffi include internal/pycore_pystate.h. I guess this might not be the ideal final outcome

[issue36093] UnicodeEncodeError raise from smtplib.verify() method

2019-02-25 Thread STINNER Victor
STINNER Victor added the comment: Barry: would you mind to have a look at this issue? It seems like smtplib encodes Unicode commands to ASCII, whereas verify() argument (SMTP "VRFY" command) is an hostname and hostname can be non-ASCII ("punycode" encoding, RFC 3492). -- nosy:

[issue34656] [CVE-2018-20406] memory exhaustion in Modules/_pickle.c:1393

2019-02-25 Thread STINNER Victor
STINNER Victor added the comment: As I wrote in my previous comment, I don't think that Python 2.7 is affected by this issue. -- components: +Library (Lib) -ctypes versions: +Python 3.4, Python 3.5, Python 3.6, Python 3.7, Python 3.8 -Python 2.7

[issue10308] Modules/getpath.c bugs

2019-02-25 Thread STINNER Victor
STINNER Victor added the comment: I reviewed getpath.diff: diff -pru Python-2.7/Modules/getpath.c Python-2.7/Modules/getpath.c --- Python-2.7/Modules/getpath.c +++ Python-2.7/Modules/getpath.c @@ -218,7 +218,7 @@ joinpath(char *buffer, char *stuff) if (n > MAXPATHLEN)

[issue35886] Move PyInterpreterState into Include/internal/pycore_pystate.h

2019-02-25 Thread STINNER Victor
STINNER Victor added the comment: > This broke cffi: Well, that's not a surprise :-) It's a deliberate backward incompatible change. But that's where I suggested to test "popular C extensions" with a C API change before merging it. It's ok if issues are discovered later, but the author of

[issue36103] Increase shutil.COPY_BUFSIZE

2019-02-25 Thread Inada Naoki
New submission from Inada Naoki : shutil.COPY_BUFSIZE is 16KiB on non-Windows platform. But it seems bit small for performance. As this article[1], 128KiB is the best performance on common system. [1]: https://eklitzke.org/efficient-file-copying-on-linux Another resource: EBS document [2]

[issue36103] Increase

2019-02-25 Thread Inada Naoki
Change by Inada Naoki : -- nosy: inada.naoki priority: normal severity: normal status: open title: Increase ___ Python tracker ___

[issue29659] Expose the `length` arg from shutil.copyfileobj for public use

2019-02-25 Thread Inada Naoki
Inada Naoki added the comment: bpo-33671 fixed this. -- resolution: -> fixed stage: test needed -> resolved status: open -> closed versions: +Python 3.8 -Python 3.7 ___ Python tracker

[issue36102] TestSharedMemory fails on AMD64 FreeBSD CURRENT Shared 3.x

2019-02-25 Thread STINNER Victor
New submission from STINNER Victor : TestSharedMemory fails on AMD64 FreeBSD CURRENT Shared 3.x: * The tests should be skipped on this buildbot worker * Or the feature should be fixed on FreeBSD https://buildbot.python.org/all/#/builders/168/builds/617 Example: ERROR:

[issue33671] Efficient zero-copy for shutil.copy* functions (Linux, OSX and Win)

2019-02-25 Thread STINNER Victor
STINNER Victor added the comment: shutil.COPY_BUFSIZE isn't documented. Is it a deliberate choice? https://docs.python.org/dev/library/shutil.html -- ___ Python tracker ___

<    1   2