[issue37337] Add _PyObject_VectorcallMethod() function

2019-08-13 Thread Inada Naoki
Inada Naoki added the comment: New changeset 43d564c18c97421f73025ac3132a194975c76bd6 by Inada Naoki (Zackery Spytz) in branch 'master': bpo-37337: Fix a GCC 9 warning in Objects/descrobject.c (GH-14814) https://github.com/python/cpython/commit/43d564c18c97421f73025ac3132a194975c76bd6

[issue28747] Expose SSL_CTX_set_cert_verify_callback

2019-08-13 Thread Chih-Hsuan Yen
Change by Chih-Hsuan Yen : -- nosy: -yan12125 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37846] declare that Text I/O use buffer inside

2019-08-13 Thread Inada Naoki
Inada Naoki added the comment: It's just an implementation detail. Python implementation and C implementation behave slightly different. But user program shouldn't rely on the detail. Why do you think implementation details should be declared? Who needs the information? -- nosy:

[issue37848] More fully implement Unicode's case mappings

2019-08-13 Thread Greg Price
New submission from Greg Price : Splitting this out from #32771 for more specific discussion. Benjamin writes there that it would be good to: > implement the locale-specific case mappings of > https://www.unicode.org/Public/UCD/latest/ucd/SpecialCasing.txt and §3.13 of > the Unicode 12

[issue28747] Expose SSL_CTX_set_cert_verify_callback

2019-08-13 Thread Marcelo Salhab Brogliato
Marcelo Salhab Brogliato added the comment: Exposing SSL_CTX_set_cert_verify_callback is useful when we want to use a Public Key Authentication, like it is done in the SSH Protocol. Do you know any other way to use Public Key Authentication besides using SSL_CTX_set_cert_verify_callback?

[issue33012] Invalid function cast warnings with gcc 8 for METH_NOARGS

2019-08-13 Thread Zackery Spytz
Change by Zackery Spytz : -- pull_requests: +14986 pull_request: https://github.com/python/cpython/pull/14814 ___ Python tracker ___

[issue37845] SLCertVerificationError: Unable to handle SAN names (from Certifications) published with white spaces at start

2019-08-13 Thread Christian Heimes
Christian Heimes added the comment: This is not a bug in Python but a misconfiguration on your side. A workaround for a misconfiguration doesn't belong into upstream code. The certificate validation code is security-sensitive and I don't feel comfortable to add unnecessary string

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-13 Thread Greg Price
Change by Greg Price : -- pull_requests: +14985 pull_request: https://github.com/python/cpython/pull/15265 ___ Python tracker ___

[issue17305] IDNA2008 encoding is missing

2019-08-13 Thread Christian Heimes
Christian Heimes added the comment: You have to ask the Chrome team. -- versions: +Python 3.8 ___ Python tracker ___ ___

[issue17305] IDNA2008 encoding is missing

2019-08-13 Thread Ashwin Ramaswami
Ashwin Ramaswami added the comment: Why would chrome still be using IDNA 2003 to link http://straße.de to http://strasse.de? -- ___ Python tracker ___

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-13 Thread Greg Price
Greg Price added the comment: > From my perspective, the main problem with using type annotations is that > there's nothing checking them in CI. Yeah, fair concern. In fact I think I'm on video (from PyCon 2018) warning everyone not to do that in their codebases, because what you really

[issue17305] IDNA2008 encoding is missing

2019-08-13 Thread Ashwin Ramaswami
Change by Ashwin Ramaswami : -- nosy: +epicfaace versions: +Python 3.9 -Python 3.8 ___ Python tracker ___ ___ Python-bugs-list

[issue33661] urllib may leak sensitive HTTP headers to a third-party web site

2019-08-13 Thread Ashwin Ramaswami
Ashwin Ramaswami added the comment: Martin, are you okay with doing this? It seems like this issue has been the topic of a few CVEs (https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-20060, https://cve.mitre.org/cgi-bin/cvename.cgi?name=2018-18074,

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

2019-08-13 Thread Ashwin Ramaswami
Ashwin Ramaswami added the comment: Can this be closed now? -- nosy: +epicfaace ___ Python tracker ___ ___ Python-bugs-list

[issue37847] The IDLE does not show previous code suggestions if I tap on the up arrow

2019-08-13 Thread Edwin Pratt
New submission from Edwin Pratt : If I am typing some Python code in the IDLE, for example a function: def sayHi(name): print('Hello ', name) and I execute the function: sayHi('Ed') I can not edit the function or execute a previous line of code again if I tap the up arrow on my

[issue32423] The Windows SDK version 10.0.15063.0 was not found

2019-08-13 Thread Isuru Fernando
Isuru Fernando added the comment: Fixed in https://github.com/python/cpython/pull/12445 -- stage: -> resolved status: open -> closed ___ Python tracker ___

[issue29535] datetime hash is deterministic in some cases

2019-08-13 Thread Ashwin Ramaswami
Ashwin Ramaswami added the comment: I've added a PR which should fix this. Do you think the documentation should also be updated to change "By default, the :meth:`__hash__` values of str, bytes and datetime objects are "salted" with an unpredictable random value." to "By default, the

[issue37811] [FreeBSD, OSX] Socket module: incorrect usage of poll(2)

2019-08-13 Thread Artem Khramov
Change by Artem Khramov : -- components: +FreeBSD, IO, Library (Lib), macOS nosy: +ned.deily, ronaldoussoren ___ Python tracker ___

[issue37821] IDLE shell uses wrong namespace for completions

2019-08-13 Thread Terry J. Reedy
Terry J. Reedy added the comment: The current behavior is the quick and easy/dirty solution that we have, not what we especially want. #27609 has multiple issues and ideas for completion improvements. I made testing and improving the code priorities before worrying about most of the

[issue37846] declare that Text I/O use buffer inside

2019-08-13 Thread Windson Yang
New submission from Windson Yang : At the beginning of https://docs.python.org/3.7/library/io.html#io.RawIOBase, we declared that > Binary I/O (also called buffered I/O) and > Raw I/O (also called unbuffered I/O) But we didn't mention if Text I/O use buffer or not which led to confusion.

[issue37757] TargetScopeError not raised for comprehension scope conflict

2019-08-13 Thread Nick Coghlan
Nick Coghlan added the comment: The outcome of the python-dev discussion was that we agreed to switch to raising a plain SyntaxError, as that's what we do everywhere else that this kind of problem comes up (e.g. conflicts between global and nonlocal declarations, or between those and

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-13 Thread Benjamin Peterson
Benjamin Peterson added the comment: New changeset c03e698c344dfc557555b6b07a3ee2702e45f6ee by Benjamin Peterson (Greg Price) in branch 'master': bpo-37760: Factor out standard range-expanding logic in makeunicodedata. (GH-15248)

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-13 Thread Benjamin Peterson
Benjamin Peterson added the comment: >From my perspective, the main problem with using type annotations is that >there's nothing checking them in CI. -- ___ Python tracker

[issue32771] merge the underlying data stores of unicodedata and the str type

2019-08-13 Thread Benjamin Peterson
Benjamin Peterson added the comment: The goal is to implement the locale-specific case mappings of https://www.unicode.org/Public/UCD/latest/ucd/SpecialCasing.txt and §3.13 of the Unicode 12 standard in str.lower/upper/casefold. To do this, you need access to certain character properties

[issue37831] bool(~True) == True

2019-08-13 Thread Raymond Hettinger
Raymond Hettinger added the comment: Essentially we've got two competing desires: * Given that & | and ^ are closed under bools, it would be nice for ~ to be closed as well. NOT isn't a reasonable alternative because of its operator precedence. * Given that bool is a subclass of int,

[issue37256] urllib.request.Request documentation erroneously refers to the "final two"

2019-08-13 Thread Senthil Kumaran
Senthil Kumaran added the comment: New changeset 38c7199beb30ae9a5005c0f0d9df9fae0da3680a by Senthil Kumaran (Ngalim Siregar) in branch 'master': bpo-37256: Wording in Request class docs (#14792) https://github.com/python/cpython/commit/38c7199beb30ae9a5005c0f0d9df9fae0da3680a --

[issue29535] datetime hash is deterministic in some cases

2019-08-13 Thread Ashwin Ramaswami
Change by Ashwin Ramaswami : -- keywords: +patch pull_requests: +14983 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15264 ___ Python tracker

[issue37834] readlink on Windows cannot read app exec links

2019-08-13 Thread Steve Dower
Steve Dower added the comment: > I'm wary of trying to return it without the prefix. Me too, but suddenly adding "\\?\" to the paths breaks a lot of assumptions. > We would need a function that's shared with the proposed implementation of > realpath() to determine whether the given path

[issue21131] test_faulthandler.test_register_chain fails on 64bit ppc/arm with kernel >= 3.10

2019-08-13 Thread Bennet Fauber
Bennet Fauber added the comment: Perhaps I should add, that we are able to reproduce this behavior on this hardware Dell R640 Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz Dell R740 Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz Dell R440 Intel(R) Xeon(R) Silver 4116 CPU @ 2.10GHz Dell C6420 Intel(R)

[issue25172] Unix-only crypt should not be present on Windows.

2019-08-13 Thread Srinivas Nyayapati
Srinivas Nyayapati added the comment: Thank you Steve for accepting my pull requests. I was surprised to see the methods in the class and its decorators getting evaluated and causing the failures initially, but I then realized that the code is parsed before execution and that's when I was

[issue25172] Unix-only crypt should not be present on Windows.

2019-08-13 Thread miss-islington
miss-islington added the comment: New changeset e7ec9e04c82be72aef621fdfba03f41cbd8599aa by Miss Islington (bot) in branch '3.8': bpo-25172: Add test for crypt ImportError on Windows (GH-15252) https://github.com/python/cpython/commit/e7ec9e04c82be72aef621fdfba03f41cbd8599aa --

[issue37834] readlink on Windows cannot read app exec links

2019-08-13 Thread Eryk Sun
Eryk Sun added the comment: > Until then, I think it makes sense for os.readlink() to handle the > prefix and _getfinalpathname() call, but leave nt.readlink() as > returning the raw value. os.readlink() shouldn't resolve the final path or realpath(). It should simply return the link

[issue25172] Unix-only crypt should not be present on Windows.

2019-08-13 Thread Steve Dower
Steve Dower added the comment: Thanks for the patches, Srinivas! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue25172] Unix-only crypt should not be present on Windows.

2019-08-13 Thread miss-islington
miss-islington added the comment: New changeset 7f7f74734acd729d1f82b7cf672e064c9525fced by Miss Islington (bot) in branch '3.8': bpo-25172: Raise appropriate ImportError msg when crypt module used on Windows (GH-15149)

[issue25172] Unix-only crypt should not be present on Windows.

2019-08-13 Thread miss-islington
Change by miss-islington : -- pull_requests: +14982 pull_request: https://github.com/python/cpython/pull/15263 ___ Python tracker ___

[issue25172] Unix-only crypt should not be present on Windows.

2019-08-13 Thread Steve Dower
Steve Dower added the comment: New changeset 243a73deee4ac61fe06602b7ed56b6df01e19f27 by Steve Dower (shireenrao) in branch 'master': bpo-25172: Add test for crypt ImportError on Windows (GH-15252) https://github.com/python/cpython/commit/243a73deee4ac61fe06602b7ed56b6df01e19f27 --

[issue37834] readlink on Windows cannot read app exec links

2019-08-13 Thread Steve Dower
Steve Dower added the comment: I think we'll want issue9949 merged as well, so that ntpath.realpath() does its job. Certainly the tests would benefit from it. Until then, I think it makes sense for os.readlink() to handle the prefix and _getfinalpathname() call, but leave nt.readlink() as

[issue29535] datetime hash is deterministic in some cases

2019-08-13 Thread Armin Rigo
Change by Armin Rigo : -- nosy: -arigo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37834] readlink on Windows cannot read app exec links

2019-08-13 Thread Eryk Sun
Eryk Sun added the comment: > Replacing "\??\" with "\\?\" in place is trivial though, as we start > with a mutable buffer. I'm just not clear that it's as simple as that, > though. If the path starts with "\\??\\" we can just change the first question mark to a backslash. For a symlink,

[issue32771] merge the underlying data stores of unicodedata and the str type

2019-08-13 Thread Greg Price
Greg Price added the comment: Speaking of improving functionality: > Having unicodedata readily accessible to the str type would also permit > higher a fidelity unicode implementation. For example, implementing > language-tailored str.lower() requires having canonical combining class of a

[issue25172] Unix-only crypt should not be present on Windows.

2019-08-13 Thread Srinivas Nyayapati
Srinivas Nyayapati added the comment: Thank you @paul.moore -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue32771] merge the underlying data stores of unicodedata and the str type

2019-08-13 Thread Greg Price
Greg Price added the comment: > Loading it dynamically reduces the memory footprint. Ah, this is a good question to ask! First, FWIW on my Debian buster desktop I get a smaller figure for `import unicodedata`: only 64 kiB. $ python Python 3.7.3 (default, Apr 3 2019, 05:39:12) [GCC 8.3.0]

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-13 Thread Greg Price
Greg Price added the comment: > This is good. But the title mentioned dataclasses, and they are 3.7+. Ahh, sorry, I think now I understand you. :-) Indeed, when I switch to the branch with that change (https://github.com/gnprice/cpython/commit/2b4aec4dd -- it comes after the patch that's

[issue37689] Add Path.is_relative_to()

2019-08-13 Thread Antoine Pitrou
Change by Antoine Pitrou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue37689] Add Path.is_relative_to()

2019-08-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: New changeset 82642a052dc46b2180679518bc8d87e1a28a88b5 by Antoine Pitrou (Hai Shi) in branch 'master': bpo-37689: add Path.is_relative_to() method (GH-14982) https://github.com/python/cpython/commit/82642a052dc46b2180679518bc8d87e1a28a88b5 --

[issue37834] readlink on Windows cannot read app exec links

2019-08-13 Thread Eryk Sun
Eryk Sun added the comment: > I feel like that's more work than is worth us doing for something that > will be relatively rarely used, will live in the stdlib, and is > obviously something that will become outdated as Microsoft adds new > reparse points. Junctions (NT 5) and symlinks (NT

[issue37814] typing module: empty tuple syntax is undocumented

2019-08-13 Thread miss-islington
miss-islington added the comment: New changeset 37fd9f73e2fa439554977cfba427bf94c1fedb6b by Miss Islington (bot) (Josh Holland) in branch '3.7': [3.7] bpo-37814: Document the empty tuple type annotation syntax (GH-15208) (GH-15262)

[issue29535] datetime hash is deterministic in some cases

2019-08-13 Thread Ashwin Ramaswami
Change by Ashwin Ramaswami : -- nosy: +epicfaace versions: +Python 3.8, Python 3.9 ___ Python tracker ___ ___ Python-bugs-list

[issue37814] typing module: empty tuple syntax is undocumented

2019-08-13 Thread Josh Holland
Change by Josh Holland : -- pull_requests: +14981 pull_request: https://github.com/python/cpython/pull/15262 ___ Python tracker ___

[issue37814] typing module: empty tuple syntax is undocumented

2019-08-13 Thread Guido van Rossum
Guido van Rossum added the comment: Thanks Josh! The automated backport to 3.7 didn't work, that's okay, so I'll close this now. (Though if you want to experiment with the cherry-picker tool go ahead.) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue35669] tar symlink

2019-08-13 Thread Ashwin Ramaswami
Ashwin Ramaswami added the comment: I believe the SafeTarFile class proposed in issue21109 fixes this. -- nosy: +epicfaace ___ Python tracker ___

[issue37814] typing module: empty tuple syntax is undocumented

2019-08-13 Thread miss-islington
miss-islington added the comment: New changeset 6ad902a08814909b4d52c4000d5a10ce58516dac by Miss Islington (bot) in branch '3.8': bpo-37814: Document the empty tuple type annotation syntax (GH-15208) https://github.com/python/cpython/commit/6ad902a08814909b4d52c4000d5a10ce58516dac

[issue37814] typing module: empty tuple syntax is undocumented

2019-08-13 Thread miss-islington
Change by miss-islington : -- pull_requests: +14980 pull_request: https://github.com/python/cpython/pull/15261 ___ Python tracker ___

[issue37814] typing module: empty tuple syntax is undocumented

2019-08-13 Thread miss-islington
miss-islington added the comment: New changeset 8a784af750fa82c8355903309e5089eb2b60c16b by Miss Islington (bot) (Josh Holland) in branch 'master': bpo-37814: Document the empty tuple type annotation syntax (GH-15208)

[issue37830] continue and break in finally with return in try results with segfault

2019-08-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There may be a solution that does not require a significant change to the code generator, but small changes in many places with keeping the general structure. But it is a difficult task, so it takes some time. Don't worry, I'm working on it. --

[issue21131] test_faulthandler.test_register_chain fails on 64bit ppc/arm with kernel >= 3.10

2019-08-13 Thread Bennet Fauber
Bennet Fauber added the comment: One additional note on this. Thanks to a colleague at USC who pointed out that this bug does not seem to get exercised if one does not include `--enable-shared` at configuration. I confirmed this using the distributed Python-3.7.4.tgz file and `configure

[issue37845] SLCertVerificationError: Unable to handle SAN names (from Certifications) published with white spaces at start

2019-08-13 Thread David K.
Change by David K. : -- keywords: +patch pull_requests: +14979 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15260 ___ Python tracker ___

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > I just checked and `python3.6 Tools/unicode/makeunicodedata.py` works fine, > both at master and with GH-15248. This is good. But the title mentioned dataclasses, and they are 3.7+. -- ___ Python tracker

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-13 Thread Greg Price
Greg Price added the comment: > What is the minimal Python version for developing CPython? The system Python > 3 on current Ubuntu LTS (18.04) is 3.6, so I think it should not be larger. Ah, I think my previous message had an ambiguous parse: the earliest that *uses* of the typing module

[issue37834] readlink on Windows cannot read app exec links

2019-08-13 Thread Steve Dower
Steve Dower added the comment: Latest PR update uses GetFinalPathName to resolve SubstituteName, returning it unmodified on failure (e.g. symlink where the target file no longer exists). Replacing "\??\" with "\\?\" in place is trivial though, as we start with a mutable buffer. I'm just not

[issue37845] SLCertVerificationError: Unable to handle SAN names (from Certifications) published with white spaces at start

2019-08-13 Thread David K.
New submission from David K. : Unable to establish SSL connections using company's private certificates where their SANs (Subject Alternative Names) contain at least one DNS Name that starts with white spaces. Attempting to establish SSL connection would result in Exception:

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: What is the minimal Python version for developing CPython? The system Python 3 on current Ubuntu LTS (18.04) is 3.6, so I think it should not be larger. -- nosy: +serhiy.storchaka ___ Python tracker

[issue37844] PyRun_SimpleFile should provide a version that does not need a FILE*

2019-08-13 Thread Christian Biesinger
New submission from Christian Biesinger : Because FILE* requires that the runtime library matches between Python and a program using it, it is very hard to use this correctly on Windows. It would be nice if Python provided either: - A function to open a FILE* given a filename, suitable for

[issue37834] readlink on Windows cannot read app exec links

2019-08-13 Thread Steve Dower
Steve Dower added the comment: > If we support reading junctions, this should be using the substitute name > (with \??\ replaced by \\?\) instead of the print name. GetFinalPathName() does this conversion for us, any reason not to use that? (GetFullPathName() doesn't seem to recognize the

[issue37583] Got a 113 error when running the test_socket

2019-08-13 Thread miss-islington
miss-islington added the comment: New changeset ee989512528d178d6f088916aba3e67ea9487ceb by Miss Islington (bot) in branch '3.8': bpo-37583: Add err 113 to support.get_socket_conn_refused_errs() (GH-14729) https://github.com/python/cpython/commit/ee989512528d178d6f088916aba3e67ea9487ceb

[issue37813] PEP 7 line-breaking with binary operations contradicts Knuth's rule

2019-08-13 Thread Guido van Rossum
Guido van Rossum added the comment: PEP 8 intentionally allows users to choose whether to put the operator at the start or end of the line (as long as they're consistent within a file or project). This is to avoid a barrage of "style fixes" that are just noise. But PEP 7 is only for

[issue37838] typing.get_type_hints not working with forward-declaration and decorated functions

2019-08-13 Thread Netzeband
Netzeband added the comment: Thanks for your feedback. I can create a pull-request. However, I did it never before for the Python-Lib, so I first have to setup the correct environment for that and ensure, that I can run all test-cases. Since I'm on vacation soon, it could take several

[issue37583] Got a 113 error when running the test_socket

2019-08-13 Thread hai shi
Change by hai shi : -- pull_requests: +14978 pull_request: https://github.com/python/cpython/pull/15259 ___ Python tracker ___ ___

[issue37841] Python store app launcher has dependency on msvcp140.dll

2019-08-13 Thread miss-islington
miss-islington added the comment: New changeset 853eecc7692503fec8240fd9a74d9f88e0392630 by Miss Islington (bot) in branch '3.8': bpo-37841: Remove python_uwp dependency on msvcp140.dll (GH-15253) https://github.com/python/cpython/commit/853eecc7692503fec8240fd9a74d9f88e0392630 --

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-13 Thread Greg Price
Greg Price added the comment: > BTW: Since when do we use type annotations in Python's stdlib ? Hmm, interesting question! At a quick grep, it's in a handful of places in the stdlib: asyncio, functools, importlib. The earliest it appeared was in 3.7.0a4. It's in more places in the test

[issue37834] readlink on Windows cannot read app exec links

2019-08-13 Thread Steve Dower
Steve Dower added the comment: > I looked into this spawn problem. It's due to Cygwin's spawnve, which calls > NtOpenFile to open the file, and then memory-maps it and reads the image > header [1]. Great, that's roughly what I suspected. Unfortunately, I've been told that looking into

[issue37583] Got a 113 error when running the test_socket

2019-08-13 Thread miss-islington
Change by miss-islington : -- pull_requests: +14977 pull_request: https://github.com/python/cpython/pull/15258 ___ Python tracker ___

[issue37841] Python store app launcher has dependency on msvcp140.dll

2019-08-13 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved ___ Python tracker ___ ___ Python-bugs-list

[issue37583] Got a 113 error when running the test_socket

2019-08-13 Thread STINNER Victor
STINNER Victor added the comment: New changeset 1ac2a83f30312976502fda042db5ce18d10ceec2 by Victor Stinner (Hai Shi) in branch 'master': bpo-37583: Add err 113 to support.get_socket_conn_refused_errs() (GH-14729)

[issue37841] Python store app launcher has dependency on msvcp140.dll

2019-08-13 Thread miss-islington
Change by miss-islington : -- pull_requests: +14976 pull_request: https://github.com/python/cpython/pull/15257 ___ Python tracker ___

[issue37841] Python store app launcher has dependency on msvcp140.dll

2019-08-13 Thread Steve Dower
Steve Dower added the comment: New changeset b0dace3e979381426385c551b116d0f1434096ee by Steve Dower in branch 'master': bpo-37841: Remove python_uwp dependency on msvcp140.dll (GH-15253) https://github.com/python/cpython/commit/b0dace3e979381426385c551b116d0f1434096ee --

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-08-13 Thread Greg Price
Greg Price added the comment: > I like to run pyflakes time to time on the Python code base. Please avoid > "import *" since it prevents pyflakes (and other code analyzers) to find bugs. Ah fair enough, thanks! Pushed that change to the next/current PR, GH-15248. --

[issue37813] PEP 7 line-breaking with binary operations contradicts Knuth's rule

2019-08-13 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- versions: -Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37813] PEP 7 line-breaking with binary operations contradicts Knuth's rule

2019-08-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: PEP 8 contains contradictory examples. https://www.python.org/dev/peps/pep-0008/#indentation > # No extra indentation. > if (this_is_one_thing and > that_is_another_thing): > do_something() > > # Add a comment, which will

[issue37813] PEP 7 line-breaking with binary operations contradicts Knuth's rule

2019-08-13 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I personally don't think we need to change this. C and Python are different, and the PEP 7 rules have been in place for ages. +Guido -- nosy: +gvanrossum ___ Python tracker

[issue37843] CGIHTTPRequestHandler does not take args.directory in constructor

2019-08-13 Thread Richard Jayne
New submission from Richard Jayne : In Lib/http/server.py if args.cgi: handler_class = CGIHTTPRequestHandler else: handler_class = partial(SimpleHTTPRequestHandler, directory=args.directory) Notice that CGIHTTPRequestHandler does not

[issue37813] PEP 7 line-breaking with binary operations contradicts Knuth's rule

2019-08-13 Thread Brett Cannon
Change by Brett Cannon : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25299] TypeError: __init__() takes at least 4 arguments (4 given)

2019-08-13 Thread paul j3
paul j3 added the comment: I'm not set up to work with the current development distribution (via github). All my proposed patches are diffs for earlier repos. Paul -- ___ Python tracker

[issue21109] tarfile: Traversal attack vulnerability

2019-08-13 Thread Ashwin Ramaswami
Ashwin Ramaswami added the comment: SafeTarFile does not pass the existing tests, mainly because the existing file Lib/test/tarfiletestdata/testtar.tar seems to be "unsafe", producing errors like these: tarfile.SecurityError: : block device tarfile.SecurityError: : duplicate name It

[issue37842] Initialize Py_buffer variables more efficiently

2019-08-13 Thread Sergey Fedoseev
Change by Sergey Fedoseev : -- keywords: +patch pull_requests: +14975 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15254 ___ Python tracker ___

[issue37842] Initialize Py_buffer variables more efficiently

2019-08-13 Thread Sergey Fedoseev
New submission from Sergey Fedoseev : Argument Clinic generates `{NULL, NULL}` initializer for Py_buffer variables. Such initializer zeroes all Py_buffer members, but as I understand only `obj` and `buf` members are really had to be initialized. Avoiding unneeded initialization provides tiny

[issue37838] typing.get_type_hints not working with forward-declaration and decorated functions

2019-08-13 Thread Guido van Rossum
Guido van Rossum added the comment: Maybe we should tag this issue "newcomer friendly"? It seems a pretty open and shut case. -- ___ Python tracker ___

[issue37838] typing.get_type_hints not working with forward-declaration and decorated functions

2019-08-13 Thread Ivan Levkivskyi
Ivan Levkivskyi added the comment: > Using `__wrapped__` if present sounds like a good idea. Yeah, I like this idea, this will likely cover most use cases (since most people actually do use @wraps). -- ___ Python tracker

[issue37830] continue and break in finally with return in try results with segfault

2019-08-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Note, that we have a regression in 3.8. There is a use case for "break" in "finally", and such code is even used in the stdlib. And who know in what third-party code it is used. In specific circumstances (see msg349513) it now can cause a crash. Other

[issue37830] continue in finally with return in try results with segfault

2019-08-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Batuhan, unfortunately your second solution does not work too, because continue and break can be conditional. For example: def simple(x): for number in range(2): try: return number finally: if x:

[issue37841] Python store app launcher has dependency on msvcp140.dll

2019-08-13 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +14974 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/15253 ___ Python tracker

[issue37841] Python store app launcher has dependency on msvcp140.dll

2019-08-13 Thread Steve Dower
New submission from Steve Dower : A change made to the python_uwp.vcxproj (or more likely the .cpp file) has introduced a runtime dependency on msvcp140.dll. As we don't distribute this dependency, and it is not always installed by default, we should statically link it instead. --

[issue20861] datetime argument handling inconsistent; should accept logical integers, not coercible values

2019-08-13 Thread STINNER Victor
STINNER Victor added the comment: This issue has been fixed in Python 3.3 by bpo-17576 which started to emit the DeprecationWarning. -- resolution: -> duplicate stage: needs patch -> resolved status: open -> closed superseder: -> PyNumber_Index() is not int-subclass friendly (or

[issue37774] Micro-optimize vectorcall using PY_LIKELY

2019-08-13 Thread STINNER Victor
STINNER Victor added the comment: Few more links about likely/__builtin_expect: * GCC documentation says: "In general, you should prefer to use actual profile feedback for this (-fprofile-arcs), as programmers are notoriously bad at predicting how their programs actually perform."

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

2019-08-13 Thread egaudry
egaudry added the comment: Hi, I think that there are some issues in the last patch (0001-Build-or-disable-readline-module-with-Editline.patch) made available. For instance, the using_libedit_emulation variable should be protected by DETECT_EDITLINE ifdef (and not SUPPORT_EDITLINE). And the

[issue36266] Which module could not be found?

2019-08-13 Thread Srinivas Nyayapati
Srinivas Nyayapati added the comment: can a reviewer please take a look to my PR? -- ___ Python tracker ___ ___ Python-bugs-list

[issue8243] curses writing to window's bottom right position raises: `_curses.error: addstr() returned ERR'

2019-08-13 Thread Anthony Sottile
Anthony Sottile added the comment: In case it helps someone else, `insstr` seems to not have this limitation -- nosy: +Anthony Sottile ___ Python tracker ___

[issue37774] Micro-optimize vectorcall using PY_LIKELY

2019-08-13 Thread STINNER Victor
STINNER Victor added the comment: > We're not talking about prefetching here. The Py_LIKELY/Py_UNLIKELY macros > only affect which of the two code paths in a branch is the "default" one, > i.e. the one not involving a jmp. I know. My point about prefetching is that if we provide a way to

[issue37830] continue in finally with return in try results with segfault

2019-08-13 Thread Ethan Furman
Ethan Furman added the comment: My apologies if I missed something, but do we have a consensus on the desired solution? My understanding of `try/finally` is that whatever happens in the `finally` clause should: - always happen - win any conflicts with `try` clause For example: try:

[issue25172] Unix-only crypt should not be present on Windows.

2019-08-13 Thread Paul Moore
Paul Moore added the comment: To clarify, I think adding the label needs core dev (or maybe triager) rights on github, so I don't think it's something you can do yourself. -- ___ Python tracker

  1   2   >