[issue39481] Implement PEP 585 (Type Hinting Generics In Standard Collections)

2020-03-16 Thread Łukasz Langa
Łukasz Langa added the comment: Submitted a request for consideration by the Steering Council: https://github.com/python/steering-council/issues/21 -- nosy: +lukasz.langa ___ Python tracker

[issue39360] python3.8 regression - ThreadPool join via __del__ hangs forever

2020-03-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > So 3.8 branch + 9ad58acbe8b90b4d0f2d2e139e38bb5aa32b7fb6 + > 4d96b4635aeff1b8ad41d41422ce808ce0b971c8 is working for me. I can confirm that these commits together fix the problem. Victor, are you OK if we backport both changes to 3.8? --

[issue39360] python3.8 regression - ThreadPool join via __del__ hangs forever

2020-03-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Can you try applying 4f384af067d05b16a554bfd976934fca9f87a1cf and 4d96b4635aeff1b8ad41d41422ce808ce0b971c8 together? -- ___ Python tracker

[issue39360] python3.8 regression - ThreadPool join via __del__ hangs forever

2020-03-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Oh, sorry, I missed your last message. -- ___ Python tracker ___ ___ Python-bugs-list

[issue39360] python3.8 regression - ThreadPool join via __del__ hangs forever

2020-03-16 Thread Arkadiusz Miśkiewicz
Arkadiusz Miśkiewicz added the comment: This one is also needed on 3.8 to get it not hang with 1) test case. So 3.8 branch + 9ad58acbe8b90b4d0f2d2e139e38bb5aa32b7fb6 + 4d96b4635aeff1b8ad41d41422ce808ce0b971c8 is working for me. commit 4d96b4635aeff1b8ad41d41422ce808ce0b971c8 Author: Victor

[issue39977] Python aborts trying to load libcrypto.dylib

2020-03-16 Thread foldr
New submission from foldr : Good morning. I recently updated my system to MacOS Catalina and python crashes if it tries to load libcrypto.dylib. I have attached the crash report generated by MacOS. Steps to reproduce: Calling a binary that loads the library causes the crash: $ luigi [1]

[issue36287] Make ast.dump() not output optional default fields

2020-03-16 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: @serhiy.storchaka, with these ASDL signatures, I have a patch that would omit default values for both Nones and [] in case they are redundant. But this is a bit different than your approach so I wanted to ask what's your opinion about adding an extra

[issue39974] A race condition with GIL releasing exists in stringlib_bytes_join

2020-03-16 Thread Bruce Merry
Bruce Merry added the comment: > static_buffers is not a static variable. It is auto local variable. > So I think other thread don't hijack it. Oh yes, quite right. I should have looked closer at the code first before commenting. I think this can be closed as not-a-bug, unless +tzickel has

[issue39879] Update language reference to specify that dict is insertion-ordered.

2020-03-16 Thread Furkan Önder
Furkan Önder added the comment: I sent pr. All tests passed successfully. If accepted, this will be my first contribution :) https://github.com/python/cpython/pull/19027 -- ___ Python tracker

[issue39974] A race condition with GIL releasing exists in stringlib_bytes_join

2020-03-16 Thread Inada Naoki
Inada Naoki added the comment: > > > > perhaps add an if to check if the backing object is really mutable ? > (Py_buffer.readonly) > > Py_buffer.readonly doesn't mean immutable. You can create read only buffer from bytearray too. Current logic uses PyBytes_CheckExact. It is safe and enough

[issue39360] python3.8 regression - ThreadPool join via __del__ hangs forever

2020-03-16 Thread Arkadiusz Miśkiewicz
Arkadiusz Miśkiewicz added the comment: On master test 1) hangs before commit below and works after commit below. Unfortunately applying that commit to 3.8 branch doesn't help - 3.8 still hangs. Some other fix is also needed I guess commit 9ad58acbe8b90b4d0f2d2e139e38bb5aa32b7fb6 Author:

[issue39974] A race condition with GIL releasing exists in stringlib_bytes_join

2020-03-16 Thread Inada Naoki
Inada Naoki added the comment: static_buffers is not a static variable. It is auto local variable. So I think other thread don't hijack it. -- ___ Python tracker ___

[issue39879] Update language reference to specify that dict is insertion-ordered.

2020-03-16 Thread Furkan Önder
Change by Furkan Önder : -- nosy: +furkanonder nosy_count: 4.0 -> 5.0 pull_requests: +18375 pull_request: https://github.com/python/cpython/pull/19027 ___ Python tracker ___

[issue39952] Using VS2019 to automatically build Python3 and it failed to build

2020-03-16 Thread Lin Gao
Lin Gao added the comment: Hi, Thanks for your reply and info! I've tried to use you provided --no-tkinter to re-build python3.6. And now There is only one error left. Have you encountered this problem? build -e -r --no-tkinter -v "/p:PlatformToolset=v142"

[issue39638] Keep ASDL signatures for AST nodes

2020-03-16 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue38938] Possible performance improvement for heaqq.merge()

2020-03-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Are there any algorithmic optimizations in the Python version or it was just rewritten from a generator function to a class? If yes, how hard to keep the functional design? -- ___ Python tracker

[issue39638] Keep ASDL signatures for AST nodes

2020-03-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 4ab362cec6dc68c798b3e354f687cf39e207b9a9 by Batuhan Taşkaya in branch 'master': bpo-39638: Keep ASDL signatures in the AST nodes (GH-18515) https://github.com/python/cpython/commit/4ab362cec6dc68c798b3e354f687cf39e207b9a9 --

[issue39976] Add "**other_popen_kwargs" to subprocess API signatures in docs

2020-03-16 Thread Nick Coghlan
New submission from Nick Coghlan : Two of my colleagues missed the "The arguments shown above are merely the most common ones, ..." caveat on the subprocess.run documentation, and assumed that Python 3.5 only supported the "cwd" option in the low level Popen API, and not any of the higher

[issue39974] A race condition with GIL releasing exists in stringlib_bytes_join

2020-03-16 Thread tzickel
tzickel added the comment: Also, semi related, (dunno where to discuss it), would a good .join() optimization be to add an optional length parameter, like .join(iterable, length=10), and when running in that code-path, it would skip all the calls to (PySequence_Fast which converts no list

[issue39975] Group of commands running in Python 3.7.6 Shell, but failing as Script file.

2020-03-16 Thread Noel del rosario
New submission from Noel del rosario : Python 3.7.6 (tags/v3.7.6:43364a7ae0, Dec 19 2019, 00:42:30) [MSC v.1916 64 bit (AMD64)] on win32 Type "help", "copyright", "credits" or "license()" for more information. from future import absolute_import, division, print_function, unicode_literals

[issue39974] A race condition with GIL releasing exists in stringlib_bytes_join

2020-03-16 Thread tzickel
tzickel added the comment: Also, in line: https://github.com/python/cpython/blob/d07d9f4c43bc85a77021bcc7d77643f8ebb605cf/Objects/stringlib/join.h#L85 perhaps add an if to check if the backing object is really mutable ? (Py_buffer.readonly) --

[issue39972] Math library Bug Return None for "degrees(0)"

2020-03-16 Thread SilentGhost
Change by SilentGhost : -- nosy: +Ion SKALAMERA resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker ___

[issue39972] Math library Bug Return None for "degrees(0)"

2020-03-16 Thread Hamid Nazari
Hamid Nazari added the comment: You seem to be calling `turtle.degrees()`, not `math.degrees()`. Try this in your Repl.it: (which does not use cpython, rather it uses Skulpt) import math import turtle print(turtle.degrees(0)) print(math.degrees(0)) -- nosy: +hamidnazari

[issue39974] A race condition with GIL releasing exists in stringlib_bytes_join

2020-03-16 Thread Bruce Merry
Bruce Merry added the comment: Good catch! I'll take a look this week to see what makes sense for the use case for which I originally proposed this optimisation. -- ___ Python tracker

[issue39972] Math library Bug Return None for "degrees(0)"

2020-03-16 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: math.degrees returns 0.0 and even has a test for this at https://github.com/python/cpython/blob/5b66ec166b81c8a77286da2c0d17be3579c3069a/Lib/test/test_math.py#L476 . I am not sure of the environment under which repl.it runs as sys is not

[issue39974] A race condition with GIL releasing exists in stringlib_bytes_join

2020-03-16 Thread tzickel
Change by tzickel : -- nosy: +bmerry, inada.naoki ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39974] A race condition with GIL releasing exists in stringlib_bytes_join

2020-03-16 Thread tzickel
New submission from tzickel : bpo 36051 added optimization to release GIL on certain conditions of bytes joining, but it has missed a critical path. If the number of items joining is less or equal to NB_STATIC_BUFFERS (10) than static_buffers will be used to hold the buffers.

<    1   2