[issue41343] Convert complex methods to Argument Clinic

Dong-hee Na added the comment: Hmm, I re-ran all the benchmark. - conjugate => It looks like noise. - __getnewargs__ -> consistently showing performance improvement. (2-3%) FYI, I ran benchmarks on the macOS. -- ___ Python tracker

[issue41343] Convert complex methods to Argument Clinic

Dong-hee Na added the comment: > But I am surprised that you get a difference for conjugate() and > __getnewargs__. It could be a noise :) -- ___ Python tracker ___

[issue41342] Convert int.__round__ to Argument Clinic

Serhiy Storchaka added the comment: Yes, you can do this without Argument Clinic, but Argument Clinic allows to hide the use of unstable private API and cumbersome code under macros and in generated files. > That said, it would be great if someone were to work on building-out AC to >

[issue41273] asyncio: proactor read transport: use recv_into instead of recv

David Bolen added the comment: First, I also no longer see the error with a local PR 21446 build on the Win10 buildbot. As for timing, I believe policy is to revert, but in my view it can probably depend on how short "a bit" is for the fix. We've been in this state for 4-5 days already,

[issue36777] unittest discover throws TypeError on namespace packages

Inada Naoki added the comment: This issue is not duplicate of #23882. In the example, test1 and test1.test2 are namespace package. But they are specified explicitly. `./python.exe -m unittest discover test1.test2` -- ___ Python tracker

[issue41338] test_decimal emits DeprecationWarning due to PyUnicode_FromUnicode(NULL, size)

Change by Inada Naoki : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue41338] test_decimal emits DeprecationWarning due to PyUnicode_FromUnicode(NULL, size)

Inada Naoki added the comment: New changeset 902356a7b0564e2c9659aaec56211de4d37109d0 by Inada Naoki in branch 'master': bpo-41338: Fix DeprecationWarning in tests (GH-21542) https://github.com/python/cpython/commit/902356a7b0564e2c9659aaec56211de4d37109d0 --

[issue41341] Recursive evaluation of ForwardRef (and PEP 563)

Joseph Perez added the comment: Ok, I admit that I did not think about recursive type when proposing this "fix". I've tried an implementation that just stop when recursion is encountered in a PR. -- ___ Python tracker

[issue41341] Recursive evaluation of ForwardRef (and PEP 563)

Change by Joseph Perez : -- keywords: +patch pull_requests: +20699 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21553 ___ Python tracker ___

[issue41342] Convert int.__round__ to Argument Clinic

Raymond Hettinger added the comment: I don't have an opinion on the PR but want to point-out the Argument Clinic itself doesn't provide a performance benefit. Anything that it does can also be done directly by the code itself, including vectorcall logic. You should be able to optimize the

[issue41342] Convert int.__round__ to Argument Clinic

Change by Raymond Hettinger : -- Removed message: https://bugs.python.org/msg373973 ___ Python tracker ___ ___ Python-bugs-list

[issue41340] Not very good strcpy implementation in cpython/Python/strdup.c

Benjamin Peterson added the comment: I don't think we need to spend much effort on this implementation, since it will only be used if the system libc doesn't have a strdup already. -- nosy: +benjamin.peterson ___ Python tracker

[issue41045] f-string's "debug" feature is undocumented

Ama Aje My Fren added the comment: Hello all, I have attempted to resolve this issue by adding some comments to PR21464 and later provided a reworded PR21509 that attempts to resolve this using ideas from @rishi93. Finally I have tried to document f-string within pydoc itself with PR21552.

[issue41045] f-string's "debug" feature is undocumented

Change by Ama Aje My Fren : -- pull_requests: +20698 pull_request: https://github.com/python/cpython/pull/21552 ___ Python tracker ___

[issue41273] asyncio: proactor read transport: use recv_into instead of recv

Tony added the comment: Ok so I checked and the PR I am currently having a CR on fixes this issue: https://github.com/python/cpython/pull/21446 Do you want me to make a different PR tomorrow that fixes this specific issue to get it faster to master or is it ok to wait a bit? --

[issue41342] Convert int.__round__ to Argument Clinic

Raymond Hettinger added the comment: I don't have an opinion on the PR but want to point-out the Argument Clinic itself doesn't provide a performance benefit. Anything that it does can also be done directly by the code itself, including vectorcall logic. You should be able to optimize

[issue39017] Infinite loop in the tarfile module

Michał Górny added the comment: Given that a CVE was assigned for this, I think it'd be better if the news were in the 'Security' category and not 'Library'. -- nosy: +mgorny ___ Python tracker

[issue39093] tkinter objects garbage collected from non-tkinter thread cause crash

Change by E. Paine : -- keywords: +patch pull_requests: +20697 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21532 ___ Python tracker ___

[issue31821] pause_reading() doesn't work from connection_made()

Change by Alex Grönholm : -- nosy: +alex.gronholm ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41336] Random segfaults during zoneinfo object creation stopped using Ctrl-C

Change by Raymond Hettinger : -- priority: normal -> high ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41339] make queue.Queue objects iterable

Raymond Hettinger added the comment: I prefer the current API because it makes the blocking step explicit. That isn't the kind of thing that should be hidden behind a "for" or buried in another tool that accepts an iterable argument, sorted(q), for example. Also, the get() method supports

[issue41273] asyncio: proactor read transport: use recv_into instead of recv

Tony added the comment: I see, I'll start working on a fix soon -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue41273] asyncio: proactor read transport: use recv_into instead of recv

David Bolen added the comment: I can at least confirm that this commit is the source of the issue on the Windows 10 buildbot. Interactively, it fails every time with it in place (unlike the buildbot which has had the occasional success) and passes reliably with it reverted. The error

[issue39093] tkinter objects garbage collected from non-tkinter thread cause crash

Change by E. Paine : -- keywords: +patch pull_requests: +20695 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21532 ___ Python tracker ___

[issue39093] tkinter objects garbage collected from non-tkinter thread cause crash

Change by E. Paine : -- keywords: +patch pull_requests: +20696 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21532 ___ Python tracker ___

[issue39093] tkinter objects garbage collected from non-tkinter thread cause crash

Change by E. Paine : -- keywords: +patch pull_requests: +20694 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21532 ___ Python tracker ___

[issue38227] Setting a signal handler gets multiprocessing.Pool stuck

Change by Greg Lindahl : -- nosy: +wumpus ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39093] tkinter objects garbage collected from non-tkinter thread cause crash

Change by E. Paine : -- keywords: +patch pull_requests: +20693 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21532 ___ Python tracker ___

[issue41343] Convert complex methods to Argument Clinic

Serhiy Storchaka added the comment: I wrote similar patch for __format__ and got similar tiny speed up. It is expectable. But I am surprised that you get a difference for conjugate() and __getnewargs__. It may be a compiler artifact. In any case the benefit of converting to Argument Clinic

[issue41295] CPython 3.8.4 regression on __setattr__ in multiinheritance with metaclasses

Guido van Rossum added the comment: @Łukasz: this should be good for the 3.8.5 release. -- ___ Python tracker ___ ___

[issue41342] Convert int.__round__ to Argument Clinic

Change by Mark Dickinson : -- nosy: +mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41343] Convert complex methods to Argument Clinic

Change by Dong-hee Na : -- keywords: +patch pull_requests: +20692 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21550 ___ Python tracker ___

[issue41343] Convert complex methods to Argument Clinic

Change by Dong-hee Na : -- assignee: -> corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41343] Convert complex methods to Argument Clinic

New submission from Dong-hee Na : Mean +- std dev: [master_format] 3.54 us +- 0.06 us -> [clinic_format] 3.29 us +- 0.07 us: 1.08x faster (-7%) Mean +- std dev: [master_conjugate] 3.56 us +- 0.09 us -> [clinic_conjugate] 3.32 us +- 0.06 us: 1.07x faster (-7%) Mean +- std dev:

[issue41295] CPython 3.8.4 regression on __setattr__ in multiinheritance with metaclasses

kam193 added the comment: @Jonas: I know, running those tests isn't so easy, I think a few libraries are incompatible with python 3.9/3.10 yet or I didn't find right prerequisites. But fortunately, everything is running on patched 3.8, so after back-porting I can run it --

[issue38169] Increase Code Coverage for SharedMemory and ShareableListe

Dong-hee Na added the comment: New changeset bfd0fbdc1352534b3c91b46dbae4285f5220acf4 by Vinay Sharma in branch 'master': bpo-38169: Increase code coverage for SharedMemory and ShareableList (GH-16139) https://github.com/python/cpython/commit/bfd0fbdc1352534b3c91b46dbae4285f5220acf4

[issue38169] Increase Code Coverage for SharedMemory and ShareableListe

Change by Dong-hee Na : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue41342] Convert int.__round__ to Argument Clinic

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +20691 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21549 ___ Python tracker

[issue41342] Convert int.__round__ to Argument Clinic

New submission from Serhiy Storchaka : int.__round__ was not converted to Argument Clinic because it is not impossible to express a correct signature for it in Python. But now we can at least make Argument Clinic not producing incorrect signature. And converting to Argument Clinic has a

[issue41339] make queue.Queue objects iterable

Change by Karthikeyan Singaravelan : -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41262] Convert memoryview to Argument Clinic

Stefan Krah added the comment: Thanks, I can confirm that the speedup for memoryview.cast() is large in microbenchmarks. Still, if the speedup cannot be seen in programs like test_buffer, the amount of code that's being added for a speedup < 5% in real world programs is quite substantial (if

[issue23882] unittest discovery doesn't detect namespace packages when given no parameters

Inada Naoki added the comment: In such case, both directories must be specified explicitly. Test discovery doesn't know that a directory is namespace package or namespace package. So it shouldn't assume it is namespace package unless specified. Note that PEP 420 searches namespace package

[issue41341] Recursive evaluation of ForwardRef (and PEP 563)

New submission from Joseph Perez : (This issue is already broached in https://bugs.python.org/issue38605, and a in some way in https://bugs.python.org/issue35834, but only as a secondary subject, that's why I've opened a ticket on this particular issue) ForwardRef of ForwardRef are not

[issue41205] Documentation Decimal power 0 to the 0 is Nan (versus 0 to the 0 which is 1)

miss-islington added the comment: New changeset dac8a3a15647d016842e2ae7284cefa27ce5e838 by Miss Islington (bot) in branch '3.8': bpo-41205: Document Decimal power 0 to the 0 (GH-21386) https://github.com/python/cpython/commit/dac8a3a15647d016842e2ae7284cefa27ce5e838 --

[issue41205] Documentation Decimal power 0 to the 0 is Nan (versus 0 to the 0 which is 1)

miss-islington added the comment: New changeset 8831162464138eb0267f4967b85710247ee95fde by Miss Islington (bot) in branch '3.9': bpo-41205: Document Decimal power 0 to the 0 (GH-21386) https://github.com/python/cpython/commit/8831162464138eb0267f4967b85710247ee95fde --

[issue38169] Increase Code Coverage for SharedMemory and ShareableListe

Vinay Sharma added the comment: Remove Check to prevent creating shared_memory with size 0. Will create a different issue for the same. -- ___ Python tracker ___

[issue41205] Documentation Decimal power 0 to the 0 is Nan (versus 0 to the 0 which is 1)

Change by miss-islington : -- nosy: +miss-islington nosy_count: 8.0 -> 9.0 pull_requests: +20689 pull_request: https://github.com/python/cpython/pull/21547 ___ Python tracker

[issue41205] Documentation Decimal power 0 to the 0 is Nan (versus 0 to the 0 which is 1)

Change by miss-islington : -- pull_requests: +20690 pull_request: https://github.com/python/cpython/pull/21548 ___ Python tracker ___

[issue41205] Documentation Decimal power 0 to the 0 is Nan (versus 0 to the 0 which is 1)

Stefan Krah added the comment: New changeset 10e466448f67850ed7bb2e2a4e7f017f2b050cad by Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) in branch 'master': bpo-41205: Document Decimal power 0 to the 0 (GH-21386)

[issue41336] Random segfaults during zoneinfo object creation stopped using Ctrl-C

Change by Zackery Spytz : -- keywords: +patch nosy: +ZackerySpytz nosy_count: 4.0 -> 5.0 pull_requests: +20688 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21546 ___ Python tracker

[issue41229] Asynchronous generator memory leak

Change by Joongi Kim : -- nosy: +Joongi Kim nosy_count: 6.0 -> 7.0 pull_requests: +20687 pull_request: https://github.com/python/cpython/pull/21545 ___ Python tracker ___

[issue41340] Not very good strcpy implementation in cpython/Python/strdup.c

Change by fj92f3jj923f923 : -- keywords: +patch pull_requests: +20686 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21544 ___ Python tracker ___

[issue41340] Not very good strcpy implementation in cpython/Python/strdup.c

New submission from fj92f3jj923f923 : Hi, all! strdup implementation inside cpython/Python/strdup.c is not the best one. It calls strlen + strcpy, which is the same as calling strlen twice + memcpy. So I replaced it by the call of strlen + memcpy. It is easy to look any implementation in any

[issue41229] Asynchronous generator memory leak

Nathaniel Smith added the comment: Oh! I see it. This is actually working as intended. What's happening is that the event loop will clean up async generators when they're garbage collected... but, this requires that the event loop get a chance to run. In the demonstration program, the main

[issue41229] Asynchronous generator memory leak

Nathaniel Smith added the comment: ...On closer examination, it looks like that Trio PR has at least one test that checks that async generators are collected promptly after they stop being referenced, and that test passes:

[issue23882] unittest discovery doesn't detect namespace packages when given no parameters

Roger Gammans added the comment: But namespace packages are still useful for what PEP420 envisages and they should be able to have runnable tests. For instance projectX/ - interfaces/ - proxyX.py - testX.py projectY/ - intefaces/ - proxyY.py -

[issue41229] Asynchronous generator memory leak

Nathaniel Smith added the comment: Huh, this is very weird. I can confirm that the async generator objects aren't cleaned up until loop shutdown on asyncio. On the trio main branch, we don't yet use the `set_asyncgen_hooks` mechanism, and the async generator objects are cleaned up

[issue41339] make queue.Queue objects iterable

New submission from Alan Iwi : It is possible to make `queue.Queue` and `queue.SimpleQueue` objects iterable by adding simple `__iter__` and `__next__` methods. This is to suggest adding these methods to the existing `Queue` and `SimpleQueue` so that they are iterable by default. ``` class

[issue41337] strangnedd with the parser

Eric V. Smith added the comment: This doesn't appear to be a Python bug, but rather an issue with how you're using PyTorch. I suggest you ask for help on a PyTorch support forum, or maybe try StackOverflow. -- nosy: +eric.smith status: open -> pending

[issue39073] [security] email module incorrect handling of CR and LF newline characters in Address objects.

Ned Deily added the comment: Merged for release in 3.9.0a6, 3.8.4, 3.7.8, 3.6.11, and 3.5.10. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue41229] Asynchronous generator memory leak

Change by Joongi Kim : -- nosy: +njs ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41229] Asynchronous generator memory leak

Joongi Kim added the comment: I've searched the Python documentation and the docs must be updated to explicitly state the necessity of aclose(). refs) https://docs.python.org/3/reference/expressions.html#asynchronous-generator-functions https://www.python.org/dev/peps/pep-0525/ I'm not sure

[issue39603] [security] http.client: HTTP Header Injection in the HTTP method

Ned Deily added the comment: Merged for release in 3.9.0b5, 3.8.5, 3.7.9, and 3.6.12. Thanks, everyone! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10 -Python 2.7 ___ Python tracker

[issue39603] [security] http.client: HTTP Header Injection in the HTTP method

Ned Deily added the comment: New changeset f02de961b9f19a5db0ead56305fe0057a78787ae by Miss Islington (bot) in branch '3.6': bpo-39603: Prevent header injection in http methods (GH-18485) (GH-21539) https://github.com/python/cpython/commit/f02de961b9f19a5db0ead56305fe0057a78787ae

[issue39603] [security] http.client: HTTP Header Injection in the HTTP method

Ned Deily added the comment: New changeset ca75fec1ed358f7324272608ca952b2d8226d11a by Miss Islington (bot) in branch '3.7': bpo-39603: Prevent header injection in http methods (GH-18485) (GH-21538) https://github.com/python/cpython/commit/ca75fec1ed358f7324272608ca952b2d8226d11a

[issue41311] Add a function to get a random sample from an iterable (reservoir sampling)

Oscar Benjamin added the comment: Yeah, I guess it's a YAGNI. Thanks Raymond and Tim for looking at this! -- ___ Python tracker ___

[issue41229] Asynchronous generator memory leak

Joongi Kim added the comment: >From the given example, if I add "await q.aclose()" after "await >q.asend(123456)" it does not leak the memory. This is a good example showing that we should always wrap async generators with explicit "aclosing" context manager (which does not exist yet in the

[issue41320] async process closing after event loop closed

Change by Joongi Kim : -- nosy: +achimnol ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41338] test_decimal emits DeprecationWarning due to PyUnicode_FromUnicode(NULL, size)

Change by Serhiy Storchaka : -- nosy: +serhiy.storchaka nosy_count: 2.0 -> 3.0 pull_requests: +20685 pull_request: https://github.com/python/cpython/pull/21543 ___ Python tracker

[issue36777] unittest discover throws TypeError on namespace packages

Karthikeyan Singaravelan added the comment: I didn't know packages without __init__.py are namespace packages back then and used empty packages. I guess it's related to the other issues with unittest and namespace packages issue36723, issue23882 and issue35617 -- nosy: +inada.naoki

[issue41338] test_decimal emits DeprecationWarning due to PyUnicode_FromUnicode(NULL, size)

Change by Inada Naoki : -- keywords: +patch pull_requests: +20684 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21542 ___ Python tracker ___

[issue32528] Change base class for futures.CancelledError

miss-islington added the comment: New changeset 700cb6617545cdb8a9e16bb2e6efe90788a60d4d by Miss Islington (bot) in branch '3.8': bpo-32528: Document the change in inheritance of asyncio.CancelledError (GH-21474)

[issue41338] test_decimal emits DeprecationWarning due to PyUnicode_FromUnicode(NULL, size)

New submission from Karthikeyan Singaravelan : Probably related to issue36346 ./python -Wall -m test test_decimal 0:00:00 load avg: 3.07 Run tests sequentially 0:00:00 load avg: 3.07 [1/1] test_decimal /root/cpython/Lib/test/test_decimal.py:592: DeprecationWarning:

[issue41297] Remove doctest import from heapq

Change by Ronald Oussoren : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker ___ ___

[issue40828] shared memory problems with multiprocessing.Pool

Vinay Sharma added the comment: Hi, Can you please confirm the python version in which you replicated this issue. I tried replicating (segmentation fault) this issue in python 3.8.0b3 but didn't succeed. And shared_memory isn't present in 3.7. Also, shared_memory is known to throw some

[issue41337] strangnedd with the parser

New submission from Justin Hodder : Here a colab that demostrates the bug https://colab.research.google.com/drive/1OWSEoV7Wx-EBA_2IprNZoASNvXIky3iC?usp=sharing the following code gives"received an invalid combination of arguments - got (Tensor, Tensor), but expected one of:" import torch

[issue41295] CPython 3.8.4 regression on __setattr__ in multiinheritance with metaclasses

Stefan Behnel added the comment: > test_asyncio altered the execution environment That happened several times before in previous builds. I think there's just a part of the asyncio tests that is unreliable. I left a comment in issue 41273 since it might be related, the sporadic failures

[issue41273] asyncio: proactor read transport: use recv_into instead of recv

Stefan Behnel added the comment: There have been sporadic buildbot failures in "test_asyncio" since this change, message being "1 test altered the execution environment", e.g. https://buildbot.python.org/all/#/builders/129/builds/1443 Could someone please check if they are related?

[issue41295] CPython 3.8.4 regression on __setattr__ in multiinheritance with metaclasses

Jonas Schäfer added the comment: @kam193 Thanks for running the aioxmpp tests. I built the patched python yesterday, but I didn’t manage to get a virtualenv with it up Good to hear that the fix works as expected! -- ___ Python tracker

[issue41333] Convert OrderedDict.pop() to Argument Clinic

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue41333] Convert OrderedDict.pop() to Argument Clinic

Serhiy Storchaka added the comment: New changeset 6bf3237379b17632db52cb39d181e8bac70173f3 by Serhiy Storchaka in branch 'master': bpo-41333: Convert OrderedDict.pop() to Argument Clinic (GH-21534) https://github.com/python/cpython/commit/6bf3237379b17632db52cb39d181e8bac70173f3 --

[issue41323] Perform "peephole" optimization directly on control-flow graph.

Change by Raymond Hettinger : -- nosy: +tim.peters ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41297] Remove doctest import from heapq

Raymond Hettinger added the comment: Can we close this? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41272] New clause in FOR and WHILE instead of ELSE

Raymond Hettinger added the comment: I see that this was already moved to the mailing list. Am marking this as closed. If the mail list discussion proves favorable, feel free to reopen. -- nosy: +rhettinger resolution: -> later stage: -> resolved status: open -> closed

[issue41311] Add a function to get a random sample from an iterable (reservoir sampling)

Raymond Hettinger added the comment: > I agree that this could be out of scope for the random module > but I wanted to make sure the reasons were considered. I think we've done that. Let's go ahead and close this one down. In general, better luck can be had by starting with a common real