[issue42974] tokenize reports incorrect end col offset and line string when input ends without explicit newline

2021-01-20 Thread Brian Romanowski
Brian Romanowski added the comment: I took a look at Parser/tokenizer.c. From what I can tell, the tokenizer does fake a newline character when the input buffer does not end with actual newline characters and that the returned NEWLINE token has an effective length of 1 because of this

[issue42980] argparse: GNU-style help formatter

2021-01-20 Thread Raymond Hettinger
Raymond Hettinger added the comment: This sounds reasonable to me and the patch is non-invasive. Paul, what do you think? -- ___ Python tracker ___

[issue42035] [C API] PyType_GetSlot cannot get tp_name

2021-01-20 Thread hai shi
hai shi added the comment: > New C API functions must not return borrowed references, but strong > references. Thanks petr, victor for your suggestion. It's more friendly to users. > Which one should be returned by PyType_GetName()? Is there a warranty that > it's always short or always

[issue42980] argparse: GNU-style help formatter

2021-01-20 Thread hai shi
Change by hai shi : -- nosy: +paul.j3, rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-01-20 Thread hai shi
Change by hai shi : -- nosy: +shihai1991 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42967] [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-01-20 Thread Senthil Kumaran
Change by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42987] HTTP header injection in urllib on windows

2021-01-20 Thread bfpiaoran
New submission from bfpiaoran : Recently,(on windows) I discovered a security issue during a security review due to urllib.I checked the document and found that it has been fixed at https://bugs.python.org/issue22928.but My python version is 3.7.2 over the fix bug version .Then tried to find

[issue42973] argparse: mixing optional and positional arguments... not again

2021-01-20 Thread Tadek Kijkowski
Tadek Kijkowski added the comment: >> I tried to checkout python sources, but even with -depth 1 it took too long >> for my patience and I gave up after 'du -sh .git' showed 2G. Ignore that. I must have been doing something worng. -- ___ Python

[issue42843] What min_sphinx for Python 3.10

2021-01-20 Thread Julien Palard
Change by Julien Palard : -- pull_requests: +23103 pull_request: https://github.com/python/cpython/pull/24282 ___ Python tracker ___

[issue42974] tokenize reports incorrect end col offset and line string when input ends without explicit newline

2021-01-20 Thread Brian Romanowski
Brian Romanowski added the comment: Shoot, just realized that consistency isn't the important thing here, the most important thing is that the tokenizer module exactly matches the output of the Python tokenizer. It's possible that my changes violate that constraint, I'll take a look at

[issue42978] Improve error message when "self" is missing from the method definition

2021-01-20 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> rejected stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue42973] argparse: mixing optional and positional arguments... not again

2021-01-20 Thread Tadek Kijkowski
Tadek Kijkowski added the comment: >> Your example is incomplete. That is _CustomAction? What namespace does >> your patch produce. >> In your example I'd suggest making '--tracks' a nargs=2 and 'append' option. >> 'choices' would have to be replaced with a either a custom 'type', a

[issue42978] Improve error message when "self" is missing from the method definition

2021-01-20 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Thanks, everyone for your valuable comments and for explaining your concerns! I will close the PR as it seems that there is no clear consensus that will be a win after balancing the problems. -- ___ Python

[issue42978] Improve error message when "self" is missing from the method definition

2021-01-20 Thread Raymond Hettinger
Raymond Hettinger added the comment: -0 for this PR. It would cause more problems than it solves, and traditionally we leave this sort of problem for linters and type checkers. Also, this kind of error surfaces readily with even minimal testing. So, I don't think this PR is worth it.

[issue42392] remove the deprecated 'loop' parameter asyncio API

2021-01-20 Thread miss-islington
miss-islington added the comment: New changeset dcea78ff53d02733ac5983255610b651aa1c0034 by Ken Jin in branch 'master': bpo-42392: Mention loop removal in whatsnew for 3.10 (GH-24256) https://github.com/python/cpython/commit/dcea78ff53d02733ac5983255610b651aa1c0034 -- nosy:

[issue42986] pegen parser: Crash on SyntaxError with f-string on Windows

2021-01-20 Thread neonene
neonene added the comment: For me, I confirmed no crash with PR 24279. Thanks for the fix in no time. -- ___ Python tracker ___

[issue42978] Improve error message when "self" is missing from the method definition

2021-01-20 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Of course, being said all this, if the general consensus is that is not worth the trouble, I am happy to retract the PR :) -- ___ Python tracker

[issue42968] multiprocessing handle leak on Windows when child process is killed during startup/unpickling

2021-01-20 Thread Eryk Sun
Eryk Sun added the comment: I'm not fond of the way reduction.DupHandle() expects the receiving process to steal the duplicated handle. I'd prefer using the resource_sharer module, like reduction.DupFd() does in POSIX. Except spawning is a special case, for which reduction.DupHandle() can

[issue42986] pegen parser: Crash on SyntaxError with f-string on Windows

2021-01-20 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +23102 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24279 ___ Python tracker

[issue42986] pegen parser: Crash on SyntaxError with f-string on Windows

2021-01-20 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Seems that this problem was introduced by e5fe509054183bed9aef42c92da8407d339e8af8 -- ___ Python tracker ___

[issue42978] Improve error message when "self" is missing from the method definition

2021-01-20 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Guido already listed them. Library functions, static and class methods, PR 24272 will work on all those cases. > and names like slf and _self (used either in local classes and wrapper > functions to avoid conflict with the self parameter of the

[issue42780] os.set_inheritable() fails for O_PATH file descriptors on Linux

2021-01-20 Thread cptpcrd
Change by cptpcrd : -- pull_requests: +23101 pull_request: https://github.com/python/cpython/pull/24278 ___ Python tracker ___ ___

[issue42780] os.set_inheritable() fails for O_PATH file descriptors on Linux

2021-01-20 Thread cptpcrd
Change by cptpcrd : -- pull_requests: +23100 pull_request: https://github.com/python/cpython/pull/24277 ___ Python tracker ___ ___

[issue42986] pegen parser: Crash on SyntaxError with f-string on Windows

2021-01-20 Thread neonene
New submission from neonene : On Windows, Python master crashes using f-string (which has an invalid char with braces) on line 3 and after. It seems the issue is from commit (e5fe509054183bed9aef42c92da8407d339e8af8). I tried 1) exec("f'{.}'") 2) exec("\nf'{.}'") 3) exec("\n\nf'{.}'")

[issue42862] Use functools.lru_cache iso. _sqlite.Cache in sqlite3 module

2021-01-20 Thread Erlend Egeberg Aasland
Erlend Egeberg Aasland added the comment: Tried applying bpo-42972 to sqlite and functools, but the error persists. -- ___ Python tracker ___

[issue42978] Improve error message when "self" is missing from the method definition

2021-01-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > Could you list some cases where this will give the wrong advice? Guido already listed them. Library functions, static and class methods, and names like slf and _self (used either in local classes and wrapper functions to avoid conflict with the self

[issue40176] unterminated string literal tokenization error messages could be better

2021-01-20 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10 -Python 3.9 ___ Python tracker ___

[issue40176] unterminated string literal tokenization error messages could be better

2021-01-20 Thread miss-islington
miss-islington added the comment: New changeset a698d52c3975c80b45b139b2f08402ec514dce75 by Batuhan Taskaya in branch 'master': bpo-40176: Improve error messages for unclosed string literals (GH-19346) https://github.com/python/cpython/commit/a698d52c3975c80b45b139b2f08402ec514dce75

[issue42985] AMD64 Arch Linux Asan 3.x fails: command timed out: 1200 seconds without output

2021-01-20 Thread STINNER Victor
Change by STINNER Victor : -- nosy: +pablogsal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42985] AMD64 Arch Linux Asan 3.x fails: command timed out: 1200 seconds without output

2021-01-20 Thread STINNER Victor
New submission from STINNER Victor : The AMD64 Arch Linux Asan 3.x buildbot worker started to fail at build 262: https://buildbot.python.org/all/#/builders/582/builds/262 --- ... 0:39:09 load avg: 1.15 running: test_multiprocessing_forkserver (30.0 sec) 0:39:39 load avg: 1.64 running:

[issue42978] Improve error message when "self" is missing from the method definition

2021-01-20 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Do you also exclude class and static methods? Yup, there is a test in the PR for that IIRC >I still worry that this might confuse users when a library for some reason >uses a different name than 'self'. That's a good point but I think it should be

[issue42978] Improve error message when "self" is missing from the method definition

2021-01-20 Thread Guido van Rossum
Guido van Rossum added the comment: > I use the same heuristic as Pypy: the callable is a bound method, the first > name in the definition is not named "self" and it was called with n+1 > positional arguments. Okay, that makes sense, you could have said so in the bug or PR description. :-)

[issue42984] Python 3.7 and qt Libraries

2021-01-20 Thread Guido van Rossum
Guido van Rossum added the comment: I recommend asking on a user forum, perhaps https://discuss.python.org/c/users/ -- nosy: +gvanrossum resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker

[issue42973] argparse: mixing optional and positional arguments... not again

2021-01-20 Thread paul j3
paul j3 added the comment: Your patch is incomplete, without documentation or tests. Your example is incomplete. That is _CustomAction? What namespace does your patch produce. It's been a while since I worked on the intermixed patch, but as I recall the OP was happy with the fix. Also I

[issue42983] sys.argv incorrectly parses command lines with args in environment variables.

2021-01-20 Thread Guido van Rossum
Guido van Rossum added the comment: That looks like you need to learn more about the shell. It is not a Python bug. -- nosy: +gvanrossum resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker

[issue42984] Python 3.7 and qt Libraries

2021-01-20 Thread Rob Simsiman
New submission from Rob Simsiman : Hello, I am trying to run an application on CentOS-8 that is unable to find qt4 libraries, namely libQtCore.so.4. My PC has qt5 libraries, namely libQt5Core.so.5. How can I configure my Python 3.7 to look for the qt5 libraries instead of the qt4 libraries.

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-01-20 Thread Erlend Egeberg Aasland
Change by Erlend Egeberg Aasland : -- nosy: +erlendaasland ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42982] Update suggested number of iterations for pbkdf2_hmac()

2021-01-20 Thread Illia Volochii
Change by Illia Volochii : -- keywords: +patch pull_requests: +23099 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24276 ___ Python tracker ___

[issue42983] sys.argv incorrectly parses command lines with args in environment variables.

2021-01-20 Thread Jason Williams
Change by Jason Williams : Added file: https://bugs.python.org/file49754/private_key.pem ___ Python tracker ___ ___ Python-bugs-list

[issue42980] argparse: GNU-style help formatter

2021-01-20 Thread Will Noble
Change by Will Noble : -- keywords: +patch pull_requests: +23098 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24275 ___ Python tracker ___

[issue42983] sys.argv incorrectly parses command lines with args in environment variables.

2021-01-20 Thread Jason Williams
Change by Jason Williams : -- components: +Library (Lib) type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing

[issue42983] sys.argv incorrectly parses command lines with args in environment variables.

2021-01-20 Thread Jason Williams
New submission from Jason Williams : Passing arguments to a Python script using an environment variable like: export en_auth="--arg1 test --arg2 \"$(https://bugs.python.org/file49753/test.py ___ Python tracker

[issue42982] Update suggested number of iterations for pbkdf2_hmac()

2021-01-20 Thread Illia Volochii
New submission from Illia Volochii : Documentation [1] suggests using at least 100,000 iterations of SHA-256 as of 2013. Currently, it is 2021, and it is common to use much more iterations. For example, Django will use 260,000 by default in the next 3.2 LTS release and 320,000 in 4.0 [2][3].

[issue42955] Add sys.module_names: list of stdlib module names (Python and extension modules)

2021-01-20 Thread SylvainDe
SylvainDe added the comment: For similar reasons as friendly-traceback, I'd be interested in a list of stdlib modules to be able to provide additional information in case of exceptions. For instance: string.ascii_lowercase > Before: NameError("name 'string' is not defined",) > After:

[issue42978] Improve error message when "self" is missing from the method definition

2021-01-20 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Seems that that guess will be wrong in most cases. Maybe I am missing something. Could you list some cases where this will give the wrong advice? -- ___ Python tracker

[issue42864] Improve error messages regarding unclosed parentheses

2021-01-20 Thread miss-islington
miss-islington added the comment: New changeset c3f167d7b243f8b8e1b797586e6cef35add013bc by Pablo Galindo in branch 'master': bpo-42864: Simplify the tokenizer exceptions after generic SyntaxError (GH-24273) https://github.com/python/cpython/commit/c3f167d7b243f8b8e1b797586e6cef35add013bc

[issue42978] Improve error message when "self" is missing from the method definition

2021-01-20 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > I don't think this makes sense. How do you know there's a missing 'self'? > Surely it's just as likely that there is indeed an extra argument. Especially > if A.foo is defined by a library (stdib or 3rd party). I use the same heuristic as Pypy: the

[issue42981] Error messages raised by _hashlib_scrypt_impl() are slightly misleading

2021-01-20 Thread Illia Volochii
Change by Illia Volochii : -- keywords: +patch pull_requests: +23097 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24274 ___ Python tracker ___

[issue42981] Error messages raised by _hashlib_scrypt_impl() are slightly misleading

2021-01-20 Thread Illia Volochii
New submission from Illia Volochii : Error messages state that maxmem and dklen must be smaller than INT_MAX, but values equal to INT_MAX are allowed too. Also, another error message states that n must be a power of 2, but it does not mention that 1 or 2⁰ is not allowed. --

[issue42864] Improve error messages regarding unclosed parentheses

2021-01-20 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +23096 pull_request: https://github.com/python/cpython/pull/24273 ___ Python tracker ___

[issue42980] argparse: GNU-style help formatter

2021-01-20 Thread Will Noble
New submission from Will Noble : argparse allows GNU-style long options (with '=' in between the option and the value as opposed to a space): https://docs.python.org/3/library/argparse.html#option-value-syntax Call it pickiness, but I'd like to be able to print the help message in that

[issue42978] Improve error message when "self" is missing from the method definition

2021-01-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Concur with Guido. Seems that that guess will be wrong in most cases. -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue42604] EXT_SUFFIX too short on FreeBSD and AIX

2021-01-20 Thread mattip
mattip added the comment: I think this issue can only cause failed tests. `sysconfig.get_config_var('EXT_SUFFIX')` is, as far as I can tell, not used internally by any cpython build or import code. -- ___ Python tracker

[issue42604] EXT_SUFFIX too short on FreeBSD and AIX

2021-01-20 Thread STINNER Victor
STINNER Victor added the comment: > Assertion failed: (item != NULL) ^ (PyErr_Occurred() != NULL), file > Objects/abstract.c, line 163 This is bpo-42979: "_zoneinfo: zoneinfomodule_exec() doesn't check for PyDateTime_IMPORT failure". It's a side effect of the broken _datetime module.

[issue42979] _zoneinfo: zoneinfomodule_exec() doesn't check for PyDateTime_IMPORT failure

2021-01-20 Thread STINNER Victor
New submission from STINNER Victor : _zoneinfo starts with: static int zoneinfomodule_exec(PyObject *m) { PyDateTime_IMPORT; with: #define PyDateTime_CAPSULE_NAME "datetime.datetime_CAPI" #define PyDateTime_IMPORT \ PyDateTimeAPI = (PyDateTime_CAPI

[issue42978] Improve error message when "self" is missing from the method definition

2021-01-20 Thread Guido van Rossum
Guido van Rossum added the comment: I don't think this makes sense. How do you know there's a missing 'self'? Surely it's just as likely that there is indeed an extra argument. Especially if A.foo is defined by a library (stdib or 3rd party). -- nosy: +gvanrossum

[issue42856] ensurepip: add configure --with-wheel-pkg-dir=PATH to get wheel packages from a system directory

2021-01-20 Thread STINNER Victor
STINNER Victor added the comment: New changeset 75e59a97f5d1fddb0c30ed9747b1b8cb84420a62 by Victor Stinner in branch 'master': bpo-42856: Add --with-wheel-pkg-dir=PATH configure option (GH-24210) https://github.com/python/cpython/commit/75e59a97f5d1fddb0c30ed9747b1b8cb84420a62 --

[issue42967] [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-01-20 Thread Ken Jin
Ken Jin added the comment: FWIW, a surprising amount of things rely on treating ';' as a valid separator in the standard test suite. >From just a cursory look: test_cgi test_urlparse A change in the public API of urlparse will also require a change in cgi.py's FieldStorage,

[issue42604] EXT_SUFFIX too short on FreeBSD and AIX

2021-01-20 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Can it be related to the commit a44ce6c9f725d336aea51a946b42769f29fed613 of > this issue? Quite likely. @mattip, can you investigate? -- ___ Python tracker

[issue42955] Add sys.module_names: list of stdlib module names (Python and extension modules)

2021-01-20 Thread STINNER Victor
STINNER Victor added the comment: Another example: the unimport project ("linter, formatter for finding and removing unused import statements") uses the following function to guess if a module object is part of the stdlib: def is_std(package: str) -> bool: """Returns True if package

[issue42978] Improve error message when "self" is missing from the method definition

2021-01-20 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +23095 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24272 ___ Python tracker

[issue42978] Improve error message when "self" is missing from the method definition

2021-01-20 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : We currently say: Traceback (most recent call last): File "/Users/pgalindo3/github/python/master/lel.py", line 5, in A().foo(1,2) TypeError: foo() takes 2 positional arguments but 3 were given but we should say: Traceback (most recent call

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

2021-01-20 Thread STINNER Victor
STINNER Victor added the comment: Oh, it seems like Python no long builds on PPC64 AIX 3.x buildbot :-( https://bugs.python.org/issue42604#msg385347 -- ___ Python tracker ___

[issue42604] EXT_SUFFIX too short on FreeBSD and AIX

2021-01-20 Thread STINNER Victor
STINNER Victor added the comment: I reopen the issue. It seems like Python no long builds on PPC64 AIX 3.x buildbot: https://buildbot.python.org/all/#/builders/438/builds/753 "setup.py build" crash with an assertion error: Assertion failed: (item != NULL) ^ (PyErr_Occurred() != NULL), file

[issue36769] doc Document that fnmatch.filter supports any kind of iterable not just lists

2021-01-20 Thread Irit Katriel
Change by Irit Katriel : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10 -Python 3.7 ___ Python tracker ___

[issue42967] [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-01-20 Thread Ken Jin
Change by Ken Jin : -- keywords: +patch nosy: +kj nosy_count: 4.0 -> 5.0 pull_requests: +23094 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24271 ___ Python tracker

[issue42967] [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-01-20 Thread STINNER Victor
STINNER Victor added the comment: > Python implementation obeys contemporary standards The contemporary standard is HTML5 and HTML5 asks to only split at "&", no? -- ___ Python tracker

[issue42977] Tkinter Optionmenu Too Narrow on Mac

2021-01-20 Thread DDavid
New submission from DDavid : Hello, I am building a program with Tkinter. However, I found the Optionmenu widget has inconsistent behaviors on default lengths on a Mac and a Windows PC. So I set the width of an optionmenu through menu.configure(width=70). On Windows, this correctly sets

[issue42967] [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-01-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It looks to me, that this is an issue of proxies, not Python. Python implementation obeys contemporary standards, and they are not formally cancelled yet. If we add an option in parse_qsl() or change its default behavior, it should be considered as a new

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

2021-01-20 Thread STINNER Victor
STINNER Victor added the comment: New changeset c1c3493fb7a3af8efdc50175e592d29e8cb93886 by Victor Stinner in branch 'master': bpo-42323: Fix math.nextafter() for NaN on AIX (GH-24265) https://github.com/python/cpython/commit/c1c3493fb7a3af8efdc50175e592d29e8cb93886 --

[issue42967] [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-01-20 Thread STINNER Victor
STINNER Victor added the comment: > Sorry for the title mess: It seems that when replying to a ticket, RoundUp > uses the subject line as the new header regardless of what it was set to > before. Yeah, it's annoying :-( I like to put a module name in the issue title, to help bug triage.

[issue42967] [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-01-20 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Sorry for the title mess: It seems that when replying to a ticket, RoundUp uses the subject line as the new header regardless of what it was set to before. -- ___ Python tracker

[issue42780] os.set_inheritable() fails for O_PATH file descriptors on Linux

2021-01-20 Thread STINNER Victor
STINNER Victor added the comment: Thanks cptpcrd for your bug report and your great fix! I like your tests ;-) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue42967] [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-01-20 Thread STINNER Victor
Change by STINNER Victor : -- title: [security] Web cache poisoning - `;` as a query args separator -> [security] urllib.parse.parse_qsl(): Web cache poisoning - `;` as a query args separator ___ Python tracker

[issue42780] os.set_inheritable() fails for O_PATH file descriptors on Linux

2021-01-20 Thread miss-islington
Change by miss-islington : -- pull_requests: +23093 pull_request: https://github.com/python/cpython/pull/24270 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

2021-01-20 Thread Dong-hee Na
Change by Dong-hee Na : -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42780] os.set_inheritable() fails for O_PATH file descriptors on Linux

2021-01-20 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +23092 pull_request: https://github.com/python/cpython/pull/24269 ___ Python tracker

[issue42780] os.set_inheritable() fails for O_PATH file descriptors on Linux

2021-01-20 Thread STINNER Victor
STINNER Victor added the comment: New changeset 7dc71c425cf6aa6a4070a418dce5d95ca435c79f by cptpcrd in branch 'master': bpo-42780: Fix set_inheritable() for O_PATH file descriptors on Linux (GH-24172) https://github.com/python/cpython/commit/7dc71c425cf6aa6a4070a418dce5d95ca435c79f

[issue42864] Improve error messages regarding unclosed parentheses

2021-01-20 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset ae7d3cd980fae6b9a9778c0ccd162b93035ad33e by Pablo Galindo in branch 'master': bpo-42864: Fix compiler warning in the tokenizer with the new paren stack for column numbers (GH-24266)

[issue42864] Improve error messages regarding unclosed parentheses

2021-01-20 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +23091 pull_request: https://github.com/python/cpython/pull/24266 ___ Python tracker ___

[issue42967] [security] Web cache poisoning - `; ` as a query args separator

2021-01-20 Thread Marc-Andre Lemburg
Change by Marc-Andre Lemburg : -- title: Web cache poisoning - `;` as a query args separator -> [security] Web cache poisoning - `;` as a query args separator ___ Python tracker

Re: [issue42967] Web cache poisoning - `;` as a query args separator

2021-01-20 Thread M.-A. Lemburg
On 20.01.2021 12:07, STINNER Victor wrote: > Maybe we should even go further in Python 3.10 and only split at "&" by > default, but let the caller to opt-in for ";" separator as well. +1. Personally, I've never seen URLs encoded with ";" as query parameter separator in practice on the server

[issue42197] Disable automatic update of frame locals during tracing

2021-01-20 Thread Fabio Zadrozny
Fabio Zadrozny added the comment: I agree that it can be made better, but I think most of the issues right now comes from CPython trying to automatically do something that's not bound to work (calling PyFrame_FastToLocals/PyFrame_LocalsToFast under the hood during the tracing call).

[issue42048] Document Argument Clinic's defining_class converter

2021-01-20 Thread Erlend Egeberg Aasland
Change by Erlend Egeberg Aasland : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue42976] __text_signature__ parser silently drops arguments with certain unsupported default forms

2021-01-20 Thread Antony Lee
New submission from Antony Lee : Starting from the keyword-arguments example at https://docs.python.org/3/extending/extending.html#keyword-parameters-for-extension-functions, change the docstring of `parrot` to "parrot(voltage, state, action, type=1<<5)\n--\n\n" (yes, the documented default

[issue42048] Document Argument Clinic's defining_class converter

2021-01-20 Thread STINNER Victor
STINNER Victor added the comment: New changeset e982fe496bf756afd2ead8e56eb24b28a93c627a by Erlend Egeberg Aasland in branch 'master': bpo-42048: Clinic Howto: Document AC's defining_class converter (GH-23978) https://github.com/python/cpython/commit/e982fe496bf756afd2ead8e56eb24b28a93c627a

[issue26003] Issues with PyEval_InitThreads and PyGILState_Ensure

2021-01-20 Thread STINNER Victor
STINNER Victor added the comment: The GIL is now created by _PyEval_InitGIL() which is called by Py_Initialize(): at Python startup. _PyRuntime.main_thread is set by _PyRuntime_Initialize() which is also called by Py_Initialize(): at Python startup. The code to handle signals and pending

[issue42967] [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-01-20 Thread STINNER Victor
Change by STINNER Victor : -- title: urllib.parse.parse_qsl(): Web cache poisoning - `;` as a query args separator -> [security] urllib.parse.parse_qsl(): Web cache poisoning - `;` as a query args separator ___ Python tracker

[issue42967] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-01-20 Thread STINNER Victor
Change by STINNER Victor : -- title: Web cache poisoning - `;` as a query args separator -> urllib.parse.parse_qsl(): Web cache poisoning - `;` as a query args separator ___ Python tracker

[issue42967] Web cache poisoning - `;` as a query args separator

2021-01-20 Thread STINNER Victor
STINNER Victor added the comment: Oops, I missed this issue. I just marked my bpo-42975 issue as a duplicate of this one. My message: urllib.parse.parse_qsl() uses "&" *and* ";" as separators: >>> urllib.parse.parse_qsl("a=1=2=3") [('a', '1'), ('b', '2'), ('c', '3')] >>>

[issue42975] urllib.parse.parse_qsl(): add an option to not consider semicolon (; ) as separator

2021-01-20 Thread STINNER Victor
STINNER Victor added the comment: Oh, I mark my issue as a duplicate of bpo-42967. -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Web cache poisoning - `;` as a query args separator ___ Python tracker

[issue41798] [C API] Revisit usage of the PyCapsule C API with multi-phase initialization API

2021-01-20 Thread STINNER Victor
STINNER Victor added the comment: New changeset 61d26394f97306ab4890f1522f26ee6d17461e2b by Erlend Egeberg Aasland in branch 'master': bpo-41798: Allocate unicodedata CAPI on the heap (GH-24128) https://github.com/python/cpython/commit/61d26394f97306ab4890f1522f26ee6d17461e2b --

[issue42197] Disable automatic update of frame locals during tracing

2021-01-20 Thread Mark Shannon
Mark Shannon added the comment: I don't think so. Tracing is already somewhat fragile, see https://bugs.python.org/issue30744. Making it more complex is likely to add more bugs. PEP 558 should help, as f_locals becomes a proxy. There are some minor issues with PEP 558 (I'm not convinced that

[issue42975] urllib.parse.parse_qsl(): add an option to not consider semicolon (; ) as separator

2021-01-20 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: See also https://bugs.python.org/issue42967 -- nosy: +xtreak ___ Python tracker ___

[issue42975] urllib.parse.parse_qsl(): add an option to not consider semicolon (; ) as separator

2021-01-20 Thread STINNER Victor
New submission from STINNER Victor : urllib.parse.parse_qsl() uses "&" *and* ";" as separators: >>> urllib.parse.parse_qsl("a=1=2=3") [('a', '1'), ('b', '2'), ('c', '3')] >>> urllib.parse.parse_qsl("a=1=2;c=3") [('a', '1'), ('b', '2'), ('c', '3')] But the W3C standards evolved and now suggest

[issue42680] unicode identifiers not accessible or assignable through globals()

2021-01-20 Thread STINNER Victor
Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

2021-01-20 Thread STINNER Victor
STINNER Victor added the comment: I wrote PR 24265 to fix the issue. math.nextafter(x, y) already had a special case for AIX for x==y. test_nextafter fails on PPC64 AIX 3.x (build 749). test_nextafter pass on POWER6 AIX 3.x (build 701). -- ___

[issue36769] doc Document that fnmatch.filter supports any kind of iterable not just lists

2021-01-20 Thread miss-islington
miss-islington added the comment: New changeset 8f334dbbf04582071d1318e5817e2fe99f1e5169 by Miss Islington (bot) in branch '3.8': bpo-36769: Document that fnmatch.filter supports any kind of iterable (GH-13039) https://github.com/python/cpython/commit/8f334dbbf04582071d1318e5817e2fe99f1e5169

[issue42323] [AIX] test_math: test_nextafter(float('nan'), 1.0) does not return a NaN on AIX

2021-01-20 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +23090 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24265 ___ Python tracker ___

[issue42778] Add follow_symlinks=True parameter to both os.path.samefile() and Path.samefile()

2021-01-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Why is this feature needed? Currently you can use a combination of samestat() with lstat(). And more, you can follow symbolic links only for one of arguments. samestat(stat(path1), stat(path1)) # same as samefile(path1, path1) samestat(lstat(path1),

  1   2   >