[issue41322] unittest: deprecate test methods returning non-None values

Serhiy Storchaka added the comment: Every new feature should be documented and covered by tests (unless it is very trivial or it is very difficult to write a test for it). -- ___ Python tracker

[issue41322] unittest: deprecate test methods returning non-None values

Change by Andrei Kulakov : -- pull_requests: +26308 stage: test needed -> patch review pull_request: https://github.com/python/cpython/pull/27846 ___ Python tracker ___ ___

[issue43884] Cannot cleanly kill a subprocess using high-level asyncio APIs

Eli Skeggs added the comment: I'm also experiencing this, with virtually identical code, on macOS 10.15.7. The given fix (process._transport.close()) also works for me, so I'm just using that workaround for the time being. -- nosy: +skeggse ___ Py

[issue44934] Windows installer: Append Python to PATH instead of prepending it

Steve Dower added the comment: > why is this confusion not written here >From https://docs.python.org/3/using/windows.html#configuring-python > While the installer provides an option to configure the PATH and PATHEXT > variables for you, this is only reliable for a single, system-wide > ins

[issue44934] Windows installer: Append Python to PATH instead of prepending it

Sascha added the comment: hi, if you know that it will lead to confusion why is this confusion not written here: https://docs.python.org/3/using/windows.html If you do software deployment in a company you will only have one version so having more than one version is not the point. And if y

[issue44956] curses getch returns wrong value

Serhiy Storchaka added the comment: Your terminal emulator does not support this key. I tested it on Konsole and it returned 27. But on XTerm and on the Linux virtual console I get the expected result. -- nosy: +serhiy.storchaka ___ Python tracker

[issue43350] [sqlite3] Active statements are reset twice in _pysqlite_query_execute()

Erlend E. Aasland added the comment: msg387858 (Serhiy): > Maybe the code could be rewritten in more explicit way and call > pysqlite_statement_reset() only when it is necessary [...] I've opened bpo-44958 for such an enhancement. Closing this issue. -- resolution: -> duplicate stage

[issue44073] [sqlite3] drop statement in_use field in favour of sqlite3_stmt_busy()

Erlend E. Aasland added the comment: See also bpo-44958 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue44958] [sqlite3] only reset statements when needed

Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +26307 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27844 ___ Python tracker __

[issue44958] [sqlite3] only reset statements when needed

New submission from Erlend E. Aasland : Ref. Serhiy's msg387858 in bpo-43350: "Maybe the code could be rewritten in more explicit way and call pysqlite_statement_reset() only when it is necessary [...]" Currently, we try to reset statements in all "statement exit" routes. IMO, it would be cle

[issue44933] python3.9-intel64 hardened runtime not enabled

tester added the comment: I found the fix for it earlier today and of course the fix is always right in front of you, you just need to look in the right place lol jokes on me. I orginnaly had this and a few other things in my notarization script to get python notarized. codesign --force --op

[issue42560] Improve Tkinter Documentation

Change by Mark Roseman : -- pull_requests: +26306 pull_request: https://github.com/python/cpython/pull/27842 ___ Python tracker ___

[issue44524] __name__ attribute in typing module

Jelle Zijlstra added the comment: I don't think we need to support Annotated as a base class. PEP 593 is titled "Flexible function and variable annotations", and base classes are neither of those things. None of the examples in the PEP or the implementation use Annotated as a base class eith

[issue44524] __name__ attribute in typing module

Ken Jin added the comment: > Now a subclass of an Annotated alias is a generic type. Should it be? I'm unsure if Annotated should be subclassable in the first place, but if I understand PEP 593 correctly, class X(Annotated[int, (1, 10)]), should be equivalent to class X(int) right? If that's

[issue41322] unittest: deprecate test methods returning non-None values

Andrei Kulakov added the comment: I will add the test in the next 1-2 days, I should have asked if it's needed in this case.. -- ___ Python tracker ___ __

[issue44524] __name__ attribute in typing module

Change by Ken Jin : -- pull_requests: +26305 pull_request: https://github.com/python/cpython/pull/27841 ___ Python tracker ___ ___ P

[issue44957] typing docs: Mention PEP 604 syntax more prominently

Guido van Rossum added the comment: Thanks to both of you!! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue44923] Unittest incorrect result with argparse.ArgumentError in self asserRaises context

Change by Serhiy Storchaka : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Pyth

[issue41322] unittest: deprecate test methods returning non-None values

Change by Serhiy Storchaka : -- nosy: +andrei.avk, defreng, ezio.melotti, michael.foord, rbcollins, terry.reedy, xtreak, zach.ware ___ Python tracker ___ _

[issue44957] typing docs: Mention PEP 604 syntax more prominently

Ken Jin added the comment: Sure. Sebastian has created a really thorough PR at GH-27833 and I like it (with only one point for discussion). -- ___ Python tracker ___

[issue41322] unittest: deprecate test methods returning non-None values

Change by Terry J. Reedy : -- nosy: +lukasz.langa, serhiy.storchaka -fdrake, stefan, terry.reedy versions: +Python 3.11 -Python 3.7 ___ Python tracker ___ _

[issue44942] Add number pad enter bind to TK's simpleDialog

Change by Terry J. Reedy : -- resolution: -> rejected stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-

[issue44524] __name__ attribute in typing module

Serhiy Storchaka added the comment: There are some side effects of setting _name. In 3.9: >>> class X(Annotated[int, (1, 10)]): pass ... >>> X.__mro__ (, , ) In 3.10: >>> class X(Annotated[int, (1, 10)]): pass ... >>> X.__mro__ (, , , ) Now a subclass of an Annotated alias is a generic ty

[issue41322] unittest: deprecate test methods returning non-None values

Change by santhosh : -- nosy: +fdrake, stefan, terry.reedy versions: +Python 3.7 -Python 3.8 ___ Python tracker ___ ___ Python-bugs-

[issue41322] unittest: deprecate test methods returning non-None values

santhosh added the comment: def split_module_names(module): unnamed, named = set(), set() for name in dir(module): if not name.startswith('_'): attr = getattr(module, name) try: if hasattr(attr, '__name__'): named.add(n

[issue44921] dict subclassing is slow

Marco Sulla added the comment: Since probably Monica are taking her holidays, I try to decipher her answer. Probably, the more problematic function spotted by Monica is update_one_slot. I re-quote her sentence: update_one_slot looks for the parent implementation by trying to find the genera

[issue44957] typing docs: Mention PEP 604 syntax more prominently

Guido van Rossum added the comment: Ken, this sounds like a good idea. Can you help? -- nosy: +gvanrossum, kj ___ Python tracker ___ __

[issue42560] Improve Tkinter Documentation

Change by Mark Roseman : -- pull_requests: +26304 pull_request: https://github.com/python/cpython/pull/27840 ___ Python tracker ___

[issue42560] Improve Tkinter Documentation

Change by Mark Roseman : -- pull_requests: +26303 pull_request: https://github.com/python/cpython/pull/27839 ___ Python tracker ___

[issue42560] Improve Tkinter Documentation

Change by Mark Roseman : -- pull_requests: +26302 pull_request: https://github.com/python/cpython/pull/27838 ___ Python tracker ___

[issue42255] webbrowser.MacOSX is unused, untested and undocumented

Change by Dong-hee Na : -- keywords: +patch pull_requests: +26301 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27837 ___ Python tracker ___

[issue42560] Improve Tkinter Documentation

Change by Mark Roseman : -- pull_requests: +26300 pull_request: https://github.com/python/cpython/pull/27836 ___ Python tracker ___

[issue42560] Improve Tkinter Documentation

Change by Mark Roseman : -- pull_requests: +26299 pull_request: https://github.com/python/cpython/pull/27835 ___ Python tracker ___

[issue22239] asyncio: nested event loop

Douglas Raillard added the comment: Drive by comment: I landed on this thread for the exact same reason: > This situation is very frequent when e.g. a library is designed to be > async-first, and also provides a blocking API which just wraps the async code > by running it until complete. The

[issue44954] Bug in float.fromhex

Change by Mark Dickinson : -- keywords: +patch pull_requests: +26298 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27834 ___ Python tracker ___ _

[issue44957] typing docs: Mention PEP 604 syntax more prominently

Change by Sebastian Rittau : -- keywords: +patch pull_requests: +26297 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27833 ___ Python tracker ___

[issue44957] typing docs: Mention PEP 604 syntax more prominently

New submission from Sebastian Rittau : The new PEP 604 syntax for type unions should be mentioned more prominently in the typing docs, starting with Python 3.10. I'm preparing a PR for discussion. -- assignee: docs@python components: Documentation messages: 399919 nosy: docs@python, sr

[issue44524] __name__ attribute in typing module

Serhiy Storchaka added the comment: There are still cryptic TypeError messages for Annotated: >>> class X(Annotated[int | float, "const"]): pass ... Traceback (most recent call last): File "", line 1, in TypeError: metaclass conflict: the metaclass of a derived class must be a (non-strict

[issue44949] test_readline: test_auto_history_disabled() fails randomly on aarch64 RHEL8 Refleaks 3.9, 3.10 and 3.x

Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10, Python 3.11 ___ Python tracker ___ __

[issue44956] curses getch returns wrong value

New submission from Robert T McQuaid : This applies to Python 3.8 under Debian-11 Bullseye. Under curses getch should return the value of curses.KEY_B2 (350 decimal) when pressing the keypad 5. Instead it returns 574. The simple program following the signature block illustrates the problem.

[issue44942] Add number pad enter bind to TK's simpleDialog

Serhiy Storchaka added the comment: Tk does not bind KP_Enter in standard TK dialogs. I do not think we should introduce additional discrepancy between dialogs implemented in Tk and Python. Please file a feature request for Tk. If they add a binding for KP_Enter we will follow them. ---

[issue41322] unittest: deprecate test methods returning non-None values

Serhiy Storchaka added the comment: Tests are needed. -- resolution: fixed -> stage: resolved -> test needed status: closed -> open ___ Python tracker ___ ___

[issue42491] Tkinter wait_visibility hanging when used in thread

Steve Carll added the comment: This is a Tkinter problem and not a TK problem. I ended up working around the problem by forcing garbage collection before opening and after closing any Tkinter windows that are created from other Tkinter windows. Since adding this code I have not had the proble

[issue44954] Bug in float.fromhex

Mark Dickinson added the comment: The bug is in this line: https://github.com/python/cpython/blob/3db42fc5aca320b0cac1895bc3cb731235ede794/Objects/floatobject.c#L1467 which reads: (half_eps == 8 && (HEX_DIGIT(key_digit+1) & 1) != 0)) In the buggy case, key_digit=0 and the HEX_DI

[issue44946] Integer operations are inefficient for "medium" integers.

Change by Mark Shannon : -- keywords: +patch pull_requests: +26296 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27832 ___ Python tracker ___ ___

[issue44951] selector.EpollSelector: EPOLLEXCLUSIVE, round 2

David Gilman added the comment: Reflecting on this a bit I wonder if the best of all worlds is to have an EpollExclusiveSelector whose modify() implementation just unregisters and registers the file descriptor. -- ___ Python tracker

[issue44955] Method stopTestRun() is not always called for skipped tests

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +26295 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27831 ___ Python tracker ___

[issue44955] Method stopTestRun() is not always called for skipped tests

New submission from Serhiy Storchaka : Method startTestRun() is always called for the TestResult object implicitly created by TestCase.defaultTestResult() when no TestResult object is passed to TestCase.run(). But method stopTestRun() is not always called in pair with startTestRun() for skipp

[issue44954] Bug in float.fromhex

Mark Dickinson added the comment: Thanks for the report! I can reproduce the issue, and agree with your analysis. -- assignee: -> mark.dickinson nosy: +mark.dickinson versions: +Python 3.10, Python 3.11 ___ Python tracker

[issue41379] Configparser is not reading Indended Sections as Mentioned in Docs

Change by Roundup Robot : -- nosy: +python-dev nosy_count: 2.0 -> 3.0 pull_requests: +26294 pull_request: https://github.com/python/cpython/pull/27830 ___ Python tracker ___ __

[issue44954] Bug in float.fromhex

New submission from Pedro Gimeno : >>> float.fromhex('0x0.8p-1074') 0.0 >>> float.fromhex('0x.8p-1074') 5e-324 One of them is obviously wrong. It's the second one, because: - The smallest denormal is 0x1p-1074 - Therefore, 0x0.8p-1074 is a tie for rounding purposes. - The digit in the last plac

[issue44940] Hint the use of non-capturing group in re.findall() documentation

Vedran Čačić added the comment: Ah, now I see. When some_match.group(0) is called, the whole match is returned. So match can be considered kinda group (quasigroup?:). I see how it can be confusing: python usually starts indexing at 0, and someone might think that a .group(0) would be included

[issue44940] Hint the use of non-capturing group in re.findall() documentation

Vedran Čačić added the comment: It currently says: ...matches are returned in the order found. If one or more groups are present in the pattern, return a list of groups... I'm not quite sure how it could be clearer. Maybe "Alternatively" at the start of the second sentence? regexr does the

[issue44914] tp_version_tag is not unique when test runs with -R :

Ken Jin added the comment: I just realised I'm slightly wrong about identity checks -- there is a very very small chance where if the type object occupies the same address and the attribute is in a dynamically allocated __dict__ (and not some static slot), we can trick the checks and a segfa

[issue44941] Add check_methods function to standard library

Ken Jin added the comment: @finnjavier08 sorry, I'd misinterpreted your original message. Thanks for clarifying your intent! > I'd be happy to do the implementation and pull request once approval is given > and a module is decided on. I can't comment because I'm not an expert on collections

[issue44949] test_readline: test_auto_history_disabled() fails randomly on aarch64 RHEL8 Refleaks 3.9, 3.10 and 3.x

Łukasz Langa added the comment: New changeset 0215257c613d55bec27201683f3dcb00f1726536 by Miss Islington (bot) in branch '3.9': bpo-44949: Fix test_readline auto history tests (GH-27813) (GH-27822) https://github.com/python/cpython/commit/0215257c613d55bec27201683f3dcb00f1726536 --

[issue44850] Could operator.methodcaller be optimized using LOAD_METHOD?

Mark Shannon added the comment: If the problem is that methodcaller is not faster than a lambda, then why not use a lambda? Lambdas are just Python functions and calling them will get faster. We aren't going to spend time optimizing calls to methodcaller, so you might as well use a lambda.

[issue41322] unittest: deprecate test methods returning non-None values

Change by Łukasz Langa : -- versions: +Python 3.11 -Python 3.10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41322] unittest: deprecate test methods returning non-None values

Łukasz Langa added the comment: Thanks for reporting, Alexander, and Andrei for the patch! ✨ 🍰 ✨ -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue41322] unittest: deprecate test methods returning non-None values

Łukasz Langa added the comment: New changeset 3db42fc5aca320b0cac1895bc3cb731235ede794 by andrei kulakov in branch 'main': bpo-41322: added deprecation warning for tests returning value!=None (GH-27748) https://github.com/python/cpython/commit/3db42fc5aca320b0cac1895bc3cb731235ede794 ---

[issue44953] Add vectorcall on operator.itemgetter and attrgetter objects

Change by Dennis Sweeney : -- keywords: +patch pull_requests: +26293 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27828 ___ Python tracker ___ _

[issue44953] Add vectorcall on operator.itemgetter and attrgetter objects

New submission from Dennis Sweeney : ## Below are my benchmarks for this change. from operator import itemgetter, attrgetter from pyperf import Runner class MyClass: __slots__ = "a", "b" namespace = {'itemgetter': itemgetter, 'attrgetter': attrgetter, 'MyClass':

[issue36384] [security] CVE-2021-29921: ipaddress Should not reject IPv4 addresses with leading zeroes as ambiguously octal

Łukasz Langa added the comment: New changeset 98820250a3c9c131d3c2d57c4fc5260aebd8aa1d by Miss Islington (bot) in branch '3.9': bpo-36384: [doc] Mention CVE-2021-29921 fix in 3.8.12 (GH-27824) (GH-27827) https://github.com/python/cpython/commit/98820250a3c9c131d3c2d57c4fc5260aebd8aa1d --

[issue36384] [security] CVE-2021-29921: ipaddress Should not reject IPv4 addresses with leading zeroes as ambiguously octal

miss-islington added the comment: New changeset 1204dfc89cb3ed5e21dce32aed0339b7569fe1f9 by Miss Islington (bot) in branch '3.10': bpo-36384: [doc] Mention CVE-2021-29921 fix in 3.8.12 (GH-27824) https://github.com/python/cpython/commit/1204dfc89cb3ed5e21dce32aed0339b7569fe1f9 -- _

[issue27035] Cannot set exit code in atexit callback

Mike Hommey added the comment: > In 2.7 the only exception that _did_ change the exit code was SystemExit. (and only if it was the last thrown exception) -- ___ Python tracker __

[issue27035] Cannot set exit code in atexit callback

Mike Hommey added the comment: > I think we should change the documentation to expand the parenthetical " > (unless SystemExit is raised)" to a complete explanation of that special case. That would not be enough, since the case for other exceptions would still be ambiguous, as the described

[issue36384] [security] CVE-2021-29921: ipaddress Should not reject IPv4 addresses with leading zeroes as ambiguously octal

Change by miss-islington : -- pull_requests: +26291 pull_request: https://github.com/python/cpython/pull/27826 ___ Python tracker ___ __

[issue36384] [security] CVE-2021-29921: ipaddress Should not reject IPv4 addresses with leading zeroes as ambiguously octal

Change by miss-islington : -- pull_requests: +26292 pull_request: https://github.com/python/cpython/pull/27827 ___ Python tracker ___ __

[issue36384] [security] CVE-2021-29921: ipaddress Should not reject IPv4 addresses with leading zeroes as ambiguously octal

Łukasz Langa added the comment: New changeset 0fd66e46b2f472d0d206a185dc8892f4f0347cb6 by Łukasz Langa in branch 'main': bpo-36384: [doc] Mention CVE-2021-29921 fix in 3.8.12 (GH-27824) https://github.com/python/cpython/commit/0fd66e46b2f472d0d206a185dc8892f4f0347cb6 --

[issue44949] test_readline: test_auto_history_disabled() fails randomly on aarch64 RHEL8 Refleaks 3.9, 3.10 and 3.x

miss-islington added the comment: New changeset fc6ad0585e8133ee0fca05f0f8075b62fe71a95d by Miss Islington (bot) in branch '3.10': bpo-44949: Fix test_readline auto history tests (GH-27813) https://github.com/python/cpython/commit/fc6ad0585e8133ee0fca05f0f8075b62fe71a95d -- ___

[issue36384] [security] CVE-2021-29921: ipaddress Should not reject IPv4 addresses with leading zeroes as ambiguously octal

Łukasz Langa added the comment: New changeset 6ebfe8da6331bfcf54057f6e22a6f353a5621d35 by Łukasz Langa in branch '3.8': [3.8] bpo-36384: [doc] Correct typos in CVE-2021-29921 fix description (GH-27825) https://github.com/python/cpython/commit/6ebfe8da6331bfcf54057f6e22a6f353a5621d35 ---

[issue44830] Broken Mozilla devguide link in "Dealing with Bugs" doc section

Łukasz Langa added the comment: Thanks, everyone! ✨ 🍰 ✨ -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue36384] [security] CVE-2021-29921: ipaddress Should not reject IPv4 addresses with leading zeroes as ambiguously octal

Change by Łukasz Langa : -- pull_requests: +26290 pull_request: https://github.com/python/cpython/pull/27825 ___ Python tracker ___ _

[issue36384] [security] CVE-2021-29921: ipaddress Should not reject IPv4 addresses with leading zeroes as ambiguously octal

Change by Łukasz Langa : -- pull_requests: +26289 pull_request: https://github.com/python/cpython/pull/27824 ___ Python tracker ___ _

[issue44830] Broken Mozilla devguide link in "Dealing with Bugs" doc section

Łukasz Langa added the comment: New changeset fb6074f5d71a6f9802bad97a129378c9556ed8d3 by Miss Islington (bot) in branch '3.9': bpo-44830: [doc] Restore missing Mozilla devguide link (GH-27818) (GH-27821) https://github.com/python/cpython/commit/fb6074f5d71a6f9802bad97a129378c9556ed8d3 -

[issue44830] Broken Mozilla devguide link in "Dealing with Bugs" doc section

miss-islington added the comment: New changeset ad16f93942a398ca1ec9bba54bb9c53a4e121e75 by Miss Islington (bot) in branch '3.10': bpo-44830: [doc] Restore missing Mozilla devguide link (GH-27818) https://github.com/python/cpython/commit/ad16f93942a398ca1ec9bba54bb9c53a4e121e75 --

[issue44949] test_readline: test_auto_history_disabled() fails randomly on aarch64 RHEL8 Refleaks 3.9, 3.10 and 3.x

Change by miss-islington : -- pull_requests: +26288 pull_request: https://github.com/python/cpython/pull/27823 ___ Python tracker ___ __

[issue44949] test_readline: test_auto_history_disabled() fails randomly on aarch64 RHEL8 Refleaks 3.9, 3.10 and 3.x

Change by miss-islington : -- nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +26287 pull_request: https://github.com/python/cpython/pull/27822 ___ Python tracker _

[issue36384] [security] CVE-2021-29921: ipaddress Should not reject IPv4 addresses with leading zeroes as ambiguously octal

Change by Łukasz Langa : -- versions: +Python 3.10, Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44830] Broken Mozilla devguide link in "Dealing with Bugs" doc section

Change by miss-islington : -- pull_requests: +26286 pull_request: https://github.com/python/cpython/pull/27821 ___ Python tracker ___ __

[issue44830] Broken Mozilla devguide link in "Dealing with Bugs" doc section

Change by miss-islington : -- pull_requests: +26285 pull_request: https://github.com/python/cpython/pull/27820 ___ Python tracker ___ __

[issue44830] Broken Mozilla devguide link in "Dealing with Bugs" doc section

Łukasz Langa added the comment: New changeset 942d1a4284e9341df47c48d7c63e921136dc9719 by Jack DeVries in branch 'main': bpo-44830: [doc] Restore missing Mozilla devguide link (GH-27818) https://github.com/python/cpython/commit/942d1a4284e9341df47c48d7c63e921136dc9719 -- ___

[issue44079] [sqlite3] remove superfluous statement weak ref list from connection object

Erlend E. Aasland added the comment: Thanks Pablo for merging, and Berker for pushing me to investigate further. Highly appreciated! -- ___ Python tracker ___ ___