[issue12556] Disable size checks in mmap.mmap()

2012-07-27 Thread Ricky Ng-Adam
Ricky Ng-Adam rnga...@lophilo.com added the comment: I find this resolution to rejected somewhat questionable. It has been pointed that the mmap behavior in Python differs from the behavior of the underlying mmap as defined by the system documentation. I think the incorrect assumption here

[issue14432] Bug in generator if the generator in created in a C thread

2012-04-02 Thread Adam Tomjack
Adam Tomjack adam.tomj...@zuerchertech.com added the comment: For what it's worth, I think I've seen this bug in 2.6 and 2.5, using generators created in python threads, while profiling not tracing. I'm creating generators in one python thread and storing them in a variable. In a different

[issue14453] profile.Profile.calibrate can produce incorrect numbers in some circumstances

2012-03-30 Thread Adam Tomjack
New submission from Adam Tomjack adam.tomj...@zuerchertech.com: profile.Profile.calibrate can only produces a bias for the default timer. If you've specified a different timer, it will not be used when calibrating. Additionally, setting profile.Profile.bias will affect the computed bias

[issue6884] Impossible to include file in sdist that starts with 'build' on Win32

2012-02-26 Thread Adam Groszer
Adam Groszer agros...@gmail.com added the comment: Hello, On Sun, 26 Feb 2012 03:37:06 + you wrote: BTW if someone knows about a continuous integration service which provides Windows and Mac OS X VMs I’m all ears. ZTK (Zope toolkit) ended up with renting a windows (server) VM. http

[issue672115] Assignment to __bases__ of direct object subclasses

2012-02-23 Thread Adam Venturella
Adam Venturella aventure...@gmail.com added the comment: I too just found the same issue, dunno if it was settled on as being a bug per se. class object(object): pass Also worked for me. I don't feel great about doing that though. So I opted for more verbose name as not to collide

[issue13659] Add a help() viewer for IDLE's Shell.

2011-12-30 Thread Ron Adam
Ron Adam ron3...@gmail.com added the comment: What about having idle open a web browser session with pydocs new browse option? python3 -m pydoc -b We've added input fields to the pages that take the same input as help() command does. It also links to the online help pages, and you can view

[issue13607] Move generator specific sections out of ceval.

2011-12-23 Thread Ron Adam
Changes by Ron Adam ron3...@gmail.com: Removed file: http://bugs.python.org/file24047/f_why1.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13607

[issue13607] Move generator specific sections out of ceval.

2011-12-23 Thread Ron Adam
Ron Adam ron3...@gmail.com added the comment: Updated patch with suggested changes. It also has a cleaned up fast_block_end section. Concerning speed. What happens is (as Tim and Raymond have pointed out) that we can make some things a little faster, in exchange for other things being

[issue13607] Move generator specific sections out of ceval.

2011-12-21 Thread Ron Adam
Ron Adam ron3...@gmail.com added the comment: I think the time benefits I saw are dependent on how the C code is compiled. So it may be different on different compilers or the same compiler with only a very minor change. Some of the things I've noticed... A switch is sometimes slower

[issue13607] Move generator specific sections out of ceval.

2011-12-18 Thread Ron Adam
Changes by Ron Adam ron3...@gmail.com: Removed file: http://bugs.python.org/file23969/f_why.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13607

[issue13607] Move generator specific sections out of ceval.

2011-12-18 Thread Ron Adam
Ron Adam ron3...@gmail.com added the comment: New diff file. The main difference is I moved the saved why value to the tstate object instead of the frame object as why_exit. I'm not seeing the time savings now for some reason. Maybe the previous increase was a case of coincidental noise

[issue13607] Move generator specific sections out of ceval.

2011-12-15 Thread Ron Adam
New submission from Ron Adam ron3...@gmail.com: The following changes cleanup the eval loop and result in a pretty solid 2 to 3% improvement in pybench for me. And it is about 5% faster for long generators. * Change why enum type to int and #defines. And moved the why defines to opcode.h so

[issue13607] Move generator specific sections out of ceval.

2011-12-15 Thread Ron Adam
Ron Adam ron3...@gmail.com added the comment: A simple test to show the difference. BEFORE: $ python3 -mtimeit def y(n): for x in range(n): yield x sum(y(10)) 10 loops, best of 3: 3.87 usec per loop $ python3 -mtimeit def y(n): for x in range(n): yield x sum(y(100)) 10

[issue11682] PEP 380 reference implementation for 3.3

2011-12-07 Thread Ron Adam
Ron Adam ron3...@gmail.com added the comment: Thanks for the updated links Nick. There is a comment in the docs that recommends putting parentheses around any yield expression that returns a value. So it is in agreement with that in the function argument case. The grammar I used does keep

[issue11682] PEP 380 reference implementation for 3.3

2011-12-06 Thread Ron Adam
Ron Adam ron3...@gmail.com added the comment: There is a test for 'yield from' as a function argument without the extra parentheses. f(yield from x) You do need them in the case of a regular yield. f((yield)) or f((yield value)) Shouldn't the same rule apply in both cases

[issue11816] Refactor the dis module to provide better building blocks for bytecode analysis

2011-12-03 Thread Ron Adam
Ron Adam ron3...@gmail.com added the comment: Instead of a get_instructions() function, How about using a DisCode class that defines the API for accessing Opinfo tuples of a disassembled object. So instead of... for instr in dis.bytecode_instructions(thing): process(instr) You

[issue13003] Bug in equivalent code for itertools.izip_longest

2011-12-01 Thread Adam Forsyth
Adam Forsyth agfors...@gmail.com added the comment: This is marked as wont fix but has been fixed, the resolution should be changed. -- nosy: +agforsyth ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13003

[issue13062] Introspection generator and function closure state

2011-10-10 Thread Ron Adam
Changes by Ron Adam ron3...@gmail.com: -- nosy: +ron_adam ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13062 ___ ___ Python-bugs-list mailing

[issue13107] Text width in optparse.py can become negative

2011-10-05 Thread Adam Byrtek
New submission from Adam Byrtek adambyr...@gmail.com: Code snippet from optparse.py: 344 self.help_position = min(max_len + 2, self.max_help_position) 345 self.help_width = self.width - self.help_position Where self.width is initialized with the COLUMNS environment

[issue12398] Sending binary data with a POST request in httplib can cause Unicode exceptions

2011-09-22 Thread Adam Cohen
Adam Cohen a...@seatgeek.com added the comment: I encountered this issue as well. params is simply a bytestring, with no encoding. Workaround/proper solution is to cast the string as a bytearray with bytearray(params). -- nosy: +Adam.Cohen

[issue12973] int_pow() implementation is incorrect

2011-09-13 Thread Adam
New submission from Adam a...@netbsd.org: int_pow() (from Objects/intobject.c) shows incorrect results when Python is compiled with Clang (llvm.org); long story short: int_pow() function should use 'unsigned long' type instead of 'long' or some code gets optimised out. Please, refer

[issue12409] Moving Documenting Python to Devguide

2011-08-30 Thread Adam Woodbeck
Changes by Adam Woodbeck adam.woodb...@gmail.com: -- nosy: +adam.woodbeck ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12409 ___ ___ Python-bugs

[issue11176] give more meaningful argument names in argparse documentation

2011-08-30 Thread Adam Woodbeck
Changes by Adam Woodbeck adam.woodb...@gmail.com: -- nosy: +adam.woodbeck ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11176 ___ ___ Python-bugs

[issue12803] SSLContext.load_cert_chain() should accept a password argument

2011-08-24 Thread Adam Simpkins
Adam Simpkins a...@adamsimpkins.net added the comment: Good catch. Here's an updated patch to fix the missing decref in _pwinfo_set() The length check in _password_callback() applies to both callback functions and predefined strings. The C API always uses a callback, so _password_callback

[issue12803] SSLContext.load_cert_chain() should accept a password argument

2011-08-24 Thread Adam Simpkins
Adam Simpkins a...@adamsimpkins.net added the comment: OpenSSL doesn't appear to do any special handling for i18n, and just treats the strings as binary data. It uses fgets() to read the password from the terminal, so it will receive it however the terminal encodes it. It's not clear to me

[issue12803] SSLContext.load_cert_chain() should accept a password argument

2011-08-24 Thread Adam Simpkins
Adam Simpkins a...@adamsimpkins.net added the comment: Here's a patch with updates to the documentation to more fully specify the behavior of the password field, including specifying that strings will be encoded using UTF-8. -- Added file: http://bugs.python.org/file23043/ssl-password.4

[issue12803] SSLContext.load_cert_chain() should accept a password argument

2011-08-21 Thread Adam Simpkins
New submission from Adam Simpkins a...@adamsimpkins.net: The SSLContext.load_cert_chain() method should accept a password argument to use if the private key is encrypted. Currently it always uses OpenSSL's default password callback, which prompts the user interactively for a password. I've

[issue12803] SSLContext.load_cert_chain() should accept a password argument

2011-08-21 Thread Adam Simpkins
Adam Simpkins a...@adamsimpkins.net added the comment: It seems a bit strange to me to accept string types or callable in the same argument. If it just supported strings, people could still write password=somefunction(), right? The function is only called if the private key is encrypted

[issue12803] SSLContext.load_cert_chain() should accept a password argument

2011-08-21 Thread Adam Simpkins
Adam Simpkins a...@adamsimpkins.net added the comment: Here's a new patch that accepts any callable. The old patch only accepted actual function objects. -- Added file: http://bugs.python.org/file22975/ssl-password.2.patch ___ Python tracker rep

[issue12436] Provide reference to detailed installation instructions

2011-07-22 Thread Adam Woodbeck
Adam Woodbeck adam.woodb...@gmail.com added the comment: So what we're looking for is comprehensive HOWTOs for installing and running Python on Windows, OSX and Linux to be added to http://docs.python.org/howto/index.html? -- ___ Python tracker rep

[issue10503] os.getuid() documentation should be clear on what kind of uid it is referring

2011-07-21 Thread Adam Woodbeck
Changes by Adam Woodbeck adam.woodb...@gmail.com: -- nosy: +adam.woodbeck ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10503 ___ ___ Python-bugs

[issue12436] Provide reference to detailed installation instructions

2011-07-21 Thread Adam Woodbeck
Changes by Adam Woodbeck adam.woodb...@gmail.com: -- nosy: +adam.woodbeck ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12436 ___ ___ Python-bugs

[issue10608] Add a section to Windows FAQ explaining os.symlink

2011-07-05 Thread Adam Woodbeck
Changes by Adam Woodbeck adam.woodb...@gmail.com: -- nosy: +adam.woodbeck ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10608 ___ ___ Python-bugs

[issue10403] Use member consistently

2011-06-24 Thread Adam Woodbeck
Adam Woodbeck adam.woodb...@gmail.com added the comment: I was always under the impression attributes and methods were mutually exclusive. I've corrected the patch as requested. -- Added file: http://bugs.python.org/file22436/issue10403_v2.patch

[issue10403] Use member consistently

2011-06-24 Thread Adam Woodbeck
Changes by Adam Woodbeck adam.woodb...@gmail.com: Added file: http://bugs.python.org/file22438/issue10403_v3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10403

[issue10403] Use member consistently

2011-06-21 Thread Adam Woodbeck
Changes by Adam Woodbeck adam.woodb...@gmail.com: -- nosy: +adam.woodbeck ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10403 ___ ___ Python-bugs

[issue10403] Use member consistently

2011-06-21 Thread Adam Woodbeck
Adam Woodbeck adam.woodb...@gmail.com added the comment: I grepped the documentation in the cpython repository and replaced all mentions of member(s) with attribute(s) where I felt appropriate. I left mentions of members related to structs or any C documentation alone as I'm less confident

[issue12369] Revised core mentorship section of help.rst

2011-06-19 Thread Adam Woodbeck
New submission from Adam Woodbeck adam.woodb...@gmail.com: Here is the latest update to the devguide's help.rst for your consideration. It includes Nick's tweaks to what I originally submitted. -- components: Devguide files: help.rst.patch keywords: patch messages: 138668 nosy

[issue12278] Core mentorship mention in the devguide

2011-06-07 Thread Adam Woodbeck
New submission from Adam Woodbeck adam.woodb...@gmail.com: Jesse requested the devguide be updated to include a mention of the Python Mentors site. The attached patch is my rough draft. -- components: Devguide files: help.rst.patch keywords: patch messages: 137807 nosy: adam.woodbeck

[issue12278] Core mentorship mention in the devguide

2011-06-07 Thread Adam Woodbeck
Adam Woodbeck adam.woodb...@gmail.com added the comment: Éric, good point. I'll propose different wording when I have an opportunity later today. In the mean time, I'm certainly open to suggestions, especially as I get my feet wet. So you would also prefer a mention of the python-ideas

[issue12185] Decimal documentation lists first and second arguments, should be self and other

2011-06-03 Thread Adam Woodbeck
Adam Woodbeck adam.woodb...@gmail.com added the comment: Hi Francisco, I finally found time to create a patch for this issue. I was just saving the patch I wrote as your update arrived in my inbox. I've included my patch for good measure. It's better to have two proposed patches than none

[issue12185] Decimal documentation lists first and second arguments, should be self and other

2011-05-29 Thread Adam Woodbeck
Adam Woodbeck adam.woodb...@gmail.com added the comment: I propose: object.copy_sign(other) Return a copy of *object* with the sign set to be the same as the sign of *other*. This format is most familiar to me. But like Ezio wrote, all other methods referring to first and second

[issue12185] Decimal documentation lists first and second arguments, should be self and other

2011-05-29 Thread Adam Woodbeck
Adam Woodbeck adam.woodb...@gmail.com added the comment: Or rather: object.copy_sign(other) Return a copy of *object* with the sign set to be that of *other*. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12185

[issue12185] Decimal documentation lists first and second arguments, should be self and other

2011-05-29 Thread Adam Woodbeck
Adam Woodbeck adam.woodb...@gmail.com added the comment: Sorry guys. I'm new at this. After reviewing this thread, Terry's suggestion makes the most sense to me. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12185

[issue12185] Decimal documentation lists first and second arguments, should be self and other

2011-05-28 Thread Adam Woodbeck
Changes by Adam Woodbeck adam.woodb...@gmail.com: -- nosy: +adam.woodbeck ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12185 ___ ___ Python-bugs

[issue11699] Doc for optparse.OptionParser.get_option_group is wrong

2011-05-28 Thread Adam Woodbeck
Changes by Adam Woodbeck adam.woodb...@gmail.com: -- nosy: +adam.woodbeck ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11699 ___ ___ Python-bugs

[issue11644] Cross-link 2to3 documentation, what’s new and pyporting howto

2011-05-28 Thread Adam Woodbeck
Changes by Adam Woodbeck adam.woodb...@gmail.com: -- nosy: +adam.woodbeck ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11644 ___ ___ Python-bugs

[issue11203] gzip doc is behind

2011-05-28 Thread Adam Woodbeck
Changes by Adam Woodbeck adam.woodb...@gmail.com: -- nosy: +adam.woodbeck ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11203 ___ ___ Python-bugs

[issue11785] email subpackages documentation problems

2011-05-28 Thread Adam Woodbeck
Changes by Adam Woodbeck adam.woodb...@gmail.com: -- nosy: +adam.woodbeck ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11785 ___ ___ Python-bugs

[issue11786] ConfigParser.[Raw]ConfigParser optionxform()

2011-04-06 Thread Adam Groszer
New submission from Adam Groszer agros...@gmail.com: The documentation http://docs.python.org/library/configparser.html states that optionxform() is used only beginning ConfigParser.ConfigParser, whereas it is ALSO in effect for ConfigParser.RawConfigParser. (As I checked in the source

[issue11741] shutil2.copy fails with destination filenames

2011-04-02 Thread Adam Matan
New submission from Adam Matan a...@matan.name: shutil.copy2(file, dest) fails when dest has unicode characters: [2011-04-02 17:19:54 adam@adam-laptop ~/personal :) ]$ python Python 2.6.5 (r265:79063, Apr 16 2010, 13:57:41) [GCC 4.4.3] on linux2 Type help, copyright, credits or license

[issue11741] shutil2.copy fails with destination filenames

2011-04-02 Thread Adam Matan
Adam Matan a...@matan.name added the comment: Don't you think that shutil should be able to handle mixed data types, for example byte string as file name and unicode destination directory? This is, in my opinion, a very common scenario. Would you consider converting all arguments to Unicode

[issue11741] shutil2.copy fails with destination filenames

2011-04-02 Thread Adam Matan
Adam Matan a...@matan.name added the comment: Don't you think it should be changed in Python 2.x, so that the ASCII filename will be automatically converted to to Unicode? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue11741] shutil2.copy fails with destination filenames

2011-04-02 Thread Adam Matan
Adam Matan a...@matan.name added the comment: Do you think it should be fixed at the module level? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11741

[issue11444] logging FileHandler.close should acquire its lock before closing stream

2011-03-08 Thread Adam Ernst
New submission from Adam Ernst adamjer...@gmail.com: This is my first report, apologies if I missed any tracker etiquette. The logging module registers shutdown() to run via atexit. shutdown() calls flush() and close() on each handler. However if a FileHandler is writing to a file while

[issue2571] cmd.py always uses raw_input, even when another stdin is specified

2011-02-17 Thread Ron Adam
Changes by Ron Adam ron_a...@users.sourceforge.net: -- nosy: +ron_adam ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2571 ___ ___ Python-bugs-list

[issue11182] pydoc.Scanner class not used by anything

2011-02-10 Thread Ron Adam
New submission from Ron Adam ron_a...@users.sourceforge.net: There doesn't seem to be any references to it in any other part of pydoc, or the Library for that matter. Searching for it on google code search (and also google web search) only turns up auto generated API references for python

[issue9364] some problems with the documentation of pydoc

2011-02-04 Thread Ron Adam
Changes by Ron Adam ron_a...@users.sourceforge.net: -- nosy: +ron_adam ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9364 ___ ___ Python-bugs-list

[issue1038909] pydoc method documentation lookup enhancement

2011-02-03 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: I agree. It is close enough to be a duplicate. I suggest closing it. As Ka-Ping noted in the other issue: There's a link to the base class provided if you want to find out what the base class does. This is easy to do if your viewing

[issue10716] Modernize pydoc to use CSS

2011-01-30 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: A reminder: Check for instances where html.escape is not called on data inserted into the html pages. I'll update the patch as the non-css (error handling) parts made it into python 3.2

[issue10961] Pydoc touchups in new browser for 3.2

2011-01-29 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: New and hopefully last patch... pydoc_misc_fix_e.diff I removed the .html in the ?key= links as Eric suggested. I checked the navbar float behavior on browsershots.org. Multiple versions of MSIE, firefox, opera, chrome, and safari

[issue10961] Pydoc touchups in new browser for 3.2

2011-01-23 Thread Ron Adam
Changes by Ron Adam ron_a...@users.sourceforge.net: Removed file: http://bugs.python.org/file20473/pydoc_misc_fix_c.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10961

[issue10961] Pydoc touchups in new browser for 3.2

2011-01-21 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: George, My apologies to you for the late corrections. And thanks for doing this. Eric, I replied to your comments on Rietveld. Thanks for taking a look. I'll wait until you have a chance to reply and test it, then upload a new patch

[issue10961] Pydoc touchups in new browser for 3.2

2011-01-20 Thread Ron Adam
New submission from Ron Adam ron_a...@users.sourceforge.net: A collection of small fix's that only effect the new browser mode. * Change title of html pages from Python ... to PyDoc * Fixed unterminated div float for items returned without a header. example: str, None, True

[issue10961] Pydoc touchups in new browser for 3.2

2011-01-20 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: new patch... Adjusted a comment in the _gettopic method. Everything else the same. -- Added file: http://bugs.python.org/file20468/pydoc_misc_fix.diff ___ Python tracker rep

[issue10961] Pydoc touchups in new browser for 3.2

2011-01-20 Thread Ron Adam
Changes by Ron Adam ron_a...@users.sourceforge.net: Removed file: http://bugs.python.org/file20467/pydoc_misc_fix.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10961

[issue10961] Pydoc touchups in new browser for 3.2

2011-01-20 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: A few last minute changes.. I think this will be all. Run topic contents through html.markup. That makes ref:, pep:, and html: links if they exist. (I meant to this earlier.) Fix case where topic reference links are to objects

[issue10961] Pydoc touchups in new browser for 3.2

2011-01-20 Thread Ron Adam
Changes by Ron Adam ron_a...@users.sourceforge.net: Removed file: http://bugs.python.org/file20468/pydoc_misc_fix.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10961

[issue10961] Pydoc touchups in new browser for 3.2

2011-01-20 Thread Ron Adam
Changes by Ron Adam ron_a...@users.sourceforge.net: -- nosy: +eric.araujo, rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10961

[issue10918] **kwargs unnecessarily restricted in concurrent.futures 'submit' API

2011-01-18 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: Yes, you are correct. Pulling the first value off of args would work. This is new for 3.2, can it still be changed? One more thing to consider... One of the things I look at for functions like these is, how easy is it to separate

[issue10918] **kwargs unnecessarily restricted in API

2011-01-17 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: Why is this surprising? def foo(c, c=None): ... pass ... File stdin, line 1 SyntaxError: duplicate argument 'c' in function definition In the previous examples, it finds the duplicate at run time instead of compile time due

[issue10918] **kwargs unnecessarily restricted in API

2011-01-17 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: Is this issue referring to something in Python's library, or a hypothetical function someone may write? If it's in the library, we can look at that case in more detail, otherwise, it's just a bad program design issue and there's

[issue10918] **kwargs unnecessarily restricted in concurrent.futures 'submit' API

2011-01-17 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: Here is the whole method for reference... def submit(self, fn, *args, **kwargs): with self._shutdown_lock: if self._shutdown_thread: raise RuntimeError('cannot schedule new futures after shutdown

[issue10918] **kwargs unnecessarily restricted in concurrent.futures 'submit' API

2011-01-17 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: Change... are never unpacked within submit. to... Are completely separate. It's the attempt to mix two function signatures together as one, that was/is the problem

[issue10818] pydoc: Remove old server and tk panel

2011-01-04 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: Here is a patch for this. Not much to it as the hard parts were already done. Apparently there was no tests for this, test_pydoc still passes without it. Does there need to be any messages for the -g option? Pydoc help is displayed

[issue10818] pydoc: refactorize duplicate DocHandler and DocServer classes

2011-01-03 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: No refactoring is needed. The second copies are part of the new server. The old server was depreciated in 3.2 and is supposed to be removed along with the tk panel for 3.3. After that there will only be one of each again

[issue10716] Modernize pydoc to use CSS

2011-01-02 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: If the colors are passed directly to the HTML they should be removed and left to the CSS(s) only. I don't know the code well enough to say if this is doable and/or if it requires a deprecation first; We may have to do dome

[issue10716] Modernize pydoc to use CSS

2011-01-02 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: To go forward I can create a new private api instead of changing HTMLDoc, that would be preferable. Should the -w option also use the new html pages? Or do we need a new option

[issue10716] Modernize pydoc to use CSS

2011-01-01 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: Here is a new diff which updates all the new pydoc pages to use the css file. The css file is simpler and cleaner. I also made a few adjustments to the url handler error handling, and changed the titles in the head sections so

[issue10716] Modernize pydoc to use CSS

2011-01-01 Thread Ron Adam
Changes by Ron Adam ron_a...@users.sourceforge.net: Removed file: http://bugs.python.org/file20081/defaultstyle.css ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10716

[issue10716] Modernize pydoc to use CSS

2011-01-01 Thread Ron Adam
Changes by Ron Adam ron_a...@users.sourceforge.net: Removed file: http://bugs.python.org/file20088/pydoc sample html files.zip ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10716

[issue10716] Modernize pydoc to use CSS

2011-01-01 Thread Ron Adam
Changes by Ron Adam ron_a...@users.sourceforge.net: Removed file: http://bugs.python.org/file20183/css_v1.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10716

[issue10716] Modernize pydoc to use CSS

2010-12-29 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: The HtmlDoc class has methods that take colors. Can this be changed or does it need to be depreciated first? def heading(self, title, fgcol, bgcol, extras=''): Format a page heading. return ''' table width=100

[issue10716] Modernize pydoc to use CSS

2010-12-29 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: It may be useful to change those to 'id=' and 'class=' if possible. It isn't clear to me how much of pydoc is still part of the public api in python 3.x. pydoc.__all__ is set only to ['help']. Entering help(pydoc) just gives

[issue10716] Modernize pydoc to use CSS

2010-12-28 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: Here is a tentative start on this. (css_v1.diff) The css file is much better. It's shorter, simpler and validated. The header and navbar panel use it in the new server. Added a markup call to the topic page contents. (The same

[issue10573] Consistency in unittest assert methods: order of actual, expected

2010-12-26 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: The issue10573.diff file with the time stamp 20:03 has a lot of document changes that don't have corresponding code changes? -- nosy: +ron_adam ___ Python tracker rep...@bugs.python.org http

[issue10087] HTML calendar is broken

2010-12-20 Thread Ron Adam
Changes by Ron Adam ron_a...@users.sourceforge.net: -- nosy: +ron_adam ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10087 ___ ___ Python-bugs

[issue10087] HTML calendar is broken

2010-12-20 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: The problem is in the following line... return ''.join(v).encode(encoding, xmlcharrefreplace) The .encode(encoding, xmlcharrefreplace) is returning a bytes object. Here is the simplest change to resolve the problem. return

[issue10087] HTML calendar is broken

2010-12-20 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: Oops. You're right. I miss understood how the encode method works in this particular case. ;-/ I agree with your comments as well. -- ___ Python tracker rep...@bugs.python.org http

[issue8916] Move PEP 362 (function signature objects) into inspect

2010-12-19 Thread Ron Adam
Changes by Ron Adam ron_a...@users.sourceforge.net: -- nosy: +ron_adam ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8916 ___ ___ Python-bugs-list

[issue10716] Modernize pydoc to use CSS

2010-12-16 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: I uploaded the css file I used in an experimental version of pydoc. It may give some useful starting values. Before this is done, the old server code should be removed (also for 3.3). (another issue?) There are two files

[issue10716] Modernize pydoc to use CSS

2010-12-16 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: Eric, most of what's in that file is what I figured out by trial and error in order to get it to work on the different browsers at that time. (about 3 years ago.) You are probably more experienced with css than I am, so you are more

[issue10716] Modernize pydoc to use CSS

2010-12-16 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: I think that's how I ended up with the style sheet I uploaded. It works, but it can be a slow process. Another factor is the pydoc server will reread an external style sheet on browser refreshes. So you can see the results of style

[issue10716] Modernize pydoc to use CSS

2010-12-16 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: Ok, I just looked at them again, I didn't remember how different it was. They probably won't be much help other than maybe seeing how some things could be done. Here's a zip file of some saved pages, so you can take a look

[issue9319] imp.find_module('test/badsyntax_pep3120') causes segfault

2010-12-15 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: Pydoc skips the badsysntax_pep3120 file for now. When this gets fixed that workaround should be removed. The work around is commented and refers to this issue #. -- ___ Python tracker rep

[issue10562] Change 'j' for imaginary unit into an 'i'

2010-12-03 Thread Adam Byrtek
Adam Byrtek adambyr...@gmail.com added the comment: What happened with there should be one-- and preferably only one --obvious way to do it? -- nosy: +adambyrtek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10562

[issue10562] Change 'j' for imaginary unit into an 'i'

2010-12-03 Thread Adam Byrtek
Changes by Adam Byrtek adambyr...@gmail.com: -- nosy: -adambyrtek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10562 ___ ___ Python-bugs-list

[issue10588] imp.find_module raises unexpected SyntaxError

2010-11-30 Thread Ron Adam
Changes by Ron Adam ron_a...@users.sourceforge.net: -- nosy: +ron_adam ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10588 ___ ___ Python-bugs

[issue2001] Pydoc interactive browsing enhancement

2010-11-27 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: Thanks for the review and style edits Éric. I think it's a much better patch with the changes and suggestions from you, Nick, and Alexander. I'll check my white space settings. Thanks for noticing it. As Nick points out, parts

[issue10509] PyTokenizer_FindEncoding can lead to a segfault if bad characters are found

2010-11-22 Thread Ron Adam
Ron Adam ron_a...@users.sourceforge.net added the comment: Is this a duplicate of issue 9319? -- nosy: +ron_adam ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10509

<    1   2   3   4   5   6   7   >