Alessandro Cucci added the comment:
Thanks Steven, I like the new name "target_time".
Just a question: why we need to check ``if number == 0:``? In the proposal you
asked for None too. What changed? Even if the function is called with False,
will it hurts to keep the default va
Change by Alessandro Cucci :
--
nosy: +acucci
___
Python tracker
<https://bugs.python.org/issue36424>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Alessandro Cucci :
--
pull_requests: +12880
___
Python tracker
<https://bugs.python.org/issue36461>
___
___
Python-bugs-list mailing list
Unsubscribe:
Alessandro Cucci added the comment:
Hello @Mariatta,
if this is simple I would like to work on that, can I?
Thanks!
--
nosy: +Alessandro Cucci
___
Python tracker
<https://bugs.python.org/issue36
Alessandro Cucci added the comment:
I would like to work on a patch if nobody currently are working on it. I'll
keep you updated
--
nosy: +acucci
___
Python tracker
<http://bugs.python.org/is
Alessandro Cucci added the comment:
Meanwhile I made corrections after @belopolsky latest review
--
Added file: http://bugs.python.org/file42063/issue19475_v17.patch
___
Python tracker
<http://bugs.python.org/issue19
Alessandro Cucci added the comment:
@belopolsky could you please review one of the latest two patches submitted? I
think I've done all required. Now I'll wait from you if I have to do more.
--
___
Python tracker
<http://bugs.python.o
Alessandro Cucci added the comment:
Oh, now I see your point.
I've uploaded a new patch with a note for that.
--
Added file: http://bugs.python.org/file42031/issue19475_v16.patch
___
Python tracker
<http://bugs.python.org/is
Alessandro Cucci added the comment:
New patch after @martin.panter comments on Rietveld. I left only this:
- ``'milliseconds'``: Append the hours, minutes, seconds and milliseconds.
> vadmium 2016/02/21 23:30:20
> I think this should explain that fractions are truncate
Changes by Alessandro Cucci :
Added file: http://bugs.python.org/file41994/issue19475_v14.patch
___
Python tracker
<http://bugs.python.org/issue19475>
___
___
Python-bug
Alessandro Cucci added the comment:
New patch
--
Added file: http://bugs.python.org/file41988/issue19475_v13.patch
___
Python tracker
<http://bugs.python.org/issue19
Alessandro Cucci added the comment:
I there anything else I can do for this?
--
___
Python tracker
<http://bugs.python.org/issue19475>
___
___
Python-bugs-list m
Alessandro Cucci added the comment:
up
--
___
Python tracker
<http://bugs.python.org/issue19475>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Alessandro Cucci :
Added file: http://bugs.python.org/file41476/doc.patch
___
Python tracker
<http://bugs.python.org/issue13305>
___
___
Python-bugs-list mailin
Alessandro Cucci added the comment:
Thanks @martin.panter, here is another patch made after your comments.
--
Added file: http://bugs.python.org/file41464/issue19475_v12.patch
___
Python tracker
<http://bugs.python.org/issue19
Alessandro Cucci added the comment:
Berker, thank you.
In the last patch, I removed details about timespec options in Python and C
docstrings, corrected the rst quotes, and checked PEP7 in the c file.
The only problem now is about versionchanged vs versionadded. I leave it as it
was, as
Alessandro Cucci added the comment:
what about the comment left by SilentGhost about versionadded?
--
___
Python tracker
<http://bugs.python.org/issue19
Alessandro Cucci added the comment:
quoting the docs:
The statement [nonlocal] allows encapsulated code to rebind variables outside
of the local scope BESIDES the global (module) scope.
--
___
Python tracker
<http://bugs.python.org/issue25
Alessandro Cucci added the comment:
I don't think the problem is about the underscores, since this work...
class Foo:
def f1(self):
__obj = object()
def f2():
nonlocal __obj
__obj = []
f2()
return isinstance(__obj, list)
Alessandro Cucci added the comment:
Sergei can you submit a patch?
Otherwise I can work on that, I have free time.
--
nosy: +acucci
___
Python tracker
<http://bugs.python.org/issue25
Alessandro Cucci added the comment:
> I think timespec= option should also be added to the time.isoformat method.
@belopolsky I've done it in my last patch.
--
Added file: http://bugs.python.org/file41420/issue19475_v10_datetime_ti
Alessandro Cucci added the comment:
Can anyone please review the c code of the last patch?
--
___
Python tracker
<http://bugs.python.org/issue19475>
___
___
Pytho
Alessandro Cucci added the comment:
Thanks SilentGhost!
--
Added file: http://bugs.python.org/file41391/issue19475_v9.patch
___
Python tracker
<http://bugs.python.org/issue19
Alessandro Cucci added the comment:
Sorry @SilentGhost, I didn't seen your comment at the bottom of the review.
With this patch is microsecond is 0, the time will display 6 zeroes.
--
Added file: http://bugs.python.org/file41388/issue19475_v8.
Changes by Alessandro Cucci :
Added file: http://bugs.python.org/file41387/issue19475_v7.patch
___
Python tracker
<http://bugs.python.org/issue19475>
___
___
Python-bug
Alessandro Cucci added the comment:
Uploaded a new patch after SilentGhost review comments.
As he told me, I've left out milliseconds and nanoseconds, but refactored both
python and c code so we could easily add support for them when they will be
available.
--
Added file:
Alessandro Cucci added the comment:
Uploaded a new patch.
This time I ran tests using:
$ ./python -m test -v test_datetime
and got no errors.
I've written the c docstring, updated docs, and rewrote _format_time function.
I know it's boring review this another time, but I'
Alessandro Cucci added the comment:
I just did that...
~/Documenti/cpython$ ./configure --with-pydebug
~/Documenti/cpython$ make -s -j2
~/Documenti/cpython$ ./python -m test -v datetimetester
...
...
--
Ran 325 tests in 1.128s
Alessandro Cucci added the comment:
Uploaded a new patch (v4):
DONE:
- now all tests work (I also added one more)
- removed non ascii chars
- added milliseconds and nanoseconds as multiple of microseconds
- removed code duplication in the datetime.py
- update the docstring.
TODO:
> The
Alessandro Cucci added the comment:
Thanks for all the comments, here and on Rietveld. I'll keep working on it.
Hope to upload a new patch soon.
--
___
Python tracker
<http://bugs.python.org/is
Alessandro Cucci added the comment:
I can work on that, although I'll need help from some senior dev. The problem
here is that millisecond and nanosecond seems not to be attributes of the
datetime object. What about open a new issue if we have to add them? Is not
about adding an optional
Alessandro Cucci added the comment:
Please can I have an update on this? It's already 4 months old, I'd like to see
it closed. :)
--
___
Python tracker
<http://bugs.python.o
Alessandro Cucci added the comment:
uploaded a new patch!
--
Added file: http://bugs.python.org/file40117/issue19475_v3.patch
___
Python tracker
<http://bugs.python.org/issue19
Changes by Alessandro Cucci :
Added file: http://bugs.python.org/file40057/issue24729_v4.patch
___
Python tracker
<http://bugs.python.org/issue24729>
___
___
Python-bug
Alessandro Cucci added the comment:
ok, this time I tested the render myself and seems ok. For rendering I used
sphinx. Sorry if I didn't try the final result in the first time, but I've
never had the chance to use rst files before.
--
Added file: http://bugs.python.org
Alessandro Cucci added the comment:
tried again :)
--
Added file: http://bugs.python.org/file40046/issue24729_v3.patch
___
Python tracker
<http://bugs.python.org/issue24
Alessandro Cucci added the comment:
@r.david.murray: just like that? (see patch v2)
--
Added file: http://bugs.python.org/file40045/issue24729_v2.patch
___
Python tracker
<http://bugs.python.org/issue24
Alessandro Cucci added the comment:
corrected
--
keywords: +patch
nosy: +acucci
Added file: http://bugs.python.org/file40033/issue24729.patch
___
Python tracker
<http://bugs.python.org/issue24
Alessandro Cucci added the comment:
udloaded a new patch, hope i had all bugs fixed!
--
___
Python tracker
<http://bugs.python.org/issue19475>
___
___
Python-bug
Changes by Alessandro Cucci :
Added file: http://bugs.python.org/file40024/issue19475_v2.patch
___
Python tracker
<http://bugs.python.org/issue19475>
___
___
Python-bug
Alessandro Cucci added the comment:
@haypo thanks for the review and the suggestions, I'll correct the code soon
--
nosy: +acucci
___
Python tracker
<http://bugs.python.org/is
Changes by Alessandro Cucci :
--
keywords: +patch
Added file: http://bugs.python.org/file40018/issue19475.patch
___
Python tracker
<http://bugs.python.org/issue19
42 matches
Mail list logo