Amaury Forgeot d'Arc added the comment:
Looks good to me, except for a 'stings' near the end of the patch.
--
nosy: +amaury.forgeotdarc
___
Python tracker
<http://bugs.py
Amaury Forgeot d'Arc added the comment:
I think you did the right thing already. The choice of which errors to catch
and which ones to let throw really depends on the usage
(what about permission or lock errors? other limitations due to a USB stick?
why is "disk full" diffe
Amaury Forgeot d'Arc added the comment:
How would you implement this? And would you turn a "disk full" error, for
example, into a ZipError as well?
--
nosy: +amaury.forgeotdarc
___
Python tracker
<http://bugs.pyt
Amaury Forgeot d'Arc added the comment:
How do you use it?
--
nosy: +amaury.forgeotdarc
___
Python tracker
<http://bugs.python.org/issue10444>
___
___
Pytho
Amaury Forgeot d'Arc added the comment:
Luke,
Please please! Don't make me say what I did not say. I just said "I disagree",
without any bad word. This may have been a bit terse, but I don't consider the
issue tracker as a place to express one's feelings; hey
Amaury Forgeot d'Arc added the comment:
> But different build system make new plaform!
Maybe, but not a new "sys.platform".
VC6 and VS9.0 don't share any project file for the compilation; but they both
build a sys.platform=='win32'.
Distutils has to use anoth
Amaury Forgeot d'Arc added the comment:
It is still time to add to 3.2 a DeprecationWarning when w9xpopen is used, and
remove the feature in 3.3.
See attached patch
--
keywords: +patch
nosy: +amaury.forgeotdarc
Added file: http://bugs.python.org/file19608/deprecate-w9xpopen.
Amaury Forgeot d'Arc added the comment:
> this is, after all, a new platform! it starts off with
> "sys.platform == 'mingw32'"
I disagree; programs compiled with mingw32 run on Windows, and use the MSVC
runtime. It's the same platform as the current wi
Amaury Forgeot d'Arc added the comment:
The patch looks good at first glance, but is there a way to test the feature?
--
nosy: +amaury.forgeotdarc
___
Python tracker
<http://bugs.python.org/is
Amaury Forgeot d'Arc added the comment:
> but the very very first thing that has to happen - before any of this
> work is begun - is for the distutils freeze to be lifted, or for
> someone to come up with a _sensible_ alternative solution.
Tarek's approach looks right to
Amaury Forgeot d'Arc added the comment:
I'm trying to read the patch. It contains many interesting things (and others I
have no opinon about), but it is very large, and makes it difficult to comment
or find why some change were made etc.
I do believe that better supporting t
Amaury Forgeot d'Arc added the comment:
Agreed. There was a similar issue in python2.6 with list comprehensions.
The issue is that both threads run the code with the same globals dictionary,
and top-level code use the same dict for locals and globals.
This is already fixed in 2.7 an
Amaury Forgeot d'Arc added the comment:
IMO a better patch would be to use the %R format specification:
PyErr_Format(
PyExc_TypeError, "expected some sort of mod, but got %R", obj);
And no need to use PyObject_Repr and the temporary variable!
--
nosy: +ama
Amaury Forgeot d'Arc added the comment:
- The patch modifies the _io module but not _pyio, why?
(try f=_pyio.open("XX","w+b") at the beginning of the script above)
- One test was *removed*, but nothing was added to test this new feature.
This is the most likely
Amaury Forgeot d'Arc added the comment:
This looks suspect (in function posix_write)::
if (!PyArg_ParseTuple(args, "iy*:write", &fd, &pbuf))
return NULL;
if (!_PyVerify_fd(fd))
return posix_error();
I'd prefer a "PyBuffer_Release(&p
Amaury Forgeot d'Arc added the comment:
This leaks one reference every time:
os.write(123456, b"b")
--
___
Python tracker
<http://bugs.pyt
Amaury Forgeot d'Arc added the comment:
This was changed by issue2522 on purpose; no suffix is allowed in
locale.format().
--
nosy: +amaury.forgeotdarc, r.david.murray
___
Python tracker
<http://bugs.python.org/is
Amaury Forgeot d'Arc added the comment:
Reproduced in a console window:
C:\>c:\python31\python.exe -m idlelib.idle
Exception in Tkinter callback
Traceback (most recent call last):
File "c:\python31\lib\tkinter\__init__.py", line 1399, in __call__
return self.fun
Amaury Forgeot d'Arc added the comment:
I'm sure the traceback changed then?
mode='r:' uses a different code path.
--
___
Python tracker
<http://bug
Amaury Forgeot d'Arc added the comment:
With a socket file you cannot rely on autodetection of the format. I suggest to
try
tarfile.open(fileobj=file_, mode='r:')
or
tarfile.open(fileobj=file_, mode='r:gz')
--
Amaury Forgeot d'Arc added the comment:
It's not about the hash value, but about consistency: help(Decimal.__hash__)
says "x.__hash__() <==> hash(x)", but this is not true for x=Decimal(-1).
--
nosy: +amaury.forgeotdarc
___
Amaury Forgeot d'Arc added the comment:
Antoine, should codecs.open() be removed or simply aliased to open()?
--
nosy: +amaury.forgeotdarc, pitrou
___
Python tracker
<http://bugs.python.org/is
Amaury Forgeot d'Arc added the comment:
> Why do you think this would be somehow an example for a blocking stream
> that does not write all data without raising an exception?
Well, that's what "clamping" means, isn't it?
--
__
Amaury Forgeot d'Arc added the comment:
On a second thought... is there another example where a *blocking* stream does
not write all the data without raising an exception?
--
___
Python tracker
<http://bugs.python.org/i
Amaury Forgeot d'Arc added the comment:
> Nice. Then I suggest a config macro for whether this is needed.
> Either a test for windows, or an autoconf thing in case some Unixes
> are equally sensible. (Linux isn't, I checked.)
I'm quite sure that all Unixes invoke
Amaury Forgeot d'Arc added the comment:
This issue is not really relevant on Windows:
- signals are actually run in a new thread specially created.
- errno is a thread-local variable; its value is thus local to the signal
handler, same for WSAGetLastError().
--
Amaury Forgeot d'Arc added the comment:
Fortunately, the lower-level write() has no such bug, at least when used in
binary mode as FileIO does: it's almost a direct call to WriteFile().
This issue is more considered because it's not a bug in the Microsoft CRT, but
in the Python
Amaury Forgeot d'Arc added the comment:
It's still an issue with 2.7, and even with 3.2a2, see issue9611.
--
nosy: +amaury.forgeotdarc
___
Python tracker
<http://bugs.python.
Amaury Forgeot d'Arc added the comment:
The code in socketmodule.c currently compile with suspect warnings:
socketmodule.c(3108) : warning C4047: 'function' : 'LPSTR' differs in levels of
indirection from 'int'
socketmodule.c(3108) : warning C4024: '
New submission from Amaury Forgeot d'Arc :
The following snippet should raise ValueError (twice :-)
f = open('foo', 'rb')
print(f.read1(1)) # OK
f.close()
print(f.read1(5)) # expected ValueError("I/O operation on closed file")
print(f.peek()) # expected
Amaury Forgeot d'Arc added the comment:
As promised, here is a quick review of the module.
https://code.launchpad.net/~proyvind/pyliblzma/py3k looks ready for a new entry
in the PyPI, but for inclusion in core python it needs some cleanup:
- I suppose that src/pyliblzma.c is the
Amaury Forgeot d'Arc added the comment:
The patch modifies _io.TextIOWrapper, but not _pyio.TextIOWrapper. Is there a
reason?
--
___
Python tracker
<http://bugs.python.org/is
Amaury Forgeot d'Arc added the comment:
About the patch: why should _PyUnicode_Init() try to call
_PyUnicode_InitGlobals() again?
--
___
Python tracker
<http://bugs.python.org/is
Amaury Forgeot d'Arc added the comment:
Does it happen when compiled in debug mode? There may be asserts that will give
a better (or earlier) error message.
Some thoughts: the '_PyTrash_delete_later' chain can only contain a limited set
of objects: lists, frames... (which c
Amaury Forgeot d'Arc added the comment:
The stack corresponds to the allocation of type(sys.float_info).__doc__.
Why would only this object appear as a memory leak? It is certainly not
deallocated, but all other types are in the same situation.
For example, sys.int_info is very similar
Amaury Forgeot d'Arc added the comment:
But this patch is a diff between a 2.7 and a 3.2 version of IDLE, isn't it?
The tkinter->Tkinter renaming is not supposed to happen in the 2.7 branch.
Could you instead show a diff between the present version of IDLE in 2.7 and
the result
Changes by Amaury Forgeot d'Arc :
--
assignee: -> jnoller
nosy: +jnoller
title: conn_recv_string() broken error handling -> multiprocessing:
conn_recv_string() broken error handling
___
Python tracker
<http://bugs.python.
Amaury Forgeot d'Arc added the comment:
Please, add a tiny unit test for the presence of this feature.
This is the only way for vm implementers to follow CPython development.
--
nosy: +amaury.forgeotdarc
stage: -> unit test needed
status: closed
Amaury Forgeot d'Arc added the comment:
Please add a similar warning in PC/_subprocess.c::sp_handle_dealloc()
I just got caught by this in PyPy because some pipe handle relies on reference
counting to be closed.
This ad-hoc fix would suppress the warning:
http://codespeak.net/pipe
Amaury Forgeot d'Arc added the comment:
Well, the syntax allows to pass either a string value (because it's a substring
of the command line), or nothing.
When no value is passed, True seems better than None, because this allows the
usage of the get() method::
x = sys.xoptions.g
Amaury Forgeot d'Arc added the comment:
_kill_with_event() does not wait for the subprocess to be ready.
It seems to me that the following test is wrong:
if m[0] == 0:
It should be "if m[0] == 1", since we want to check that the subprocess updated
the shared memory.
Amaury Forgeot d'Arc added the comment:
Why wouldn't they? A standard way to extend the command line options seems
useful in all environments.
Now the interpretation of these options are subject to variations of course...
--
nosy: +amaury.f
Amaury Forgeot d'Arc added the comment:
You already changed the test in r84449!
The doc still needs updating.
--
nosy: +amaury.forgeotdarc
___
Python tracker
<http://bugs.python.org/is
Amaury Forgeot d'Arc added the comment:
It looks very similar to issue6501.
Can you check if setting the environment variable
PYTHONIOENCODING=cp1252
solves the problem?
--
nosy: +amaury.forgeotdarc
___
Python tracker
<http://bugs.py
Amaury Forgeot d'Arc added the comment:
This also reproduces in 2.7.
2.6 and 2.7 have a different behaviour.
--
nosy: +amaury.forgeotdarc
versions: +Python 2.7
___
Python tracker
<http://bugs.python.org/is
Amaury Forgeot d'Arc added the comment:
A simpler change would to replace:
rv = self.obj.__lt__(other.obj)
with
rv = type(self.obj).__lt__(self.obj, other.obj)
--
nosy: +amaury.forgeotdarc
___
Python tracker
<http://bugs.py
Changes by Amaury Forgeot d'Arc :
--
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue5870>
___
___
Python-bugs-list mailing li
Amaury Forgeot d'Arc added the comment:
Arithmetic with void* pointers is not allowed by the Microsoft compilers. char*
should be used instead.
--
nosy: +amaury.forgeotdarc
___
Python tracker
<http://bugs.python.org/is
Amaury Forgeot d'Arc added the comment:
harobed, the -SKIP solution does not work. Doctest directives only apply to a
single line.
After a quick search, I found two workarounds there:
http://stackoverflow.com/questions/1809037/python-doctest-skip-entire-block
- Replace >>> with
Amaury Forgeot d'Arc added the comment:
I'm not a great doctest user, but did you try to disable the SKIP directive at
the end? something like "doctest: -SKIP"
--
___
Python tracker
<http://bu
Amaury Forgeot d'Arc added the comment:
Adapted patch for py3k and applied in r85239.
Maciek, if you have another tests for error handling, please open a new issue.
--
nosy: +amaury.forgeotdarc
resolution: -> fixed
status: open -> closed
___
Amaury Forgeot d'Arc added the comment:
David, can this issue be closed?
--
nosy: +amaury.forgeotdarc
___
Python tracker
<http://bugs.python.org/i
Amaury Forgeot d'Arc added the comment:
If it's a regression, it should be fixed in some 2.7.x release
Is there a patch somewhere?
--
nosy: +amaury.forgeotdarc
stage: -> needs patch
___
Python tracker
<http://bugs.pyth
Amaury Forgeot d'Arc added the comment:
There is already doctest.SKIP. Isn't it already what you want?
--
nosy: +amaury.forgeotdarc
___
Python tracker
<http://bugs.python.
Amaury Forgeot d'Arc added the comment:
> but Python 2.x doesn't appear to actually bother
> to compile dup2.c even if the system lacks dup2
Is it sure? The file configure.in has the same command in both versions:
AC_REPLACE_FUNCS(dup2 getcwd strdup)
Added the #include
Amaury Forgeot d'Arc added the comment:
- The "memory leaks" are reported in the IDE output window when the process
exits; this lists all non deallocated blocks of memory. This feature is not
enabled by default. Creating a CString probably initializes this feature.
- Py_Fin
Amaury Forgeot d'Arc added the comment:
Yes, sax parsers may split CHARACTER events. See also the discussion:
http://www.mail-archive.com/xml-...@python.org/msg00234.html
Again, the END_ELEMENT event is guaranteed to return the complete
Amaury Forgeot d'Arc added the comment:
Please read
http://docs.python.org/library/xml.etree.elementtree.html?highlight=elementtree#xml.etree.ElementTree.iterparse
At START_ELEMENT, the element is not guaranteed to be fully populated;
you should handle the END_ELEMENT event instead.
Amaury Forgeot d'Arc added the comment:
The C encoder should not be used when indent=0. Here is a patch+test for 2.7.
Note that json.dump (into a file object) already correctly emit newlines.
--
keywords: +patch
nosy: +amaury.forgeotdarc
Added file: http://bugs.python.org/file
Amaury Forgeot d'Arc added the comment:
Thanks for the confirmation!
--
resolution: -> accepted
___
Python tracker
<http://bugs.python.org/issue9369>
___
Amaury Forgeot d'Arc added the comment:
Martin, what do you think about this kind of changes? Are there possible
regressions or incompatibilities?
--
nosy: +amaury.forgeotdarc, loewis
___
Python tracker
<http://bugs.python.org/i
Amaury Forgeot d'Arc added the comment:
It's easy enough to subclass the Transport type and add custom types to the
dispatcher object, see the script below.
Attila, Bhargav, is this solution acceptable to you?
from xmlrpclib import Transport, ServerProxy
class MyTransport
Amaury Forgeot d'Arc added the comment:
Python 3.1 improves the situation, the file looks more like utf-16, except that
the BOM ("\xff\xfe") is repeated all the time, probably on every internal call
to file.write().
Here is a test script that should work on both 2.7 and 3.1.
Amaury Forgeot d'Arc added the comment:
A unit test is needed. Not to check the code, but to ensure that we don't break
it in the future.
--
nosy: +amaury.forgeotdarc
___
Python tracker
<http://bugs.python.
Amaury Forgeot d'Arc added the comment:
Too late for version 2. I updated patch for 3.2, and tried to improve the
documentation a little bit.
--
nosy: +amaury.forgeotdarc
versions: -Python 2.7, Python 3.1
Added file: http://bugs.python.org/file19100/pyclbr_nested_objects-py3k.
Changes by Amaury Forgeot d'Arc :
Added file: http://bugs.python.org/file19098/fatalhook-2.patch
___
Python tracker
<http://bugs.python.org/issue1195571>
___
___
Changes by Amaury Forgeot d'Arc :
Removed file: http://bugs.python.org/file19096/fatalhook-2.patch
___
Python tracker
<http://bugs.python.org/issue1195571>
___
___
Changes by Amaury Forgeot d'Arc :
Added file: http://bugs.python.org/file19096/fatalhook-2.patch
___
Python tracker
<http://bugs.python.org/issue1195571>
___
___
Amaury Forgeot d'Arc added the comment:
Here is a new patch; I lifted the pre-Py_Initialize() restriction, because it
seems to me that a wxPython application, for example, could use it.
A wxPython application is not embedded, but it already often redirects stdout
and even installs a seg
New submission from Amaury Forgeot d'Arc :
>From an old post on python-dev:
2010/08/04 Paul Kippes:
> For the most part, the information at
> http://www.python.org/download/releases/2.4/msi/ assisted me with
> automating a 2.7 installation on Windows XP. The following initial
&
New submission from Amaury Forgeot d'Arc :
When porting pypy to 2.7, we found that many tests actually exercise features
specific to CPython, either the garbage collector, or the precise memory layout
(__sizeof__).
They should be marked as such, and skipped when run with
Amaury Forgeot d'Arc added the comment:
+1 from me as well.
But shouldn't PyUnicode_AsWideCharString() merge surrogate pairs when it can?
The implementation doesn't do this.
--
nosy: +amaury.forgeotdarc
___
Python tracker
<http
Amaury Forgeot d'Arc added the comment:
"man sh" does not list [[:alpha:]]* as an accepted pattern. This is a glob
pattern, not a regular expression.
While the proposed patch may work for some environments, we should find a more
compatible way. Maybe a new case
"
Amaury Forgeot d'Arc added the comment:
Yes, mingw uses a different C runtime (msvcrt.dll) than Python (msvcr90.dll),
so file descriptors are completely different and this causes the error.
I can see two solutions:
- Use the same compiler as python26; I've also heard about a wa
Amaury Forgeot d'Arc added the comment:
the patch looks OK, but out of curiosity: do you really declare all the fields
of a PyTypeObject?
This structure is really designed so that newer members are left at the end;
most types don't need to initialize them, C standard ensures that th
Amaury Forgeot d'Arc added the comment:
the OP is right: str.upper is supposed to be locale-dependent
http://docs.python.org/library/stdtypes.html#str.upper
But the implementation uses _toupper() which is a macro with Visual Studio, and
obviously not locale-dependent:
#define _toupper(
Amaury Forgeot d'Arc added the comment:
The given script yields an item on a "start" event; but the element may not be
fully populated at this point. please read
http://docs.python.org/library/xml.etree.elementtree.html#xml.etree.ElementTree.iterparse
You should use the "
Amaury Forgeot d'Arc added the comment:
Which "SDK Example" are you referring to? I could not find any example.
--
___
Python tracker
<http://bugs.py
Amaury Forgeot d'Arc added the comment:
> the random data you run in interpreter 1 won't be the same data
> you run in interpreter 2
what about adding a simple "random.seed(12345)"
--
nosy: +amaury.forgeotdarc
___
Amaury Forgeot d'Arc added the comment:
With CPython, even objects that don't change see their reference counter
modified quite frequently, just by looking at them.
What kind of memory would you mark this way?
--
nosy: +amaury.f
Amaury Forgeot d'Arc added the comment:
Of course, you get the same error with:
>>> f = open('foo', 'wb')
>>> x, y = f
Traceback (most recent call last):
File "", line 1, in
IOError: File not open for reading
i.e. the tuple
Amaury Forgeot d'Arc added the comment:
The _multiprocessing module already have similar objects.
_multiprocessing.Connection is based on file descriptors (and initialized with
the result of os.pipe())
_multiprocessing.PipeConnection uses Windows named pipes.
--
Amaury Forgeot d'Arc added the comment:
yes, this was fixed by issue7150.
--
nosy: +amaury.forgeotdarc
resolution: -> out of date
status: open -> closed
superseder: -> datetime operations spanning MINYEAR give bad results
___
Python
Amaury Forgeot d'Arc added the comment:
issue6610 looks very similar. issue9074 may also be related.
--
nosy: +amaury.forgeotdarc
___
Python tracker
<http://bugs.python.org/i
Amaury Forgeot d'Arc added the comment:
Can you try to open a Command Prompt and type (with the quotes):
"C:\Program Files\Python\python.exe" "C:\Program
Files\Python\Lib\idle\idle.py"
Do you see error messages?
--
Amaury Forgeot d'Arc added the comment:
The patch looks good.
--
___
Python tracker
<http://bugs.python.org/issue9808>
___
___
Python-bugs-list mailing list
Amaury Forgeot d'Arc added the comment:
exit code = 128 + # of failed atexits
I don't agree with the feature. Do we need something so complex?
--
nosy: +amaury.forgeotdarc
___
Python tracker
<http://bugs.python.
Amaury Forgeot d'Arc added the comment:
OK, I reproduce the issue. It is now clear to me as well that r39492 was
slightly wrong: the replacement of "break" should avoid to execute the end of
the loop.
The following patch fixes the issue for me, can someone with better gdb
kno
Amaury Forgeot d'Arc added the comment:
Can you show an example which shows an incorrect lineno?
--
nosy: +amaury.forgeotdarc
___
Python tracker
<http://bugs.python.org/i
Changes by Amaury Forgeot d'Arc :
--
Removed message: http://bugs.python.org/msg117111
___
Python tracker
<http://bugs.python.org/issue1962>
___
___
Pytho
Changes by Amaury Forgeot d'Arc :
--
nosy: -BreamoreBoy
___
Python tracker
<http://bugs.python.org/issue1962>
___
___
Python-bugs-list mailing list
Unsubsc
Changes by Amaury Forgeot d'Arc :
Removed file: http://bugs.python.org/file18958/unnamed
___
Python tracker
<http://bugs.python.org/issue1962>
___
___
Python-bugs-l
Amaury Forgeot d'Arc added the comment:
yes, displaying the stderr content is a good idea.
--
stage: -> needs patch
___
Python tracker
<http://bugs.python.or
Amaury Forgeot d'Arc added the comment:
I don't think this should happen by default.
but what the user wants is already possible, by using the from_param() method.
For example, the AutoStrParam type converts everything to a string (and a
char*):
from ctypes import *
class Au
Amaury Forgeot d'Arc added the comment:
A non-empty stderr does not mean that a command failed.
For example, the Microsoft compiler "cl.exe" prints the version string to
stderr.
--
nosy: +amaury.forgeotdarc
___
Python
Amaury Forgeot d'Arc added the comment:
Removing select.PIPE_BUF does not seem a good idea to me because this breaks
compatibility. I suggest to simply set it to 512 on AIX.
(An ideal solution would be to really determine the actual buffer size in
./configure; this is probably ove
Amaury Forgeot d'Arc added the comment:
The remarks above haven't been addressed. The feature is OK, but the patch is
not yet perfect.
--
nosy: +amaury.forgeotdarc
___
Python tracker
<http://bugs.python.
Amaury Forgeot d'Arc added the comment:
yes, as you can see in the diffs, it's already in 3.2alpha2.
--
___
Python tracker
<http://bugs.python.
Amaury Forgeot d'Arc added the comment:
Of course, the implementation is now in the io module:
Modules/_io/_iomodule.c *and* Lib/_pyio.py
--
nosy: +amaury.forgeotdarc
___
Python tracker
<http://bugs.python.org/i
Amaury Forgeot d'Arc added the comment:
The fix was applied to trunk before the creation of the 2.7 branch.
There is nothing to backport
--
status: open -> closed
___
Python tracker
<http://bugs.python.or
801 - 900 of 2691 matches
Mail list logo