[issue46376] PyMapping_Check returns 1 for list

2022-01-23 Thread Aviram
Aviram added the comment: I sent it to sig-capi - https://mail.python.org/archives/list/capi-...@python.org/thread/T6DHEKHKKZIYU2GEPGHUQJ3DHTJXZGWW/ -- ___ Python tracker <https://bugs.python.org/issue46

[issue46376] PyMapping_Check returns 1 for list

2022-01-19 Thread Aviram
Aviram added the comment: Sure, I will do so. The proposal should be written here, right? -- ___ Python tracker <https://bugs.python.org/issue46376> ___ ___

[issue46376] PyMapping_Check returns 1 for list

2022-01-15 Thread Aviram
Aviram added the comment: I agree that a developer should and would prefer the `Py_TPFLAGS_*` but when you visit https://docs.python.org/3/c-api/sequence.html It seems like the best practice to determine Sequence protocol is by using this function, hence leading to confusion. There's

[issue46376] PyMapping_Check returns 1 for list

2022-01-14 Thread Aviram
Aviram added the comment: I submitted a draft patch. Using TPFlags alone doesn't cut it as some types are excluded (bytes, str, bytearray) in sequence and same for mapping. I'm thinking of checking for those cases specifically as those are very very specific casings. Would love some input

[issue46376] PyMapping_Check returns 1 for list

2022-01-14 Thread Aviram
Change by Aviram : -- keywords: +patch pull_requests: +28799 stage: -> patch review pull_request: https://github.com/python/cpython/pull/30600 ___ Python tracker <https://bugs.python.org/issu

[issue46376] PyMapping_Check returns 1 for list

2022-01-14 Thread Aviram
Aviram added the comment: Would checking the TPFLAGS for `Py_TPFLAGS_SEQUENCE` & `Py_TPFLAGS_MAPPING` when using `PySequence_Check` & `PyMapping_Check` be a valid fix? -- ___ Python tracker <https://bugs.python.org

[issue46376] PyMapping_Check returns 1 for list

2022-01-14 Thread Aviram
Aviram added the comment: https://github.com/PyO3/pyo3/issues/2072 Relevant discussion in PyO3 related issue -- ___ Python tracker <https://bugs.python.org/issue46

[issue46376] PyMapping_Check returns 1 for list

2022-01-14 Thread Aviram
Change by Aviram : -- nosy: +benjamin.peterson, bukzor, georg.brandl, jmillikin, levkivskyi, miss-islington, pitrou, rhettinger, serhiy.storchaka ___ Python tracker <https://bugs.python.org/issue46

[issue46376] PyMapping_Check returns 1 for list

2022-01-14 Thread Aviram
New submission from Aviram : This is re-open of https://bugs.python.org/issue5945. In the former issue, it was decided that documenting the odd behavior and later providing clean, good ABC C API would be the long term solution. Few years passed and there are no alternatives AFAIK I am

[issue40001] ignore errors in SimpleCookie

2020-10-24 Thread Aviram
Aviram added the comment: Hi all, still waiting for review. -- ___ Python tracker <https://bugs.python.org/issue40001> ___ ___ Python-bugs-list mailin

[issue40002] Cookie load error inconsistency

2020-03-18 Thread Aviram
Change by Aviram : -- keywords: +patch nosy: +aviramha nosy_count: 1.0 -> 2.0 pull_requests: +18411 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19058 ___ Python tracker <https://bugs.python.org/i

[issue40001] ignore errors in SimpleCookie

2020-03-18 Thread Aviram
New submission from Aviram : SimpleCookie (http/cookies.py) load method fails if one of the has an issue. In real life scenarios, we want to be tolerant toward faulty cookies, and just ignore those. My suggestion is to add ignore_errors keyword argument to the load method of SimpleCookie