[issue11709] help-method crashes if sys.stdin is None

2014-06-07 Thread B D
B D added the comment: added unit test for this behavior with roxane. verified that the updated patch applies cleanly, passes make patch check, and unit tests all pass. -- nosy: +bdettmer, roxane Added file: http://bugs.python.org/file35523/issue11709.patch

[issue11709] help-method crashes if sys.stdin is None

2014-06-07 Thread B D
B D added the comment: added try finally as suggested by berkerpeksag. make patchcheck still works and all test cases still pass. did not use the test.support.swap_attr context manager because it may inhibit readability for those that are not familiar with it. -- Added file: http

[issue11709] help-method crashes if sys.stdin is None

2014-06-07 Thread B D
B D added the comment: removed comments. -- Added file: http://bugs.python.org/file35531/issue11709.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11709

[issue11709] help-method crashes if sys.stdin is None

2014-06-07 Thread B D
B D added the comment: I've updated the unit test and have verified that it does fail when the original patch is not included. I also ran make patchcheck again and re-ran all of the tests. This should be good to go. Thanks for your insights, Benjamin. -- Added file: http