Barun Parruck added the comment:
Hi!
Okay, sorry for disappearing like that(this is becoming rather a habit isn't
it!), but with Gsoc applications, I've been insanely busy trying to get patches
and bugs accepted for my first Gsoc ever. I do apologize for leaving you
hanging, it was not my
Barun Parruck added the comment:
So...firstly hi, and sorry for disappearing like that!
You want tests for the dis.findlabels library? What sort of tests are you
looking for? Similiarly sized bytecode streams like the ones we worked with, or
did you have something else in mind?
B
Barun Parruck added the comment:
Hi, sorry, been pretty busy, and will be for a few days, so my replies may not
be instant!
Having looked through the dis test module, to be honest, I can't even find a
call to dis.findlabels...odd. Maybe I've got it wrong, and I wouldn't mind
somebody else
Barun Parruck added the comment:
Sorry, the previous file had a bug.
--
Added file: http://bugs.python.org/file42038/testfindlabels2.py
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Barun Parruck added the comment:
Four test cases have been included in the unittests, using the module unittest.
One is the original one you gave me, the others are some that I played around
with it, and thought would be useful to include.
I would love some code reviews at this point
Barun Parruck added the comment:
Hi, yes, that works much better, and I've definitely understood!
Now, about the tests, how large would you like them to be? For instance :
code = bytes (
chr(opmap["JUMP_FORWARD"]) + chr(0) + chr(255) +
chr(EXTENDED_ARG) + chr(
Barun Parruck added the comment:
Hi, I'm a little confused as to how to write a test using bytecode
streams...probably due to my lack of clarity as to what exactly dis.disassemble
does. Is there any way you could give me a bit more information
Barun Parruck added the comment:
The patch I forgot to attach. Ha ha.
--
keywords: +patch
Added file: http://bugs.python.org/file42035/preliminarypatch.diff
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Barun Parruck added the comment:
Allright, so I'm uploading a preliminary patch, please look through it to see
if I understood what you meant me to do about dis.findlabels.
The tests seem to mostly pass, except oddly enough, urlstdlib2, which is
probably system-specific?
I get the correct
Barun Parruck added the comment:
Hi, to check if I've done things right, which functions did you try out dis.dis
on?
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Barun Parruck added the comment:
I'll take a look at it! :) Would you like unit tests as well?
--
nosy: +Barun Parruck
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Barun Parruck added the comment:
Added a patch that changes the documentation to reflect TypeError instead of
ValueError*
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Barun Parruck added the comment:
I just changed the ValueError to TypeError. This is my first attempt at fixing
anything, so let me know if I've screwed up anywhere.
--
keywords: +patch
nosy: +Barun Parruck
Added file: http://bugs.python.org/file41712/typeerror.patch
13 matches
Mail list logo
