Changes by Benjamin Peterson :
--
pull_requests: +456
___
Python tracker
<http://bugs.python.org/issue29571>
___
___
Python-bugs-list mailing list
Unsubscribe:
Benjamin Peterson added the comment:
Why is the X11 locale alias map used at all? It seems like it can only create
confusion with libc.
--
nosy: +benjamin.peterson
___
Python tracker
<http://bugs.python.org/issue20
Changes by Benjamin Peterson :
--
pull_requests: +455
___
Python tracker
<http://bugs.python.org/issue29571>
___
___
Python-bugs-list mailing list
Unsubscribe:
Benjamin Peterson added the comment:
I don't see what's odd about it. re.LOCALE uses the C locale, which one
obtains from locale.getlocale(). getpreferredencoding() is not
documented to have anything to do with the C locale, and indeed on
Windows it may be completely
Benjamin Peterson added the comment:
getpreferredencoding() takes a completely different path on windows
(returns a codepage) and isn't related to the C locale.
--
___
Python tracker
<http://bugs.python.org/is
Benjamin Peterson added the comment:
But the test was never broken on windows.
On Sun, Mar 5, 2017, at 23:54, Serhiy Storchaka wrote:
>
> Serhiy Storchaka added the comment:
>
> I'm not sure this will help on Windows.
>
> --
>
> ___
Benjamin Peterson added the comment:
Yep, I think we should merge https://github.com/python/cpython/pull/422 and
revert ncoghlan's change.
--
nosy: +benjamin.peterson
___
Python tracker
<http://bugs.python.org/is
Changes by Benjamin Peterson :
--
pull_requests: +352
___
Python tracker
<http://bugs.python.org/issue29571>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Benjamin Peterson :
--
pull_requests: +351
___
Python tracker
<http://bugs.python.org/issue20087>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Benjamin Peterson :
--
resolution: fixed ->
status: closed -> open
___
Python tracker
<http://bugs.python.org/issue10513>
___
___
Python-bugs-
Benjamin Peterson added the comment:
C99 is required to build or include Python headers since 3.6. PEP 7 could be
clearer. The bullet about C99 is meant to override for 3.6 other directives
such as the comment prohibition.
--
resolution: -> not a bug
status: open ->
Benjamin Peterson added the comment:
Does that mean it no longer respects -fwrapv?
--
nosy: +benjamin.peterson
___
Python tracker
<http://bugs.python.org/issue29
Benjamin Peterson added the comment:
I think that's fine for 2.7.
On Mon, Jan 2, 2017, at 13:07, Christian Heimes wrote:
>
> New submission from Christian Heimes:
>
> OpenSSL 1.1.1 is going to provide TLS 1.3. The preferred protocols
> PROTOCOL_TLS (old
Benjamin Peterson added the comment:
Is there a reason to ever not use relative offsets? It seems that's strictly
more general the absolute.
--
___
Python tracker
<http://bugs.python.org/is
Benjamin Peterson added the comment:
https://docs.python.org/2/faq/programming.html#why-do-lambdas-defined-in-a-loop-with-different-values-all-return-the-same-result
--
nosy: +benjamin.peterson
resolution: -> not a bug
status: open ->
Benjamin Peterson added the comment:
Are you using that implementation on Python 2? Python 3's socket.listen has one
optional backlog argument.
--
nosy: +benjamin.peterson
resolution: -> not a bug
status: open -> closed
___
Python tra
Changes by Benjamin Peterson :
--
assignee: -> serhiy.storchaka
nosy: +serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issue29094>
___
___
Python-
Benjamin Peterson added the comment:
Right, my question is why does configure define HAVE_SYS_RANDOM_H if including
sys/random.h causes an error?
--
___
Python tracker
<http://bugs.python.org/issue29
Benjamin Peterson added the comment:
So, if sys/random.h can't be included without error why does the configure
check for it work?
--
___
Python tracker
<http://bugs.python.org/is
Benjamin Peterson added the comment:
BTW, at least for #25731, I think the right approach in the MI case is to
synthesize a __new__ on the subclass that calls the solid base __new__.
--
___
Python tracker
<http://bugs.python.org/issue5
Benjamin Peterson added the comment:
Why do you think this change caused that breakage? That bot looks like it's
been broken for days. This change should have no behavior change whatsoever for
Python itself.
--
___
Python tracker
Benjamin Peterson added the comment:
I think we should take this for 3.6.
--
assignee: -> ned.deily
nosy: +ned.deily
priority: normal -> release blocker
___
Python tracker
<http://bugs.python.org/i
New submission from Benjamin Peterson:
It looks like the test if not the fix for #15578 reveals a reference leak
somewhere in the import system:
$ ./python Lib/test/regrtest.py -R :: test_import
[1/1] test_import
beginning 9 repetitions
123456789
.
test_import leaked [1, 1, 1, 1
Benjamin Peterson added the comment:
I also think forcing callers to cast is fine. Most of our APIs require PyObject
*.
--
___
Python tracker
<http://bugs.python.org/issue28
Benjamin Peterson added the comment:
(Sorry, I noticed and landed a fix before completely reading the issue.)
--
___
Python tracker
<http://bugs.python.org/issue28
Benjamin Peterson added the comment:
It doesn't seem like the question is whether to use inline functions but
whether to force all callers to cast. Your original code would work if you
added all the casts in your static_inline.patch
Benjamin Peterson added the comment:
I don't mind if it gets updated.
On Wed, Nov 30, 2016, at 00:01, Serhiy Storchaka wrote:
>
> Serhiy Storchaka added the comment:
>
> Why not? 8.5.15 is 3 years old. There were 4 bugfix
Benjamin Peterson added the comment:
Doesn't seem terribly urgent, so maybe not 2.7.13.
--
___
Python tracker
<http://bugs.python.org/issue27647>
___
___
Benjamin Peterson added the comment:
Python just passes socket options to the operating system, so whatever behavior
you're seeing is likely part of the OS.
--
nosy: +benjamin.peterson
resolution: -> not a bug
status: open -> closed
___
Benjamin Peterson added the comment:
Yes, I suppose this falls under the general exemption in 2.x for -3
warning changes.
On Fri, Nov 25, 2016, at 09:13, Berker Peksag wrote:
>
> Berker Peksag added the comment:
>
> Roy's patch looks good to me in general. Benjamin, as the RM
Benjamin Peterson added the comment:
If python.org can be MITMed, it doesn't matter how secure the hash is.
On Tue, Nov 8, 2016, at 11:17, Big Stone wrote:
>
> Big Stone added the comment:
>
> I fear GPG is not easy stuff for Windows users.
>
> I fear a bunch of peo
Benjamin Peterson added the comment:
md5 is provided to verify the integrity of the download only. Use the GPG
signatures to verify authenticity if the fact that all the downloads are served
over HTTPS is insufficient.
--
nosy: +benjamin.peterson
resolution: -> wont fix
status: o
Benjamin Peterson added the comment:
I changed the dtrace stubs to static inline. Probably should reopen an
investigation for 3.7. I would like to have exportable inlines.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
Benjamin Peterson added the comment:
Any different results with CFLAGS="-fno-gnu89-inline"?
--
___
Python tracker
<http://bugs.python.org/issue28092>
___
___
Benjamin Peterson added the comment:
Please see https://docs.python.org/3/tutorial/floatingpoint.html
Python 3.5.2 (default, Sep 10 2016, 08:21:44)
[GCC 5.4.0 20160609] on linux
Type "help", "copyright", "credits" or "license" for more information.
>
Benjamin Peterson added the comment:
This is no different than this simpler case:
class A:
def __init__(self, name):
print("init {!r}".format(self))
self.name = name
def __repr__(self):
return "I am {}".format(self.name)
The instance of A doe
New submission from Benjamin Peterson:
Guido Vranken reports:
This results in a segmentation fault on 32 bit:
python -c "import _json; print
_json.encode_basestring_ascii(unicode(chr(0x22)) * 0x2AAB)"
This is a tentative patch:
diff --git a/Modules/_json.c b/Modules/_js
Benjamin Peterson added the comment:
ASan is quiet on the POC now.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Benjamin Peterson added the comment:
3.5 probably works.
On Thu, Sep 15, 2016, at 22:21, David wrote:
>
> David added the comment:
>
> Thanks.
>
> What is the last official version of Python which does support GCC
> versions
> < 4.3 ?
>
> On Fri, Sep 16, 2
Benjamin Peterson added the comment:
We don't support GCC versions < 4.3 anymore.
--
nosy: +benjamin.peterson
resolution: -> wont fix
status: open -> closed
___
Python tracker
<http://bugs.pyth
Benjamin Peterson added the comment:
I think that should take care of it (and also possible double-frees I noticed)?
--
nosy: +benjamin.peterson
___
Python tracker
<http://bugs.python.org/issue28
Benjamin Peterson added the comment:
lgtm
--
nosy: +benjamin.peterson
___
Python tracker
<http://bugs.python.org/issue28131>
___
___
Python-bugs-list mailin
Benjamin Peterson added the comment:
Here's a patch that requires 8-byte alignment. It almost completely works
except that on ABIs with 32-bit pointers, unicode objects can have their data
pointers aligned at only 4-bytes. Perhaps we can get away with requiring only
4-byte alignment on 3
Benjamin Peterson added the comment:
On Mon, Sep 12, 2016, at 10:34, Łukasz Langa wrote:
>
> Łukasz Langa added the comment:
>
> Benjamin, what's the rationale behind switching those to inline
> functions? Does it improve runtime performance or build speed? If not, I
> d
Benjamin Peterson added the comment:
GCC 4.3 was released in March 2008, so I think we are within our rights to drop
support for older toolchains.
--
___
Python tracker
<http://bugs.python.org/issue28
Benjamin Peterson added the comment:
I believe the unaligned memory access configure check is supposed to prevent
siphash from being used, so we might look into why that's not working.
IMO, though, we should just require alignment for the argument to
_PyHash_Bytes. It's private
Changes by Benjamin Peterson :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue28051>
___
___
Python-bugs-
Changes by Benjamin Peterson :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue27350>
___
___
Python-bugs-
Benjamin Peterson added the comment:
I'm not too worried about slowing down __module__ especially since it's
not any slower for heap types or types in builtins.
On Thu, Sep 8, 2016, at 14:39, Serhiy Storchaka wrote:
>
> Serhiy Storchaka added the comment:
>
> This is w
Benjamin Peterson added the comment:
I think it's better not write into the type dict in a getter. You might just
use PyUnicode_InternFromString every time.
FWIW, __name__ also has this behavior.
--
___
Python tracker
<http://bugs.py
Benjamin Peterson added the comment:
stc99 means "C99 + GCC extensions that aren't incompatible with the
standard". gnuc99 means "sort of C99 with whatever GNU weirdness"
On Thu, Sep 8, 2016, at 11:25, Christian Heimes wrote:
>
> Christian Heimes added the c
Benjamin Peterson added the comment:
Hmm, I prefer to compile with stdc99. I wonder if we should consider
this (presumably quite old) bluetooth.h to not exist if it doesn't work
with c99.
On Thu, Sep 8, 2016, at 02:49, Christian Heimes wrote:
>
> Christian Heimes added the comme
Benjamin Peterson added the comment:
It's strange because it seems to imply the system headers are
syntatically invalid.
--
___
Python tracker
<http://bugs.python.org/is
Benjamin Peterson added the comment:
I don't think it can be NULL either.
On Wed, Sep 7, 2016, at 11:36, Serhiy Storchaka wrote:
>
> Serhiy Storchaka added the comment:
>
> Indeed, the PyDict_Check() check can be omitted.
>
> --
>
> ___
Benjamin Peterson added the comment:
I don't understand why you need to check the validity of tp_dict at all. We
generally assume it's a dict.
--
___
Python tracker
<http://bugs.python.o
Benjamin Peterson added the comment:
I don't understand this code:
type->tp_dict && PyDict_Check(type->tp_dict)
since the code explicitly assume it's not NULL and access it as a dict earlier
in the function
--
nosy: +benjamin.peterson
__
Benjamin Peterson added the comment:
PEP 466 is explicitly not blanket approval for backporting All The
Things to 2.7. The only justification for pbkdf2 in PEP 466 is to "lower
the barriers to secure password storage and checking in Python 2 server
applications". While scrypt is prob
Benjamin Peterson added the comment:
Why are we adding scrypt and not argon2 anyway?
On Wed, Sep 7, 2016, at 03:25, Christian Heimes wrote:
>
> Christian Heimes added the comment:
>
> Benjamin, what's your take on Alex's suggestion?
>
> gutworth: Alex_Gaynor ha
Benjamin Peterson added the comment:
Sorry I missed this. The changes which I didn't already make look good. :)
--
___
Python tracker
<http://bugs.python.org/is
New submission from Benjamin Peterson:
ubsan complains about unaligned access when structs include "long double". An
example error:
runtime error: member access within misaligned address 0x7f77dbba9798 for
type 'struct CDataObject', which requires 16 byte alignment
Thi
Benjamin Peterson added the comment:
Thank you all for your advice. The buildbots seem to have survived the removal
of conditional includes of . I've also replaced most of the Python
compatibility aliases with the standard ones. Closing this issue.
--
resolution: -> fixe
Benjamin Peterson added the comment:
In 3.6, I just deprecated support for platforms without "long long".
https://bugs.python.org/issue27961 "deprecated" is a strong word because I
couldn't actually find a modern Python version that compiles without it. I'm
info
Benjamin Peterson added the comment:
MSVC 2008 (at least) is documented to have "long long", too.
https://msdn.microsoft.com/en-us/library/s3f49ktz(v=vs.90).aspx
In fact, after this patch, I'm probably going to go s/PY_LONG
Changes by Benjamin Peterson :
--
keywords: +patch
stage: -> patch review
Added file: http://bugs.python.org/file44384/longlong.patch
___
Python tracker
<http://bugs.python.org/issu
New submission from Benjamin Peterson:
Neither Python 2.7 nor 3.3+ compile without HAVE_LONG_LONG, so effectively this
is already completely unsupported. Let's completely dump it in 3.6.
--
components: Interpreter Core
messages: 274473
nosy: benjamin.peterson
priority: normal
sev
New submission from Benjamin Peterson:
dict_traverse shows up a lot on statistical profiles of Python programs. This
is not surprising since Python programs have lots of dicts. There isn't a huge
amount of room for optimization here, but we can avoid some memory indirection.
This patch
Benjamin Peterson added the comment:
Thank you, Armin.
--
nosy: +benjamin.peterson
___
Python tracker
<http://bugs.python.org/issue27811>
___
___
Python-bug
New submission from Benjamin Peterson:
Thomas E Hybel reports:
This vulnerability exists in /Modules/_operator.c in the function
methodcaller_new.
Here is the problematic code:
mc = PyObject_GC_New(methodcallerobject, &methodcaller_type);
if (mc == NULL)
return
New submission from Benjamin Peterson:
Thomas E Hybel reports:
This vulnerability exists in the function _sre_SRE_Match_groupdict_impl which
resides in the /Modules/_sre.c file.
The problem is that the code calls Py_DECREF(key); without having done a
corresponding Py_INCREF on the key.
Here&#
New submission from Benjamin Peterson:
Thomas E. Hybel reports:
This vulnerability exists in the function newPySSLSocket in /Modules/_ssl.c. The
problem is that Py_XDECREF is called on an object, self->server_hostname, which
isn't owned anymore.
The code looks like this:
New submission from Benjamin Peterson:
Thomas E Hybel reports:
This vulnerability resides in /Modules/binascii.c in the function
binascii_b2a_qp_impl. The problem is that the integer variable "odatalen" can
overflow to become a small number.
The function binascii_b2a_qp_impl qp-enco
Changes by Benjamin Peterson :
--
resolution: -> rejected
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue27754>
___
___
Python-bugs-
New submission from Benjamin Peterson:
Thomas E Hybel on PSRT reports:
This vulnerability is an integer overflow leading to a heap buffer overflow. I
have attached a proof-of-concept script below.
The vulnerability resides in the Modules/_csv.c file, in the join_append and
join_append_data
Benjamin Peterson added the comment:
Are you planning on sending us patches to make Python compile without open(2)?
Putting #ifdef around various constants is one thing but it seems like this
could become quite invasive.
--
___
Python tracker
Benjamin Peterson added the comment:
Why do you remove the flag rather than just making it a noop?
--
nosy: +benjamin.peterson
___
Python tracker
<http://bugs.python.org/issue27
Changes by Benjamin Peterson :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue27369>
___
___
Python-bugs-
Benjamin Peterson added the comment:
lgtm
--
nosy: +benjamin.peterson
___
Python tracker
<http://bugs.python.org/issue27301>
___
___
Python-bugs-list mailin
Benjamin Peterson added the comment:
Okay, I think it's fine then. However, you have a for loop in
compiler_subkwargs which only executes once.
--
___
Python tracker
<http://bugs.python.org/is
Benjamin Peterson added the comment:
Does this change break this function?
def subtle():
one = {-0. : 'a', -1: 'b'}
two = {0. : 'a', -1: 'b'}
assert all(math.copysign(1, x) < 0 for x in one)
assert any(math.copysign(1, x) > 0 for x i
Benjamin Peterson added the comment:
It seems to me a simpler solution would be allocate all nodes for a parse tree
in an arena.
--
___
Python tracker
<http://bugs.python.org/issue26
New submission from Benjamin Peterson:
Guido Vranken on PSRT report:
Python-2.7.11/Modules/_io/iobase.c iobase_readline():
531 old_size = PyByteArray_GET_SIZE(buffer);
532 PyByteArray_Resize(buffer, old_size + PyBytes_GET_SIZE(b));
533 memcpy(PyByteArray_AS_STRING
Benjamin Peterson added the comment:
On Thu, Jun 2, 2016, at 18:28, Martin Panter wrote:
>
> Martin Panter added the comment:
>
> FWIW I doubt Git is any better at this than Mercurial:
> <https://github.com/python/cpython/blame/master/Lib/test/test_string.py#L190>
>
Benjamin Peterson added the comment:
We should be able to commit it now. git blame can usually figure out
this stuff post facto.
On Thu, Jun 2, 2016, at 13:54, R. David Murray wrote:
>
> R. David Murray added the comment:
>
> Benjamin: meaning we should wait for git to merge it,
Benjamin Peterson added the comment:
I'm not too concerned about that. git can handle it well, which we will
have soon.
On Thu, Jun 2, 2016, at 12:50, Serhiy Storchaka wrote:
>
> Serhiy Storchaka added the comment:
>
> This is not so easy. After adding all the tests from te
Benjamin Peterson added the comment:
It probably makes sense to move test_pep292.py tests into test_string.py. Test
files named after peps are not very helpful.
--
nosy: +benjamin.peterson
___
Python tracker
<http://bugs.python.org/issue27
Benjamin Peterson added the comment:
I think the patch is okay except for the use of "-=" instead of the more
verbose version.
--
nosy: +benjamin.peterson
___
Python tracker
<http://bugs.python.o
Benjamin Peterson added the comment:
I'll have to think about how to fix this while maintaining compatiblity with
obscure cases like above.
--
___
Python tracker
<http://bugs.python.org/is
Benjamin Peterson added the comment:
That's just how Python works.
https://docs.python.org/3/faq/programming.html#how-do-i-create-a-multidimensional-list
--
nosy: +benjamin.peterson
resolution: -> not a bug
status: open -> closed
___
Pyt
Benjamin Peterson added the comment:
I don't completely understand. If you get an AttributeError for __enter__, will
you think only an __enter__ is required?
--
nosy: +benjamin.peterson
___
Python tracker
<http://bugs.python.org/is
Benjamin Peterson added the comment:
Fixing seems fine with me.
--
___
Python tracker
<http://bugs.python.org/issue21199>
___
___
Python-bugs-list mailin
Changes by Benjamin Peterson :
--
resolution: -> not a bug
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue26989>
___
___
Pyth
Changes by Benjamin Peterson :
--
resolution: -> third party
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue26813>
___
___
Pyth
Changes by Benjamin Peterson :
--
resolution: -> not a bug
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue26751>
___
___
Pyth
Benjamin Peterson added the comment:
I believe the correct behavior is actually
Traceback (most recent call last):
File "", line 1, in
File "bar.py", line 7, in
C()
TypeError: foo.A.__new__(C) is not safe, use foo.B.__new__()
This is because A comes before B in
Benjamin Peterson added the comment:
Thanks for the explanation. Your patch lgtm.
On Sat, Mar 26, 2016, at 15:01, Martin Panter wrote:
>
> Martin Panter added the comment:
>
> Socket objects aren’t exactly file-like. Plain non-SSL sockets don’t even
> have read() methods.
>
Benjamin Peterson added the comment:
Is this what other file-like objects do with negatives sizes?
--
nosy: +benjamin.peterson
___
Python tracker
<http://bugs.python.org/issue26
Benjamin Peterson added the comment:
Let's make Windows use the same version as the Mac installer.
--
assignee: benjamin.peterson -> steve.dower
___
Python tracker
<http://bugs.python.org
Benjamin Peterson added the comment:
The full case mappings do not preserve normalization form.
>>> for c in 'ΰ'.upper().lower(): print(unicodedata.name(c))
...
GREEK SMALL LETTER UPSILON
COMBINING DIAERESIS
COMBINING ACUTE ACCENT
>>> unicodedata.normalize('
Benjamin Peterson added the comment:
Can you add just one patch to seq_test.py?
--
___
Python tracker
<http://bugs.python.org/issue26492>
___
___
Python-bug
Benjamin Peterson added the comment:
The patch itself seems fine, so I committed that. It doesn't seem like how best
to test this has been figured out, so leaving the issue open.
--
nosy: +benjamin.peterson
resolution: fixed ->
stage: resolved ->
status: clo
901 - 1000 of 4969 matches
Mail list logo
