Berker Peksag added the comment:
All of the PyModule_AddIntMacro() changes have already been applied in
https://github.com/python/cpython/commit/6782b14bcba612e4a39e41992c77306217b91e30.
The remaining parts are:
-x = PyLong_FromLong((long)NSIG);
-if (!x || PyDict_SetItemString(d
Berker Peksag added the comment:
Some parts of the patch have already been applied into master:
* PySys_GetObject():
https://github.com/python/cpython/commit/7a5457b6878db61910c81017d10579edb7c91512
* PyDict_SetItem():
https://github.com/python/cpython/commit
Berker Peksag added the comment:
Eryk, would you like to address Steve's comments and convert your patch to a
GitHub pull request? Let me know if you don't have time to prepare a new patch.
--
nosy: +berker.peksag
versions: -Python 3.6,
Change by Berker Peksag :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue34420>
___
___
Berker Peksag added the comment:
Thanks for the report and for the patch! 3.5 is in security-fix-only mode, so
it doesn't get documentation fixes anymore.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: -> behavior
versions: +P
Berker Peksag added the comment:
New changeset 02c4d4b6dcd772ec3a7fdca517118f3fa53b0b88 by Berker Peksag (Miss
Islington (bot)) in branch '3.6':
bpo-34418: Fix HTTPErrorProcessor documentation (GH-8793)
https://github.com/python/cpython/commit/02c4d4b6dcd772ec3a7fdca517118f
Berker Peksag added the comment:
New changeset c53aaec793e018edef4e72a3edbd338b10db10aa by Berker Peksag
(Sebastian Rittau) in branch 'master':
bpo-34418: Fix HTTPErrorProcessor documentation (GH-8793)
https://github.com/python/cpython/commit/c53aaec793e018edef4e72a3edbd33
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.o
Berker Peksag added the comment:
The list has been updated in
https://github.com/python/cpython/commit/bf9d317626eebcf79bd0756b4dd43df82d5cc186
(Issue 31810
Closing this as 'outdated'. Thanks for the report and for the patch.
--
nosy: +berker.peksag
resolution: ->
Berker Peksag added the comment:
Ammar's pull request looks good to me, but it would be nice to include the
item's title in the box. I will add my comments about the design and
implementation in the pull request.
--
resolution: t
Berker Peksag added the comment:
New changeset e0b5b2096ead4cc094a129ce7602ac5c0e998086 by Berker Peksag in
branch 'master':
bpo-34384: Fix os.readlink() on Windows (GH-8740)
https://github.com/python/cpython/commit/e0b5b2096ead4cc094a129ce7602ac
Change by Berker Peksag :
--
nosy: +steve.dower
___
Python tracker
<https://bugs.python.org/issue34406>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
All PRs have been merged (commit message from the 3.6 branch doesn't listed
here but PR 7889 has been merged in
https://github.com/python/cpython/commit/8f8ad2c38237caf5ee48f690289e8c811d245455)
Closing this as 'fixed'. Please reopen if this
Berker Peksag added the comment:
ArgumentParser.parse_intermixed_arg() has been added in
https://github.com/python/cpython/commit/0f6b9d230674da784ca79a0cf1a03d2af5a8b6a8
(Issue 14191) and the "Upgrading optparse code" section now has the following
item:
Berker Peksag added the comment:
Thanks for the suggestions! I've updated PR 8740. I will submit separate PRs to
fix os.readlink() documentation in 3.6 and 3.7 branches.
--
___
Python tracker
<https://bugs.python.org/is
Berker Peksag added the comment:
In msg235615 (Issue 9949), Zachary said using bytes paths on Windows is
deprecated, but I can't see the actual conversation because Rietveld seems to
be down: https://bugs.python.org/review/9949/#ps5077 I think the os.readlink()
documentation needs
Berker Peksag added the comment:
Issue 20055 was a duplicate of this one. Both tests have been adjusted in
https://github.com/python/cpython/commit/3f48ac98c04fc17f12c63dcf593dd0c19379c7df.
--
dependencies: -os.chmod() does not follow symlinks on Windows,
os.path.realpath on
Berker Peksag added the comment:
Steve and/or Eryk, I was adding some tests for os.readlink() in PR 8740 and I
noticed that os.readlink() always returns str on Windows. However, the
documentation for os.readlink() says:
If the path is a bytes object (direct or indirectly), the result
Change by Berker Peksag :
--
components: +Library (Lib) -Argument Clinic
nosy: +eric.smith -larry
___
Python tracker
<https://bugs.python.org/issue34387>
___
___
Berker Peksag added the comment:
I'd suggest adding a FAQ entry to the "Core Language" section at
https://docs.python.org/3/faq/programming.html#core-language then we can link
to it from the places (except pydoc docs) Zachary listed in msg223893.
--
nosy:
Change by Berker Peksag :
--
keywords: +patch
pull_requests: +8225
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue34384>
___
___
Py
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.7, Python 3.8 -Python 3.5, Python 3.6
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
New changeset 8fc21c80af73226de875886132e0c32a4ffb32c5 by Berker Peksag (Miss
Islington (bot)) in branch '3.7':
bpo-26818: Add a test to make sure the bug is fixed (GH-8664)
https://github.com/python/cpython/commit/8fc21c80af73226de875886132e0c3
Berker Peksag added the comment:
New changeset 8fc21c80af73226de875886132e0c32a4ffb32c5 by Berker Peksag (Miss
Islington (bot)) in branch '3.7':
bpo-26818: Add a test to make sure the bug is fixed (GH-8664)
https://github.com/python/cpython/commit/8fc21c80af73226de875886132e0c3
Berker Peksag added the comment:
New changeset c8b0dbc4928a1fe4bd5abebd810b6849374c7af3 by Berker Peksag in
branch 'master':
bpo-26818: Add a test to make sure the bug is fixed (GH-8664)
https://github.com/python/cpython/commit/c8b0dbc4928a1fe4bd5abebd810b68
Berker Peksag added the comment:
New changeset c8b0dbc4928a1fe4bd5abebd810b6849374c7af3 by Berker Peksag in
branch 'master':
bpo-26818: Add a test to make sure the bug is fixed (GH-8664)
https://github.com/python/cpython/commit/c8b0dbc4928a1fe4bd5abebd810b68
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.o
Berker Peksag added the comment:
New changeset 84a13fbda0d79789e3c9efcc9f64752261ce1e8d by Berker Peksag in
branch 'master':
bpo-9372: Deprecate several __getitem__ methods (GH-8609)
https://github.com/python/cpython/commit/84a13fbda0d79789e3c9efcc9f6475
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 3.6
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
New changeset c614121224a5a81d958643471720645b1cb3166e by Berker Peksag (Miss
Islington (bot)) in branch '3.7':
bpo-34333: Fix %-formatting in Path.with_suffix() (GH-8663)
https://github.com/python/cpython/commit/c614121224a5a81d95864347172064
Berker Peksag added the comment:
New changeset 423d05f6f59b24c91b9ef6b2e4ac130316764382 by Berker Peksag in
branch 'master':
bpo-34333: Fix %-formatting in Path.with_suffix() (GH-8663)
https://github.com/python/cpython/commit/423d05f6f59b24c91b9ef6b2e4ac13
Berker Peksag added the comment:
This is probably a regression from the Argument Clinic conversion.
Another docstring mismatches:
select(rlist, wlist, xlist, timeout=None, /)
Wait until one or more file descriptors are ready for some kind of I/O.
>>> select.select(ti
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.7, Python 3.8 -Python 3.4, Python 3.5
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
New changeset 671a13a7b6ff1022a6fd868e5842687123ab9fd1 by Berker Peksag (Miss
Islington (bot)) in branch '3.6':
bpo-18540: Fix EAI_NONAME in imaplib.IMAP4*() (GH-8634)
https://github.com/python/cpython/commit/671a13a7b6ff1022a6fd868e584268
Berker Peksag added the comment:
New changeset 5799e5a84c78eac672e5f5f4f3fd2d903ba51a9d by Berker Peksag (Miss
Islington (bot)) in branch '3.7':
bpo-18540: Fix EAI_NONAME in imaplib.IMAP4*() (GH-8634)
https://github.com/python/cpython/commit/5799e5a84c78eac672e5f5f4f3fd2d
Berker Peksag added the comment:
New changeset e4dcbbd7f4ac18d01c0ec85f64ae98b8281ed403 by Berker Peksag in
branch 'master':
bpo-18540: Fix EAI_NONAME in imaplib.IMAP4*() (GH-8634)
https://github.com/python/cpython/commit/e4dcbbd7f4ac18d01c0ec85f64ae98
Change by Berker Peksag :
--
pull_requests: +8187
___
Python tracker
<https://bugs.python.org/issue2122>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Thanks for the report. wiki.python.org is maintained by the Python community,
not by Python core developers. You can fix those broken links by creating an
account and requesting edit access by emailing to pydotorg-...@python.org. See
https://wiki.python.org
Berker Peksag added the comment:
PR 8590 only changes dbm.gnu. If we do this, we should update dbm.ndbm as well:
https://github.com/python/cpython/blob/4a745333406a4b9c5b0194bdac4a77d9fadd5457/Modules/_dbmmodule.c#L65
--
nosy: +berker.peksag
type: -> enhancement
versi
Change by Berker Peksag :
--
nosy: +berker.peksag
type: -> enhancement
versions: +Python 3.7, Python 3.8 -Python 3.5
___
Python tracker
<https://bugs.python.org/issu
Change by Berker Peksag :
--
keywords: +patch
pull_requests: +8177
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Berker Peksag added the comment:
All changes (except PyUnicode_EncodeDecimal() which was deprecated in Python
3.3) have already been implemented in the following commits:
*
https://github.com/python/cpython/commit/c679227e31245b0e8dec74a1f7cc77710541d985
*
https://github.com/python/cpython
Berker Peksag added the comment:
It would be nice to remove PyCObject_* entries from Doc/data/refcounts.dat.
+.. _documentation: http://py3c.readthedocs.org/en/latest/capsulethunk.html
Nit: We could the HTTPS link.
--
nosy: +berker.peksag
stage: -> patch review
t
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
The documentation has been modernized in
https://github.com/python/cpython/commit/1d80a561734b9932961c546b0897405a3bfbf3e6
and the "Weak Reference Support" section has been updated to show the modern
way of adding weakref support:
https://
Change by Berker Peksag :
--
keywords: +patch
pull_requests: +8161
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue34171>
___
___
Py
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
New changeset 39fcd9949832323b672f7ff05fd1498b8844a329 by Berker Peksag (Miss
Islington (bot)) in branch '3.7':
bpo-34329: Doc'd how to remove suffix of pathlib.Path() (GH-8655)
https://github.com/python/cpython/commit/39fcd9949832323b672f7ff05
Berker Peksag added the comment:
New changeset 764f9d09b03654d7cd70d59afafafd51d24f2750 by Berker Peksag (Miss
Islington (bot)) in branch '3.6':
bpo-34329: Doc'd how to remove suffix of pathlib.Path() (GH-8655)
https://github.com/python/cpython/commit/764f9d09b03654d7cd70d59af
Change by Berker Peksag :
--
pull_requests: +8160
___
Python tracker
<https://bugs.python.org/issue31908>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Berker Peksag :
--
pull_requests: +8159
___
Python tracker
<https://bugs.python.org/issue26818>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Berker Peksag :
--
keywords: +patch
pull_requests: +8158
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
New submission from Berker Peksag :
import pathlib
path = pathlib.Path('TR')
with_suffix = path.with_suffix(('/', '.md'))
The snippet I shared above will raise:
TypeError: not all arguments converted during string formatting
While we are relying on du
Berker Peksag added the comment:
New changeset 46dc4e34ed8005a688d7f3512844ef227a3465f4 by Berker Peksag (Stefan
Otte) in branch 'master':
bpo-34329: Doc'd how to remove suffix of pathlib.Path() (GH-8655)
https://github.com/python/cpython/commit/46dc4e34ed8005a688d7f3512
Change by Berker Peksag :
--
superseder: -> test_subprocess.POSIXProcessTestCase fails in AMD64 Ubuntu 3.x
___
Python tracker
<https://bugs.python.org/issu
Berker Peksag added the comment:
Thanks for the PR, but we usually avoid unnecessary churn in Python codebase.
Both versions look fine, and deciding which one to use is just a matter of
personal taste.
--
components: -Windows
nosy: +berker.peksag -paul.moore, steve.dower
Berker Peksag added the comment:
This seems like a reasonable request. The feature was added in
https://github.com/python/cpython/commit/e50dafcd636ba32db890600164698bb070d40d97
(issue 20639) in Python 3.4.
I'd normally suggest adding a ".. versionchanged:: 3.4" marker
Berker Peksag added the comment:
> I suppose stable branches should be left alone?
We do backport lib2to3 PRs to maintenance branches, but since this is already
in 3.7 and 3.6 is four months away from being in security-fix-only mode, I
think we can close this as 'fi
Berker Peksag added the comment:
The workaround was removed in
https://github.com/berkerpeksag/cpython/commit/133138a284be1985ebd9ec9014f1306b9a425d98
Can this issue be closed now?
--
___
Python tracker
<https://bugs.python.org/issue27
Change by Berker Peksag :
--
components: +macOS
nosy: +ned.deily, ronaldoussoren
___
Python tracker
<https://bugs.python.org/issue34105>
___
___
Python-bug
Change by Berker Peksag :
--
pull_requests: +8139
___
Python tracker
<https://bugs.python.org/issue18540>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<https://bugs.python.org/issue25573>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Berker Peksag :
--
keywords: +patch
pull_requests: +8137
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.6
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
New changeset 295342adbfd905d5b4a77f960ea39649df7d9997 by Berker Peksag (Miss
Islington (bot)) in branch '3.6':
bpo-27910: Update documentation of traceback module (GH-6116)
https://github.com/python/cpython/commit/295342adbfd905d5b4a77f960ea396
Berker Peksag added the comment:
New changeset 0f9df886d6d1c6b239a2861a0ad0d56bb59e3922 by Berker Peksag (Miss
Islington (bot)) in branch '3.7':
bpo-27910: Update documentation of traceback module (GH-6116)
https://github.com/python/cpython/commit/0f9df886d6d1c6b239a2861a0ad0d5
Berker Peksag added the comment:
New changeset f394ee5eaf6d6d8f45e0478e77d4dbff25c6bea7 by Berker Peksag
(torsava) in branch 'master':
bpo-27910: Update documentation of traceback module (GH-6116)
https://github.com/python/cpython/commit/f394ee5eaf6d6d8f45e0478e77d4db
Berker Peksag added the comment:
The documentation you've quoted is for traceback.extract_tb().
traceback.format_tb() documentation only says:
A shorthand for ``format_list(extract_tb(tb, limit))``.
Issue 27910 is about updating the documentation of extract_tb(), format_list(),
Berker Peksag added the comment:
I ran "python3.7 -m test test_lib2to3" in a separate terminal. I don't remember
the exact location, but I'm sure it wasn't the build location (it was probably
my home directory)
Is it possible to add some debug print()s inside
Berker Peksag added the comment:
I've fixed a bug that uses DOMEventStream.__getitem__ at work today. I've
opened PR 8609 to deprecate __getitem__ methods of DOMEventStream, FileInput
and FileWrapper classes.
--
components: +Library (Lib)
nosy: +berker.peksag
versions: +
Change by Berker Peksag :
--
pull_requests: +8115
___
Python tracker
<https://bugs.python.org/issue9372>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
I'm not able to reproduce this:
./configure
make -s -j
sudo make install
python3.7 -m test test_lib2to3
Run tests sequentially
0:00:00 load avg: 0.86 [1/1] test_lib2to3
== Tests result: SUCCESS ==
1 test OK.
Total duration: 13 sec 456 ms
Change by Berker Peksag :
--
nosy: +vinay.sajip
___
Python tracker
<https://bugs.python.org/issue34307>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Berker Peksag :
--
assignee: -> berker.peksag
stage: -> needs patch
type: -> behavior
versions: +Python 3.7, Python 3.8
___
Python tracker
<https://bugs.python.or
Change by Berker Peksag :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue14266>
___
___
Pyth
Change by Berker Peksag :
--
keywords: +patch
pull_requests: +8076
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Berker Peksag added the comment:
HTMLParser.error() method was deprecated in Python 3.4
(https://github.com/python/cpython/commit/88ebfb129b59dc8a2b855fc93fcf32457128d64d#diff-1a7486df8279dbac7f20abd487947845R157)
and removed in Python 3.5
(https://github.com/python/cpython/commit
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: -> enhancement
___
Python tracker
<https://bugs.python
Change by Berker Peksag :
--
keywords: -needs review
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8 -Python 2.7, Python 3.5
___
Python tracker
<https://bugs.python.o
Berker Peksag added the comment:
Thanks for the report!
--
components: +Library (Lib) -Distutils
nosy: -dstufft, eric.araujo
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8
___
Pytho
Berker Peksag added the comment:
https://github.com/python/cpython/commit/ab994ed8b97e1b0dac151ec827c857f5e7277565
wasn't merged in the 2.7 branch, so this should only be reproduced in Python
3.6+.
--
components: -Interpreter Core
versions: +Python 3.8 -Pytho
Change by Berker Peksag :
--
keywords: +patch
pull_requests: +8028
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32215>
___
___
Py
Change by Berker Peksag :
--
keywords: +patch
pull_requests: +8027
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Berker Peksag added the comment:
msilib.Win64 has been removed in
https://github.com/python/cpython/commit/49ce74efe845a8a91939ff3990a5f233262d3e1f#diff-c762e09a046c2ff3cd91f0643cc58049L12
I guess the ``if msilib.Win64:`` clause can be replaced with ``if
msilib.AMD64
Berker Peksag added the comment:
This is expected, because there is a package named 'xml' in the Python standard
library. See
http://python-notes.curiousefficiency.org/en/latest/python_concepts/import_traps.html#the-name-shadowing-trap
and
http://python-notes.curiousefficie
Change by Berker Peksag :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue30722>
___
___
Pyth
Berker Peksag added the comment:
New changeset 9d85856044a2c7d681ea38b5ff99af375b228a0f by Berker Peksag in
branch '3.6':
bpo-30722: Fix NEWS entry (GH-8501)
https://github.com/python/cpython/commit/9d85856044a2c7d681ea38b5ff99af
Berker Peksag added the comment:
New changeset 7cbde0e09daba4259565738e48f141851287fe29 by Berker Peksag (Miss
Islington (bot)) in branch '3.7':
bpo-30722: Fix NEWS entries (GH-8501)
https://github.com/python/cpython/commit/7cbde0e09daba4259565738e48f141
Change by Berker Peksag :
--
pull_requests: +8023
___
Python tracker
<https://bugs.python.org/issue30722>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
New changeset 612dbefe9dfce0f67bce358613e472e913be8a57 by Berker Peksag in
branch 'master':
bpo-30722: Fix NEWS entries (GH-8501)
https://github.com/python/cpython/commit/612dbefe9dfce0f67bce358613e472
Change by Berker Peksag :
--
superseder: -> Efficient zero-copy for shutil.copy* functions (Linux, OSX and
Win)
___
Python tracker
<https://bugs.python.org/issu
Change by Berker Peksag :
--
nosy: -berker.peksag
___
Python tracker
<https://bugs.python.org/issue29411>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Berker Peksag :
--
pull_requests: +8019
stage: resolved -> patch review
___
Python tracker
<https://bugs.python.org/issue30722>
___
___
Python-
Change by Berker Peksag :
--
nosy: -berker.peksag
___
Python tracker
<https://bugs.python.org/issue22021>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Berker Peksag :
--
pull_requests: +8017
___
Python tracker
<https://bugs.python.org/issue8145>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Looking at this again, I think the current version of the documentation should
stay as-is. Perhaps my patch can make the insecure example separated from the
secure one, but I don't think it's worth to apply it.
--
resolution: -> r
Change by Berker Peksag :
--
nosy: +vinay.sajip
___
Python tracker
<https://bugs.python.org/issue34244>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8 -Python 3.5
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
New changeset defcffdf86780e3a184ebb25dc9a7b807753d57a by Berker Peksag in
branch 'master':
bpo-12743: Delete comment from marshal.rst (GH-8457)
https://github.com/python/cpython/commit/defcffdf86780e3a184ebb25dc9a7b
Berker Peksag added the comment:
Good catch, Zackery, thanks! This is indeed a duplicate of issue 11691.
--
resolution: -> duplicate
stage: needs patch -> resolved
status: open -> closed
superseder: -> sqlite3 Cursor.description doesn
401 - 500 of 3715 matches
Mail list logo