[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: I've tested the new patch and it is still able to properly find both chrome and firefox and is able to differentiate between new window and new tab for those two browsers so it is still working. Would someone review the patch

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: applying 25005_1.patch patching file Lib/webbrowser.py Hunk #1 FAILED at 498 Hunk #2 FAILED at 524 Hunk #3 FAILED at 532 Hunk #4 FAILED at 540 Hunk #5 FAILED at 548 I'm trying to apply your patch after applying webbrowserfix6.patch but I am encountering problems

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: Ok I've been able to test the new patch now and I'm not sure that os.startfile is going to work. I've been able to get os.startfile() to open a specified browser (>>> os.startfile("chrome.exe", "open")), however, the functi

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: Finally got it rebuilt after having trouble with visual studio for awhile. I've tested the new patch and it is still able to properly find both chrome and firefox and is able to differentiate between new window and new tab for those two browsers so it appears

[issue24452] Make webbrowser support Chrome on Mac OS X

Brandon Milam added the comment: Boštjan Mejak the windows issue has been addressed in issue 8232 and recently patched for 3.5. http://bugs.python.org/issue8232 -- nosy: +jbmilam ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: Moved the 64 bit browser list to its own loop and switched to browsers.append rather than +=. -- Added file: http://bugs.python.org/file39650/webbrowserfix6.patch ___ Python tracker rep...@bugs.python.org http

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: Here's a patch addressing all of the comments in the review. Changing the browsers from a set to a list though resulted in duplicates in the _tryorder list that were not present before because the set had filtered the duplicates before the partial string

[issue24148] 'cum' not a valid sort key for pstats.Stats.sort_stats

Brandon Milam added the comment: They are correct. 'cum' is not one of the available keywords and so here is the fix changing it to say 'cumulative' for consistency as ramiro suggested. -- keywords: +patch nosy: +jbmilam Added file: http://bugs.python.org/file39627

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: Forgive me the excessive number of patch submissions as I am still getting my feet wet in contributing to Python. I'm posting another patch that is not functionally different from the last patch but should better adhere to the PEP8 style guide. Please let me

[issue12020] Attribute error with flush on stdout,stderr

Brandon Milam added the comment: I've been looking over the issue and the error is just raised by the stdout change not the stderr change (when the stdout line is commented out in the setAutoFlush function no error is raised). The flush method doesn't seem to be required as Serhiy pointed out

[issue21297] csv.skipinitialspace only skips spaces, not whitespace in general

Changes by Brandon Milam jmilam...@gmail.com: -- keywords: +patch Added file: http://bugs.python.org/file39560/csv_skipinitialspace_docfix.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21297

[issue21297] csv.skipinitialspace only skips spaces, not whitespace in general

Changes by Brandon Milam jmilam...@gmail.com: Added file: http://bugs.python.org/file39559/csv_skipinitialspace_testing.csv ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21297

[issue21297] csv.skipinitialspace only skips spaces, not whitespace in general

Brandon Milam added the comment: This code shows what Daniel Andersson was talking about. I changed the whitespace references in the documentation that Daniel mentioned to say spaces. Also I changed ignore space at the start of the field to ignore spaces at the start of the field due

[issue24147] Dialect class defaults are not documented.

Brandon Milam added the comment: Here I added on to the Dialects and Formatting Parameters paragraph explaining that the defaults listed are for the excel dialect and that all the attributes need to be specified if the user is wanting to create custom dialects through sub-classing. I

[issue24147] Dialect class defaults are not documented.

Changes by Brandon Milam jmilam...@gmail.com: Added file: http://bugs.python.org/file39553/csv.html ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24147

[issue23659] csv.register_dialect doc string

Brandon Milam added the comment: I believe this was the requested change. Let me know if more was desired. -- keywords: +patch nosy: +jbmilam Added file: http://bugs.python.org/file39540/register_dialect_docstring_fix.patch ___ Python tracker rep

[issue23659] csv.register_dialect doc string

Brandon Milam added the comment: Sorry, I forgot an end parentheses in the doc string of the last patch. -- Added file: http://bugs.python.org/file39541/register_dialect_docstring_fix.patch ___ Python tracker rep...@bugs.python.org http

[issue24147] Dialect class defaults are not documented.

Brandon Milam added the comment: Hi all, I've been looking at this bug and am ready to start putting in some work on it but I have some questions about what is wanting to be done. From what I can tell these are the possible tasks for this issue. - Add to the docs under the dialect section

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: I went ahead and took the assert statement out and added support for vista using a union of sets for both the 32 bit and 64 bit locations. -- Added file: http://bugs.python.org/file39533/webbrowserfix3.patch

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: On second thought no type testing is required if sets are used because the union will take out duplicates anyways and so I removed the type testing and left in the set union code. -- Added file: http://bugs.python.org/file39534/webbrowserfix3.patch

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: I kept the changes to the WindowsDefault.open() method and used and extended eryksun's code to build the browser list using the registry. Also I added support for a few more browsers. Some of the browsers I could not find ways to differentiate between opening

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: I got rid of the __init__ for the WindowsDefault class that I asked about earlier and changed it to match the sub-classing model that the Unix browsers use. This caused some changes in the get function too. Due to the _isexecutable still not completely working

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: In order to fix the issue I added on to the WindowsDefault class so that it is the main browser class for windows platforms as opposed to being a default when no other browser is given. I gave the class an init where it specifies specific flags for firefox

[issue8232] webbrowser.open incomplete on Windows

Brandon Milam added the comment: How the _isexecutable function is set up now it would require a full path name in order to be able to tell if a specific browser is on the system. The area under platform support for windows checks for multiple browsers using this function but only passes