[issue29276] HTMLParser in Python 2.7 doesn't recognize image tags wrapped up in link tags

2017-01-14 Thread Brendan Donegan
Brendan Donegan added the comment: I even get the correct behaviour in 2.7.12: Python 2.7.12+ (default, Sep 17 2016, 12:08:02) [GCC 6.2.0 20160914] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> from HT

[issue29061] secrets.randbelow(-1) hangs

2016-12-27 Thread Brendan Donegan
Brendan Donegan added the comment: If I'm not mistaken, _randbelow is defined in Random, which SystemRandom inherits from. Just for clarity On Tue, 27 Dec 2016 at 22:08 Josh Rosenberg <rep...@bugs.python.org> wrote: > > Josh Rosenberg added the comment: > > SystemRan

[issue29061] secrets.randbelow(-1) hangs

2016-12-27 Thread Brendan Donegan
Brendan Donegan added the comment: Ok, here's a second version of the patch. Normally I don't like testing multiple things in one test but I've gone with what seems to be the convention here in test_secrets.py -- Added file: http://bugs.python.org/file46054/issue_29061_randbelow_v2

[issue29061] secrets.randbelow(-1) hangs

2016-12-27 Thread Brendan Donegan
Brendan Donegan added the comment: Hi Raymond, I have done that when creating the patch and have confirmation in my inbox - perhaps Ewa hasn't filed it yet? On Tue, 27 Dec 2016 at 14:43 Raymond Hettinger <rep...@bugs.python.org> wrote: > > Raymond Hettinger added the comment:

[issue29061] secrets.randbelow(-1) hangs

2016-12-24 Thread Brendan Donegan
Brendan Donegan added the comment: Ok, here it is. My first code patch in Python. Basically the existing code was depending on bit_length to DTRT and raise a ValueError, but negative numbers have a positive bit length. Then when it hits: 234 while r >

[issue29061] secrets.randbelow(-1) hangs

2016-12-24 Thread Brendan Donegan
Brendan Donegan added the comment: Reproducible on Linux as well, I think I know where the issue is and will try to submit a patch soon. -- nosy: +brendan-donegan ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue29010] Incorrect description about scope related with inheritance

2016-12-20 Thread Brendan Donegan
Brendan Donegan added the comment: Worth putting them side by side I think: "The name BaseClassName must be defined in a scope containing the derived class definition" vs. "BaseClassName must be defined in a namespace accessible from the scope containing the derived c

[issue29010] Incorrect description about scope related with inheritance

2016-12-19 Thread Brendan Donegan
Brendan Donegan added the comment: IMO there's no actual bug in Python. Perhaps documentation can be clarified in a short simple way. I would reiterate the point that restating facts of the language all over the documentation is not a great idea, but maybe here the benefits outweigh

[issue29010] Incorrect description about scope related with inheritance

2016-12-19 Thread Brendan Donegan
Brendan Donegan added the comment: Hi. Can you please provide a small code snippet illustrating where this diverges from the actual behaviour? -- nosy: +brendan-donegan ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue28989] .dll files missing

2016-12-16 Thread Brendan Donegan
Brendan Donegan added the comment: This more likely to be a system misconfiguration issue than a Python one. Following http://stackoverflow.com/questions/33265663/api-ms-win-crt-runtime-l1-1-0-dll-is-missing-when-opening-microsoft-office-file will probably fix the issue for you

[issue28980] ResourceWarning when imorting antigravity in 3.6

2016-12-15 Thread Brendan Donegan
Brendan Donegan added the comment: I think this is essentially a duplicate of http://bugs.python.org/issue27069, or at least fixing that will fix this (as the exception is caused by the webbrowser.open() call) -- nosy: +brendan-donegan ___ Python

[issue27069] webbrowser creates zombi processes in the background mode

2016-12-15 Thread Brendan Donegan
Brendan Donegan added the comment: This appears to be Firefox specific? At least: b = webbrowser.get("chromium-browser") b.open("https://bugs.python.org/issue26741;) returns simply: True With no exception ------ nosy: +brendan-donegan ___

[issue28976] incorrect description that dose not conform to the actual behavior

2016-12-15 Thread Brendan Donegan
Brendan Donegan added the comment: I think the consensus is that the wording is correct. If you can come up with text that is clearer, and still correct, please do submit a patch. On Thu, 15 Dec 2016 at 20:50 woo yoo <rep...@bugs.python.org> wrote: > > woo yoo added the comment:

[issue28976] incorrect description that dose not conform to the actual behavior

2016-12-15 Thread Brendan Donegan
Brendan Donegan added the comment: None represents the case where the if statement is false On Thu, 15 Dec 2016 at 20:40 woo yoo <rep...@bugs.python.org> wrote: > > woo yoo added the comment: > > According to the original description, "either all or none...",

[issue28979] What's New entry on compact dict mentions "faster" implementation

2016-12-15 Thread Brendan Donegan
Brendan Donegan added the comment: Agree. Patch provided. -- keywords: +patch nosy: +brendan-donegan Added file: http://bugs.python.org/file45919/whatsnew36.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue28976] incorrect description that dose not conform to the actual behavior

2016-12-15 Thread Brendan Donegan
Brendan Donegan added the comment: Indeed, but that's merely because an exception has been raised. The example given doesn't include any statements that would raise an exception. I'm not sure it's necessary to re-iterate well known Python behaviour in this section. Anyway, that's my 2c

[issue28976] incorrect description that dose not conform to the actual behavior

2016-12-15 Thread Brendan Donegan
Brendan Donegan added the comment: How does that contradict the documentation? Both print statements were executed - the second one raised an exception because of 'op' not being defined. -- ___ Python tracker <rep...@bugs.python.org>

[issue28976] incorrect description that dose not conform to the actual behavior

2016-12-15 Thread Brendan Donegan
Brendan Donegan added the comment: Can you provide a code snippet that demonstrates the actual problem? As far as I can see this code behaves as documented -- nosy: +brendan-donegan ___ Python tracker <rep...@bugs.python.org> <http://bugs.p