Brian Brazil added the comment:
I'm on gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3, this was the only warning I
saw (though I don't have all the optional libraries installed).
--
___
Python tracker
<http://bugs.python.o
Brian Brazil added the comment:
The attached patch fixes this.
--
keywords: +patch
nosy: +bbrazil
Added file: http://bugs.python.org/file27330/issue15677.patch
___
Python tracker
<http://bugs.python.org/issue15
Brian Brazil added the comment:
How does the attached patch look?
I also reworded the first line to be a bit clearer, and be under 80 chars.
--
keywords: +patch
nosy: +bbrazil
Added file: http://bugs.python.org/file27329/issue15350.patch
___
Python
New submission from Brian Brazil:
Please see attached patch to fix warnings about error being set but not used,
I've eliminated error except for the one function that was using it.
--
components: Interpreter Core
files: pthread-warnings.patch
keywords: patch
messages: 171432
Brian Brazil added the comment:
There's already existing infrastructure not to run certain tests when
there's no internet connection, no ipv6, no tk etc.
--
___
Python tracker
<http://bugs.python.o
Brian Brazil added the comment:
This patch is a result of frustration encountered when debugging #15002.
Not being able to use 'type' directly is rather annoying, so after figuring
that bug out I set some time aside to make it easier for the next person.
This could be considered
Changes by Brian Brazil :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue15284>
___
___
Python-bugs-list
Brian Brazil added the comment:
I don't think anything in 127/8 is going to work, all Debian/Ubuntu systems I'm
aware of have all of 127/8 equivalent to 127.0.0.1.
Maybe 192.0.2.0/24 per RFC 5737?
A better solution might be to chose some host/port on a python.org server and
set
Brian Brazil added the comment:
Here's a patch that should clarify this.
--
keywords: +patch
nosy: +bbrazil
Added file: http://bugs.python.org/file26306/issue15228-utime-touch-doc.patch
___
Python tracker
<http://bugs.python.org/is
New submission from Brian Brazil :
If ipv6 is compiled in but disabled in the kernel then test_socket attempts to
bind to ports and gets lots of stack traces. The attached patch skips the
relevant tests.
--
components: Tests
files: ipv6-disabled-test-socket.patch
keywords: patch
New submission from Brian Brazil :
See attached patch, there's still self.type in places. I also converted one map
to a list comprehension.
--
components: Library (Lib)
files: urllib-request-cleanup-builtin-names.patch
keywords: patch
messages: 164874
nosy: bbrazil
priority: n
New submission from Brian Brazil :
I'm running Ubuntu Precise and have net.ipv6.conf.all.disable_ipv6 = 1 in my
sysctl.conf. With this configuration at head there's a fd leak in
_is_ipv6_enabled in support.py when the bind fails, which the attached patch
should fix.
--
Brian Brazil added the comment:
Looks like someone else has already fixed this.
--
resolution: -> out of date
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Brian Brazil added the comment:
More particularly, the ftpwrapper's ftp member is being GCed sometime after
FtpHandler.ftp_open returns.
--
___
Python tracker
<http://bugs.python.org/is
Brian Brazil added the comment:
I've tested this on head, and the issue appears to be buggy ftp code in python.
>From the attached tcpdump for fetching delegated-ripencc-20120706:
12:57:19.933607 IP myhost.39627 > ftp.ripe.net.ftp: Flags [.], ack 511, win
115, options [nop
Brian Brazil added the comment:
Issue confirmed, patch looks good.
--
nosy: +bbrazil
___
Python tracker
<http://bugs.python.org/issue15094>
___
___
Python-bug
Brian Brazil added the comment:
Issue confirmed, patch looks good.
--
nosy: +bbrazil
___
Python tracker
<http://bugs.python.org/issue15130>
___
___
Python-bug
Brian Brazil added the comment:
The attached patch fixes this
--
keywords: +patch
nosy: +bbrazil
Added file: http://bugs.python.org/file26283/issue11908-islice-docs.patch
___
Python tracker
<http://bugs.python.org/issue11
Brian Brazil added the comment:
Here's a path to fix the problem.
--
Added file: http://bugs.python.org/file23359/12923-maxtries-reset.patch
___
Python tracker
<http://bugs.python.org/is
Brian Brazil added the comment:
The actual problem is that FancyURLOpener self.tries isn't being reset if the
protocol is file://
I've attached a patch that'll help improve the test at least.
--
keywords: +patch
Added file: http://bugs.python.org/file23358
Brian Brazil added the comment:
This appears to fail every 9th, 19th, 29th, etc. repetition of the test.
This seems to be something to do with the reference counting/close logic of the
FakeSocket but I haven't managed to figure out what.
--
nosy: +bb
New submission from Brian Brazil :
This is already documented:
http://docs.python.org/library/threading.html#using-locks-conditions-and-semaphores-in-the-with-statement
--
nosy: +bbrazil
___
Python tracker
<http://bugs.python.org/issue13
Brian Brazil added the comment:
The problem is around line 1734 of callproc.c in tip:
} else if (PyType_Check(cls)) {
typ = (PyTypeObject *)cls;
buf = alloca(strlen(typ->tp_name) + 3 + 1);
sprintf(buf, "LP_%s", typ->tp_name); <-- segfault is
Brian Brazil added the comment:
David's change sounds good to me.
--
___
Python tracker
<http://bugs.python.org/issue9921>
___
___
Python-bugs-list m
Brian Brazil added the comment:
I don't see your patch on the other bug, so I've updated mine not to use with.
--
Added file: http://bugs.python.org/file19470/distutils_fd_leak_v2.patch
___
Python tracker
<http://bugs.python.o
New submission from Brian Brazil :
If saxutils.prepare_input_source is passed a filename or url, it'll end up
leaking an fd via IncrementalParser.parse and ExpatParser.parse. This can be
seen by enabling resource warnings and running test_sax.
This should be fixed.
--
compo
New submission from Brian Brazil :
Please see attached.
--
components: Tests
files: test_threading_fd_leak.patch
keywords: patch
messages: 120079
nosy: bbrazil
priority: normal
severity: normal
status: open
title: Fix resource warnings in test_threading
Added file: http
New submission from Brian Brazil :
Please see attached.
--
components: Tests
files: test_sax_fd_leak.patch
keywords: patch
messages: 120077
nosy: bbrazil
priority: normal
severity: normal
status: open
title: Fix some resource warnings in test_sax
versions: Python 3.3
Added file: http
Brian Brazil added the comment:
The garbage collector should take care of the vast majority of these, it's only
bugs in the C like issue 10253 that I'd worry about.
--
___
Python tracker
<http://bugs.python.o
Brian Brazil added the comment:
Currently, if you pass in a fd it'll be closed by the __del__. My patch no
longer does this so any use of the module depending on this behaviour could
leak an fd. However, noone seems to use the module that way.
V2 attached.
--
Added file:
Brian Brazil added the comment:
The patch is against current SVN.
--
___
Python tracker
<http://bugs.python.org/issue10266>
___
___
Python-bugs-list mailin
Brian Brazil added the comment:
That'd help alright.
--
keywords: +patch
Added file: http://bugs.python.org/file19446/sunau_fd_leak.patch
___
Python tracker
<http://bugs.python.org/is
New submission from Brian Brazil :
I missed this when fixing issue 10246. The attached patch fixes this and adds a
test that produces a resource warning with the old code.
--
components: Library (Lib)
files: uu_decode_fd_leak.patch
keywords: patch
messages: 120054
nosy: bbrazil
New submission from Brian Brazil :
Please see attached.
It's possible that this change will lead to fds leaking if someone is passing
in a fd, however a) this is consistent with how other modules (e.g. uu) do it
and b) of the 2 (!) uses of this module I found on Google Codesearch, both
New submission from Brian Brazil :
Please see attached.
--
components: Tests
files: test_smtplib_fd_leak.patch
keywords: patch
messages: 120047
nosy: bbrazil
priority: normal
severity: normal
status: open
title: Fix resource warnings in test_smtplib
versions: Python 3.3
Added file: http
Brian Brazil added the comment:
Fixing title.
--
title: Fix resource warnings in distutil test_tokenize -> Fix resource warnings
in test_tokenize
___
Python tracker
<http://bugs.python.org/issu
New submission from Brian Brazil :
Please see attached patch.
--
components: Tests
files: test_tokenize_fd_leak.patch
keywords: patch
messages: 120019
nosy: bbrazil
priority: normal
severity: normal
status: open
title: Fix resource warnings in distutil test_tokenize
versions: Python 3.3
Brian Brazil added the comment:
I'm used to a slightly different style guide, v2 has the right indentation.
--
Added file: http://bugs.python.org/file19438/test_os_fd_leak_v2.patch
___
Python tracker
<http://bugs.python.org/is
New submission from Brian Brazil :
Please see attached.
--
components: Tests
files: test_os_fd_leak.patch
keywords: patch
messages: 120015
nosy: bbrazil
priority: normal
severity: normal
status: open
title: Fix resource warnings in test_os
versions: Python 3.3
Added file: http
New submission from Brian Brazil :
Please see attached patch.
--
components: Tests
files: test_pkgimport_fd_leak.patch
keywords: patch
messages: 120014
nosy: bbrazil
priority: normal
severity: normal
status: open
title: Fix resource warnings in test_pkgimport
versions: Python 3.3
Added
Brian Brazil added the comment:
Version 2 of the patch is attached.
This fixes a warning at line 256 in test_fileio.py:
f = _FileIO("/dev/tty", "a")
on my Hardy machine.
--
Added file: http://bugs.python.org/file19433/fil
New submission from Brian Brazil :
fileio_init will leak a fd if you open a file for append that isn't seekable.
We should close this fd before returning the failure.
The attached patch fixes this and a resource warning in the tests, but I'm
unsure if it'd be better to use inte
New submission from Brian Brazil :
Please see attached.
--
assignee: tarek
components: Distutils
files: distutils_fd_leak.patch
keywords: patch
messages: 119988
nosy: bbrazil, eric.araujo, tarek
priority: normal
severity: normal
status: open
title: Fix resource warnings in distutil
New submission from Brian Brazil :
Please see attached.
--
components: Tests
files: test_file_fd_leak.patch
keywords: patch
messages: 119987
nosy: bbrazil
priority: normal
severity: normal
status: open
title: Fix resource warnings in test_file
versions: Python 3.3
Added file: http
New submission from Brian Brazil :
Please see attached, not sure this is quite right.
--
components: Tests
files: test_urllib2_localnet_fd_leak.patch
keywords: patch
messages: 119985
nosy: bbrazil
priority: normal
severity: normal
status: open
title: Fix resource warnings in
New submission from Brian Brazil :
Please see attached.
--
components: Library (Lib)
files: test_unicodedata_fd_leak.patch
keywords: patch
messages: 119984
nosy: bbrazil
priority: normal
severity: normal
status: open
title: Fix resource warnings in test_unicodedata
versions: Python 3.3
New submission from Brian Brazil :
I'm not 100% comfortable with this patch as my knowledge of the xmlrpc
interface is very limited, a simple p.close() would seem cleaner - but that
doesn't work.
--
files: test_xmlrpclib_fd_leak.patch
keywords: patch
messages: 119983
nos
Brian Brazil added the comment:
How does v2 look?
--
Added file: http://bugs.python.org/file19426/uu_fd_leak_v2.patch
___
Python tracker
<http://bugs.python.org/issue10
New submission from Brian Brazil :
Please see attached patch, I'm not sure if this is the cleanest way to fix
this. This also fixes the resource warnings in the test.
--
components: Library (Lib)
files: uu_fd_leak.patch
keywords: patch
messages: 119975
nosy: bbrazil, brett.c
New submission from Brian Brazil :
Please see attached patch and "closing files and sockets in a timely manner in
the stdlib" on python-dev.
--
components: Tests
files: test_telnetlib_fd_leak.patch
keywords: patch
messages: 119974
nosy: bbrazil, brett.cannon
priority: norma
Brian Brazil added the comment:
That doesn't cover the os.path.join('', 'x') case, and I'm not sure it makes
os.path.join('x//', 'y') clear - though that doesn't matter as much.
How about making (2) "the result is si
Brian Brazil added the comment:
The behaviour is a bit more nuanced:
>>> os.path.join('x', '')
'x/'
>>> os.path.join('x', '', 'y')
'x/y'
>>> os.path.join('x', '', 'y
Brian Brazil added the comment:
I'd already had a look around, and my knowledge of ioctls is not sufficient to
answer that question but I suspect the answer is no.
Does someone know of a ioctl that works across platforms, doesn't require
specific hardware or privileges and that
New submission from Brian Brazil :
The spacing in fcntl.fcntl's docstring isn't consistent, the attached patch
fixes this.
--
assignee: d...@python
components: Documentation
files: fcntl_docstring_spacing.patch
keywords: patch
messages: 115582
nosy: bbrazil, d...@pytho
Brian Brazil added the comment:
This mistake is also in the docstring, I've attached a path to fix both.
--
keywords: +patch
nosy: +bbrazil
Added file: http://bugs.python.org/file18748/getresgid_group_not_user.patch
___
Python tracker
Brian Brazil added the comment:
The attached patch fixes this.
--
keywords: +patch
nosy: +bbrazil
Added file: http://bugs.python.org/file18747/ioctl_1024_mutable.patch
___
Python tracker
<http://bugs.python.org/issue9
Brian Brazil added the comment:
The attached patch removes the dead code, regrtest is happy.
--
keywords: +patch
nosy: +bbrazil
Added file: http://bugs.python.org/file18438/xmlparse_ParseFile-dead-code.patch
___
Python tracker
<h
Brian Brazil added the comment:
Here's a quick test:
Python 3.2a1+ (py3k:83811, Aug 8 2010, 09:00:22)
[GCC 4.2.4 (Ubuntu 4.2.4-1ubuntu4)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import os, s
Changes by Brian Brazil :
Added file: http://bugs.python.org/file18436/socket-sendall-doc-py3k.patch
___
Python tracker
<http://bugs.python.org/issue6005>
___
___
Pytho
Brian Brazil added the comment:
I've updated this patch to apply cleanly to 2.7, and also adapted it to for
py3k. I added a small tweak to the example description in socket.rst.
I've tested the instructions for both 2.7 and 3k and verified they still work
as expected.
-
Brian Brazil added the comment:
The attached patch handles short writes, and adds ajaksu2's tests.
--
Added file: http://bugs.python.org/file18433/tests-iter-urllib-py3k.patch
___
Python tracker
<http://bugs.python.org/i
Brian Brazil added the comment:
This looks as though its a short write:
[pid 28343] recvfrom(5, "GET / HTTP/1.1\r\nAccept-Encoding:"..., 8192, 0, NULL,
NULL) = 118
[pid 28343] poll([{fd=5, events=POLLOUT, revents=POLLOUT}], 1, 1) = 1
[pid 28343] sendto(5, "HTTP/1.0 200
New submission from Brian Brazil :
fnmatch.translate's docstraing says "There is no way to quote
meta-characters.", but this isn't in the html docs. The attached patch fixes
that.
--
assignee: d...@python
components: Documentation
files: fnmatch_translate_doc.p
New submission from Brian Brazil :
The attached patch improves the code coverage of queue to 98% by testing empty,
full, put_nowait, get_nowait and some error conditions.
--
components: Library (Lib)
files: test_queue.patch
keywords: patch
messages: 111354
nosy: bbrazil
priority
Brian Brazil added the comment:
Looks like it lost my patch, but Steven's does the same.
One tweak: in threading.rst put all of the class signature on one line or the
html formatting will be a bit off.
--
___
Python tracker
Brian Brazil added the comment:
I've updated the patch for 3.2 and improved the documentation formatting.
--
nosy: +bbrazil
___
Python tracker
<http://bugs.python.org/i
Brian Brazil added the comment:
It helps if the diff is from the root...
--
Added file: http://bugs.python.org/file18151/fnmatch_test_and_cleanup.patch
___
Python tracker
<http://bugs.python.org/issue9
Changes by Brian Brazil :
Removed file: http://bugs.python.org/file18150/fnmatch_test_and_cleanup.patch
___
Python tracker
<http://bugs.python.org/issue9356>
___
___
Pytho
New submission from Brian Brazil :
The attached path adds tests for translate and filter, and also fixes a few
style issues in fnmatch itself.
--
components: Interpreter Core
files: fnmatch_test_and_cleanup.patch
keywords: patch
messages: 111340
nosy: bbrazil
priority: normal
severity
New submission from Brian Brazil :
The attached patch:
Remove unused "self-test" from threading.py that doesn't really test much.
Add better testing for Thread.__repr__.
This brings coverage as measured by regrtest from 40% to 45%.
--
components: Interpr
Brian Brazil added the comment:
Here's a slightly cleaner version.
--
Added file: http://bugs.python.org/file18141/threading-roughly-doc-fix.patch
___
Python tracker
<http://bugs.python.org/i
Changes by Brian Brazil :
Removed file: http://bugs.python.org/file18140/threading-roughly-doc-fix.patch
___
Python tracker
<http://bugs.python.org/issue9339>
___
___
New submission from Brian Brazil :
http://docs.python.org/py3k/library/threading.html
"Roughly, a thread is alive from the moment the start() method returns until
its run() method terminates."
Using "Roughly" in relation to threading is a bit unspecific. I&#x
73 matches
Mail list logo
