Brian Curtin added the comment:
Rather than mucking with the string, we should probably set some of these
details as attributes on ImportError. #10854 wanted something similar - details
on the pyd file that failed if you get an ImportError on an extension module on
Windows.
--
nosy
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue2636>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brian Curtin :
--
resolution: -> invalid
stage: -> committed/rejected
status: open -> closed
type: -> behavior
___
Python tracker
<http://bugs.python
Brian Curtin added the comment:
Sorry it took so long to get to this - thanks a lot for the patch, Robbie!
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bug
Changes by Brian Curtin :
--
stage: -> committed/rejected
status: open -> closed
type: crash -> behavior
___
Python tracker
<http://bugs.python.or
Brian Curtin added the comment:
Can you post some example code or a test case?
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue12
Brian Curtin added the comment:
Agreed. I think we should pass on the raw data - how the user wants to format
and present that is up to them.
--
___
Python tracker
<http://bugs.python.org/issue12
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue12442>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
Just had a successful XP buildbot run:
http://www.python.org/dev/buildbot/all/builders/x86%20XP-5%203.2/builds/304
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
_
Brian Curtin added the comment:
I think quick3 is the way to go - checked in, we'll see how the buildbots react.
1524a60016d0 is the changeset for the 3.2 checkin (forgot to mention the issue#
there)
--
___
Python tracker
<http://bugs.py
Brian Curtin added the comment:
How about this patch?
We yield the GIL in posix_do_stat, so as Antoine pointed out in IRC, we were
calling PyErr_SetString without having the GIL. I think this is the correct fix
as I've stepped through the code in Visual Studio, forcing it to take
Brian Curtin added the comment:
It has something to do with the GetFinalPathNameByHandle dance.
--
___
Python tracker
<http://bugs.python.org/issue12084>
___
___
Brian Curtin added the comment:
Well apparently that killed the XP build bots. Does anyone currently have
access to XP that could test this?
--
___
Python tracker
<http://bugs.python.org/issue12
Brian Curtin added the comment:
Here's a cleaned up patch which includes the test and lstat change Victor
mentioned. I think this addresses everything we need to cover here. Can you run
the tests once more with this new patch?
--
Added file: http://bugs.python.org/file
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue9035>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brian Curtin :
--
resolution: -> invalid
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Brian Curtin :
--
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue12284>
___
___
Python-bugs-list mailing list
Unsubscri
Brian Curtin added the comment:
This was also pushed to 2.7 in f1509fc75435.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
versions: -Python 3.1
___
Python tracker
<http://bugs.python.or
Brian Curtin added the comment:
You might want to check out the python-tutor or python-list email lists (see
http://mail.python.org/mailman/listinfo). This is a tracker for bug reports or
problems with the Python interpreter and standard libraries.
--
nosy: +brian.curtin
resolution
Brian Curtin added the comment:
Victor - does the new patch pass all tests for you on 3.2?
--
Added file: http://bugs.python.org/file22274/issue12084_v2.diff
___
Python tracker
<http://bugs.python.org/issue12
Brian Curtin added the comment:
I should have specified - the patch is for 3.2. 2.7 code in this area is
different but I'll get to that, and default/3.3 will also get this patch but
it'll probably require some tweaking.
I guess I went overboard on the refactoring which is why
Brian Curtin added the comment:
Also, what I meant by "full" (in "fully working") in my message was that the
full test suite passes. There are a number of code changes that have to be
made, mostly around various constants used, e.g.,
Brian Curtin added the comment:
We have to have x64 support, and the 2010 express version can now target x64
provided you have the x64 SDK installed. That wasn't true of 2008, but there
were some registry/config file messing you could do in order to get x64 support
out of
Brian Curtin added the comment:
I have a fully working VS2010 build that I'm working on getting the ok to
contribute from my employer. We may be able to use this for 3.3 but nothing
earlier. I started a discussion on the Python-Dev list a few months ago but I
don't believe we
Brian Curtin added the comment:
This code has changed a lot since originally being committed, so I'll handle
backporting in #12084 which has the latest changes.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org
Brian Curtin added the comment:
Here's a patch that works. All tests are passing.
I changed from using FindFirstFile to GetFileAttributes, which provides
basically the same performance characteristics.
One change in this implementation is to not raise a WindowsError when the file
cann
Brian Curtin added the comment:
Can you provide a simple test script?
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue12262>
___
___
Pytho
Brian Curtin added the comment:
Looks like I didn't test this enough - many other test failures are occurring.
Disregard this patch for now.
--
___
Python tracker
<http://bugs.python.org/is
Brian Curtin added the comment:
Attached is a patch that makes this about twice as fast for regular files and
about 15 times faster for symbolic links and directories.
Not that this would be anyone's performance bottleneck, but it does make the
time more of a constant due to the recu
Brian Curtin added the comment:
Attached is a complete patch. All tests pass.
Lib/test/support.py
* Handle AttributeError, which Hirokazu noticed on pre-XP machines
Lib/test/test_os.py
* This sets up a three-deep directory tree and creates a symbolic link in the
middle (second) directory
Changes by Brian Curtin :
--
stage: -> needs patch
type: -> behavior
versions: +Python 2.7, Python 3.1
___
Python tracker
<http://bugs.python.org/i
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue12239>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
I have this working when you stat the symlink from the directory it was created
or above...but oddly it does not work when you open a symlink below the
directory it exists in.
DeviceIoControl isn't used for reparse tag handling anymore, and I
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue12226>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
Oops, nevermind that, thought this was suggesting a change to PyPI itself, not
distutils.
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue12
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue12226>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
This should probably be discussed on catalog-SIG, not the CPython bug tracker.
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue12
Changes by Brian Curtin :
--
keywords: +needs review
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue11416>
___
___
Python-bugs-list mai
Brian Curtin added the comment:
It turns out DeviceIoControl/FSCTL_GET_REPARSE_POINT (in win32_read_link) will
only work for us as long as the symlink was created with a full path. Starting
at the top level of a source checkout, if I create `os.symlink("README",
"README.lnk
Brian Curtin added the comment:
Ok, so it's actually 0a1baa619171 that broke it, not sure how I came up with
the other revision. In any case, it's too hairy to try and piece everything
together across the numerous bug fixes, feature adds, and refactorings in this
area in order to g
Brian Curtin added the comment:
Correction for msg136711 -- s/patch/test/g
--
___
Python tracker
<http://bugs.python.org/issue12084>
___
___
Python-bugs-list m
Brian Curtin added the comment:
Ok, so it's 893b098929e7 where that test stops working.
--
___
Python tracker
<http://bugs.python.org/issue12084>
___
___
Brian Curtin added the comment:
Here's standalone patch which should cover this problem. The patch fails right
now but succeeds if you apply it back to 652baf23c368 (the changeset before one
of several changes around this code). I'll try to find the actual offending
checkin and w
Brian Curtin added the comment:
Please report this to the regex bug tracker.
--
nosy: +brian.curtin
resolution: -> rejected
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue11455>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
This is intentional. See the implementation of join in Lib/posixpath.py and the
Windows implementation in Lib/ntpath.py which also includes a comment
explaining why.
# path is not empty and does not end with a backslash,
# but b is empty; since, e.g., split(
Brian Curtin added the comment:
With the patch applied, the new test fails along with
test.test_os.WalkTests.test_traversal and
test.test_os.Win32SymlinkTests.test_directory_link.
Overall, I agree that this doesn't work correctly. The patch, which is pretty
large, breaks more than it
Brian Curtin added the comment:
I'm hoping to. I have time to work on it tonight and tomorrow night US/Chicago
time and will keep you posted.
--
assignee: -> brian.curtin
___
Python tracker
<http://bugs.python.org
Brian Curtin added the comment:
If we can generate a testable MSI file that would be the best. Including a very
small pre-generated MSI for the purposes of the test would be acceptable.
As-is, the tests don't pass because my machine has
C:\Windows\installer\1032f.msi that gets used fo
Brian Curtin added the comment:
Wow, nice analysis. http://connect.microsoft.com/ is the external Microsoft bug
tracker, as far as I know.
--
___
Python tracker
<http://bugs.python.org/issue6
Changes by Brian Curtin :
--
Removed message: http://bugs.python.org/msg136132
___
Python tracker
<http://bugs.python.org/issue12084>
___
___
Python-bugs-list m
Brian Curtin added the comment:
Looks like I was referring to a different patch from the email - sorry for any
confusion.
--
___
Python tracker
<http://bugs.python.org/issue12
Brian Curtin added the comment:
That's already fixed, it'll be in 3.2.1
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue11990>
___
__
Brian Curtin added the comment:
Hirokazu contacted me directly with these patches a few days ago but I haven't
been able to email him because his host's DNS is apparently down.
The tests in this patch do not end up testing anything, so we'll need to start
with a proper tes
Brian Curtin added the comment:
Out of the patches listed,
http://www.microsoft.com/technet/security/advisory/2269637.mspx is the only
part that appears to be related in any way, although it doesn't specify a whole
lot on the surface. The title is "Insecure Library Loading Could Al
Brian Curtin added the comment:
Don't do anything you're not comfortable with. If you can get your system to
whatever state it was in the past where things worked properly, feel free to
dig into it. I will try to look into this situation and see if there's anything
in these s
Brian Curtin added the comment:
Are you able to narrow it down to which security update(s) caused the breakage?
--
___
Python tracker
<http://bugs.python.org/issue6
Brian Curtin added the comment:
Issues with Regexp should probably be handled on the Regexp tracker.
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue2
Brian Curtin added the comment:
Looks like we already mention that.
"""
Popen objects are supported as context managers via the with statement, closing
any open file descriptors on exit.
"""
Antoine, do you think this should be more strongly worded?
Brian Curtin added the comment:
Hm, yeah, not sure what I was thinking there.
I'm thinking there's not a lot we can do here, but also not a lot that we
should do here. We don't want to wait, and we don't want to close, so maybe we
should just document that the usage shoul
Brian Curtin added the comment:
Actually, I don't think the wait() is a good idea. If you want to block and
infinitely wait on the process to close, you should do so explicitly.
It's probably better that we try to use terminate() or kill() and raise if t
Brian Curtin added the comment:
Seems like it would be enough to add a wait() at the end?
diff -r 9e473917cbfb Lib/subprocess.py
--- a/Lib/subprocess.py Mon May 09 21:17:02 2011 +0200
+++ b/Lib/subprocess.py Mon May 09 15:30:02 2011 -0500
@@ -796,6 +796,7 @@
self.stderr.close
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue12018>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
I don't have time to test it at the moment, but it seems fine to me.
--
___
Python tracker
<http://bugs.python.org/is
Brian Curtin added the comment:
On XP, os.path.samefile is really "os.path.abspath(x) == os.path.abspath(y)",
which does not work correctly with different cases. We could add a ".lower()"
to line 657 of Lib/ntpath.py so the abspath is always returned in lower, so the
XP
Changes by Brian Curtin :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue11834>
___
___
Python-bugs-list mailing list
Unsubscri
Brian Curtin added the comment:
Thanks for the patches and reviews!
--
assignee: -> brian.curtin
resolution: -> fixed
stage: needs patch -> committed/rejected
type: -> behavior
___
Python tracker
<http://bugs.python
Brian Curtin added the comment:
Duplicate of #11642, #11272, and #11278.
This is fixed. It'll be released in 3.2.1
--
nosy: +brian.curtin
resolution: -> duplicate
stage: -> committed/rejected
___
Python tracker
<http://bugs.python.
Brian Curtin added the comment:
Thanks for having a look, Ezio.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Brian Curtin :
--
assignee: -> brian.curtin
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue11361>
___
___
Python-bugs-list mai
New submission from Brian Curtin :
Attached is a patch that adds documentation for a few things that have existed
in subprocess for a while without documentation.
The "startupinfo" parameter takes subprocess.STARTUPINFO object which takes a
few different options for its attributes
Changes by Brian Curtin :
--
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue11954>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Brian Curtin :
--
components: +Tests -Build
nosy: -brian.curtin
type: crash -> behavior
versions: +Python 3.3 -Python 3.4
___
Python tracker
<http://bugs.python.org/issu
Changes by Brian Curtin :
--
components: +Tests -Build
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issue11956>
___
___
Python-bugs-lis
Changes by Brian Curtin :
--
components: +Tests -Build
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issue11955>
___
___
Python-bugs-lis
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue11344>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
> I'm not confident to start using this build until I can pin down why eg
> test_argparse and test_import are failing.
Feel free to look into the failures in Lib/test/test_argparse.py and
Lib/test/test_import.py
--
nosy: +b
Changes by Brian Curtin :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Brian Curtin added the comment:
I created/assigned #10646 to myself for other samefile issues - I can cover
this as well unless someone beats me to it.
--
assignee: -> brian.curtin
nosy: +brian.curtin
stage: -> needs patch
versions: +Pyth
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue11834>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brian Curtin :
--
resolution: -> out of date
stage: -> committed/rejected
status: open -> closed
versions: -Python 3.4
___
Python tracker
<http://bugs.python.or
Brian Curtin added the comment:
2.6 is only receiving security fixes at the moment, so it won't make it into
there.
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/is
Changes by Brian Curtin :
--
type: crash -> behavior
versions: -Python 2.5, Python 2.6, Python 3.4
___
Python tracker
<http://bugs.python.org/issue11891>
___
_
Changes by Brian Curtin :
--
resolution: accepted -> fixed
stage: patch review -> committed/rejected
status: open -> closed
versions: -Python 3.1
___
Python tracker
<http://bugs.python.o
Brian Curtin added the comment:
This hasn't been an issue for quite some time, and I suspect the follow-up work
on symbolic and hard links and their supporting functions corrected any
problems in this area.
--
resolution: -> works for me
stage: needs patch -> committ
Brian Curtin added the comment:
I no longer have access to a Server 2003 machine and I don't remember this
happening the last few times I worked on that OS so it may have been fixed.
If this occurs for anyone else, feel free to reopen.
--
resolution: -> rejected
stage: nee
Brian Curtin added the comment:
This is something that should be handled on the trackers of any of the external
SOAP libraries. If they are ported to Python 3 and are seen as best in class
and are willing to move all development into the standard library, then
inclusion could be considered
Brian Curtin added the comment:
For the first point, I just put it there since other Windows-only modules
already exist there. _subprocess did, msvcrt and winreg currently do, and
there's a few other Windows-only things in there. It's not a big deal, so I can
move it into Modules
Changes by Brian Curtin :
--
keywords: +needs review
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue11750>
___
___
Python-bugs-list mai
Brian Curtin added the comment:
Here's a patch replacing Modules/_multiprocessing/win32_functions.c and
PC/_subprocess.c with a common PC/_windows.c. There's not much to the patch
despite its size -- it just shuffles around the C code and does a few renames
in the appropriate Pyth
Changes by Brian Curtin :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue5162>
___
___
Python-bugs-list mailing list
Unsubscri
Brian Curtin added the comment:
True. In the end all it does is wait for input not specific to attaching
debuggers. How about ``--wait``?
I'm used to this functionality being `-x` in another app, so we're iteratively
gett
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue11834>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brian Curtin :
--
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue11834>
___
___
Python-bugs-list mailing list
Unsubscri
New submission from Brian Curtin :
Patch to add -a/--attach option to Lib/test/regrtest.py to pause before
beginning test runs. This would allow a user to attach Visual Studio or some
other debugger. Very simply, this option just blocks waiting for a keystroke
during argument parsing - once
Brian Curtin added the comment:
Thanks for the patch!
--
assignee: jnoller -> brian.curtin
resolution: -> fixed
stage: patch review -> committed/rejected
___
Python tracker
<http://bugs.python.o
Brian Curtin added the comment:
This looks reasonable to me. If no one beats me to it, I'll check it in tonight.
--
___
Python tracker
<http://bugs.python.org/i
Brian Curtin added the comment:
Disabling and re-enabling is another possibility, and it's probably more likely
to help in the long run. Most (all?) Windows machines have error reporting
enabled unless you mess with the registry manually, so the only place tests
would be run with my
Changes by Brian Curtin :
--
stage: -> needs patch
type: -> behavior
___
Python tracker
<http://bugs.python.org/issue11776>
___
___
Python-bugs-list
Brian Curtin added the comment:
http://psf.upfronthosting.co.za/roundup/meta is the bug tracker for the bug
tracker.
Also, consider that if you are subscribed to any of the tracker mailing lists
such as python-bugs-list, you might get multiple copies of tracker comments.
--
nosy
401 - 500 of 1382 matches
Mail list logo