Changes by Chris Jerdonek :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Chris Jerdonek added the comment:
Okay, even better. :)
--
___
Python tracker
<http://bugs.python.org/issue16170>
___
___
Python-bugs-list mailing list
Unsub
Chris Jerdonek added the comment:
That's great, thanks for the pointer, Antoine. I will try that out later today.
--
___
Python tracker
<http://bugs.python.org/is
Changes by Chris Jerdonek :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue16170>
___
___
Python-bugs-list mailing list
Unsubscri
Chris Jerdonek added the comment:
Thanks for the explanation and suggestion, Antoine. I'm attaching a patch that
incorporates the suggestion, but I haven't checked that it works yet (I would
need to use snakebite).
--
keywords: +patch
Added file: http://bugs.python.org
Changes by Chris Jerdonek :
--
assignee: -> chris.jerdonek
___
Python tracker
<http://bugs.python.org/issue16114>
___
___
Python-bugs-list mailing list
Un
Chris Jerdonek added the comment:
Thanks, Senthil!
--
___
Python tracker
<http://bugs.python.org/issue15922>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Jerdonek added the comment:
> BTW, the patch fails for 3.2 and 3.3 but works for 3.4
By "patch" do you mean "test"? And by "works", do you mean fails or succeeds?
:)
I haven't prepared a patch yet, but I just started working on it. On my
machine
Changes by Chris Jerdonek :
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Chris Jerdonek :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Chris Jerdonek added the comment:
For future reference, this issue resulted from the tests committed for issue
16115.
--
___
Python tracker
<http://bugs.python.org/issue16
Chris Jerdonek added the comment:
I just created issue 16170 about a newly-added subprocess.Popen() test that
succeeds on Windows and Mac but fails on Linux. It seems closely related to
the issue discussed here.
Perhaps it signals an underlying issue that needs to be fixed.
--
nosy
Chris Jerdonek added the comment:
I created issue 16170 to track fixing the Linux-skip for the test_executable()
test.
--
___
Python tracker
<http://bugs.python.org/issue16
New submission from Chris Jerdonek:
This issue is to make whatever changes are necessary to remove the skip from
test_subprocess's test_executable() test (currently skipping machines that are
neither Windows nor Mac):
http://hg.python.org/cpython/file/ef90c5e482f4/Lib/test/test_subproce
Chris Jerdonek added the comment:
More information on the failure above (from the same buildbot link):
test_executable (test.test_subprocess.ProcessTestCase) ... Could not find
platform independent libraries
Could not find platform dependent libraries
Consider setting $PYTHONHOME to
Chris Jerdonek added the comment:
The test_executable test fails on AMD64 Ubuntu LTS. For example:
http://buildbot.python.org/all/builders/AMD64%20Ubuntu%20LTS%203.3/builds/38/steps/test/logs/stdio
FAIL: test_executable (test.test_subprocess.ProcessTestCase
Chris Jerdonek added the comment:
I am pushing the documentation changes separately (which will include 2.7 and
3.2).
--
___
Python tracker
<http://bugs.python.org/issue16
Chris Jerdonek added the comment:
> Incidentally, it was also odd that the VS executable wasn't obvious to locate.
Scratch this last comment. A "Visual C++ 2008 Express Edition" folder was
created under the Start menu. It just wasn't highlighted as having been newly
a
Chris Jerdonek added the comment:
Thanks for the good suggestion and pointer to the relevant discussion, Andrew.
I agree re: the sentence beginning with "normally." Incidentally, that was
existing language that I had preserved.
I'm attaching an updated patch that incorporates
Chris Jerdonek added the comment:
> Have you verified that vcsetup.exe is the right thing? I *guess* that
> vcsetup stands for "Visual C++ setup" and vcssetup for "Visual C Sharp Setup"
> but I'm not sure about it.
Yes, after choosing wrong the first
Chris Jerdonek added the comment:
Thanks for the report and patch. Can you also provide a test that fails using
the current code (and that passes with the patch applied)?
--
nosy: +chris.jerdonek
___
Python tracker
<http://bugs.python.
Chris Jerdonek added the comment:
I also checked the tests in the patch on Windows for 2.7.
--
___
Python tracker
<http://bugs.python.org/issue16115>
___
___
Pytho
Chris Jerdonek added the comment:
It might also be good to say that "vcsetup.exe" is the file you're supposed to
download (as opposed to, say, "vcssetup.exe"). Strangely, the files aren't
labeled, and they're listed in a
New submission from Chris Jerdonek:
The link to Visual Studio 2008 in the devguide doesn't seem to work:
http://docs.python.org/devguide/setup.html#windows
https://www.microsoft.com/visualstudio/en-us/products/2008-editions/express
This seems to be a better link:
http://www.microsoft.c
Chris Jerdonek added the comment:
Proposed patch attached.
I verified that the tests included in the patch pass on 2.7, 3.2, 3.3, and
default (replacing FileNotFoundError with OSError as necessary). I also
verified that the tests pass on Windows for default.
The patch also includes
Changes by Chris Jerdonek :
--
resolution: -> fixed
stage: commit review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Chris Jerdonek added the comment:
Leaving open to backport applicable portions to 2.7. I should get to that
later today.
--
___
Python tracker
<http://bugs.python.org/issue14
Chris Jerdonek added the comment:
> I considered the directive, but I mildly prefer the code change.
I just wanted to point the directive out as an available option (especially for
Ravi if he does further patches like this). Either way is fine with
Chris Jerdonek added the comment:
Any comments on the latest patch, in particular on the int() docstring?
Especially you, Terry, as you created the issue?
--
___
Python tracker
<http://bugs.python.org/issue14
Chris Jerdonek added the comment:
> Trailing blanks are *really* a problem
The NORMALIZE_WHITESPACE doctest directive is another option to deal with cases
like these. It ignores whitespace-only differences between the actual and
expected outputs. Does it pass with that direct
Chris Jerdonek added the comment:
> fsum will pass if 'from math import fsum' is done before it, but I've left
> such issues for now since there seems to be a debate about how to go about
> that
For now, you can at least use the "testsetup" directive wh
Chris Jerdonek added the comment:
> it does not seem to pick the whitespace in the docs and does not match -
> Doc/faq/general.rst
Can you provide a link to the line (or one of the lines) in question so it's
easier to see what you are referring to?
> os.path.isdir returns True
Chris Jerdonek added the comment:
Thanks, Andrew. I'm hoping to finish preparing the patch sometime this weekend.
--
___
Python tracker
<http://bugs.python.org/is
Chris Jerdonek added the comment:
Sorry, I was confusing this issue with issue 15533. Yes, I support adding the
file path to the error message in the Windows implementation, though my
preference would be for that to be addressed as part of a separate issue
Chris Jerdonek added the comment:
I will be opening a separate issue to have the same behavior in a future
version after this issue is closed. For existing releases, we don't want to
break working code that could be relying on the diffe
Chris Jerdonek added the comment:
Actually, I was still working on this. I had assigned it to myself.
+p = subprocess.Popen(["nonexistent","-c",'import sys; sys.exit(42)'],
+executable=sys.executable, cwd=python_dir)
The te
Changes by Chris Jerdonek :
--
nosy: +brett.cannon, ncoghlan
___
Python tracker
<http://bugs.python.org/issue16144>
___
___
Python-bugs-list mailing list
Unsub
Chris Jerdonek added the comment:
> I don't know why, but it seems that the bug reappeared in 3.3.
Part of it could be that the original fix added no tests.
--
___
Python tracker
<http://bugs.python.org
Chris Jerdonek added the comment:
Thanks, Nick. It looks like there are a few more though? I'm counting four
more in default (search for "doctest:"): three IGNORE_EXCEPTION_DETAIL and one
ELLIPSIS.
--
___
Python tracker
<http
Chris Jerdonek added the comment:
Attaching proposed tests.
--
keywords: +patch
stage: test needed -> needs patch
Added file: http://bugs.python.org/file27396/issue-16114-1-tests-default.patch
___
Python tracker
<http://bugs.python.org/issu
Chris Jerdonek added the comment:
I thought of an easy work-around we can use after looking at the changeset
Terry referenced above:
> [2] https://bitbucket.org/birkenfeld/sphinx/changeset/d91bf8e465ef
At the expense of pretty color highlighting, we can enable Pygments' TextLexer
Chris Jerdonek added the comment:
Adding issue 16115 as a dependency so that the more general case can be settled
and committed before dealing with the current issue's more specific (and
platform-specific) case.
--
dependencies: +test that executable arg to Popen() takes prece
New submission from Chris Jerdonek:
The executable argument to Popen() takes precedence over args[0] when the
executable argument is provided. The test suite should include a test of this
that runs on all systems. The test suite does not currently include such a
test. This test is a
Chris Jerdonek added the comment:
It looks like the error is here:
if issubclass(child_exception_type, OSError) and hex_errno:
errno_num = int(hex_errno, 16)
if errno_num != 0:
err_msg = os.strerror(errno_num)
if errno_num == errno.ENOENT:
err_msg
Chris Jerdonek added the comment:
2.7 is not affected because 2.7 makes no attempt to display the path:
OSError: [Errno 2] No such file or directory
--
versions: +Python 3.2
___
Python tracker
<http://bugs.python.org/issue16
New submission from Chris Jerdonek:
The error message in the FileNotFoundError error raised by subprocess.Popen()
displays the wrong path when the bad path is due to the executable argument
rather than args. The message gives the path for args[0] rather than for the
executable argument.
For
Changes by Chris Jerdonek :
--
assignee: docs@python -> chris.jerdonek
___
Python tracker
<http://bugs.python.org/issue15888>
___
___
Python-bugs-list mai
Chris Jerdonek added the comment:
Oh, this explains it. I was wondering why my browser was opening xkcd whenever
I tried running doctest against all modules in the library.
--
nosy: +chris.jerdonek
___
Python tracker
<http://bugs.python.
Chris Jerdonek added the comment:
The section of the Dev Guide on "affirmative tone" should also be applied:
"The documentation focuses on affirmatively stating what the language does and
how to use it effectively"
http://docs.python.org/devguide/documenting.h
Chris Jerdonek added the comment:
I copy-edited the patch just looking for minor things like punctuation, etc:
+a :ref:`command-line-interface` as well as :ref:`callable `
a callable one
+See also Tim Peters' introduction to the "Algorithms" chapter in the Python
+Cookboo
Chris Jerdonek added the comment:
Ed, yes, switching all of test_curses to using unittest patterns is the
eventual goal of this issue, though this may be done in more than one stage.
As I said in my previous comment, I limited the first patch to focus on the
proper setUp(), tearDown(), etc
Chris Jerdonek added the comment:
Ed, yes, switching all of test_curses to using unittest patterns is the
eventual goal of this issue, though this may be done in more than one stage.
As I said in my previous comment, I limited the first patch to focusing on the
proper setUp(), tearDown
Chris Jerdonek added the comment:
Attaching proposed patch. This updates the docstrings for int() and str(), as
well as for range() and slice() in a similar way.
It also makes the documentation for str() closer to that of the docstring. The
documentation for int(), range(), and slice() has
Chris Jerdonek added the comment:
I propose addressing the remainder of this issue by:
1) Documenting the difference in behavior between Windows and non-Windows,
adjusting the tests to reflect this difference, and then closing this issue,
and then
2) Creating a new issue to discuss whether
Chris Jerdonek added the comment:
Chris (cvrebert), feel free to create a new issue to improve the int() docs
further.
--
___
Python tracker
<http://bugs.python.org/issue16
Chris Jerdonek added the comment:
[Django/Rietveld is erroring out for me when I try to reply there, so replying
here]
On 2012/10/01 01:45:03, cvrebert wrote:
> Doc/library/functions.rst:636: arguments are given. If *x* is a number,
> return
> :meth:`x.__int__()
> How is
Chris Jerdonek added the comment:
> So (a) there is precedent for multiple signatures in docstrings
For the record, this is also true of 2.7:
http://hg.python.org/cpython/file/15fd0b4496e0/Objects/bytearrayobject.c#l2870
--
___
Python trac
Chris Jerdonek added the comment:
The change for issue 15831 contains a number of places where a single signature
line was converted to multiple -- but in the docs and not the docstrings.
Those instances can also be examined for this issue.
The signature line for str() was not updated in
Chris Jerdonek added the comment:
So it seems the cwd argument to Popen() currently works differently on Windows
from Mac OS X. For example, the following doesn't work on Windows (but does on
Mac). Windows doesn't look for arg0 relative to arg_cwd:
def test_cwd(arg0, arg_cwd):
Chris Jerdonek added the comment:
A few comments on the patch:
1) You should also check the exception type (e.g. by using
PyErr_ExceptionMatches()).
2) If the exception doesn't match, you should restore the original exception so
that the pure Python test framework will in turn raise i
Chris Jerdonek added the comment:
Two of the tests fail on at least some of the Windows bots. I am investigating.
==
ERROR: test_cwd_with_relative_arg (test.test_subprocess.ProcessTestCase
Chris Jerdonek added the comment:
I will commit to 2.7 separately.
--
versions: +Python 3.2, Python 3.4
___
Python tracker
<http://bugs.python.org/issue15
New submission from Chris Jerdonek:
The test_threading.ThreadingExceptionTests.test_recursion_limit test fails on
Mac OS X with the standard compilation command:
$ ./configure --with-pydebug && make -j2
Python 3.2.3+ (3.2:247d3e3c08ca, Sep 29 2012, 23:45:43)
[GCC 4.2.1 (Based on A
Chris Jerdonek added the comment:
Attaching patch updated for backport to 2.7.
In cases where the 2.7 language was substantively different, I preserved the
2.7 language (e.g. I preserved the reference to plain and long integers). I
also added the lone "0" prefix for octals,
Changes by Chris Jerdonek :
--
assignee: docs@python -> chris.jerdonek
___
Python tracker
<http://bugs.python.org/issue15533>
___
___
Python-bugs-list mai
Chris Jerdonek added the comment:
Yes, I noticed that later, too. :)
--
___
Python tracker
<http://bugs.python.org/issue16084>
___
___
Python-bugs-list mailin
Chris Jerdonek added the comment:
See the following comment to issue 16045 for a couple differences in the
behavior of int() in 2.7:
http://bugs.python.org/issue16045#msg171595
--
___
Python tracker
<http://bugs.python.org/issue16
Chris Jerdonek added the comment:
Adding patch modified for 2.7. Here are the differences I found from 3.3.
Unlike 3.3--
(1) 2.7 does not accept bytearrays for x (though it accepts str/bytes).
(2) 2.7 raises a TypeError if passed a string base without providing x.
Is it acceptable to add
Chris Jerdonek added the comment:
Serhiy, feel free to create a new issue for Doc/howto/functional.rst if you
feel an addition there is warranted.
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
_
Changes by Chris Jerdonek :
--
assignee: docs@python -> chris.jerdonek
___
Python tracker
<http://bugs.python.org/issue16077>
___
___
Python-bugs-list mai
Changes by Chris Jerdonek :
--
title: docs: 2 code examples not Pygmented (syntax color coded) -> docs: "yield
from" breaks Pygments syntax coloring in doc examples
___
Python tracker
<http://bugs.pytho
Changes by Chris Jerdonek :
--
stage: -> committed/rejected
___
Python tracker
<http://bugs.python.org/issue16084>
___
___
Python-bugs-list mailing list
Un
Chris Jerdonek added the comment:
Thanks for the report. Closing though as this is a duplicate.
--
resolution: -> duplicate
superseder: -> docs: 2 code examples not Pygmented (syntax color coded)
___
Python tracker
<http://bugs.p
Changes by Chris Jerdonek :
--
assignee: docs@python -> chris.jerdonek
nosy: +chris.jerdonek
___
Python tracker
<http://bugs.python.org/issue16084>
___
___
Py
Chris Jerdonek added the comment:
For informational purposes, here is where unittest defaults to the prefix
"test" for finding test methods:
http://hg.python.org/cpython/file/f11649b21603/Lib/unittest/loader.py#l48
sqlite3 is able to use "Check" because it manages its own
Chris Jerdonek added the comment:
It can take up to 24 hours for the changes to show up on the web site. They
are regenerated at least once per day.
--
___
Python tracker
<http://bugs.python.org/issue16
Chris Jerdonek added the comment:
Attaching first version of patch. Interestingly, not all of these pass when I
tried applying to 2.7. For example,
>>> int(base='foo')
Traceback (most recent call last):
File "", line 1, in
TypeError: an integer is required
Chris Jerdonek added the comment:
Thanks, Serhiy. :) Sure, I should be able to help with the documentation
portion of this issue if the community is in agreement. Would the deprecation
need to be moved up to 3.4 though now?
--
___
Python tracker
Changes by Chris Jerdonek :
--
assignee: chris.jerdonek ->
___
Python tracker
<http://bugs.python.org/issue16071>
___
___
Python-bugs-list mailing list
Un
Changes by Chris Jerdonek :
--
assignee: docs@python -> chris.jerdonek
versions: +Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/issu
Chris Jerdonek added the comment:
> But the whole 18.4.2 is mount mailbox.Message
But the first reference is a reference to email.Message's Message, so that word
should link to email.Message.Message. Sphinx lets you to link to classes, etc.
outside the current scope. It's a si
Chris Jerdonek added the comment:
> I thought you were talking about test files.
Oh, I see why you said that then. To find the test files themselves, this
logic was used in the patch:
+ fn.startswith(os.path.join('Lib', 'test'))]
Regarding your questi
Chris Jerdonek added the comment:
Here are a couple examples of test method names that don't begin with "test_":
def testLoadTk(self):
def testLoadTkFailure(self):
http://hg.python.org/cpython/file/f1094697d7dc/Lib/tkinter/test/test_tkinter/te
Chris Jerdonek added the comment:
Benjamin, unless I'm overlooking something, long_new() does its own check of
the base argument before calling PyLong_FromString():
http://hg.python.org/cpython/file/default/Objects/longobject.c#l4251
So long_new() won't let you pass a b
Chris Jerdonek added the comment:
I would like to see this written in a way that would let one run it globally or
on a single file independent of a patch (e.g. an independent script from which
patchcheck could import certain functions). Or is that what you explicitly
didn't want
Chris Jerdonek added the comment:
Thanks a lot, Georg.
FYI, though, the page linked to in the original e-mail still seems to show up
for me:
http://docs.python.org/dev/library/packaging.html
Is this change something that won't necessarily take effect right
Chris Jerdonek added the comment:
It could be done that way. It just seems simpler to me to do a simple string
check when regex's aren't necessary. Then you don't have to worry about
escaping characters, etc.
--
___
Python
Chris Jerdonek added the comment:
Thanks for helping with the patch and search, Peter.
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Chris Jerdonek added the comment:
2.7 is not affected.
--
assignee: docs@python -> chris.jerdonek
versions: +Python 3.2
___
Python tracker
<http://bugs.python.org/issu
Chris Jerdonek added the comment:
Attaching failing test for pure Python portion.
--
Added file: http://bugs.python.org/file27333/issue-16055-1-failing-test.patch
___
Python tracker
<http://bugs.python.org/issue16
Chris Jerdonek added the comment:
> Are you happy for me to write the test?
I had started working on that, but sure, be my guest. :)
You seem to be on the right track. I didn't find precedent nearby either. We
basically want a C version of unittest's assertRaisesRegex() (bu
Chris Jerdonek added the comment:
[Reopening] It looks like at least *some* change is warranted here. Notice
that all the functions document "s" for the string argument but
string.replace() documents "str". However, we have (in 2.7):
>>> string.replace(str='
Chris Jerdonek added the comment:
Thanks, Andrew. I didn't look closely enough when reading the e-mail or I
wouldn't have posted. I had assumed from the e-mail that this was in the
string *method* section rather than string module.
--
Chris Jerdonek added the comment:
I should have said that I had started working on this issue. I think failing
tests for both messages should accompany the patch (otherwise I would have
already submitted a patch). The tricky one is the error message for
PyLong_FromString(), which I believe
Chris Jerdonek added the comment:
(I was just including the line for the convenience of anyone that might happen
to come across the issue. It was not to inform you of course! :) )
FWIW, if you already know from talking to Michael or looking at the code, I
think a comment saying why sys.argv
Chris Jerdonek added the comment:
It looks like the offending line is here:
http://hg.python.org/cpython/file/6ccb04c4cbae/Lib/unittest/__main__.py#l5
if sys.argv[0].endswith("__main__.py"):
sys.argv[0] = "python -m unittest"
--
n
New submission from Chris Jerdonek:
> Date: Thu, 6 Sep 2012 20:38:21 +0800
> To: d...@python.org
> Subject: [docs] There is bug about the built-in function reduce in the
> document
>
> I found a bug in the document about reduce :
> http://docs.python.org/library/
New submission from Chris Jerdonek:
When pushing commits to hg.python.org, I got the following error re: the
"incoming.cia" hook:
$ hg push ssh://h...@hg.python.org/cpython
pushing to ssh://h...@hg.python.org/cpython
searching for changes
remote: adding changesets
remote: adding
Chris Jerdonek added the comment:
Leaving open until the change is made in 2.7 (the current wording is somewhat
different there). I will do that in the next day or so.
--
versions: +Python 2.7
___
Python tracker
<http://bugs.python.org/issue16
New submission from Chris Jerdonek:
> Date: Thu, 20 Sep 2012 15:14:36 -0400
> To: d...@python.org
> Subject: [docs] map objects are not lists
>
> 5.1.3. List
> Comprehensions<http://docs.python.org/dev/tutorial/datastructures.html#list-comprehensions>
>
> List co
801 - 900 of 1575 matches
Mail list logo
