Changes by Christoph Sieghart s...@0x2a.at:
--
nosy: -sigi
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23566
___
___
Python-bugs-list mailing
Changes by Christoph Sieghart s...@0x2a.at:
--
nosy: +sigi
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23566
___
___
Python-bugs-list mailing
Changes by Christoph Sieghart s...@0x2a.at:
--
nosy: +sigi
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14102
___
___
Python-bugs-list mailing
Christoph Sieghart s...@0x2a.at added the comment:
I took a look at the code and I don't think that adding an argument to the
IrrationalVersionError constructor is the right way to go.
The exception is raised in places where we don't know for which project we are
raising the exception (eg
Christoph Sieghart s...@0x2a.at added the comment:
The optional argument approach doesn't seem clean to me either.
I think the correct approach is - as you wrote - to change the higher level
code to include the project name in the exception message
Christoph Sieghart s...@0x2a.at added the comment:
I wrote a trivial patch against the CPython repository that adds the name to
the exception message. Did I forget anything? What kind of test would make
sense?
--
keywords: +patch
Added file: http://bugs.python.org/file25587
Changes by Christoph Sieghart s...@0x2a.at:
Removed file:
http://bugs.python.org/file25587/bad_version_number_with_name.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14778
Changes by Christoph Sieghart s...@0x2a.at:
Added file: http://bugs.python.org/file25589/bad_version_number_with_name.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14778
