Conrad Ho added the comment:
Hi Sanyam, were you able to fix the CI errors?
The fixes for the infinite loop that you are seeing in your PR CI run and the
changes to test correct logging (vs testing stdout) etc are in my original
patch already. I've checked that the test suite passes wi
Conrad Ho added the comment:
@Eryn in the news blurb thing I'm going to say
"original patch done by Eryn Wells." Your employer should be okay with that
right? :D
--
___
Python tracker
<https://bugs.pyt
Conrad Ho added the comment:
Thanks Eryn!
@Sanyam if you apply the original patch directly that will currently result in
some merge failures, and there are test fixes etc that I did on the second
patch. Think we should combine them.
I just made the chgs suggested by David on my own forked
Conrad Ho added the comment:
Hi,
I have referenced the original patch and created an updated patch that uses the
logging module + f-strings in place of the print statements in the http.client
module. Also updated the relevant tests for print/logging in test_httplib to
reflect these changes
