Daniel Wozniak added the comment:
Sure, your way is much easier to tell what is getting tested. The only thing I
was trying to avoid is including the static text "HTTP Error" so the test will
not break if that static text changes. That said, I really doubt the text would
change for
Daniel Wozniak added the comment:
Senthil,
The two lines you excluded from that patch give us coverage on
HTTPError.__str__ , I added to the existing interface test so as not to
re-produce the code there. I still think it could be added since it will give
us that last line of coverage and
New submission from Daniel Wozniak:
The patch to fix issue http://bugs.python.org/issue16464 neglects the deleter
method of the Request.data property. This allows Request._data to get updated
without removing the Content-length header.
--
components: Library (Lib)
files: patch.diff
Daniel Wozniak added the comment:
Yes, I was trying to add tests for the behavior. I'll try to make the titles
more meaningful in the future. Thanks.
--
title: In urlopen the check_hostname variable can never be False. -> Can not
tell urlopen not to check the hostname f
New submission from Daniel Wozniak:
In the urllib.request.urlopen on line 154 the code path that sets
check_hostname to False will never run. I'm not sure what the desired behavior
is. If we want to have a way to tell urlopen not to check the hostname for
https connections it looks as t
New submission from Daniel Wozniak:
Adding additional tests to get 100% coverage in urllib.parse module. It should
be noted that line 598 technically has coverage but it does not appear that way
due to an peephole optimization, at least we think that is the case.
--
components: Tests
New submission from Daniel Wozniak:
Adding test to get 100% coverage in urllib.error.
--
components: Tests
files: patch.diff
keywords: patch
messages: 184554
nosy: dwoz
priority: normal
severity: normal
status: open
title: Patch for Additional Test Coverage for urllib.error
type
