Derek Morr derekm...@psu.edu added the comment:
I'm not sure how to best write a unit test for this. The patch should only be
invoked if the client doesn't have a name-served hostname and has IPv6 enabled.
Also, there are several IPv4-isms in the smtplib tests
Derek Morr derekm...@psu.edu added the comment:
You're right. My mistake when I made the patch. I've attached a new one without
the trailing else
--
Added file: http://bugs.python.org/file17863/smtplib.patch
___
Python tracker rep...@bugs.python.org
Changes by Derek Morr derekm...@psu.edu:
--
nosy: +dmorr
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5625
___
___
Python-bugs-list mailing list
Derek Morr derekm...@psu.edu added the comment:
Thanks.
Is there any chance of getting bug 1655 fixed as well? imaplib has the
same issue as nntplib, and the patch is identical.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Derek Morr derekm...@psu.edu added the comment:
Any chance of this being applied soon? It's been sitting in the
bugtracker for over a year now.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1664
Changes by Derek Morr derekm...@psu.edu:
--
nosy: +dmorr
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5111
___
___
Python-bugs-list mailing list
Derek Morr derekm...@psu.edu added the comment:
I'm confused by that.
In order to apply a 3 line patch (which replaces one standard library
function with another), you want an entire test suite written for
nntplib?
If we're willing to accept that nttplib works reasonably well now, why
Derek Morr derekm...@psu.edu added the comment:
Senthil,
I don't think your gethost_addrinfo() function will work. On a v6-
enabled machine, it will only return v6 or v4 names. Shouldn't it
return both (since a machine could have both v4 and v6 addresses)? For
example, on my machine, I have
Derek Morr derekm...@psu.edu added the comment:
Question: Why does FTPHandler.ftp_open() try to resolve the hostname()?
The hostname will be passed into connect_ftp(), then into
urllib.ftpwrapper(), and eventually into ftplib.FTP.connect(), which is
IPv6-aware
Derek Morr derekm...@psu.edu added the comment:
My understanding is that the FileHandler checks if the file:// URL
contains the hostname or localhost IP of the local machine (isn't that
what FileHandler.names is for?). So, shouldn't the following URLs all
open the same file:
file:///foo.txt
Derek Morr derekm...@psu.edu added the comment:
Yes. The patch is against 2.6. It uses the socket.create_connection()
helper function, which was added in 2.6. See http://svn.python.org/view?
rev=54546view=rev for the commit message.
If you really want to apply it to 2.5, it's trivial to adapt
New submission from Derek Morr [EMAIL PROTECTED]:
On an IPv6-only machine, smtplib does not send an IPv6 address in the
EHLO. It sends EHLO [0.0.0.0] instead. For example, on a v6-only
network with stateless autoconfiguration enabled (a common
configuration), smtplib will show this error
New submission from Derek Morr:
nntplib hardcodes AF_INET for the socket address family. This prevents
it from using IPv6. Attached is a patch that converts NNTP.__init__() to
use socket.create_connection(), which is IPv6-capable.
--
components: Library (Lib)
files: nntplib_ipv6.patch
Derek Morr added the comment:
I think it makes more sense to use socket.create_connection(), which
performs the getaddrinfo call. It makes the patch against imaplib more
compact. I've attached a new patch that uses create_connection()
Added file: http://bugs.python.org/file9004/imaplib_ipv6
New submission from Derek Morr:
httplib.HTTPSConnection is not IPv6-capable, even though
httplib.HTTPConnection is. HTTPSConnection has its own connect() method
which does not call socket.getaddrinfo().
--
components: Library (Lib)
messages: 58769
nosy: dmorr
severity: normal
status
New submission from Derek Morr:
imaplib.IMAP4 and IMAP4_SSL do not use IPv6-capable name resolution
APIs. Attached is a patch (lifted from httplib) that enables IPv6 in
their open() methods.
--
components: Library (Lib)
files: imaplib_ipv6.patch
messages: 58775
nosy: dmorr
severity
Derek Morr added the comment:
My apologies. This should have been filed against Python 2.3. I see it
was fixed with checkin 54546. Go ahead and close this bug.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1654
17 matches
Mail list logo
