Changes by Ent <pyspl...@gmail.com>:
--
status: open -> languishing
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue23255>
___
__
Ent added the comment:
Hi,
Is it possible for this patch to be reviewed now?
Regards,
Ent
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Ent added the comment:
Thanks Ned Berker,
I can only imagine the amount of work the core devs have to deal with.
Hope my patch makes it through in next version.
Regards,
Ent
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Ent added the comment:
No I think it's better if you put up a separate patch. That way any questions
other reviewers will have, you will be better suited to answer them.
Cheers!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Ent added the comment:
@vadmium: Thanks for the suggestion - I opted for the first one. While I wasn't
happy with it being called twice, wasn't getting an idea of how to address it.
Am I supposed to include your patch as part of my patch? I am not much
knowledgeable about the protocol
Ent added the comment:
I have updated the patch such that for any directory, if they have a file with
name in index_files, it will be served by default. Also a few tweaks.
--
Added file: http://bugs.python.org/file37951/Feb1st.patch
___
Python
Ent added the comment:
Thanks for the update! I wasn't expecting this to be such a friendly positive
experience. Glad to be proven wrong :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23255
Ent added the comment:
Latest patch with simpler(?) logic?
@Demian: This is a tough task! And I appreciate your kind words.
I have gone through your comments and I have made a few changes as per your
suggestion but I have refrained from a few as well.
get_status_type, apply_success_headers
Ent added the comment:
Based on the comments of many good netizens,
I have further updated the patch.
--
Added file: http://bugs.python.org/file37849/jan25.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23255
Ent added the comment:
New patch for review! Let me know if anything is missing.
--
Added file: http://bugs.python.org/file37840/jan24th.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23255
Ent added the comment:
@demian: That's a tall order! :)
I would love to use HTTPStatus but for some reason http/__init__.py is devoid
of code related to it -
https://hg.python.org/cpython/file/31982d70a52a/Lib/http/__init__.py
I wasn't sure why this change was made because it like feels
Ent added the comment:
@demian: If you don't mind, could you please elaborate a bit more on
`_resolve_path()` you mentioned in the review/comment? Or maybe link me to the
type of behaviour you mentioned? I will accordingly make the changes. As for
self.apply_headers, I will see if I can make
Ent added the comment:
Following is updated patch with
* Refactored code with helper functions
* Unit Tests
* Documentation - Explanation + Examples
SimpleHTTPRequestHandler's copyfile has been renamed to copy_file but not
shutils'.
--
Added file: http://bugs.python.org/file37786
Ent added the comment:
I am having some issues with replying to comments on review page. It is giving
500 error hence posting replies here.
@berker.peksag: Thanks! I will add the methods' documentation examples into
the Doc/library/http.server.rst. As well as include a few unit tests.
I
Ent added the comment:
@vadmium: My Mistake. It should read file path not file object. (500 error
when submitting to review page.)
Renaming get_html_or_dir_path to get_path_or_dir for accurate description.
Also renaming copyfile to more pythonic copy_file.
--
Added file: http
New submission from Ent:
Use of http.server.BaseHTTPRequestHandler for exploratory or simple usage,
SimpleHTTPRequestHandler provides a good platform to start on. However, the
current code in SimpleHTTPRequestHandler's send_head is tightly coupled
together as a single unit.
This patch aims
Ent added the comment:
Changing base_files to point @ ['index.htm', 'index.html']
--
Added file: http://bugs.python.org/file37737/simplehttp1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23255
17 matches
Mail list logo
