Erlend Egeberg Aasland added the comment:
This issue could probably be expanded to the whole Modules directory. A lot of
the modules fail to clean up properly on PyModule_AddObject() error.
--
___
Python tracker
<https://bugs.python.
New submission from Erlend Egeberg Aasland :
SQLite 3.32.0 is out: https://www.sqlite.org/releaselog/3_32_0.html
I'll preparing a PR for cpython-source-deps and cpython.
--
components: Windows, macOS
messages: 369711
nosy: erlendaasland, ned.deily, paul.moore, ronaldous
Change by Erlend Egeberg Aasland :
--
pull_requests: +19592
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/20323
___
Python tracker
<https://bugs.python.org/issu
New submission from Erlend Egeberg Aasland :
According to the documentation, PyModule_AddObject() only decrements the
reference count of value on success. The calling code must PyDECREF() manually
on error.
Fixed by attached patch.
--
components: Library (Lib)
files: 0001-Use
Change by Erlend Egeberg Aasland :
Removed file:
https://bugs.python.org/file49163/0001-bpo-40656-Clean-up-detect_socket.patch
___
Python tracker
<https://bugs.python.org/issue40
Change by Erlend Egeberg Aasland :
--
pull_requests: +19453
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/20148
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend Egeberg Aasland :
--
nosy: +berker.peksag
___
Python tracker
<https://bugs.python.org/issue40318>
___
___
Python-bugs-list mailing list
Unsub
Change by Erlend Egeberg Aasland :
Added file:
https://bugs.python.org/file49163/0001-bpo-40656-Clean-up-detect_socket.patch
___
Python tracker
<https://bugs.python.org/issue40
Change by Erlend Egeberg Aasland :
Removed file:
https://bugs.python.org/file49161/0001-Clean-up-detect_socket.patch
___
Python tracker
<https://bugs.python.org/issue40
New submission from Erlend Egeberg Aasland :
Rewrite to use `if cond`, iso. `if not cond`
--
components: Build
files: 0001-Clean-up-detect_socket.patch
keywords: patch
messages: 369101
nosy: erlendaasland
priority: normal
severity: normal
status: open
title: Clean up detect_socket() in
Change by Erlend Egeberg Aasland :
--
pull_requests: +18919
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19581
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend Egeberg Aasland :
--
nosy: +ghaering
___
Python tracker
<https://bugs.python.org/issue40318>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend Egeberg Aasland :
--
type: -> enhancement
___
Python tracker
<https://bugs.python.org/issue40318>
___
___
Python-bugs-list mailing list
Un
New submission from Erlend Egeberg Aasland :
Currently, we're using the sqlite3_trace() for tracing statements. This API was
been superseded by sqlite3_trace_v2() in SQLite3 v3.14 back in August 2016.
Proposing to migrate to the new API, which allows more fine grained control
over wh
Change by Erlend Egeberg Aasland :
--
pull_requests: +18876
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/19526
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend Egeberg Aasland :
--
versions: +Python 3.9
___
Python tracker
<https://bugs.python.org/issue35569>
___
___
Python-bugs-list mailing list
Unsub
Erlend Egeberg Aasland added the comment:
Added (Mac OS specific) unit tests.
--
Added file:
https://bugs.python.org/file49059/0002-bpo-35569-Add-unit-tests.patch
___
Python tracker
<https://bugs.python.org/issue35
Erlend Egeberg Aasland added the comment:
Thanks for testing @chrysn. I guess I should add unit tests if this is to be
applied to master.
--
___
Python tracker
<https://bugs.python.org/issue35
Change by Erlend Egeberg Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue39851>
___
___
Python-bugs-list mailing list
Unsub
Change by Erlend Egeberg Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue39844>
___
___
Python-bugs-list mailing list
Unsub
Erlend Egeberg Aasland added the comment:
Cool. Should I remove Python-3.* from the Versions label, so it doesn't show up
in searches for 3.* issues?
--
___
Python tracker
<https://bugs.python.org/is
Erlend Egeberg Aasland added the comment:
Ok, thanks for your patience and time. I'll fix the NEWS entries right away.
--
___
Python tracker
<https://bugs.python.org/is
Erlend Egeberg Aasland added the comment:
Ah, but you're all set @steve.dower, someone at cpython-source-deps already
pulled my tags: https://github.com/python/cpython-source-deps/tags :)
But I guess that if I were to do the same maneouver again, it would probably be
preferable if I
Erlend Egeberg Aasland added the comment:
Would you prefer that I close GH_18678 and split it up in separate RPs for
macOS and Windows?
--
___
Python tracker
<https://bugs.python.org/issue38
Erlend Egeberg Aasland added the comment:
Proposed patch attached.
--
keywords: +patch
Added file:
https://bugs.python.org/file48937/0001-bpo-35569-Expose-RFC-3542-socket-options-on-macOS.patch
___
Python tracker
<https://bugs.python.
Erlend Egeberg Aasland added the comment:
> I wrote a whole new page for -X dev:
> https://docs.python.org/dev/library/devmode.html#devmode
That's nice, but references for PYTHONFAULTHANDLER and PYTHONTRACEMALLOC are
still missing. If you think the cross refs for -X dev and PY
Change by Erlend Egeberg Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue35569>
___
___
Python-bugs-list mailing list
Unsub
Erlend Egeberg Aasland added the comment:
I've rebased Catherine Devlin's patch onto 3.9 (and adjusted the docs a tiny
bit). If anyone still is interested, I can create a PR (for 3.9) for this.
--
nosy: +erlendaasland
Added file:
https://bugs.python.org/file48936/0001
Erlend Egeberg Aasland added the comment:
Understood; I’ll remember it for future PRs. Thanks for clarifying.
--
___
Python tracker
<https://bugs.python.org/issue38
Change by Erlend Egeberg Aasland :
--
title: Update SQLite to 3.30 in Windows and macOS installer builds -> Update
SQLite to 3.31.1 in Windows and macOS installer builds
___
Python tracker
<https://bugs.python.org/issu
Erlend Egeberg Aasland added the comment:
Great, thanks folks! I've pushed an update to GH-18678.
(BTW, is it kosher to force push to PRs like this?)
--
___
Python tracker
<https://bugs.python.org/is
Erlend Egeberg Aasland added the comment:
I agree. I've updated the branches for source deps and cpython. I'll wait for
Steve's approval before I open a new PR over at cpython-source-deps and update
GH-18678.
--
___
Python
Erlend Egeberg Aasland added the comment:
You're welcome. If you are ok with that, I'd be happy to prepare a PR for the
source deps for sqlite3 v3.31.1, and update GH-18678 as soon as it is tagged.
--
___
Python tracker
<https://bu
Erlend Egeberg Aasland added the comment:
Yes, we need the tag for the Windows build, so the PR currently fails the
Windows checks. (Tagging must be done explicitly by the maintainers, IIRC.) I
also forgot to add a NEWS entry, so I'll do another push to add those (and kick
off the CI)
Erlend Egeberg Aasland added the comment:
I'm a bit uncertain if the previous patch can handle the emit() case correctly.
Proposed improvement in attached patch (0002-Improve-emit.patch).
--
Added file: https://bugs.python.org/file48934/0002-Improve-emit.
Change by Erlend Egeberg Aasland :
Added file:
https://bugs.python.org/file48933/0001-bpo-38780-Harden-socket-use-in-logging.handlers.patch
___
Python tracker
<https://bugs.python.org/issue38
Change by Erlend Egeberg Aasland :
Removed file:
https://bugs.python.org/file48932/0001-bpo-38780-Harden-socket-use-in-logging.handlers.patch
___
Python tracker
<https://bugs.python.org/issue38
Erlend Egeberg Aasland added the comment:
Attached patch is based on Ronald Oussoren's and Alan Robertson's comments:
Initialise self.socket to None early in __init()__, and then check for None in
close() and emit(). Passes make test on 3.9, 3.8 and 3.7.
If this solution is ok
Erlend Egeberg Aasland added the comment:
I might have missed something, but I thought .pyw files were a Windows specific
thing.
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue36
Erlend Egeberg Aasland added the comment:
I've created a patch that applies fine to 3.7, 3.8 and 3.9, if anyone still is
interested.
(Backporting to 3.6 and 2.7 is probably not going to happen, but at least the
patch applies fine to both of them.)
The "Versions" label list
Change by Erlend Egeberg Aasland :
--
nosy: +erlendaasland
nosy_count: 9.0 -> 10.0
pull_requests: +18045
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/18685
___
Python tracker
<https://bugs.p
Change by Erlend Egeberg Aasland :
Added file: https://bugs.python.org/file48927/0001-3.8-bpo-39712.patch
___
Python tracker
<https://bugs.python.org/issue39712>
___
___
Change by Erlend Egeberg Aasland :
--
keywords: +patch
Added file: https://bugs.python.org/file48926/0001-bpo-39712.patch
___
Python tracker
<https://bugs.python.org/issue39
Change by Erlend Egeberg Aasland :
Added file: https://bugs.python.org/file48928/0001-3.7-bpo-39712.patch
___
Python tracker
<https://bugs.python.org/issue39712>
___
___
Change by Erlend Egeberg Aasland :
--
pull_requests: +18038
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/18678
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend Egeberg Aasland :
Added file:
https://bugs.python.org/file48922/0002-bpo-38380-Update-Windows-builds-to-use-SQLite-3.30.1.patch
___
Python tracker
<https://bugs.python.org/issue38
Change by Erlend Egeberg Aasland :
Added file:
https://bugs.python.org/file48921/0001-bpo-38380-Update-macOS-installer-to-use-SQLite-3.30.1.patch
___
Python tracker
<https://bugs.python.org/issue38
Erlend Egeberg Aasland added the comment:
I've updated these patches to sqlite3-3.30.1
(https://www.sqlite.org/releaselog/3_30_1.html).
cpython-source-deps is updated
(https://github.com/python/cpython-source-deps/pull/17).
CPython commits are updated and rebased onto current 3.9 m
Erlend Egeberg Aasland added the comment:
Update: Tested on macOS 10.14.6 with make test on 2.7.17rc1, 3.7.5rc1+,
3.8.0rc1+.
--
___
Python tracker
<https://bugs.python.org/issue38
Erlend Egeberg Aasland added the comment:
FYI: Compiled cpython 3.9 with sqlite-3.30 on macOS 10.14.6. Make test
completes without errors.
--
___
Python tracker
<https://bugs.python.org/issue38
Erlend Egeberg Aasland added the comment:
bpo-38380: Update Windows builds to use SQLite 3.30.0
https://github.com/erlend-aasland/cpython/commit/e25214e6fa7a64353d9c3e16b139c41f5d62eb31
--
Added file:
https://bugs.python.org/file48652/0002-bpo-38380-Update-Windows-builds-to-use
Erlend Egeberg Aasland added the comment:
bpo-38380: Update macOS installer to use SQLite 3.30.0
https://github.com/erlend-aasland/cpython/commit/aa7d7b1a3bed9a6a73f0611d0542a3442e85b0b6
--
keywords: +patch
Added file:
https://bugs.python.org/file48651/0001-bpo-38380-Update-macOS
Erlend Egeberg Aasland added the comment:
I've prepared a PR for https://github.com/python/cpython-source-deps at
https://github.com/erlend-aasland/cpython-source-deps/tree/upgrade-sqlite.
Patches for Windows and macOS installer builds on 3.9 prepared at
https://github.com/erlend-aa
Change by Erlend Egeberg Aasland :
--
components: +macOS
nosy: +ned.deily, ronaldoussoren
___
Python tracker
<https://bugs.python.org/issue37653>
___
___
Pytho
Change by Erlend Egeberg Aasland :
--
pull_requests: +14686
pull_request: https://github.com/python/cpython/pull/14911
___
Python tracker
<https://bugs.python.org/issue37
New submission from Erlend Egeberg Aasland :
Make install is broken in subtarget libinstall. This was introduced with commit
e8692818afd731c1b7e925c626ac8200b1f1c31e.
Fix in attached patch.
--
components: Build
files: fix.patch
keywords: patch
messages: 348300
nosy: Erlend Egeberg
601 - 656 of 656 matches
Mail list logo