Fotis Koutoulakis added the comment:
Taking the feedback during code review, this is a patch that has the points
raised by Serhiy Storchaka fixed.
As always, please do note omission or mistakes from my part. Thanks for your
help.
--
Added file: http://bugs.python.org/file33057
Fotis Koutoulakis added the comment:
Oh, I see. Does the last patch meet your expectations, or would you rather see
all these changes implemented at once?
--
___
Python tracker
<http://bugs.python.org/issue18
Fotis Koutoulakis added the comment:
Ok, here is the second (modified patch) which contains a script so that no
modifications are required to existing tests.
I am uploading it as a second patch, so that the first one is left as a
reference.
As a sidenote, I fail to see convincing reasons for
Fotis Koutoulakis added the comment:
Hello again.
Is everything ok with the patch? Is there something not working as expected?
Perhaps an omission or something? Do I need to do something more to get it
accepted?
Thanks for your time
Fotis Koutoulakis added the comment:
I have finished the changes needed to move script_helper from Lib/test to
Lib/test/support, and I have also documented it. Tests run gracefully (but be
sure to check out if it works as intended on your machines too)
Two notes though:
1. I have only made
Fotis Koutoulakis added the comment:
Hello, I'm in the process of trying to find a solution to this problem, but I'm
afraid the choice of wording at some point is kind of...ambiguous.
I have some questions I want to ask, to clear some doubts in my head:
First one is:
"i
Fotis Koutoulakis added the comment:
There we go. I have changed the references to compile(), both in the docstring,
and the documentation so that it states clearly that a bytes object is also
acceptable as the "source" argument.
I also fixed the docstring to mention explicitly t
