Change by Gregory P. Smith :
--
pull_requests: +10742, 10743
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailing list
Unsub
Change by Gregory P. Smith :
--
pull_requests: +10742, 10743, 10744
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
pull_requests: +10742
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
resolution: -> fixed
stage: patch review -> commit review
versions: +Python 3.8
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
New changeset 6f9bc72c79c3262e5d0f2c0e96b016477399cfb1 by Gregory P. Smith
(Jakub Kulík) in branch 'master':
bpo-35550: Fix incorrect Solaris define guards (GH-11275)
https://github.com/python/cpython/commit/6f9bc72c79c3262e5d0f2c0e96b016477399cfb1
Gregory P. Smith added the comment:
I'm going to close this as 3.7 and 3.8 are good now, but if someone wants to
see the same thing done in 2.7 it should be possible for them make a PR. This
is primarily just a configure.ac change.
--
resolution: -> fixed
stage: commit rev
Gregory P. Smith added the comment:
New changeset a144feeb7ec501aaf30072d50e70d54b200e5ef0 by Gregory P. Smith
(Miss Islington (bot)) in branch '3.7':
bpo-28503: Use crypt_r() when available instead of crypt() (GH-11373) (GH-11376)
https://github.com/python/cpython/commit
Gregory P. Smith added the comment:
New changeset 01b9664740307b39c2907bd84cbb0b2c35be9df4 by Gregory P. Smith
(Miss Islington (bot)) in branch '3.7':
bpo-35214: MSan workarounds for socket, time, and test_faulthandler. (GH-11375)
(GH-11378)
https://github.com/python/cpython/commit
Gregory P. Smith added the comment:
These are all related to the output of the child process containing sanitizer
stuff so the stdout/stderr based tests are failing.
i skipped two of these for memory sanitizers, the third looks easy enough to
fix via the regex. PR attached
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue35225>
___
___
Python-
Change by Gregory P. Smith :
--
keywords: +patch, patch
pull_requests: +10730, 10731
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +10730
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue35225>
___
_
Change by Gregory P. Smith :
--
keywords: +patch, patch, patch
pull_requests: +10730, 10731, 10732
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Gregory P. Smith :
--
stage: -> needs patch
___
Python tracker
<https://bugs.python.org/issue31122>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by Gregory P. Smith :
--
versions: -Python 3.5, Python 3.6
___
Python tracker
<https://bugs.python.org/issue31122>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
versions: +Python 3.6, Python 3.7, Python 3.8
___
Python tracker
<https://bugs.python.org/issue31122>
___
___
Python-bugs-list m
Gregory P. Smith added the comment:
This flakiness just caused a PR merge to be blocked by AppVeyor for me:
==
ERROR: test_with_statement (test.test_nntplib.NetworkedNNTP_SSLTests
Gregory P. Smith added the comment:
New changeset b474e6774d60fa67d5373e361a0ed53c18b24f53 by Gregory P. Smith in
branch 'master':
bpo-35214: MSan workarounds for socket, time, and test_faulthandler. (GH-11375)
https://github.com/python/cpython/commit/b474e6774d60fa67d5373e361a0ed53c18b24f53
Change by Gregory P. Smith :
--
stage: patch review -> commit review
___
Python tracker
<https://bugs.python.org/issue28503>
___
___
Python-bugs-list mai
Gregory P. Smith added the comment:
As this is internal only rather than a feature, i'll bring this into 3.7 as
well.
--
versions: +Python 3.7
___
Python tracker
<https://bugs.python.org/issue28
Gregory P. Smith added the comment:
New changeset 387512c7ecde6446f2e29408af2e16b9fc043807 by Gregory P. Smith in
branch 'master':
bpo-28503: Use crypt_r() when available instead of crypt() (GH-11373)
https://github.com/python/cpython/commit/387512c7ecde6446f2e29408af2e16b9fc043807
Change by Gregory P. Smith :
--
pull_requests: +10715, 10716, 10717
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
pull_requests: +10715, 10716
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailing list
Unsub
Change by Gregory P. Smith :
--
pull_requests: +10715
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
pull_requests: +10712, 10713, 10714
___
Python tracker
<https://bugs.python.org/issue28503>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
pull_requests: +10712, 10713
___
Python tracker
<https://bugs.python.org/issue28503>
___
___
Python-bugs-list mailing list
Unsub
Change by Gregory P. Smith :
--
pull_requests: +10712
___
Python tracker
<https://bugs.python.org/issue28503>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
versions: +Python 3.8 -Python 3.7
___
Python tracker
<https://bugs.python.org/issue28503>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue28503>
___
___
Python-
Gregory P. Smith added the comment:
Thanks for all your research and reference links on this! As a
_posixsubprocess maintainer, I am not against either posix_spawn or vfork being
used directly in the future when feasible.
A challenge, especially with platform specific vfork, is making sure
Change by Gregory P. Smith :
--
assignee: -> christian.heimes
___
Python tracker
<https://bugs.python.org/issue34836>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
But the `build_all_generate_profile` build is an intermediate instrumented
interpreter build, it isn't shipped and things like PGO often require flags
that the linker sees in order to generate the instrumented binary.
If those are left off of the link
Gregory P. Smith added the comment:
Only if someone can point to a concrete problem to be fixed in the 3.7+ docs.
Looking at all references to close_fds in
https://docs.python.org/3/library/subprocess.html I don't see one.
(I'm not going to touch the 3.6 docs
Gregory P. Smith added the comment:
I believe there are still some issues to deal with. I don't want to close the
issue until I've got my buildbot running.
--
versions: -Python 3.6
___
Python tracker
<https://bugs.python.org/issue35
Gregory P. Smith added the comment:
In 3.6 this help(subprocess.Popen.__init__) is accurate and encourages looking
at the docs. In 3.7 and later it'll simply report close_fds=True in the
siguature as that is the case in 3.7 onwards.
I see nothing to fix here.
--
nosy
Change by Gregory P. Smith :
--
versions: -Python 3.6
___
Python tracker
<https://bugs.python.org/issue31823>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
Serhiy: should this one be marked fixed?
--
assignee: -> serhiy.storchaka
stage: patch review -> commit review
___
Python tracker
<https://bugs.python.org/i
Gregory P. Smith added the comment:
It is fundamentally impossible for pickled data to magically cross the 2 and 3
language boundary unscathed.
The basic str/bytes/unicode types in the language changed meaning. Code must
be written manually by the data owners to fix that up based on what
Gregory P. Smith added the comment:
New changeset e328753d91379274b699b93decff45de07854617 by Gregory P. Smith in
branch 'master':
bpo-22005: Document the reality of pickle compatibility. (GH-11054)
https://github.com/python/cpython/commit/e328753d91379274b699b93decff45de07854617
Change by Gregory P. Smith :
--
pull_requests: +10289
___
Python tracker
<https://bugs.python.org/issue22005>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
Oh neat, I didn't realize that Nathaniel. That makes such warnings much more
useful.
I'm fine if you go ahead with this change. In the unlikely event it turns out
to cause user annoyance problems in betas due to third party code that can't be
updated
Gregory P. Smith added the comment:
Given that linters like pylint can already detect the common case of this issue
when using `is` and `is not` to compare to a literal where == or != seems more
appropriate, I don't think a warning is very useful.
In my experience people are more likely
Gregory P. Smith added the comment:
I don't think it is crazy for 2.7, but I'd move that to its own issue as you
already nicely addressed the problem related to this PR without needing that.
--
___
Python tracker
<https://bugs.python.
Gregory P. Smith added the comment:
why was that only an issue on 2.7?
--
___
Python tracker
<https://bugs.python.org/issue33015>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
versions: +Python 3.8 -Python 3.6
___
Python tracker
<https://bugs.python.org/issue24209>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
versions: +Python 3.7, Python 3.8 -Python 3.4, Python 3.5
___
Python tracker
<https://bugs.python.or
Change by Gregory P. Smith :
--
versions: +Python 3.6, Python 3.8
___
Python tracker
<https://bugs.python.org/issue31354>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issue31354>
___
___
Python-bugs-list mai
Gregory P. Smith added the comment:
New changeset b6f4472dc4190e2fd668490d86aeefd2ab0df935 by Gregory P. Smith in
branch '2.7':
[2.7] bpo-35214: Fix OOB memory access in unicode escape parser (GH-10506)
(GH-10538)
https://github.com/python/cpython/commit
Change by Gregory P. Smith :
--
pull_requests: +9789
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
Correct, this issue was filed before we had the new pyc options (which came out
of our September core dev. sprint in 2016 iirc).
I'll just close it, the way forward for people using zip files on modern
CPython interpreters is to explicitly use the new
Gregory P. Smith added the comment:
Is it an actual problem to compile extension modules with -flto? (I realize as
an extension module there isn't a huge benefit to the concept unless it happens
to have multiple source files or link against a non-shared library
Gregory P. Smith added the comment:
New changeset 746b2d35ea47005054ed774fecaed64fab803d7d by Gregory P. Smith in
branch 'master':
bpo-35214: Fix OOB memory access in unicode escape parser (GH-10506)
https://github.com/python/cpython/commit/746b2d35ea47005054ed774fecaed64fab803d7d
Change by Gregory P. Smith :
--
pull_requests: +9766
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset 3015fb8ce4d25603434b9b44bb7effb98a481532 by Gregory P. Smith in
branch 'master':
bpo-35214: Add _Py_ prefix to MEMORY_SANITIZER def. (GH-10503)
https://github.com/python/cpython/commit/3015fb8ce4d25603434b9b44bb7effb98a481532
Gregory P. Smith added the comment:
> Can we prefix MEMORY_SANITIZER with _Py_?
Yes, I wondered if I should do that. not that I expect anyone would ever
define it to mean anything else, but that seems like the right thing to do.
https://github.com/python/cpython/pull/10
Change by Gregory P. Smith :
--
pull_requests: +9763
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
yeah, i've been surprised how far i was able to get from an oss CPython tree
and pre-built clang 7 binary installation. If you have headers installed for
common libraries like libssl-dev and libreadline-dev you can't produce an
interpreter that'll work
Change by Gregory P. Smith :
--
pull_requests: +9760
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset 3b5b1c0931cd32253bbf2f3bd74e90ff821e026e by Gregory P. Smith in
branch '3.6':
[3.6] bpo-35214: Initial clang MemorySanitizer support (GH-10479) (GH-10493)
https://github.com/python/cpython/commit/3b5b1c0931cd32253bbf2f3bd74e90ff821e026e
Gregory P. Smith added the comment:
it still seems relevant, having better docs is always good.
--
___
Python tracker
<https://bugs.python.org/issue25
Change by Gregory P. Smith :
--
pull_requests: +9751
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset 5f4d05d83fde05fed0b6554d0beee4f1c1f1d8f1 by Gregory P. Smith in
branch '3.7':
[3.7] bpo-35214: Initial clang MemorySanitizer support (GH-10479) (GH-10492)
https://github.com/python/cpython/commit/5f4d05d83fde05fed0b6554d0beee4f1c1f1d8f1
Change by Gregory P. Smith :
--
pull_requests: +9749
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset 1584a0081500d35dc93ff88e5836df35faf3e3e2 by Gregory P. Smith in
branch 'master':
bpo-35214: Initial clang MemorySanitizer support (GH-10479)
https://github.com/python/cpython/commit/1584a0081500d35dc93ff88e5836df35faf3e3e2
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +9746
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailin
New submission from Gregory P. Smith :
clang's memory sanitizer (-fsanitize=memory) turns up useful problems in code.
I'm working on getting a CPython buildbot running it setup but would like our
build to be cleaner to start with before I run that.
These are the initial fixes required
Gregory P. Smith added the comment:
I'm working on getting a memory-sanitizer buildbot setup. I'm so happy it made
finding and debugging this relatively easy.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -&g
Gregory P. Smith added the comment:
New changeset 65e1a1fd311943866361fcb288c0df65dadbe092 by Gregory P. Smith in
branch '3.6':
bpo-35193: Fix an off by one error in the RETURN_VALUE case. (GH-10418)
(GH-10422)
https://github.com/python/cpython/commit
Change by Gregory P. Smith :
--
pull_requests: +9703
___
Python tracker
<https://bugs.python.org/issue35193>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset 49fa4a9f1ef387e16596f271414c855339eadf09 by Gregory P. Smith in
branch 'master':
bpo-35193: Fix an off by one error in the RETURN_VALUE case. (GH-10418)
https://github.com/python/cpython/commit/49fa4a9f1ef387e16596f271414c855339eadf09
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +9698
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue35193>
___
_
Gregory P. Smith added the comment:
the off by one error fix here introduced a new off by one error. PR coming,
follow https://bugs.python.org/issue35193 for that.
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue28
New submission from Gregory P. Smith :
An off by one error was introduced to peephole.c by the "off by one error fix"
in https://bugs.python.org/issue28517. Clang's memory sanitizer detects it
(msan).
find_op is ultimately called with h == codelen so it accesses one byte out of
Gregory P. Smith added the comment:
Interesting! I have a 3.6.2 sitting around and cannot reproduce that "x=1"
behavior.
I don't know what the behavior _should_ be. It just feels natural that
untokenize should be able to round trip anything tokenize or generate_tokens
emi
Gregory P. Smith added the comment:
https://bugs.python.org/issue35107 filed to track further fallout from this API
change.
--
___
Python tracker
<https://bugs.python.org/issue33
New submission from Gregory P. Smith :
The behavior change introduced in 3.6.7 and 3.7.1 via
https://bugs.python.org/issue33899 has further consequences:
```python
>>> tokenize.untokenize(tokenize.generate_tokens(io.StringIO('#').readline))
Traceback (most recent call last):
File &
Gregory P. Smith added the comment:
This is presumably also present in 3.6 and 2.7 so I've tagged those on the
issue, but for this kind of change i'd leave it up to release managers to see
if they want to backport something of this nature that late in those release
cycles.
Observable side
Gregory P. Smith added the comment:
I left comments on the github PRs with reasons why, but PR 6008 seems correct.
PR 10057 would leave us with undefined behavior.
--
___
Python tracker
<https://bugs.python.org/issue33
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith
versions: +Python 3.7
___
Python tracker
<https://bugs.python.org/issue33012>
___
___
Python-bugs-list m
Gregory P. Smith added the comment:
New changeset dfba1f67e7f1381ceb7cec8fbcfa37337620a9b0 by Gregory P. Smith (Tal
Einat) in branch 'master':
bpo-33899: Mention tokenize behavior change in What's New (GH-10073)
https://github.com/python/cpython/commit
Gregory P. Smith added the comment:
some pylint fallout appears to be addressed in
https://github.com/PyCQA/pylint/commit/2698cbe56b44df7974de1c3374db8700296c6fad
--
___
Python tracker
<https://bugs.python.org/issue33
Gregory P. Smith added the comment:
FYI, An example of other fallout from this change - patsy broke and needed this
fix:
https://github.com/pydata/patsy/commit/4f53bbaf58c0bf1a9bed73fc67c7c6d0aa7f4e20#diff-53c70e68c6dfd4fe9b08427792cb2bd6
--
nosy: +gregory.p.smith
Gregory P. Smith added the comment:
correct, i don't see an obvious problem in the existing code.
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue34
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
New changeset 9d4712bc8f26bf1d7e626b53ab092fe030bcd68d by Gregory P. Smith in
branch 'master':
bpo-35011: Restore use of pyexpatns.h in libexpat (GH-9939)
https://github.com/python/cpython/commit/9d4712bc8f26bf1d7e626b53ab092fe030bcd68d
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +9290
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
This appears to not have been shipped in a release yet. It is new in 3.6.7.
cc'ing ned daily to see if he wants to include the fix (the PR is trivial,
coming ASAP).
I don't have a good feel for how this impacts the real world or not.
We noticed because
Gregory P. Smith added the comment:
Not a release blocker as most users probably do not run into this problem, but
the pyexpatns.h mechanics should be restored.
--
assignee: -> gregory.p.smith
components: +Build, Extension Modules
nosy: +benjamin.peterson
stage: -> needs
New submission from Gregory P. Smith :
These lines used to exist in Modules/expat/expat_external.h:
/* Namespace external symbols to allow multiple libexpat version to
co-exist. */
#include "pyexpatns.h"
https://github.com/python/cpython/commit/5dc3f23b5fb0b510926012cb3732dae63cd
Gregory P. Smith added the comment:
New changeset 3b699932e5ac3e76031bbb6d700fbea07492641d by Gregory P. Smith
(Miss Islington (bot)) in branch '3.7':
bpo-6721: Hold logging locks across fork() (GH-4071) (#9291)
https://github.com/python/cpython/commit
Gregory P. Smith added the comment:
The intent is to use only enable this during testing / continuous integration.
--
___
Python tracker
<https://bugs.python.org/issue34
Gregory P. Smith added the comment:
If we were to ship a "chaos" mode in the CPython interpreter itself, I assume
you envision an interpreter flag and/or env var? If it required someone
compiling the interpreter a special way I don't think it would be widely
adopted within
Gregory P. Smith added the comment:
The problem with a SyntaxWarning is that the wrong people will see it. It gets
in the way of users of applications that happen to be written in Python.
scenarios:
(a) A Python interpreter gets upgraded, and suddenly the _users_ of an
application start
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith
versions: +Python 3.7, Python 3.8 -Python 3.5
___
Python tracker
<https://bugs.python.org/issue15
New submission from Gregory P. Smith :
The following test code segfaults on Python 2.7:
```python
import io
class X(io.RawIOBase):
def readable(self):
return True
def readinto(self, b):
if isinstance(b, memoryview):
print(b.format) # XXX boom, crashes here.
return 0
Change by Gregory P. Smith :
--
versions: +Python 3.8
___
Python tracker
<https://bugs.python.org/issue29988>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
fwiw, agreed that this should wait for 3.7.2.
--
___
Python tracker
<https://bugs.python.org/issue34776>
___
___
Python-bug
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith
versions: +Python 3.8
___
Python tracker
<https://bugs.python.org/issue34776>
___
___
Python-bugs-list m
Gregory P. Smith added the comment:
Agreed on not exposing it.
It seems obsolete in recent glibc and the older glibc implementations that had
it may have made questionable decisions. :)
Thanks for chiming in Florian, and thanks Pablo for your detailed
investigation
1201 - 1300 of 3243 matches
Mail list logo
