Gregory P. Smith added the comment:
for what it's worth: false positives are always going to be possible in any
such "magic" check as is_zipfile is.
we don't check the start of the file because zip files are defined by their end
of file central directory which contains length i
Change by Gregory P. Smith :
--
pull_requests: +21863
pull_request: https://github.com/python/cpython/pull/22945
___
Python tracker
<https://bugs.python.org/issue35
Gregory P. Smith added the comment:
regarding excluding the setsid() case: I was being conservative as I couldn't
find a reference of what was and wasn't allowed after vfork.
I found one thing suggesting that on macOS setsid() was not safe after vfork().
But that appeared to be a Darwin
Gregory P. Smith added the comment:
New changeset 473db47747bb8bc986d88ad81799bcbd88153ac5 by Alexey Izbyshev in
branch 'master':
bpo-35823: subprocess: Fix handling of pthread_sigmask() errors (GH-22944)
https://github.com/python/cpython/commit/473db47747bb8bc986d88ad81799bcbd88153ac5
Gregory P. Smith added the comment:
Thank you for taking this on! I'm calling it fixed for now as the buildbots
are looking happy with it. If issues with it arise we can address them.
--
resolution: -> fixed
stage: commit review -> resolved
status: open -&g
Gregory P. Smith added the comment:
> * To avoid repeating long parameter lists in several functions, we can move
> them to a struct. The downside is that we'd need to convert child_exec() to
> use that struct all over the place. I don't have a strong preference here.
Agreed that
Gregory P. Smith added the comment:
now waiting to see how happy all of the buildbots are...
We currently have a `__linux__` check in the code deciding VFORK_USABLE.
>From what I can tell, vfork probably also works on macOS (darwin).
Lets let this run for a bit on Linux and it
Gregory P. Smith added the comment:
New changeset 976da903a746a5455998e9ca45fbc4d3ad3479d8 by Alexey Izbyshev in
branch 'master':
bpo-35823: subprocess: Use vfork() instead of fork() on Linux when safe
(GH-11671)
https://github.com/python/cpython/commit
Gregory P. Smith added the comment:
If you use os.fork() or any of the multiprocessing start methods that call
os.fork() with a process involving threads, this is expected behavior.
os.fork() cannot be used in processes that have threads without potential for
deadlock.
Specifically, make
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
New changeset 786addd9d07b6c712b8ea9ee06e1f9f41c1b67a1 by Gregory P. Smith in
branch 'master':
bpo-41586: Attempt to make the pipesize tests more robust. (GH-22839)
https://github.com/python/cpython/commit/786addd9d07b6c712b8ea9ee06e1f9f41c1b67a1
Change by Gregory P. Smith :
--
pull_requests: +21793
stage: commit review -> patch review
pull_request: https://github.com/python/cpython/pull/22839
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
this caused a variety of buildbot failures. investigating.
--
resolution: fixed ->
status: closed -> open
___
Python tracker
<https://bugs.python.org/i
Gregory P. Smith added the comment:
fyi - handy command to get that
python -m test.regrtest -v test_subprocess | ts '.%s'
then process that using whatever you want to compute deltas and sort. i fed
the output of that into:
```
#!/usr/bin/python3
"""Parse `python -m test.r
Gregory P. Smith added the comment:
the slowest tests on Linux today (with number of seconds prepended on my system
that runs the suite serially in 34 seconds on a debug build):
3.01 test_check_output_stdout_arg (test.test_subprocess.ProcessTestCaseNoPoll)
... ok
3.01
Change by Gregory P. Smith :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
since the time this was filed, subprocess has evolved a lot and third party
options for child process have appeared as well as modern things like:
https://docs.python.org/3/library/asyncio-subprocess.html (stdlib)
https://trio.readthedocs.io/en/stable
Gregory P. Smith added the comment:
2.7 is end of life.
if you have regular expression performance issues with something in 3, please
open a new issue.
--
nosy: +gregory.p.smith
resolution: -> wont fix
stage: -> resolved
status: pending -&g
Change by Gregory P. Smith :
--
versions: +Python 3.10 -Python 3.8
___
Python tracker
<https://bugs.python.org/issue13501>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
based on the reaction from those who own mock at this point, i'm going to close
this. shipping more handy mock matchers with mock makes sense to me as they
belong together. but i'm not willing to argue it if anyone thinks it'll be a
maintenance burden
Gregory P. Smith added the comment:
Parsing support for `f(**mapping)` support is indeed still missing.
as lib2to3 is pending deprecation at this point, i'm not going to work on this.
anyone is welcome to pick it up. modifying the lib2to3 grammar, and any
related code, and adding a test
Gregory P. Smith added the comment:
Thanks Ruben!
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
type: -> enhancement
___
Python tracker
<https://bugs.python
Gregory P. Smith added the comment:
New changeset 23c0fb8edd16fe6d796df2853a5369fd783e05b7 by Ruben Vorderman in
branch 'master':
bpo-41586: Add pipesize parameter to subprocess & F_GETPIPE_SZ and F_SETPIPE_SZ
to fcntl. (GH-21921)
https://github.com/python/cpython/co
Gregory P. Smith added the comment:
status: lib2to3 PendingDeprecationWarning shipped in 3.9. Since we don't have
a specific release planned for the final deprecation, I'll leave this issue
open while we figure that out. Once we do, we should promote this to a regular
DeprecationWarning
Change by Gregory P. Smith :
--
assignee: gregory.p.smith ->
stage: patch review ->
___
Python tracker
<https://bugs.python.org/issue40360>
___
___
Pyth
Gregory P. Smith added the comment:
thanks Kyle!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
Status: Waiting until after the importlib.metadata and importlib.resources
backports drop support for both Python 2.7 and 3.5 as keeping them in sync
would be a pain for maintainers (per jaraco on our sprint importlib-any chat
today
Change by Gregory P. Smith :
--
versions: +Python 3.10 -Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue38693>
___
___
Python-bugs-list m
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
I assume a rolling hash is linear at best, even if you do add some skip ahead
checks.
--
___
Python tracker
<https://bugs.python.org/issue41
Gregory P. Smith added the comment:
Another potential algorithm to consider in large needle situations is a
Rabin-Karp rolling hash string search.
If used, it's the kind of algorithm that I'd probably bail out to an alternate
method on if a run of Rabin-Karp started having a high percentage
Gregory P. Smith added the comment:
FWIW I think your numbers look good, a small needle cut-off is likely a good
idea.
--
___
Python tracker
<https://bugs.python.org/issue41
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue41972>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset 64eb259cc1e42a5f74b5911a518d2c50daa8d50b by Kyle Evans in branch
'master':
bpo-40422: Move _Py_*_SUPPRESS_IPH bits into _Py_closerange (GH-22672)
https://github.com/python/cpython/commit/64eb259cc1e42a5f74b5911a518d2c50daa8d50b
Gregory P. Smith added the comment:
Just reuse this bpo issue. I'll mark the PRs as "skip news"; don't worry about
a new news blurb entry as it's all tied to the original one.
--
status: closed -> open
___
Python tracker
<https:/
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue40423>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
Ah, yeah ENOSYS is it. I had to do this trick in older subprocess versions for
something else. Still visible here in the old 2.7 backport:
https://github.com/google/python-subprocess32/blob/main/_posixsubprocess.c#L801
Change by Gregory P. Smith :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue40422>
___
___
Pyth
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue40422>
___
___
Python-
Change by Gregory P. Smith :
--
versions: +Python 3.10 -Python 3.9
___
Python tracker
<https://bugs.python.org/issue40423>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
for reference, very recent Linux kernels appear to have gained a close_range
syscall. http://lkml.iu.edu/hypermail/linux/kernel/2008.0/02649.html
Your diff isn't quite sufficient as is. When depending on a syscall that has a
function provided by libc
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
looks like it, thanks!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
It's a known issue and has been outlined very well and still comes up from time
to time in real world applications, which tend to see this issue and Dave's
presentation and just work around it in any way possible for their system and
move on with life
Change by Gregory P. Smith :
--
stage: backport needed -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue9146>
___
___
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: backport needed -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
On POSIX systems, keeping the file open means you will keep a handle to the
original file in the case where something moves a new file into it's place (as
is normal during software package updates) or otherwise unlinks the original.
That is the situation
Change by Gregory P. Smith :
--
versions: +Python 3.10 -Python 3.8
___
Python tracker
<https://bugs.python.org/issue29988>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
The gps-* bots have been updated.
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue41642>
___
___
Change by Gregory P. Smith :
--
pull_requests: -21110
___
Python tracker
<https://bugs.python.org/issue6721>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
pull_requests: -2
___
Python tracker
<https://bugs.python.org/issue36533>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
versions: +Python 3.10 -Python 3.9
___
Python tracker
<https://bugs.python.org/issue4356>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue41586>
___
___
Python-
Gregory P. Smith added the comment:
fwiw, no PEP is needed for things like this. it'd just be an alternative
library implementing the core of the zlib and/or gzip modules behind the scenes.
normally this kind of thing would be done using a check for the availability of
the library
Change by Gregory P. Smith :
--
pull_requests: -21037
___
Python tracker
<https://bugs.python.org/issue41566>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
While this is present in 3.7 (and earlier?), 3.7 is EOL - security fix only
stage. the 3.8 and 3.9 PRs should automerge after CI finishes.
please reopen the issue or ping me on those PRs if they somehow fail to do so.
--
resolution: -> fi
Gregory P. Smith added the comment:
Thanks!
fyi for confirmation incase anyone doubted:
>>> issubclass(ssl.SSLEOFError, OSError)
True
So from a code point of view, anything already catching the error still catches
the error. 100% bugfix.
--
assignee: christi
Gregory P. Smith added the comment:
A workaround should be pass bufsize=0.
There might be performance consequences. That depends on your read patterns
and child process.
If this is to be supported and fixed, the selectors used in POpen._communicate
on the POSIX side presumably don't
Gregory P. Smith added the comment:
Thanks for the analysis Eryk! I think you are right, changing the default to
match the behavior that people have actually been experiencing on `os.link(src,
dst)` makes sense.
Possible suggestion:
We can go one step further if anyone believes
New submission from Gregory P. Smith :
See https://lemire.me/blog/2020/03/10/fast-float-parsing-in-practice/ for
inspiration and a reference (possibly a library to use, but if not the
techniques still apply).
Primarily usable when creating the float objects from the string data as is
common
Gregory P. Smith added the comment:
I probably I wrote these docs (a long time ago). The examples are being used
to demonstrate different uses of the APIs including calling update multiple
times, different algorithms, a binary digest and a hex digest.
They weren't mean to show
Gregory P. Smith added the comment:
Yes this should become part of --with-optimizations when building on a platform
using a compiler that (a) supports it and (b) where it matters.
If this is only relevant on --enable-shared builds (not the default), i'd
assume also make it conditional
Gregory P. Smith added the comment:
and to echo others: Do not worry about LD_PRELOAD users trying to override
internals. That is not a supported use case. It is always a hack. anyone
using it knows this.
--
___
Python tracker
<ht
Change by Gregory P. Smith :
--
nosy: +steve.dower
___
Python tracker
<https://bugs.python.org/issue41151>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
No objections, it would be great to see this finished up and land.
I've encountered a minority of users who are using a wrapped vfork-based C/C++
library for process spawning as fork+exec isn't fast enough for them
Gregory P. Smith added the comment:
The 3.7 PR is up to the release manager to decide on, it probably isn't worth
merging there as this i not security related. thanks for the fix Serhiy!
--
nosy: +gregory.p.smith
___
Python tracker
<ht
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Gregory P. Smith :
This type of change might make more sense to integrate into configure.ac and
pyconfig.h.in. (does haiku use autoconf?)
But even if not, lets not scatter haiku ifdef HAIKU references all over the
codebase. Such ifdef's to redefine things should
Change by Gregory P. Smith :
--
nosy: +christian.heimes
___
Python tracker
<https://bugs.python.org/issue41059>
___
___
Python-bugs-list mailing list
Unsub
Change by Gregory P. Smith :
--
pull_requests: +20187
pull_request: https://github.com/python/cpython/pull/21013
___
Python tracker
<https://bugs.python.org/issue41
Change by Gregory P. Smith :
--
components: +Interpreter Core
___
Python tracker
<https://bugs.python.org/issue41059>
___
___
Python-bugs-list mailing list
Unsub
New submission from Gregory P. Smith :
Here's an example:
*** CID 1464688: Control flow issues (DEADCODE)
/Parser/parser.c: 24243 in _tmp_147_rule()
24237 &&
24238 (z = disjunction_rule(p)) // disjunction
24239 )
24240
Gregory P. Smith added the comment:
those were the three in the email (20 of 106), i need to figure out how to
login to coverity again to see the rest.
--
___
Python tracker
<https://bugs.python.org/issue41
Change by Gregory P. Smith :
--
pull_requests: +20185
pull_request: https://github.com/python/cpython/pull/21011
___
Python tracker
<https://bugs.python.org/issue41
Change by Gregory P. Smith :
--
pull_requests: +20183
pull_request: https://github.com/python/cpython/pull/21009
___
Python tracker
<https://bugs.python.org/issue41
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +20181
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/21007
___
Python tracker
<https://bugs.python.org/issu
New submission from Gregory P. Smith :
*** CID 1464693: Null pointer dereferences (REVERSE_INULL)
/Modules/_zoneinfo.c: 1625 in parse_abbr()
1619 ptr++;
1620
Gregory P. Smith added the comment:
I suggest waiting to see what I come up with as a proposal for what part(s) of
this makes sense in the stdlib and why. I've closed the PR.
Nothing is going to be added to mock without your agreement.
This issue is not a high priority for me, but leaving
Change by Gregory P. Smith :
--
versions: +Python 3.10, Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue37193>
___
___
Python-bugs-list m
Change by Gregory P. Smith :
--
title: subprocess_fork_exec leaks memory -> subprocess_fork_exec leaks memory
when extra_groups are supplied
___
Python tracker
<https://bugs.python.org/issu
Change by Gregory P. Smith :
--
versions: +Python 3.10 -Python 3.8
___
Python tracker
<https://bugs.python.org/issue35823>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
nosy: -gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue25782>
___
___
Python-bugs-list mailing list
Unsub
Gregory P. Smith added the comment:
I expect the best decision to be to get rid of tempfile.tempdir entirely. That
would need be its own issue with a deprecation period involved.
A process global that alters behavior of all calls into a module that don't
explicitly opt-out is a bad API
Gregory P. Smith added the comment:
I'd feel fine doing that for 3.9 given 3.9.0 is only in beta and this changes
no public APIs. For 3.8 and 3.7 i wouldn't.
Be sure to update the versionchanged in the docs if you choose to do it for 3.9
Gregory P. Smith added the comment:
We consider it closer to new feature as it changes existing behavior in a way
that people cannot _depend_ on being present in older Python releases as it'd
only appear in a bugfix release, so most people could never write code
depending on it while
Gregory P. Smith added the comment:
Christian - Devin could likely use some help with the build/ifdef plumbing
required for (2) to use CRYPTO_memcmp from Modules/_operator.c when OpenSSL is
available.
--
assignee: -> christian.heimes
___
Pyt
Gregory P. Smith added the comment:
I disagree. Many of these do belong in the stdlib and we don't need a
python-ideas bike shedding 300 message thread about something so trivial.
We've been using these internally at Google for years.
Its on my plate to identify which ones to accept
Gregory P. Smith added the comment:
Could you please turn that into a Github PR?
--
___
Python tracker
<https://bugs.python.org/issue40701>
___
___
Python-bug
New submission from Gregory P. Smith :
https://buildbot.python.org/all/#/builders/727
test_tuples (test.test_gdb.PrettyPrintTests)
Verify the pretty-printing of tuples ... ok
test_bt (test.test_gdb.PyBtTests)
Verify that the "py-bt" command works ... FAIL
Stderr:
Python Excepti
Gregory P. Smith added the comment:
New changeset 6a5d3ff67644af42b1a781be2eacb2e82913441c by Gregory P. Smith in
branch 'master':
bpo-40636: Clarify the zip built-in docstring. (GH-20118)
https://github.com/python/cpython/commit/6a5d3ff67644af42b1a781be2eacb2e82913441c
New submission from Gregory P. Smith :
PEP 618 https://www.python.org/dev/peps/pep-0618 discussions are still on
going. This issue is being filed to track an implementation, assuming the PEP
is accepted and one is decided upon.
I'm filing it now, as I can at least use the issue
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +19422
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/20118
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
Thanks!
We use this function internally in some VM traceback grabbing code but the best
solution looks to just be for us to adopt the patch to 3.9 on our interpreter
until we're running on 3.9.
--
nosy: +gregory.p.smith
Gregory P. Smith added the comment:
New changeset 18f1c60a1625d341a905c7e07367c32c08f222df by Miro Hrončok in
branch 'master':
bpo-40360: Add a What's New entry for lib2to3 pending deprecation (GH-19898)
https://github.com/python/cpython/commit/18f1c60a1625d341a905c7e07367c32c08f222df
Gregory P. Smith added the comment:
Adding aliases in openssl is presumably process global right? Is that wise
given it'd mean other openssl using c/c++ code in the process would now see
the same aliases and could behave differently when used with python vs
without?
On Sun, May 3, 2020, 3:55
Gregory P. Smith added the comment:
I think what we're doing with the documentation update is fine. We can add a
warning on stderr to the tool in 3.11. But I don't expect people will be using
the tool _from_ the latest CPython 3.x by then.
2to3 is already included with Python 2.7
Gregory P. Smith added the comment:
New changeset 503de7149d03bdcc671dcbbb5b64f761bb192b4d by Carl Meyer in branch
'master':
bpo-40360: Deprecate lib2to3 module in light of PEP 617 (GH-19663)
https://github.com/python/cpython/commit/503de7149d03bdcc671dcbbb5b64f761bb192b4d
Gregory P. Smith added the comment:
Okay,the pending deprecation is in. Keeping open as a reminder to turn that
into a real DeprecationWarning in 3.10 after the 3.9 branch is cut.
We'll then want to track reminding us to remove it in 3.12
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +18969
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/19645
___
Python tracker
<https://bugs.python.org/issu
601 - 700 of 3243 matches
Mail list logo
