[issue7427] BadStatusLine is hell to debug

2009-12-04 Thread Jake McGuire
Jake McGuire j...@youtube.com added the comment: I think what's happening is that your connection is being closed due to inactivity, so the status line that comes back is empty. Printing repr(line) would probably make the emptiness clear, but maybe the httplib code should put in a more

[issue6790] httplib and array do not play together well

2009-08-27 Thread Jake McGuire
New submission from Jake McGuire j...@youtube.com: As of Python 2.6 you can no longer pass an array to httplib.HTTPConnection.send. Issue1065257 added code to httplib to attempt to determine whether a file-like object was passed to certain methods (e.g. send), and to stream the data if so

[issue5084] unpickling does not intern attribute names

2009-05-01 Thread Jake McGuire
Jake McGuire j...@youtube.com added the comment: This fell through the cracks. But the following unit test seems like it does the right thing (fails with the old module, works with the new ones). -- Added file: http://bugs.python.org/file13835/pickletester.diff

[issue5084] unpickling does not intern attribute names

2009-02-25 Thread Jake McGuire
Jake McGuire j...@youtube.com added the comment: Ugh. Clearly I didn't check to see if it worked or not, as it didn't even compile. A new diff, tested and verified to work, is attached. I'll work on creating a test. Added file: http://bugs.python.org/file13178/cPickle.c.diff

[issue5084] unpickling does not intern attribute names

2009-02-25 Thread Jake McGuire
Changes by Jake McGuire j...@youtube.com: Removed file: http://bugs.python.org/file12882/cPickle.c.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5084

[issue5084] unpickling does not intern attribute names

2009-02-25 Thread Jake McGuire
Changes by Jake McGuire j...@youtube.com: Removed file: http://bugs.python.org/file13169/cPickle.c.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5084

[issue5084] unpickling does not intern attribute names

2009-02-24 Thread Jake McGuire
Jake McGuire j...@youtube.com added the comment: The fromstring/asstring dance was due to my incomplete understanding of refcounting. PyDict_Next returns a borrowed reference but PyString_InternInPlace expects an owned reference. Thanks to Kirk McDonald, I have a new patch that does

[issue5084] unpickling does not intern attribute names

2009-01-27 Thread Jake McGuire
New submission from Jake McGuire j...@youtube.com: Instance attribute names are normally interned - this is done in PyObject_SetAttr (among other places). Unpickling (in pickle and cPickle) directly updates __dict__ on the instance object. This bypasses the interning so you end up with many

[issue5084] unpickling does not intern attribute names

2009-01-27 Thread Jake McGuire
Changes by Jake McGuire j...@youtube.com: Added file: http://bugs.python.org/file12880/pickle.py.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5084

[issue5084] unpickling does not intern attribute names

2009-01-27 Thread Jake McGuire
Changes by Jake McGuire j...@youtube.com: Removed file: http://bugs.python.org/file12879/cPickle.c.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5084

[issue5084] unpickling does not intern attribute names

2009-01-27 Thread Jake McGuire
Changes by Jake McGuire j...@youtube.com: Added file: http://bugs.python.org/file12882/cPickle.c.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5084

[issue5084] unpickling does not intern attribute names

2009-01-27 Thread Jake McGuire
Jake McGuire j...@youtube.com added the comment: Are you sure? I may not have enough context in my diff, which I should have done against an anonymous svn checkout, but it looks like the slot attributes get set several lines after my diff. while (PyDict_Next(slotstate, ...)) as opposed