[issue43980] netrc module looks for .netrc even on Windows where the convention is _netrc

2021-04-29 Thread Jerry Heiselman
Jerry Heiselman added the comment: The netrc file has no formal standard, but the following supports the claim of its conventional naming. Excerpt from https://curl.se/docs/manpage.html#-n: "Makes curl scan the .netrc (_netrc on Windows) file in the user's home directory for logi

[issue43980] netrc module looks for .netrc even on Windows where the convention is _netrc

2021-04-29 Thread Jerry Heiselman
Jerry Heiselman added the comment: Created a simple PR to correct this. -- keywords: +patch message_count: 1.0 -> 2.0 pull_requests: +24423 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25732 ___ Python t

[issue43980] netrc module looks for .netrc even on Windows where the convention is _netrc

2021-04-29 Thread Jerry Heiselman
New submission from Jerry Heiselman : The netrc library defaults to looking for the .netrc file in the user's home directory. On Windows, this file is conventionally named _netrc. While one could pass the correct path to the library, the conventionally correct path should be used o

[issue2824] zipfile to handle duplicate files in archive

2021-01-27 Thread Jerry Heiselman
Jerry Heiselman added the comment: Further, some tools like zipgrep, seem to iterate over the toc in the zipfile and end up running the grep part once per entry leading to some duplication of data returned without it being obvious that there wasn't actually duplicate data in the zip ar

[issue2824] zipfile to handle duplicate files in archive

2021-01-27 Thread Jerry Heiselman
Jerry Heiselman added the comment: This just bit us too. I don't feel like a warning is enough. In our case, we want to prevent it from happening to begin with so that a developer who isn't expecting this doesn't have to know ahead of time to check for a file. Once a duplicat