Johan Euphrosine added the comment:
Here is a log that shows zinfo.header_offset value after each .tell() when
running test_zipfile
--
Added file: http://bugs.python.org/file21895/zinfo.header_offset.log
___
Python tracker
<http://bugs.python.
Johan Euphrosine added the comment:
I just find it while reading the source, for fixing #11980
zinfo.header_offset is only read in self._write_check, and it seems to me that
no file operation are performed on self.fp between the two call. So I can't see
see how it could different.
Als
Johan Euphrosine added the comment:
Here is a tentative implementation.
Feel free to review it.
--
keywords: +patch
Added file: http://bugs.python.org/file21871/zipfile-add-writefp.patch
___
Python tracker
<http://bugs.python.org/issue11
Changes by Johan Euphrosine :
--
keywords: +patch
title: duplicated self.fp.tell() in zipfile.ZipFile.writestr -> dupe
self.fp.tell() in zipfile.ZipFile.writestr
Added file: http://bugs.python.org/file21870/zipfile-fix-dupe-fp-tell.patch
___
Pyt
Changes by Johan Euphrosine :
--
components: +Library (Lib)
type: -> performance
___
Python tracker
<http://bugs.python.org/issue11981>
___
___
Python-bugs-lis
New submission from Johan Euphrosine :
See:
http://hg.python.org/cpython/file/2e3346fc880f/Lib/zipfile.py#l1168
http://hg.python.org/cpython/file/2e3346fc880f/Lib/zipfile.py#l1182
--
messages: 134990
nosy: Johan.Euphrosine
priority: normal
severity: normal
status: open
title: duplicated
New submission from Johan Euphrosine :
Currently it only accept a filename (and writestr only accept bytes).
--
components: Library (Lib)
messages: 134989
nosy: Johan.Euphrosine
priority: normal
severity: normal
status: open
title: zipfile.ZipFile.write should accept fp as argument
type
