[issue5309] distutils doesn't parallelize extension module compilation

2014-09-30 Thread Jonas Wagner
Jonas Wagner added the comment: I don't understand where this error comes from... The compilation commands are exactly the same in both the before and after logs. The order of commands is also the same. The only difference is this message: *** WARNING: renaming _ssl since importing

[issue21122] CPython fails to build modules with LLVM LTO on Mac OS X

2014-09-09 Thread Jonas Wagner
Jonas Wagner added the comment: No response for a while, and problem solved... closing. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21122

[issue5309] distutils doesn't parallelize extension module compilation

2014-09-09 Thread Jonas Wagner
Jonas Wagner added the comment: I've checked the `dlopen` issue. This was due to a problem with UndefinedBehaviorSanitizer, and was solved by upgrading to Clang 3.5. It has little to do with this patch. Using this patch and http://bugs.python.org/issue22359 , I now get reliable parallel

[issue22359] Remove incorrect uses of recursive make

2014-09-08 Thread Jonas Wagner
New submission from Jonas Wagner: The attached patch fixes issues with Python's Makefile, which manifest when doing parallel builds. The Makefile invoked make recursively for some targets. This caused some files (which were depended upon by multiple targets) to be built by both the original

[issue5309] distutils doesn't parallelize extension module compilation

2014-09-05 Thread Jonas Wagner
Changes by Jonas Wagner jonas.wag...@epfl.ch: -- nosy: +Sjlver ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5309 ___ ___ Python-bugs-list mailing

[issue5309] distutils doesn't parallelize extension module compilation

2014-09-05 Thread Jonas Wagner
Jonas Wagner added the comment: Is there a reason this has not landed? The patch works perfectly for me, except for one issue: @@ -268,6 +275,9 @@ if self.undef: self.undef = self.undef.split(',') +if self.parallel

[issue5309] distutils doesn't parallelize extension module compilation

2014-09-05 Thread Jonas Wagner
Jonas Wagner added the comment: With this patch, and on Ubuntu 14.04, occasionally modules fail to build with the following error: *** WARNING: renaming _testbuffer since importing it failed: dlopen: cannot load any more object with static TLS I'm not 100% sure if this is really due

[issue21122] CPython fails to build modules with LLVM LTO on Mac OS X

2014-04-04 Thread Jonas Wagner
Jonas Wagner added the comment: I confirm that this also works with my self-compiled Clang 3.4. -export_dynamic was the missing option. Is a good place to document this? Otherwise, I think this issue can be closed. Thanks a lot for the help

[issue21122] CPython fails to build modules with LLVM LTO on Mac OS X

2014-04-02 Thread Jonas Wagner
Jonas Wagner added the comment: Thanks Ned, this is interesting! I don't know about Mac OS, but on Ubuntu, LTO and PGO apparently make Python around 10% faster (see #17781). However, that data point refers to GCC's LTO, not LLVM's. Personally I'm interested in LTO because I want to obtain

[issue21122] CPython fails to build modules with LLVM LTO on Mac OS

2014-04-01 Thread Jonas Wagner
New submission from Jonas Wagner: CPython fails to build with LLVM's link-time optimization (LTO) in Mac OS. Very similar commands work on Linux. I'm currently configuring CPython as follows: on Linux: RANLIB=ar -s --plugin=/path/to/llvm/lib/LLVMgold.so CC=/path/to/llvm/bin/clang CXX=/path

[issue21122] CPython fails to build modules with LLVM LTO on Mac OS

2014-04-01 Thread Jonas Wagner
Jonas Wagner added the comment: I am indeed using Clang 3.4 (both the one that ships with Mac OS, and a version compiled from the sources). However, the errors I get are rather different than #20767. In particular, Clang finishes successfully and does produce shared object files; they just

[issue17736] Misleading method comment in _elementtree.c : get_attrib_from_keywords

2013-04-15 Thread Jonas Wagner
New submission from Jonas Wagner: The attached patch corrects a wrong method comment in _elementtree.c. It happened to be at Line 316, and was thus discovered by random sampling. [1] [1] http://www-cs-faculty.stanford.edu/~uno/316.html -- components: Extension Modules files

[issue17738] Unnecessary if in SHA1_copy

2013-04-15 Thread Jonas Wagner
New submission from Jonas Wagner: I'm puzzled by the following code in SHA1_copy (at python/Modules/sha1module.c:320 if (Py_TYPE(self) == SHA1type) { if ( (newobj = newSHA1object())==NULL) return NULL; } else { if ( (newobj = newSHA1object())==NULL

[issue12411] cgi.parse_multipart is broken on 3.x

2011-07-04 Thread Jonas Wagner
Jonas Wagner ve...@gmx.ch added the comment: Hi Tal, Thanks a lot for your feedback. My primary objective was to increase the test coverage for cgi.py. If it is a problem to have the additional tests in this patch I'm happy to create a new issue with a separate patch. The default value

[issue12411] cgi.parse_multipart is broken on 3.x

2011-06-25 Thread Jonas Wagner
New submission from Jonas Wagner ve...@gmx.ch: While writing tests for the cgi module I came across what looks like a conversion bug. cgi.parse_multipart is comparing values it reads from a binary file like with a string literal: line = fp.readline() ... if line.startswith(--): This patch

[issue3212] ssl module - should test for a wrong cert

2008-06-26 Thread Jonas Wagner
New submission from Jonas Wagner [EMAIL PROTECTED]: Currently test_ssl.py only tests for empty or broken certificates. One can break certificate validation in _ssl.c and they still pass. The following patch should fix this. - Jonas -- components: Tests files: add_wrong_cert_test.diff