Kamilla added the comment:
Adding aliases to the set of iso-8859-8.
--
keywords: +patch
Added file: http://bugs.python.org/file34449/adding_aliases.patch
___
Python tracker
<http://bugs.python.org/issue18
Kamilla added the comment:
I'm not sure about how the aliases are represented. I found some examples:
http://web.mit.edu/Mozilla/src/mozilla/intl/uconv/src/charsetalias.properties
So I wrote the aliases like this:
'iso-8859-8-i' : 'iso8859_8_I',
'iso-
Kamilla added the comment:
Applying changes as suggested by R. David Murray in the Core-mentorship e-mail
list.
Instead of doing the if tests I've replaced the existing
if isinstance(expected_regex, (bytes, str)):
by
if expected_regex is not None:
And also made a change in o
Kamilla added the comment:
I've implemented a piece of code to check if the expected_regex is a string or
regex object. If it's not it raises a TypeError exception. The check is inside
the __init__ method of the _AssertRaisesBaseContext class so it will always
check the expected_re
Kamilla added the comment:
Just to be sure, the check must be implemented inside the assertRaisesRegex
method, right?
--
nosy: +kamie
___
Python tracker
<http://bugs.python.org/issue20