[issue45593] SpooledTemporaryFile.truncate returns None

2021-10-23 Thread Maciej Urbański
Change by Maciej Urbański : -- keywords: +patch pull_requests: +27466 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29197 ___ Python tracker <https://bugs.python.org/issu

[issue45593] SpooledTemporaryFile.truncate returns None

2021-10-23 Thread Maciej Urbański
New submission from Maciej Urbański : Related: https://bugs.python.org/issue40287 https://bugs.python.org/msg319145 -- components: Library (Lib) messages: 404914 nosy: rooter priority: normal severity: normal status: open title: SpooledTemporaryFile.truncate returns None type: behavior

[issue26528] NameError for built in function open when re-raising stored exception from yielded function

2018-01-04 Thread Maciej Urbański
Maciej Urbański <roo...@kyberian.net> added the comment: Reproduced in both v3.6.4 and v3.7.0a3 -- nosy: +rooter versions: +Python 3.6, Python 3.7 ___ Python tracker <rep...@bugs.python.org> <https://bugs.python

[issue15013] smtplib: add low-level APIs to doc?

2016-10-13 Thread Maciej Urbański
Maciej Urbański added the comment: I guess documenting `data` method may still be needed after all. For now I followed the suggestions from comments to best of my ability. Please see attached patch. -- keywords: +patch nosy: +rooter Added file: http://bugs.python.org/file45086

[issue27908] del _limbo[self] KeyError

2016-09-15 Thread Maciej Urbański
Maciej Urbański added the comment: To address @Dima.Tisnek concern I have changed exception message in case thread start process is merely in progress. I kept `self._started` check under a lock so we can avoid more extreme race condition of one thread checking `self._started` right before

[issue27908] del _limbo[self] KeyError

2016-09-13 Thread Maciej Urbański
Maciej Urbański added the comment: @Dima.Tisnek, only reason for having both of these conditions together is so I won't have to repeat the same error message in the code at little price of the performance in this edge case (trying to start the same thread multiple times). Unless I'm missing

[issue27908] del _limbo[self] KeyError

2016-09-13 Thread Maciej Urbański
Maciej Urbański added the comment: Successfully reproduced on 2.7.12 and 3.5.2 . Currently there seems to be no protection against starting the same thread twice at the same time. What was checked was only if start operation already finished once. Attached patch makes it so limbo, our