[issue9373] pulldom has low code coverage

2010-08-02 Thread Mark Smith
Mark Smith added the comment: Added a patch to increase code coverage for the pulldom module to 90%. This patch also includes 3 'expectedFailure' tests that I believe indicate erroneous behaviour, associated with issues #9453 (SAX2DOM doesn't like processing instructions

[issue9454] unittest.expectedFailure decorator does not maintain target function's docstring.

2010-08-02 Thread Mark Smith
Mark Smith added the comment: Closed this issue. The initial report was in error -- it turns out I can't even read my own console. I'm an idiot :) -- status: open -> closed ___ Python tracker <http://bugs.pyth

[issue9454] unittest.expectedFailure decorator does not maintain target function's docstring.

2010-08-02 Thread Mark Smith
Mark Smith added the comment: Removed the failing test patch, because it didn't demonstrate what I thought it did. Unwrapped tests also don't have docstrings, because they are instances of the TestCase, not references to th

[issue9454] unittest.expectedFailure decorator does not maintain target function's docstring.

2010-08-02 Thread Mark Smith
Changes by Mark Smith : Removed file: http://bugs.python.org/file18321/unittest_failing_test.patch ___ Python tracker <http://bugs.python.org/issue9454> ___ ___ Python-bug

[issue9454] unittest.expectedFailure decorator does not maintain target function's docstring.

2010-08-02 Thread Mark Smith
Mark Smith added the comment: Provided a patch to demonstrate this issue. Demonstrates that docstrings aren't copied to the decorator function. -- keywords: +patch Added file: http://bugs.python.org/file18321/unittest_failing_test.patch ___ P

[issue9454] unittest.expectedFailure decorator does not maintain target function's docstring.

2010-08-02 Thread Mark Smith
New submission from Mark Smith : When running tests with -v, the test runner prints out the docstring of each test method, if present, and falls back to the method name if it's not present. Test methods wrapped with @expectedFailure do not print out their docstring, so it looks lik

[issue9453] pulldom.SAX2DOM Doesn't support processing instructions before the root element

2010-08-02 Thread Mark Smith
Mark Smith added the comment: My recommendation is that SAX2DOM is deprecated and removed from the standard library rather than fixing this issue. The class is currently undocumented, has weird behaviour, and is unused within the Python standard library, so I don't expect that this

[issue9453] pulldom.SAX2DOM Doesn't support processing instructions before the root element

2010-08-02 Thread Mark Smith
New submission from Mark Smith : pulldom.SAX2DOM raises a TypeError if it encounters a processing instruction before the root element of an XML document. It is valid to have a processing instruction before the root node of a document (and SAX2DOM's superclass, PullDOM supports this), so

[issue7635] 19.6 xml.dom.pulldom doc: stub?

2010-07-25 Thread Mark Smith
Changes by Mark Smith : Removed file: http://bugs.python.org/file18179/7635.patch ___ Python tracker <http://bugs.python.org/issue7635> ___ ___ Python-bugs-list mailin

[issue7635] 19.6 xml.dom.pulldom doc: stub?

2010-07-25 Thread Mark Smith
Mark Smith added the comment: Terry, thanks for the feedback! I have added a patch, replacing the previous one, which deals with your points 1 and 3 in the following ways: 1. I have used (an edited form of) your synopsis - I've removed the details of exactly what is returned fro

[issue9372] pulldom.DOMEventStream.__getitem__ is broken

2010-07-24 Thread Mark Smith
Mark Smith added the comment: I should have mentioned: __iter__ is already implemented, and works as expected. -- ___ Python tracker <http://bugs.python.org/issue9

[issue9373] pulldom has low code coverage

2010-07-24 Thread Mark Smith
New submission from Mark Smith : pulldom has poor code coverage, so I am currently implementing thorough unit tests for it. -- components: XML messages: 111476 nosy: mark.smith priority: normal severity: normal status: open title: pulldom has low code coverage versions: Python 3.2

[issue9372] pulldom.DOMEventStream.__getitem__ is broken

2010-07-24 Thread Mark Smith
New submission from Mark Smith : DOMEventStream implements __getitem__, but ignores the index/key that is passed in and simply returns the next item from the stream. This is seriously unexpected behaviour. I don't believe this functionality can be sensibly implemented in this class, and

[issue9371] pulldom doesn't provide END_DOCUMENT or COMMENT nodes.

2010-07-24 Thread Mark Smith
New submission from Mark Smith : I've been developing unit tests to increase the code coverage for pulldom, and have discovered that comments and end_document do not appear to result in events being obtained from the DOMEventStream. I've attached a failing TestCase to demons

[issue7635] 19.6 xml.dom.pulldom doc: stub?

2010-07-24 Thread Mark Smith
Mark Smith added the comment: I have a patch that provides full documentation for pulldom, and adds sensible docstrings to the pulldom module. I have unfortunately created the patch on the py3k branch -- please let me know what I should do regarding porting these changes to Python 2.7