Changes by Milan Oberkirch milan...@oberkirch.org:
--
nosy: +jesstess
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15014
___
___
Python-bugs-list
New submission from Milan Oberkirch:
I found non-printable characters in the source files of the email package. Vim
rendered it as '^L', pasting it on the linux console has the same effect as
CTRL+L. In most places it was combined with regular newlines, sometimes as a
replacement, sometimes
Milan Oberkirch added the comment:
Updated the last patch according to the review comments at
https://bugs.python.org/review/20098/.
--
Added file: http://bugs.python.org/file35020/mangle_from_20140424.patch
___
Python tracker rep...@bugs.python.org
Changes by Milan Oberkirch milan...@oberkirch.org:
Added file: http://bugs.python.org/file35021/mangle_from_20140424.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20098
Changes by Milan Oberkirch milan...@oberkirch.org:
Removed file: http://bugs.python.org/file35020/mangle_from_20140424.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20098
Milan Oberkirch added the comment:
The attached patch mentions the exception besides the description of the
timeout parameter. It doesn't hurt and makes programmers aware of this common
exception.
--
keywords: +patch
nosy: +zvyn
Added file: http://bugs.python.org/file34516
Milan Oberkirch added the comment:
changed 'bytes' and 'byte string' to `bytes-like object` and reviewed usage of
'byte' and 'string' (the letter made sense to me at some points, e.g. something
like ... altchar is a string with two or less letters ...).
--
keywords: +patch
nosy
Milan Oberkirch added the comment:
Added documentation for mangle_from. since the name mangle_from_ is not
supported by the markup, changed it to mangle_from everywhere, which looks
better anyway (I understand why it was the other way so). If it was a bad idea,
I can undo it but am unable
Milan Oberkirch added the comment:
Rollback to mangle_from_, sorry for the noise.
--
Added file: http://bugs.python.org/file34321/mangle_from_with_doc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20098
Changes by Milan Oberkirch milan...@oberkirch.org:
Removed file: http://bugs.python.org/file34320/mangle_from_with_doc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20098
Changes by Milan Oberkirch milan...@oberkirch.org:
Added file: http://bugs.python.org/file34322/mangle_from_with_doc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20098
Changes by Milan Oberkirch milan...@oberkirch.org:
Removed file: http://bugs.python.org/file34321/mangle_from_with_doc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20098
New submission from Milan Oberkirch:
Accorcing to coveragepy there was only one line missing for full line coverage
in Lib/email/policy.py so I added an test to cover it.
It checks that the function email.policy.EmailPolicy.header raises an
ValueError if the second parameter includes newlines
Milan Oberkirch added the comment:
I was going to work on #3461 where IPv6-tests are missing for smtplib and
stumbled over this bug. I would be willing to work on this, since it's quiet
clear what needs to be done to me: implement what (vsergeev) suggested and
write tests (which includes
Milan Oberkirch added the comment:
The cleaning up of smtpd.socket was already implemented, so there was nothing
to do there.
What I did:
- Write two TestCases to check if the IP version is chosen depending on the
host-parameter
- Testing, that everything still works with an IPv6 address
Milan Oberkirch added the comment:
I looked into imaplib a bit to see how the problem is solved there; what I
observed:
- login() does 'PLAIN' only (and does not use authobj but smtplib would)
- there exists an extra function login_cram_md5() for 'CRAM-MD5'
So I guess the right way to do
Milan Oberkirch added the comment:
Maybe I am a bit hyperactive, but I already was at it when receiving your
message, so I finished it. Anyhow most of what I have done is completely
independent of the API chosen. What I did:
1. I implemented a new authenticate(self, mechanism, authobject
Milan Oberkirch added the comment:
(@r.david.murray) I just implemented what you suggested:
- Policy has a mangle_from_ property, overridden in EMailPolicy
- Generator and DecodedGenerator default to policy.mangle_from_ or True if
policy is None.
Would be glad if it helps :)
--
nosy
Changes by Milan Oberkirch milan...@oberkirch.org:
Removed file: http://bugs.python.org/file34275/mangle_from.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20098
Milan Oberkirch added the comment:
Updates patch to include necessary changes to test_policy.py.
--
Added file: http://bugs.python.org/file34277/mangle_from.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20098
Milan Oberkirch added the comment:
I implemented one approach to solve this by writing new member functions for
each method (see the patch attached). Bonus: It does not change the usage of
login() in any way (which uses the new functions internally).
Another option would be to make those
Milan Oberkirch added the comment:
According to the documentation[1] the values for host should be set to
'localhost' by default. I attached a patch that does just that. Also note, that
the minimal example at the end of [1] is broken by this bug.
[1]: http://docs.python.org/2/library
101 - 122 of 122 matches
Mail list logo
